From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id A00EBD8178B for ; Mon, 24 Jul 2023 07:58:37 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Jkohl/kJBcpZEPubposhEM0qayE0913VOXwyf/XpTAo=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTenantHeaders Stamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690185515; v=1; b=EaPWjDWxfTAzVtWUU/6ny1ihq2VG8L9Tgz6HSPuDB4xEZcm2whGKtGMwKsOWZK8CPdketcZc FITGrqhwuGxT2fBADZAGK4ytYrqT+BYXxZEb7KoMHdwrVVCAza+ZFm8UOtomMTORJjXrmJ2pEPQ VcofS2My9LJKTJkgTRaMNjqM= X-Received: by 127.0.0.2 with SMTP id mY1aYY7687511xLDjaEd1NQ0; Mon, 24 Jul 2023 00:58:35 -0700 X-Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.43332.1690185515334188611 for ; Mon, 24 Jul 2023 00:58:35 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="367399574" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="367399574" X-Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2023 00:58:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10780"; a="839357427" X-IronPort-AV: E=Sophos;i="6.01,228,1684825200"; d="scan'208";a="839357427" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga002.fm.intel.com with ESMTP; 24 Jul 2023 00:58:34 -0700 X-Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 24 Jul 2023 00:58:33 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 24 Jul 2023 00:58:33 -0700 X-Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.42) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 24 Jul 2023 00:58:33 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YfZkwUQw4d1+3ABCrPwS7YVPlIptgwyZTvsneY+xeG8trunRZlJnME3wXbLM7XjichRQTd1/dZg9HypnjvvVgjlkczH8J2k5vwlBJi6eQSuE2uvcju1di8KBb6fS5thQ9VQrH2plGCHcZuxeDeqzBvJTYWzO4eFhzleWufxGagHh63zKQBUN+pkxbgm/7gEODSXGEGjl1wiU5fhNeHgaYbksqV/5+CRi8avU5JF+AOzWLx8wm36ayi5X4TZMV6LmA+g3qCWcl7cXiwts03H25HNZqn8Ljpa8f0FR1sUoT5Qc9kTpD1W2pRnNz4DRa0aRxJTaMMFfSqhAs+xXwVWPTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=plnPbwu63PP9FI1WTRgylTI7sqOE0BXekyGUwoB40pU=; b=Dz29EU6iN3VVLtEo0vBzuquCxDBpWDfW33wrE99Pxghlk52kS9atYKt9LLhwmLn8WsqDSy23u4i1QrXsVzVi4SK4gSqGjj2AdWD0XFne9pDF7U0XLmVjoH9/+xwv87tM2Q2GygjfIqRUAVv7L101DEYcITbchcsJWEly87FqVQetQ/cY9lb6N3O+DJzDpEzJjTiJnY2EEGTNKZZ7h+CRrQLRFQBEr56o8uTIKpO6rsHiDP8vw6QtGLxxcXhdaaTqEL7rVYVH2nI6Z4tysF72+F7IsYew5fGjqT7w9O3ZuiB1vBNxqupJCnz5jx6Z4BVjpG2kwjUEVFPEQzpfuZ80zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5776.namprd11.prod.outlook.com (2603:10b6:303:183::9) by SA1PR11MB8447.namprd11.prod.outlook.com (2603:10b6:806:3ac::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.31; Mon, 24 Jul 2023 07:58:31 +0000 X-Received: from MW4PR11MB5776.namprd11.prod.outlook.com ([fe80::5842:74bc:4aaf:a4fb]) by MW4PR11MB5776.namprd11.prod.outlook.com ([fe80::5842:74bc:4aaf:a4fb%7]) with mapi id 15.20.6609.031; Mon, 24 Jul 2023 07:58:30 +0000 From: "Chaganty, Rangasai V" To: "Kasbekar, Saloni" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Oram, Isaac W" , "Chuang, Rosen" Subject: Re: [edk2-devel] [PATCH 6/8] AlderlakeSiliconPkg/SystemAgent: Add NVS support Thread-Topic: [PATCH 6/8] AlderlakeSiliconPkg/SystemAgent: Add NVS support Thread-Index: AQHZn7JJh7yMdvdhZEOPkr1apa2NE6/Iydqw Date: Mon, 24 Jul 2023 07:58:30 +0000 Message-ID: References: <6b58dd187980204b74c6ec718dad122674c213e1.1686851565.git.saloni.kasbekar@intel.com> <9d05eb330054c44d9fb3bfdc50b80ce667e42eae.1686851565.git.saloni.kasbekar@intel.com> In-Reply-To: <9d05eb330054c44d9fb3bfdc50b80ce667e42eae.1686851565.git.saloni.kasbekar@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5776:EE_|SA1PR11MB8447:EE_ x-ms-office365-filtering-correlation-id: 9889f7d3-c233-4831-d546-08db8c1bc57e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Gg+CCNVStUR/4v+rUjgbc5/rTbgjH0Cf5due9lfAlIjNeqbSGQcocEZ40Yd7m2R0ycRyHmKS0YcH9OmyQj6+r0Q/BpiHUi9oWASJAy4za38MIdvPIbFKfkZ4vxUYDsIYu/7cy6HqpDcFOcbda60ECDCD0PP9iJj9MAWVgf6S4jzZhzykodP2/kPDGdthXMZXf1Nij+APFw9nq1WvwwfnI194Csrzvc8LgBKarKMxaBbiyYMlgS9ajadT3HgyqPDXxv3/h/7JiEXppBwsBqwDh9Vr2LFnDXnaAGyCezvNrwQDcMjAPGc/1Psa4dcEHS7JItEobxtktO559vNsF4DK+g785tK1HqphcRl0dFpjNR+mhvPIan3Fw+vQkQIz461eI4crLz8lVS5GOUG8Y0MBneou+swO4JasZ/+63NhNqh++T0rskL1OkxTvJN7Ax3drfIp1jCDJl+pPrp4BUcmiDN+6aTnX4uHjCEqC00oFZXtj3WIqqFUlciTQaznnwaefPZI9QVV+oUslUaDNlXyYEQpF/Jso3oA+XnND7FxYAN2w1SK+rESWB7GqFTzwmQJtWfrOGUtZhP4Yv1BagrenD3G4BvPu2FgeuH7iplqg5BDBvq2ylYmNLT4dfAzb4lwL x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6WVyLZpIk4hAYNZOa2xUmC3D/RN2dxNfyVofomJ4NCTCyDldPUxUeZzSezEl?= =?us-ascii?Q?pdn9e+F3pe7suwYmAqA2OFGKq/5Py+OHuOiaRTjxfiN+f0zbzoOsZ1GfBFwF?= =?us-ascii?Q?REmD43JShKbCW2mMz9YxnHC5rcLoMO08w512xGiynMBB1YpMGAwMOOCn+P2S?= =?us-ascii?Q?PdHDMThpvU7P8O1bJFu3NMG1zugvNpzSUjR33ka7IUye1bqe9QWqT92ctJAn?= =?us-ascii?Q?oLmI8hsth5LLWD9BYi9rjEsR+SyJRKuN5lc59RlCxqTbLxHa4W/nHyyBWhy7?= =?us-ascii?Q?DjYPixMhpoOBndk2AvUT7AUQj+Bp6uJzdv3gDzL6Ue+RlJLntefjxHYluFmn?= =?us-ascii?Q?zMftYCy077Q7SmIdfa+Z35VJY1haAdrhtChlNNJrh9Vx8fWNSaxt8BhGgivW?= =?us-ascii?Q?/aeCi2ozd+dE/XNPvA6oOH93fECI+ktQmuij7/oxjLJPElzg/GRx8WMWnUn2?= =?us-ascii?Q?4zFfrcyA8v6l/6ogVVoV3VW2mPG8SQuszpG3zvc98sDcxeqw9at+Q8bNzuN0?= =?us-ascii?Q?xRXoHyP4kV1ELL0/C9UFPfTmbZZva8taBXHHPUwH6fuOHdMZlU0akKSfz476?= =?us-ascii?Q?XY9Hs0YIxTKN2zJeoi/2G7XVlQFmaAiAG+Cdr86u/hXb/uSHEx9GVC6tvIuG?= =?us-ascii?Q?j3FaJc+V2Z7KpRSYBzc0IqYhA1iRRDAvPw5se+rLJ/KhLJKVYvy9aXYVc65v?= =?us-ascii?Q?myfZSYXzPXDTWGWegUmDOKSw8q0i2RTsbBXeop4XeSHww+4bWt0DEV5wsB+C?= =?us-ascii?Q?Ea8kJQrhjZX9g04ASGHaV8aMDvJHehxCuisOOxWVd/zIR5axcpRc5JXox6c0?= =?us-ascii?Q?nYw0QU5dY+4p/BSYoqgukAjNzwvuNG2l2oUvZTLTsBOL9N2Zql7WcyKiagyy?= =?us-ascii?Q?xFiRL5GFFOv3d29XRlO6Gh8cESQl4umJ5iITgnNtgYGn/lGjOXQAZHSl1p+F?= =?us-ascii?Q?xjrR45nCUYdj55ry199iWVA5LNVAq3OG9oJleLVRk75M5qgYR6Psmo3oNNYv?= =?us-ascii?Q?Llb2LF5a4dQhCviLmCSOGLzKo3v7qAlWKcMrdvRmZgkajXSnS56j9vi7M4uM?= =?us-ascii?Q?gg8G+q7rPQwq6T7gDkj34b3ef69B7qPci+J1BiaS3OBDHPwT1pa19TOeC1w/?= =?us-ascii?Q?mRc8/iQ6RIflHfAX03MVNUSFTxDyqcyB/SApMLwnN+aj7qzPKXXgX4TIYUb7?= =?us-ascii?Q?OSGFIWpyPkE83TCqheTSFNLql7aoN3cBc7tOSdCPT2UT9+ruHCKiiprrNOGM?= =?us-ascii?Q?OGoln4d1sR2/85G6ZmvmNCtlNz+oU1/HlhFKsXSRhipyxJ0aePswuIVB0Raa?= =?us-ascii?Q?HypR2MQuwAbbknkU/cY/EVR7zVYLtX+j4KeD021F3brlQvQskr3Dq1Rntunz?= =?us-ascii?Q?qgasvTyqTDlHzVbW1YvoNCDo+CkraI6ETFalsHjTMTpwGzaYm23yGBpvycJu?= =?us-ascii?Q?g4ifMZScdoRYHZA4bI/HgWG31N+MS6fV7zVh3keK6MoPmxm18pfzvaNvZH0q?= =?us-ascii?Q?8d4jyYIl547seYrpqQ/I8KSh66sDHpLlcpvrbyojqhC+0e4Xxcxu2nqM7Mzy?= =?us-ascii?Q?KfURJO7o2YLhsU/5gV1kiWzqPNPTUWaxX0tntnnC7n+FWICea4phYrt+qf5w?= =?us-ascii?Q?1A=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9889f7d3-c233-4831-d546-08db8c1bc57e X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2023 07:58:30.8299 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ODB7cfv5HLU+U6mqZowzJsB4+0q5DX/0qEQf8t4I4akY/XMi3SSgkMQ8VOUiNWo0Q2mYWSsi1dcYkG5JWWgKNZ6+PCjFYur1GdmJ4/qktgc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB8447 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rangasai.v.chaganty@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: iW3UTYHIjow2glo7d1IaL7rbx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=EaPWjDWx; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Sai Chaganty -----Original Message----- From: Kasbekar, Saloni =20 Sent: Thursday, June 15, 2023 10:53 AM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH 6/8] AlderlakeSiliconPkg/SystemAgent: Add NVS support Adds the System Agent NVS ACPI table and structures Cc: Sai Chaganty Cc: Nate DeSimone Cc: Isaac Oram Cc: Rosen Chuang Signed-off-by: Saloni Kasbekar --- .../SystemAgent/AcpiTables/SaSsdt/SaNvs.asl | 18 +++++++++++ .../IncludePrivate/Protocol/SaNvsArea.h | 30 +++++++++++++++++++ .../SystemAgent/IncludePrivate/SaNvsAreaDef.h | 22 ++++++++++++++ 3 files changed, 70 insertions(+) create mode 100644 Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/AcpiTable= s/SaSsdt/SaNvs.asl create mode 100644 Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/IncludePr= ivate/Protocol/SaNvsArea.h create mode 100644 Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/IncludePr= ivate/SaNvsAreaDef.h diff --git a/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/AcpiTables/SaSsd= t/SaNvs.asl b/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/AcpiTables/SaSs= dt/SaNvs.asl new file mode 100644 index 0000000000..e9785873d2 --- /dev/null +++ b/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/AcpiTables/SaSsdt/Sa +++ Nvs.asl @@ -0,0 +1,18 @@ +/**@file + + Copyright (c) 2022, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent **/ + + // + // Define SA NVS Area operation region. + // + + + OperationRegion(SANV,SystemMemory,SANB,SANL) + Field(SANV,AnyAcc,Lock,Preserve) + { Offset(0), M64B, 64, // Offset(0), Base of above 4GB MMIO reso= urce + Offset(8), M64L, 64, // Offset(8), Length of above 4GB MMIO resourc= e + Offset(16), M32B, 32, // Offset(16), Base of below 4GB MMIO resourc= e + Offset(20), M32L, 32, // Offset(20), Length of below 4GB MMIO resou= rce + } \ No newline at end of file diff --git a/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/IncludePrivate/P= rotocol/SaNvsArea.h b/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/Include= Private/Protocol/SaNvsArea.h new file mode 100644 index 0000000000..3a75465843 --- /dev/null +++ b/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/IncludePrivate/Proto +++ col/SaNvsArea.h @@ -0,0 +1,30 @@ +/** @file + Definition of the System Agent global NVS area protocol. + This protocol publishes the address and format of a global ACPI NVS=20 +buffer + used as a communications buffer between SMM/DXE/PEI code and ASL code. + + Copyright (c) 2022, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent **/ + +#ifndef _SYSTEM_AGENT_NVS_AREA_H_ +#define _SYSTEM_AGENT_NVS_AREA_H_ + +// +// SA NVS Area definition +// +#include + +// +// Extern the GUID for protocol users. +// +extern EFI_GUID gSaNvsAreaProtocolGuid; + +/// +/// System Agent Global NVS Area Protocol /// typedef struct { + SYSTEM_AGENT_NVS_AREA *Area; ///< System Agent Global NVS Area St= ructure +} SYSTEM_AGENT_NVS_AREA_PROTOCOL; + +#endif // _SYSTEM_AGENT_NVS_AREA_H_ diff --git a/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/IncludePrivate/S= aNvsAreaDef.h b/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/IncludePrivat= e/SaNvsAreaDef.h new file mode 100644 index 0000000000..5b8136866a --- /dev/null +++ b/Silicon/Intel/AlderlakeSiliconPkg/SystemAgent/IncludePrivate/SaNvs +++ AreaDef.h @@ -0,0 +1,22 @@ +/**@file + + Copyright (c) 2022, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent **/ + + // + // Define SA NVS Area operation region. + // +#ifndef _SA_NVS_AREA_DEF_H_ +#define _SA_NVS_AREA_DEF_H_ + +#pragma pack (push,1) +typedef struct { + UINT64 Mmio64Base; ///< Offset 0 Base= of above 4GB MMIO resource + UINT64 Mmio64Length; ///< Offset 8 Leng= th of above 4GB MMIO resource + UINT32 Mmio32Base; ///< Offset 16 Bas= e of below 4GB MMIO resource + UINT32 Mmio32Length; ///< Offset 20 Len= gth of below 4GB MMIO resource +} SYSTEM_AGENT_NVS_AREA; + +#pragma pack(pop) +#endif -- 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107162): https://edk2.groups.io/g/devel/message/107162 Mute This Topic: https://groups.io/mt/99554477/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-