public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
To: "Oram, Isaac W" <isaac.w.oram@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>
Subject: Re: [edk2-devel][edk2-platforms][PATCH V2 2/3] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include
Date: Sun, 11 Sep 2022 07:13:17 +0000	[thread overview]
Message-ID: <MW4PR11MB5776DCA41A5EB11AF2719BCDB6459@MW4PR11MB5776.namprd11.prod.outlook.com> (raw)
In-Reply-To: <11f681b6aed545635993f317a22d351d894ee3ee.1662760603.git.isaac.w.oram@intel.com>

Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>

-----Original Message-----
From: Oram, Isaac W <isaac.w.oram@intel.com> 
Sent: Saturday, September 10, 2022 6:52 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V2 2/3] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include

Fix build issue from removed PCD and use MinPlatformFeaturesPcd.dsc.inc.

Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
 .../PlatformPayloadFeaturePkg.dsc                   | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)

diff --git a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
index 1b79e0039b..e36e5d6e1e 100644
--- a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
+++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg
+++ .dsc
@@ -48,16 +48,13 @@
 #
 ################################################################################
 
-#
-# Since there are no 32b libraries or components in this package, these PCD are specified for 64b only -# -[PcdsFeatureFlag]
   #
-  # PCD needed for MinPlatform build includes
+  # MinPlatform common include for required feature PCD  # These PCD 
+ must be set before the core include files, CoreCommonLib,  # 
+ CorePeiLib, and CoreDxeLib.
+  # Optional MinPlatformPkg features should be enabled after this
   #
-  gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable                |FALSE
-  gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable                   |FALSE
-  gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable                      |FALSE
+  !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc
 
 [PcdsPatchableInModule]
   gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7
--
2.36.1.windows.1


  reply	other threads:[~2022-09-11  7:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-11  1:52 [edk2-devel][edk2-platforms][PATCH V2 0/3] These commits fix some small build issues from various changes Isaac Oram
2022-09-11  1:52 ` [edk2-devel][edk2-platforms][PATCH V2 1/3] MinPlatformPkg/Include: Add PEI DevicePathLib instance Isaac Oram
2022-09-12 22:41   ` [edk2-devel] [edk2-platforms][PATCH " Chaganty, Rangasai V
2022-09-11  1:52 ` [edk2-devel][edk2-platforms][PATCH V2 2/3] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include Isaac Oram
2022-09-11  7:13   ` Chaganty, Rangasai V [this message]
2022-09-11  1:52 ` [edk2-devel][edk2-platforms][PATCH V2 3/3] Platform/Intel: Fix missing package issue Isaac Oram
2022-09-11  7:10   ` Chaganty, Rangasai V

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB5776DCA41A5EB11AF2719BCDB6459@MW4PR11MB5776.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox