From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.4003.1642042454503780003 for ; Wed, 12 Jan 2022 18:54:14 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=noGr2rsU; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642042454; x=1673578454; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=82PuC99epP0ar3FpDiSqqRvyCbq6bc63YIiAEMzLloM=; b=noGr2rsUiZ4L1dNfw2cvTw/Is8Mz4y0EwBM+Q1tjA5pYkS1HSV6T4CwI b79R5f6yK/ptZdT9R6b2AiTwvE8UKpQHh4JcRPYKaysagCqlyZwq57tkX RlsvIj0fcj6lBFrwLi6TK4axh+yjttfQnnkfM0Ni5MR7njjXlxaahALdj QOpgXWCPTcGVCx4/8NwrAZUY+CckjE8NL4NlJ1uRY93KiAN87LNKU+4cy cfZpsiYvrEf1RwDaLoIAtRwvKst9cGsKHRdU+azSl5rPuzNn47AXw7fCD DWSxoD8Cvy0+hf4jFOn2ZDHaYg12nPOZWBKlGpb6dMrrsFNV9WkoAmVyV w==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="244118305" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="244118305" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 18:54:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="691630305" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga005.jf.intel.com with ESMTP; 12 Jan 2022 18:54:13 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:54:13 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:54:12 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 18:54:12 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 18:54:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WLjAJBvo/QoTiPLhVn5q331ii8Yy5ESLBnXCsv9EUhuV3k4bmaSrXtwhBNYz42ZpfUUyHaCVW5ezATINzKNHNN0KfCRngOs1W8q9fYsNIKQRtQZ40R9MWziu/jl3BICQyPwPhKZzjptTU3qGXpuRhUE+1yrshdNwji5/QU7BdaioRRB9UO/wG715jz/qI8qS1CDEv/Xyco2zWwFm0CqZAoIuKSJ3jH4h114kdd6l889ME/cjhiwoTOnyIiOlrK2SyTJiHjV7vr9xNxVZ7LBM65iZtGrq0ImAKrWSjyxlZ9odZKtnp+IAAHL8glftW8aD+Rtg3J93G1DykKi98jU/ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t6u+/cwXsIAfcEb1H/erMGeGGqA7WTVAXqo63XYl7/A=; b=J9v53YL10st/4Ga1+G/96yXkv3tEewbEFrNPC/HLxPOFvzj9er91t34U3SQVqF5hzxRRslfQ038fkEYG6BBuXeXDNYSSm9/Yl1qb9He8SRSNJyFmLowQY4kEvhW9TlEMs+1EH3XnKdBeeDM7xgIQ8vsQ+u4xQhvaML4F5ffUJ7fxzqavMm+bil/Xb7zvdu4tuIkk/Zbn1EfzHQYUHqcx9ORLafRhf0csPsWYkQdrU+mhDPutmBjO9jQbz/fW5TdNoVFea1MXh34uq6XlN9zi8k2QXgX+FnMBXHsOHbg1LPk6xGtP7Z9G7eG4pueprxLGWA6z1aRtgbMx3jMT7uMd4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MW5PR11MB5764.namprd11.prod.outlook.com (2603:10b6:303:197::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Thu, 13 Jan 2022 02:54:11 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%8]) with mapi id 15.20.4867.011; Thu, 13 Jan 2022 02:54:11 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/Include: Remove duplicate file Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/Include: Remove duplicate file Thread-Index: AQHYBnMglAgYvimmXkmaeEZqVBRa2axgRLSg Date: Thu, 13 Jan 2022 02:54:11 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eca8d073-7c9e-453e-29f6-08d9d63ff9dd x-ms-traffictypediagnostic: MW5PR11MB5764:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4a/QP/CNe91IkBEXI15uxUKsfrCjoUviPT5E3bin60CdGkMBPi661XdmPyFQnbe6wOWngtBxe8YSBVAEB0EhVFO9zUrdyeutXHEn5QK5vt3ISs6DNyXIMdW4vSEP1aXJ9N8TNNzu5Vs4P8PKtYIuLwht6VUL0lYG/hYJtzeWQGdptLdcevQF7b6DaVArIs9aG1l22Tw6usq5JBcuYA07lm4MsOM2VdEB27h7BrdzrCKik4FnEfBmvWgmAEVBlQOW/dTjM6jW+EIME0fyeQF/OQ7I/iSM27AP91ZS2gTO/8pqh7EFpY4T6+z5/HWyRn3jMEubflDiqdA49NUTOpaWxPo7dCAtouQJ8wQ2RPp1ExlDxuHOZfNshIGGv/wJHskCuxuxeOpu6hd141+3XQ6iPS5UFumAjNZDirvkbf+U9IS2577kWECu/zsiolxVz3jXiCkgTwtIilLfB/e4qgua7W0YH+YkxF7Mvym7QgrxPgSnqWWDyQzPcjl+5ix5waO0p1AG+K+5pN/ulwcj6hBA0FL4OlEd5tKPYF+vnQU4e3Y4A1ticLnThxcdqzttTZIKcYc0SZizTD4QFNnLm0WomHbJBcm4ZXM7gKx3X1jCrh8NhRGsx6c/wvItkhAzT7kSGysa8ImaCTik1eO84LczKAAAC3YxOpaPhJh+wZqwMt8mc3nlO9824KIBymx//LTxfylGBo87KoR0KIsFc35SIQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(71200400001)(9686003)(316002)(52536014)(26005)(107886003)(33656002)(38100700002)(122000001)(38070700005)(110136005)(186003)(55016003)(7696005)(82960400001)(8676002)(508600001)(8936002)(83380400001)(86362001)(5660300002)(76116006)(6506007)(66446008)(64756008)(4326008)(66556008)(53546011)(66476007)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rMV4+pfDnIgS1/UAUtE24wJrX3vwMrqODDFatBCmxhlyVjBhlB8yGHGCgPeG?= =?us-ascii?Q?5WC8RKoGWUUxeN8pQW4WwyyZJVfz+NlkLovNsjw8SUvZ2OkjkjPOUe93W9AL?= =?us-ascii?Q?8wbDuXJHvm0rVjRPBFNbbPlnxxI+e9LSE+X66RcFW1vW1mOrns/6sDWPzlok?= =?us-ascii?Q?kZNBSMR9SmP27scFzfdwC+MabhMTPgfsLOYaX7/Cw9Z2/7MilWZOGLHnRpa3?= =?us-ascii?Q?NZ42uXZNW/KlUgJkA43NpO3n5K5VrlMdSIpmIQpTqpJeZ71PDfy53arr+FVI?= =?us-ascii?Q?Nlal+nqKXiZorlJmnCXfDzs4hdkZR4syQGCsy4fS+s/KEntlN7OsxdLaaESp?= =?us-ascii?Q?tpUz1QfyQ0mk9c4q4x5X0N6O7pyo3pyAor1mG40wYxlv+v81t6ynucRQADKR?= =?us-ascii?Q?B6ivvgGIysnXZnBle7bLIc+7NGmfGuYXv8jB1kkdZJ4Q8xffHw34pjpRJCf9?= =?us-ascii?Q?17O/N9I/vVZZ9uK5Jr5gFQB9/9QSqSAw1Ad4pxWHwMKVNbxDf83IlIUbd3Sn?= =?us-ascii?Q?njrzN8s2Wj+iX527w71z3cLDTAdXb0y61TkWz1DN4b2hDc4qmS4xt3755jSx?= =?us-ascii?Q?8c+rqtReQIcfU7HsWl6rt5Bd4uNO8QfRJv6YQIzYFGAHePYxdBnL7GBERQh3?= =?us-ascii?Q?I7mzXkQa2FH3Fgw2smhjUJI714RQGuyrmaelLR4sbjQtTmb7+0jh242gR8pJ?= =?us-ascii?Q?hai1Xo3CFRhRHbw3MpXvQiw4I0sdt84w5+Gw4UqGHMYw5qydkZYNtXhmHDu0?= =?us-ascii?Q?4TSPokIg4KBSpya/TA11pWWWCM/CGJ4XHJxF2MpRY8l8VBTNwPU2SNldrO4J?= =?us-ascii?Q?YzwgHKV3WWE1xDJRaEY6uLa4qlv9Onqx9OIfjYrGiljAOQ/k2PKky0Y6H6IY?= =?us-ascii?Q?HQ7mJhmymXxNAk61vdac80EJLFXh0596CTrSgERRogIqqxOUmuCEXg9LiXxj?= =?us-ascii?Q?WNT7HklKHwvYOX6KwqT/7PXN55YKPc/P/cekE3KYEWZ0ukkKffRT1C0ZCuNA?= =?us-ascii?Q?LhQm6ZaiAvpDoMNZ8dMO8TzDbFNy6NPEXKEzLrwv4YfERu1JIkshAcjFJp/H?= =?us-ascii?Q?Nk0FlL4juiAhQKxMhyFX9YJRLvWAaqsWlo+r4y1H5mEHU86jP8BlqMvAGMgA?= =?us-ascii?Q?NP8yK71Cxpv8/wkXmA6Mbncn3w6PpvTUiuYCa7LVFeLyPx+p7ShfXhRkjvMc?= =?us-ascii?Q?YUY8/88eg0Nwpl1r8FRbtOKynVuFoUQ2cAOJel9xoN82Ol0gcop6iR2kM6h9?= =?us-ascii?Q?KzF1NqyT/rx11Y32mqC272VVcG5nQURJPbz9bEgm1hM+vFx4XVge/z734K2+?= =?us-ascii?Q?AL4tTZOwJSynyxUAMXJ7OocsIqaZEy5VQdO0oNFgWg1Lz2dwBzBPVRMD2+KF?= =?us-ascii?Q?mMrnfRNvNXTwBsEz1dKYq3K5N3B8AJdQvoIl0IkNi3XQoWK/fX6QCV3eyCYG?= =?us-ascii?Q?I1yqudmX6DcsGyZm0n7eEb9rycmSnXi0yVTpv7FwNif/dKerW0698dsOFaWc?= =?us-ascii?Q?jPJA9lDmBA7RyOCCoAi+7/cFoUeOkEBVr/DxZOjV0PMBamHMRyv3xppOLDhB?= =?us-ascii?Q?JnQMPWUXk7mdmnuMoldUM5AuuYNUacdXZ3avPw+5K2LJvu6sCHCbMMspPlbi?= =?us-ascii?Q?lYRX+qDAWuWCFW1XncwsYI831bRRbIAHvy3TQQU9y983V7rRhxMunYkViNoc?= =?us-ascii?Q?/MCumA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eca8d073-7c9e-453e-29f6-08d9d63ff9dd X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 02:54:11.2314 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pLEfHehcWBDnoZ2qHByXco/lyrXGmUn9qoHeaJYPJfymGppgu7NJPh5sCcRl1RfW59c/qCcPDW1wDi1H/k4Z41FDtgtCe7EP6dErVCEZBVQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5764 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Oram, Isaac W > Sent: Monday, January 10, 2022 2:41 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; Chiu, Chasel > Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] > WhitleyOpenBoardPkg/Include: Remove duplicate file >=20 > Switch to using the IntelSiliconPkg version of the file as both were iden= tical. >=20 > Cc: Nate DeSimone > Cc: Chasel Chiu >=20 > Signed-off-by: Isaac Oram > --- >=20 > Platform/Intel/WhitleyOpenBoardPkg/Include/Library/SpiFlashCommonLib.h > | 98 -------------------- >=20 > Platform/Intel/WhitleyOpenBoardPkg/Library/SmmSpiFlashCommonLib/Sm > mSpiFlashCommonLib.inf | 1 + > 2 files changed, 1 insertion(+), 98 deletions(-) >=20 > diff --git > a/Platform/Intel/WhitleyOpenBoardPkg/Include/Library/SpiFlashCommonLi > b.h > b/Platform/Intel/WhitleyOpenBoardPkg/Include/Library/SpiFlashCommonLi > b.h > deleted file mode 100644 > index ef62ba238d..0000000000 > --- > a/Platform/Intel/WhitleyOpenBoardPkg/Include/Library/SpiFlashCommonLi > b.h > +++ /dev/null > @@ -1,98 +0,0 @@ > -/** @file > - The header file includes the common header files, defines > - internal structure and functions used by SpiFlashCommonLib. > - > - Copyright (c) 2019 Intel Corporation. All rights reserved.
> - SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef __SPI_FLASH_COMMON_LIB_H__ > -#define __SPI_FLASH_COMMON_LIB_H__ > - > -#include > -#include > -#include > -#include > -#include > -#include -#include > -#include > > - > -#define SECTOR_SIZE_4KB 0x1000 // Common 4kBytes sector size > -/** > - Enable block protection on the Serial Flash device. > - > - @retval EFI_SUCCESS Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashLock ( > - VOID > - ); > - > -/** > - Read NumBytes bytes of data from the address specified by > - PAddress into Buffer. > - > - @param[in] Address The starting physical address of the rea= d. > - @param[in,out] NumBytes On input, the number of bytes to read. O= n > output, the number > - of bytes actually read. > - @param[out] Buffer The destination data buffer for the read= . > - > - @retval EFI_SUCCESS Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashRead ( > - IN UINTN Address, > - IN OUT UINT32 *NumBytes, > - OUT UINT8 *Buffer > - ); > - > -/** > - Write NumBytes bytes of data from Buffer to the address specified by > - PAddresss. > - > - @param[in] Address The starting physical address of the w= rite. > - @param[in,out] NumBytes On input, the number of bytes to write= . On > output, > - the actual number of bytes written. > - @param[in] Buffer The source data buffer for the write. > - > - @retval EFI_SUCCESS Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashWrite ( > - IN UINTN Address, > - IN OUT UINT32 *NumBytes, > - IN UINT8 *Buffer > - ); > - > -/** > - Erase the block starting at Address. > - > - @param[in] Address The starting physical address of the block= to be > erased. > - This library assume that caller garantee t= hat the PAddress > - is at the starting address of this block. > - @param[in] NumBytes On input, the number of bytes of the logic= al > block to be erased. > - On output, the actual number of bytes eras= ed. > - > - @retval EFI_SUCCESS. Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashBlockErase ( > - IN UINTN Address, > - IN UINTN *NumBytes > - ); > - > -#endif > diff --git > a/Platform/Intel/WhitleyOpenBoardPkg/Library/SmmSpiFlashCommonLib/S > mmSpiFlashCommonLib.inf > b/Platform/Intel/WhitleyOpenBoardPkg/Library/SmmSpiFlashCommonLib/S > mmSpiFlashCommonLib.inf > index a5bcb5e2f2..b1e0896c7c 100644 > --- > a/Platform/Intel/WhitleyOpenBoardPkg/Library/SmmSpiFlashCommonLib/S > mmSpiFlashCommonLib.inf > +++ > b/Platform/Intel/WhitleyOpenBoardPkg/Library/SmmSpiFlashCommonLib/S > m > +++ mSpiFlashCommonLib.inf > @@ -33,6 +33,7 @@ >=20 > [Packages] > MdePkg/MdePkg.dec > + IntelSiliconPkg/IntelSiliconPkg.dec > WhitleySiliconPkg/WhitleySiliconPkg.dec > WhitleySiliconPkg/CpRcPkg.dec > WhitleyOpenBoardPkg/PlatformPkg.dec > -- > 2.27.0.windows.1