From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: Michael Kubacki <mikuback@linux.microsoft.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH V3] MdeModulePkg: Memory Corruption Error in CapsuleRuntimeDxe
Date: Tue, 25 Oct 2022 22:32:52 +0000 [thread overview]
Message-ID: <MW4PR11MB5821071B94F2BAE3D3B61A7BCD319@MW4PR11MB5821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <534.1666735361087087159@groups.io>
Thanks for the review Michael, I've sent a V4 patch with the added @return
> From: Michael Kubacki <mikuback@linux.microsoft.com>
> Sent: Tuesday, October 25, 2022 3:03 PM
> To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH V3] MdeModulePkg: Memory Corruption Error in CapsuleRuntimeDxe
>
> It would be nice to update @return for AllocateReservedMemoryBelow4G() to indicate NULL should be expected if an internal memory allocation fails.
>
> Other than that:
> Reviewed-by: Michael Kubacki <mailto:michael.kubacki@microsoft.com>
prev parent reply other threads:[~2022-10-25 22:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 1:33 [PATCH V3] MdeModulePkg: Memory Corruption Error in CapsuleRuntimeDxe Nate DeSimone
2022-10-25 22:02 ` [edk2-devel] " Michael Kubacki
2022-10-25 22:32 ` Nate DeSimone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB5821071B94F2BAE3D3B61A7BCD319@MW4PR11MB5821.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox