From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web08.2796.1654635588739415607 for ; Tue, 07 Jun 2022 13:59:49 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=GRc9Tcy/; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654635588; x=1686171588; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jONM9IdBZOao2ICbsS9fiOgitMIHbHgVtLyxAfFBgik=; b=GRc9Tcy/dHdo7609UqAw5KqsKvJ5q5FuqSq9aJyDMGs05rwTq08SvYtr vm9IKbznsP0CGO/MZtnfioyY+64OAnyp8/aX87NhLOD3B+4TFzn5I74RH ehlnId1jY9t4Tel5VlEM1OU3VBZEanc7HfnVQL7FyP2IR68sZcmWdIsZZ 6wO7I5A/kpiwis77iasOFhPZ3VsS1fpEL9rNwjtofVeNbgx2/AcBKsaUD 29a6G32f3q8LLW4endIF11fVRv8SJ3dVb9Tk5X+zlPa7Am8TYYt3pMH9L rpu8+wUxCTZsFHOH++fCS+1bf4fUbTgROjm5F59DpVwGZjQcOIXjT7Qv4 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="257190773" X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="257190773" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jun 2022 13:59:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,284,1647327600"; d="scan'208";a="709643913" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 07 Jun 2022 13:59:47 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 7 Jun 2022 13:59:47 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 7 Jun 2022 13:59:47 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 7 Jun 2022 13:59:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V2b1HeHrB4Jhe1pDa2mhzRj6gN127NuRqGQgZXZOO9JndRFQao5zu3P27ysJ62NBmO8DPUkse/M4KsWNLmGMo51RxG6CvMWbPNtB4m3ozwMfb4XX1qJAi7YkXhoh7YARm51poGjYTZyGfaTx6fMbTvBSsq5ogGWIhK9r3u5RaCb17mS/YbDlKZqB0A9mpnC9U7NiLRiLkVCPcQg1pKwl1HxY9ZlL3l2cFWrI1aNIQ0BGUHIRLvAIMuCSMH2c+dwVZu/oFb1PaxtFek6XWv8iUDYwMRffHXntPND9WyQaxJMbKslrJMtnObyoCuqGt9AvpLfAZeIq2sE0HQCjgkU4SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fP8rlYEDyjvlMtBomDxer5YYQonXus0hS9zTowwlNc0=; b=dDMRVUmNt8khWmy9lkCwsjViBO/wTW1kKwiSy9B6281QYxZR62qW8FKwCSs2zXKIFXKQPL/o9mu2kQXJiNmUrMOROCKTr5FdP6Wgn9oScGVPO+BGyP22CTM9eic3A7SHBOYv18iOh7fcv89sXCG742cfntQWj3em4qbBVV8kOoFUUqh6QXr/ReH26z8+KET2r4lmHYW/qGGtAHM1OVWqvrkDzIJD0NW+y+ZXVWeXIz7PrBUpQB+fZlkAD+0H/YcXGHHBQTzKGEIOkeWSYdIF0S0qHzI2bIDSoEUdaFTtVoq7pF6MZEvvs1nIgtcDSJdq3ZxDgbfbdGN0z+TQWXSi9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by BYAPR11MB2998.namprd11.prod.outlook.com (2603:10b6:a03:84::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.18; Tue, 7 Jun 2022 20:59:45 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::190c:c119:21b7:7589]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::190c:c119:21b7:7589%5]) with mapi id 15.20.5293.019; Tue, 7 Jun 2022 20:59:45 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout Thread-Index: AQHYchNbQ3TmDye9Hk2zkJHxz+U55a1Efb8g Date: Tue, 7 Jun 2022 20:59:45 +0000 Message-ID: References: <0ff4a7949acbaf1fe3ef51ba358bd6b8358339f9.1653687365.git.isaac.w.oram@intel.com> In-Reply-To: <0ff4a7949acbaf1fe3ef51ba358bd6b8358339f9.1653687365.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 880dbedb-eebe-4abc-2045-08da48c8a6c9 x-ms-traffictypediagnostic: BYAPR11MB2998:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UHYT5d/oDz1EdUt9KJbhFOnZCKlpuUz+U3v9qcxqxXWSpY1BsnsoGEn8EGEVOkAukaYeyf9lnMd9KiBxhAEodEVcheKcbD49Z9KAje2Xawoer3uuj/Es2KNRZheSqtK9rfHY5sWFmIC98T48yIRNSGRVDyEf8EkWivXTiy3aAw83B25DkAjfvwgX5xw0C0h4jpb40jUHdXIrESpoIWzzbpQu6aBVb2WswhCCYhunp95IDWTYQIW3Pmotxp5nPjO4sd8w/83tfli/IP3AJ5PBeypc63/7n7S+3ro/VntfRjSaeVugqG7vOhb3Ejy5TGIvW8HWSPxsDE+KWM8CIfGRHqk82PI6L979eLQnrAqcEe0OwqPuL2Khbk/Sl598nlUnH7cqs2s1l+eRGKPzE2eSojc4zgQ0SWzg3KjoAbpqBq+Yr+m0izqlQJI2iivEtuStxVhaq58Yre+kjU9OQo41M8anNHY2qOhHRXb8X2TSmREvEbHT5cO+FM9NJVLfWt41+lJjoLEHA7BM7JhnNWVdlk76+Ba4lc5t4GqB8YxK9IAr2lb1QysTurDLpYRZarCUBXbE2pVr/g+Z43aD8xg7jf6cxpF6jV/gajtEjQ0C5lneQsLo9+5kadarNPZ6NBBf6ZDhEd90xxo8CC1IaFw0uBbr458+UHiFKZr0PYNyJh/ODf7S1iTuKc59G1m4yqh8pue90I6W5jR4JtlNkq++lA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(110136005)(82960400001)(107886003)(76116006)(53546011)(8936002)(66946007)(83380400001)(9686003)(38070700005)(186003)(26005)(55016003)(7696005)(6506007)(122000001)(71200400001)(8676002)(66446008)(4326008)(38100700002)(86362001)(52536014)(33656002)(2906002)(64756008)(66556008)(66476007)(5660300002)(316002)(508600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?di3Ldp2UA63TTBv9rBALtX/TdPQN6Xz+MTPrR9XOvvx3h//K2M7adZ/Ubpja?= =?us-ascii?Q?RgC1ZtXgzcKpZ4vQx+cjCQxpi6K0m+YF8maWNBf22oM0r1DltSsjSQe/B1ug?= =?us-ascii?Q?O3jEcjDJmnCIFUJT0G89qq3DihwZzuod/2e4co5utEpYNX4HawnYNLUbxvVq?= =?us-ascii?Q?J2Bocd7H5bLTSEoVVC1Jh3sAScWKBPkJAe5fPUje06v4NCnGmGmRHVKPwJKx?= =?us-ascii?Q?k4Y+P/hGe7ChykfTheK4evJAmeJugoxmuoRzv10Ue7JSHBGZvVIkPBWKdVXE?= =?us-ascii?Q?ZVpn3tWKtQx04d7vdpaNxyE46KylBqLBa+1R4KBhVtHO5FC23Y7SrDbVt9Hp?= =?us-ascii?Q?jdJWRV75zdPs2cmga01jJX5gHiUCAcMC4ufAXmiMA3a1lNJ2a9kbd043CieF?= =?us-ascii?Q?Z0/UyisGoQjTSICKWEDKyrPrDV4aGpc38PtjgBtI21vIC7NmuknzAxt/HO2u?= =?us-ascii?Q?uo7sbQfYw8jhx/Ymvuiht9RiwxZuTeFrXZoTYVQTdKCGJpzqtp2/dw1JuLJa?= =?us-ascii?Q?ESJOEiyldttR2plk9hjsWqO3cSfjJlhzMfK507FbAvAu9ouRhD2VXp8aY+pn?= =?us-ascii?Q?RgzlJiGeZZFWnrqkhGBVdqMGmEZPR4og/ScFrtKTDk0IrhJTe/36YT996ddQ?= =?us-ascii?Q?4h0/YWO57C1cBc2Dn7c2Lv78i+1DA7XFfFPXeRVj2mWeYzfVsnQ58OFM4pSN?= =?us-ascii?Q?wuKYgNOW1EOFfzIxf1ItTJ2JunccBPmT1J9/NkEHcjOhfhILR3o0XZlL+pvX?= =?us-ascii?Q?LvdK8HCRPUZeXvVW+/m65QEH10TsGXJH3r/ZqSJ5+xNP2vlF6tFv1UyA13Dl?= =?us-ascii?Q?YJORnZTnoa4Hygl3ZKT/JGzheesavKh1ZcHMwZ+ryoOYsLXYIssg/XEdGUiH?= =?us-ascii?Q?6/7jfp5VYmWMdugrAbvITvErcDW7jc8MA0HtlAj8bb9qcK4aeSQiOCkU6HiA?= =?us-ascii?Q?t3gIU65VCJIE045jdP1RWLhAzh64O15DYjQ/iV5mOOPU/5G2SpM5zWOVokIr?= =?us-ascii?Q?CHJ7STMqoGD+QHiqpKGa8hMQjs2PdMsrHEfKKC/EeMeE0jV4qKbIP99kOX/v?= =?us-ascii?Q?SR+CHl4lvVLfAI2BjNIbyTsJR1zs5w0OCYrDlkAwPd+sS6V86Re2bWPJpUuk?= =?us-ascii?Q?ikf20Xl97bx1Gqw08iuwFvYjtZanI/lMP4OHQ9h7mgCMWAmdB9Lh7um2OyXJ?= =?us-ascii?Q?CR4aMQPUe9rectfnVLkIIqzhxDQwoKOUiTM1pGcW9/n89+NIUkIzC6eaJ8Zi?= =?us-ascii?Q?yFXV6yXGhw85nLK6lrmpz+D3iQtUZ3hVz0lrhhoZW4litkkNMvceaa4dbdaV?= =?us-ascii?Q?woNRydZnm4puaKWsfdsK/ndlu4TjCRJxyj5gicNHQ3xEXwi78ouG0/YXFixV?= =?us-ascii?Q?VcwbrIwYc5kXt7TFL+N1nShcvUYZl5mmgkkxRSrBOZ7OvWy9nqM9yUXYIRx9?= =?us-ascii?Q?w/QVqqzWCSo45QTYpEGurACZnfpyRz35pH+cFzdoCTUDQYlLMYF4cTDDi9OM?= =?us-ascii?Q?fB1a9gkLVZ6NfytPr6sanxxo0aGUgWvymCO/GHImMeEsF7vOr6VYMjTbnsjY?= =?us-ascii?Q?PKVhPP5w/neBXwn46rtsdEtofWtdlpDoN1W3b0yPAWxK9tiScHuN9KD0i5kI?= =?us-ascii?Q?VWrzIuCH1/PTcBUNbdm78hLjC+U8PZzwXy5yINmdySfTwCRz0xVHTSIhIZny?= =?us-ascii?Q?s0odwl2WhB22ttNRZx2uFkCyhc4SdfrfradyCg/ycvz/wBqcAxb/z9Dz1Bfq?= =?us-ascii?Q?WftGRUczJiDpW8VEkVEWArv59UQXtvYs6zyFEpnL9UrHEmamKBTF?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 880dbedb-eebe-4abc-2045-08da48c8a6c9 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2022 20:59:45.4891 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7fiw+xt9DnslmwtOJrDPVDTR24iTqsbblqlu+ivAsgI4ARhy3z0arpnRYeVY1m5RJle2TVbwQTI3eyK+Y1UFxtwZimelh+h58i4hR9Y26Rk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2998 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Isaac, Please see feedback inline. Thanks, Nate > -----Original Message----- > From: Oram, Isaac W > Sent: Friday, May 27, 2022 2:47 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Chiu, Chasel > > Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] > WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout >=20 > Disambiguate the PCH_DMI_CONFIG and PCH_TRACE_HUB_CONFIG > structure definitions such that compilers generate same binary layouts. >=20 > Cc: Nate DeSimone > Cc: Chasel Chiu > Signed-off-by: Isaac Oram > --- > .../Pch/SouthClusterLbg/Include/PchPolicyCommon.h | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git > a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCo > mmon.h > b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCo > mmon.h > index 0e10d0b8f0..c95481bf1d 100644 > --- > a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicyCo > mmon.h > +++ b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPol > +++ icyCommon.h > @@ -1351,7 +1351,9 @@ typedef struct { > **/ > UINT32 DmiAspm : 1; > UINT32 PwrOptEnable : 1; ///< 0: Disable; 1: Enabl= e DMI > Power Optimizer on PCH side. > + UINT32 Rsvdbits1 : 30; > BOOLEAN DmiStopAndScreamEnable : 1; > + BOOLEAN Rsvdbits2 : 7; Please convert this from BOOLEAN to UINT8. Since there is an strong require= ment that the bitfield be exactly 8 bits long it is best to use a data type= that is explicitly 8 bit. > UINT32 DmiLinkDownHangBypass : 1; > UINT32 Rsvdbits : 29; > UINT32 Rsvd0[6]; ///< Reserved bytes > @@ -1447,6 +1449,7 @@ typedef struct { > TRACE_HUB_CONFIG TraceHub; > UINT32 AetEnableMode : 2; > UINT32 PchTraceHubHide : 1; > + UINT32 Rsvdbits : 29; > } PCH_TRACE_HUB_CONFIG; >=20 >=20 > -- > 2.36.1.windows.1