From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F240894207C for ; Fri, 17 Nov 2023 19:49:32 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LyrIOPLfo9KOavwTIi2qqgsi7RwyJ0nGWLEOeXsrgtQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700250571; v=1; b=MnGOEhuhHZLWPIm9epzX25iPNn4s+76nBCAda78nGkcplVMq0jl9mH4zRYyDg17K7qBb6f5K /2dJ1p1oy7plRF+zC12VhEfYNwpBFNWBLkczIWoCTK5yQyNvPar/49jpJnVq+rr86/vsCRq5ZOM YQ1Ix1HU4mgSCQ9gSxZjRFmU= X-Received: by 127.0.0.2 with SMTP id B2wYYY7687511xNW5GJmRxxq; Fri, 17 Nov 2023 11:49:31 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.4867.1700250570542084389 for ; Fri, 17 Nov 2023 11:49:31 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="422453092" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="422453092" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 11:49:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="836161054" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="836161054" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Nov 2023 11:49:30 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 17 Nov 2023 11:49:29 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 17 Nov 2023 11:49:29 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 17 Nov 2023 11:49:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=alrDDzrIJcqnWeR+mSVm734XHDicGA9EexpnEylizxYxwdjFdJNuHpRC8BbCHuzun5EtqknfbojKV1YEA90mqX1xiRVxlqAlyVSk4dMFISrK+GIqgM3cIO77YWWfPLSs2yy9fjdHU1kgS5smeqO37wpT2SQ+41oJch94vUVskO7d+A9JMvhtamEk6SMSqAf54/f1cTclZhqYirvuZ25NhrPXgcOKTewtUZohO/8A018et05FPFJBB0b39Tw2W80G/5oOUo5lybPgCoyWN3aCtfcU+92mGZkw9XGWRjeN9O/yi93oPMknbtv2SVMLYFJiMB7cmPMGww8o3pLEg9OqPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mwpdsKdbDhHu4M4nK1MEHTyjyzDoJcWTFnxGhzDmqeY=; b=KChxjAISOq2Ho/JghDQQwWjlxbAtw40+c9LnBrMODDfcBwGZm/LVZ57h4E3KZH3TN4WvJUqidWnNjiC0zU088QIhml9xhbTNhYDdfb2TfHTEKrP+1GNhIOb3zmevElBp705hLrvOkGM2L4LG2KcBFLtapJQgLIFgRCR0dbc0wQL91qV4UDRqiUqOFOKi7RJWFnFl22EWsMk9+uBtllOJQahtwwbtKB6Poph81RT53fT1lbUS9LS8x0uodeC3fC2HImIdlBfe4lBxKELAlZpN6X9PZIC31cHFwYcvQgybEnDtHdWwFey91BUeUGI4S7ozHTYndR8dDaR1IouoMKVA+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by DS0PR11MB7735.namprd11.prod.outlook.com (2603:10b6:8:dd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.21; Fri, 17 Nov 2023 19:49:26 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::ced7:2db7:4cae:ab0]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::ced7:2db7:4cae:ab0%6]) with mapi id 15.20.7002.019; Fri, 17 Nov 2023 19:49:26 +0000 From: "Nate DeSimone" To: "Gong, Zhen" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback Thread-Topic: [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback Thread-Index: AQHaGOaig/BwjzHDHkSz/axG02YEw7B+7Hag Date: Fri, 17 Nov 2023 19:49:26 +0000 Message-ID: References: <6bc749b44eeed932426c046838c0901d15181a64.1700177884.git.zhen.gong@intel.com> In-Reply-To: <6bc749b44eeed932426c046838c0901d15181a64.1700177884.git.zhen.gong@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|DS0PR11MB7735:EE_ x-ms-office365-filtering-correlation-id: 769f35d5-e0a8-4f16-9747-08dbe7a64e59 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 6++9vIb/pE7waReOjJnBie2ufJJ0GX4s17k24Uux9V8qQWYh8+t41cA920IdgxvkVIv1fp38bdSCa+dyJ+vDhfVqC3W6BIb26vgtS9LJlxcTquKqB+86usS9Y4Cy1Llix87D5LBn4oiiDBSZz2qnhWnjmNYN3H5O5Drdt3pZWyWEqk+4K6yOoOMqHmbQh5++lXJ63zSSdAEhiE+bQSE6VG3Dogg3o+kL07wC/WDUe1DMYAIZfA8XsmEanydfSs1FD7Ahj4eU8qDHair/8F6jg3gVU0X3r6sMbsPvnxfhnLRY2ZHX2WYK7jO9zPBqdbjmoDfI9ayC7aRgwM+pmrNRJomvZYcY/XqkuqPKBkQE8/4pPTbbJvtlWC0/Cbvx8fupzwtKH2CPP8Oe+pD18h7ttvFMsaY99LWqntrF7NhBAY2KQ4qBtSvkaEYvxKiXsOs8eT/WTXi9LGM8KE8TDSTPxLtqNzCZLnSduVwbXGPtxqWeIGBAHoSnrPDoGS/qS2XG+0pU1iNGBeWpcIC3gLHa1Jxy6GEbmvFyUqfebusfvN3Sfa3450bdxm++f+53bETgYi6cJE4B/cYc/xgh+0cfrcrvMcJQhlAoaB1kR5vAoPzuhvlfpDSk0ESv5delRbFm x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5WPIty//sv4l3LPcyldeUBuzsoRQs4bI+MXmu1XesRAHa1cKtLzASa3h9wvr?= =?us-ascii?Q?ig9wkiecM0s7FdiRGAVJwlXszyOLMnyeL+rPxCBuu7HQaUBY5xE0PtVsAX4/?= =?us-ascii?Q?FxwQV6T7I/S4YSxaUYupWlZWxrl85IUaPFA0XhIPfqjsSHKq7V+P0lHVxA6z?= =?us-ascii?Q?Yjv7RMDuNMUSzmbibpQFGbVjJFMFezdsBhshREP5571Fj7A/4Br/IUjAP9/H?= =?us-ascii?Q?3WTaNDz4ZSotaRRZATdpxxKPQASiVICgnpa+PqSAUwxvUUSn7xfXxLcpSV+H?= =?us-ascii?Q?NFX1B0iOarEDcsz1uXpbwZEwRElsAW0f7XAUia3QeyXM6l7HOjEGLUnFIJaB?= =?us-ascii?Q?xoYQGXgYZTlRDgqFYu464b/j1u+Ni+AJ3ZvW3nlykjRz8QdaZRn50g99CEnT?= =?us-ascii?Q?Ti4nkR5V0zWa48e/Fa8pirwQsY3n1tO4E7Oxfal5xZMQBvvuYe7IObEwJm8i?= =?us-ascii?Q?kgZOk3OKeosf+i4n/tMZEOofI6V6kabgZiOZ9XBDeyKfLUBSO2hGKYPxNPof?= =?us-ascii?Q?WWnw7nHcY5/y3vu4bVIFigA2bIH06mo2qkZynlKtRbyQ2EyCiY55X5n/+NF/?= =?us-ascii?Q?6yT2HnfWltZKn3ba7h1z4bktcFCR/BiCsllRXcLemffVX3xgNp9ZD1VUDADW?= =?us-ascii?Q?pwsMMuO1bZ9zT35IYKOcWsTTWv1O85F2LCp/w77rfSgd2uvyYBRrf6aDtQCs?= =?us-ascii?Q?qpaS/UNMS/cMgquAACghwveLSU0HSNXOR+dBn43Qml7Sv82PJGnuXMmBPMCa?= =?us-ascii?Q?heFWqxSjExIqNck4UPcQlf+MoOyVkMDYDCG+o+hU4OS1EoZv1bMQJh8anV0d?= =?us-ascii?Q?CQbAYWQAFQa60e2Gr9oI5nJ56koy91+mM96ZF/B6JYDq+Vv/4uC1kCghf5oT?= =?us-ascii?Q?Jx8A7t0m41BPyibDDV4bPRazx18K0kQj4VMiYcLFd1l/skv4kj4zdMM6MJYv?= =?us-ascii?Q?9W/NBnwlUNT5s4rd2/HWIRty2k3CAbxeEQE/PQ8dCukzYoRD8qVmYa3oQ8tH?= =?us-ascii?Q?h1j3X6EGBsgSN+0eUuhqSN2geIMrq2OuAs5Pt7bFcK8sd+kCF88nPmtiXZhi?= =?us-ascii?Q?JetbNUEITKPdNcDUAaqWYZj87vZZLJjEgB7qFXGybWSbgRVe7XUEU+hA4Sbf?= =?us-ascii?Q?3IGue3aC+ek1OQg7ldiYPWzDXaAoF4NLLQy4cEKYnxhuzbu+r3DHaINo5DuF?= =?us-ascii?Q?Oldm72LrR+GA6iBh5t4lXlNKHKPirVvBkH+37z58XiTbBrkPh68gfw4QjRRJ?= =?us-ascii?Q?8FY588dzNZ/rIaDkpBbDc/2ZRy919f/keJwAXXWdubtIIDZVrMqWTnNXXt2S?= =?us-ascii?Q?JY4LtCJNjI//FFoCmTs7Mcz3T3M/rDdafYpRbvmacJ2ynOhoCfGNhHZ2Ox3a?= =?us-ascii?Q?VUMeN5CbYMB5efKme5BCGZ1Sl7L14WdIIMRtsYgxeALbn734thqs3KF4a+t2?= =?us-ascii?Q?PX8CNU/64th+VjaaTyJZnKpRurM35o2LrS9VMYUN9OlsP/YyLTwpvjiRlZJN?= =?us-ascii?Q?XZTCD9NBFv8bJhSVG95aTAkigOvrYNCQ9uouvXXGLbhXnjmWVaXZrdhMePWr?= =?us-ascii?Q?FW67MKnYe9LLYsK61rDNpB4l0TTg+XKikyFLPgpY0sZ1jS08H+I1/k6qOGd3?= =?us-ascii?Q?qg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 769f35d5-e0a8-4f16-9747-08dbe7a64e59 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2023 19:49:26.8058 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y1lnTtNmQi911G2udFP6mUwT/o5YZQMsbMV8ONW5M5CcE0XhYkslf6w0KojswTh/Q+Kyh/NV+KPV5kkH/ZyjlBzSrOayhOtXbpWkrIZS36g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7735 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: prrBxHO0D8Q1ye8m1SETPkJSx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=MnGOEhuh; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Pushed as 937e87b. -----Original Message----- From: Gong, Zhen =20 Sent: Thursday, November 16, 2023 3:42 PM To: devel@edk2.groups.io Cc: Gong, Zhen ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to = AfterConsole event for callback Use AfterConsole event instead of ReadyToBoot for callback so the driver c= an update SMBIOS table before booting to setup menu. Cc: Nate DeSimone Cc: Liming Gao Change-Id: Ife697f4c78449b90f17ffa7b7bc5a6a5f77d9436 Signed-off-by: Zhen Gong --- .../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf | 3 ++- .../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h | 1 - .../IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c | 16 +++++++++------- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru= /IpmiRedirFru.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiR= edirFru/IpmiRedirFru.inf index 24fbc94128da..814f595b5abe 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRe= dirFru.inf +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/Ipm +++ iRedirFru.inf @@ -25,6 +25,7 @@ [Packages] IpmiFeaturePkg/IpmiFeaturePkg.dec MdePkg/MdePkg.dec MdeModulePkg/MdeModulePkg.dec + MinPlatformPkg/MinPlatformPkg.dec =20 [LibraryClasses] UefiDriverEntryPoint @@ -32,12 +33,12 @@ [LibraryClasses] UefiBootServicesTableLib BaseMemoryLib MemoryAllocationLib - UefiLib IpmiBaseLib =20 [Guids] gEfiIpmiFormatFruGuid gEfiSystemTypeFruGuid + gBdsEventAfterConsoleReadyBeforeBootOptionGuid =20 [Protocols] gEfiSmbiosProtocolGuid diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru= /IpmiRedirFru.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRed= irFru/IpmiRedirFru.h index 9fd0067973a6..b5ffe1ad0518 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRe= dirFru.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/Ipm +++ iRedirFru.h @@ -12,7 +12,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include #include #include -#inclu= de =20 #include #include diff --git a/Features/Intel/OutOf= BandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c b/Features/Intel/Out= OfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c index bd4b35ba5793..9c63fae42678 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmb= ios.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/Fru +++ Smbios.c @@ -454,15 +454,17 @@ GenerateFruSmbiosData ( =20 mFruRedirProtocol =3D This; =20 - Status =3D EfiCreateEventReadyToBootEx ( - TPL_CALLBACK, - GenerateFruSmbiosType123DataNotified, - NULL, - &Event - ); + Status =3D gBS->CreateEventEx ( + EVT_NOTIFY_SIGNAL, + TPL_CALLBACK, + GenerateFruSmbiosType123DataNotified, + NULL, + &gBdsEventAfterConsoleReadyBeforeBootOptionGuid, + &Event + ); =20 if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "GenerateFruSmbiosData(): EfiCreateEventReadyToBo= otEx failed with return value: %r\n", Status)); + DEBUG ((DEBUG_ERROR, "GenerateFruSmbiosData(): Create AfterConsole=20 + event failed with return value: %r\n", Status)); } =20 return; -- 2.39.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111409): https://edk2.groups.io/g/devel/message/111409 Mute This Topic: https://groups.io/mt/102638229/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-