* [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback
@ 2023-11-16 23:42 Zhen Gong
2023-11-17 19:25 ` Nate DeSimone
2023-11-17 19:49 ` Nate DeSimone
0 siblings, 2 replies; 3+ messages in thread
From: Zhen Gong @ 2023-11-16 23:42 UTC (permalink / raw)
To: devel; +Cc: Zhen Gong, Nate DeSimone, Liming Gao
Use AfterConsole event instead of ReadyToBoot for callback so the driver
can update SMBIOS table before booting to setup menu.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Change-Id: Ife697f4c78449b90f17ffa7b7bc5a6a5f77d9436
Signed-off-by: Zhen Gong <zhen.gong@intel.com>
---
.../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf | 3 ++-
.../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h | 1 -
.../IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c | 16 +++++++++-------
3 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf
index 24fbc94128da..814f595b5abe 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf
@@ -25,6 +25,7 @@ [Packages]
IpmiFeaturePkg/IpmiFeaturePkg.dec
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
+ MinPlatformPkg/MinPlatformPkg.dec
[LibraryClasses]
UefiDriverEntryPoint
@@ -32,12 +33,12 @@ [LibraryClasses]
UefiBootServicesTableLib
BaseMemoryLib
MemoryAllocationLib
- UefiLib
IpmiBaseLib
[Guids]
gEfiIpmiFormatFruGuid
gEfiSystemTypeFruGuid
+ gBdsEventAfterConsoleReadyBeforeBootOptionGuid
[Protocols]
gEfiSmbiosProtocolGuid
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h
index 9fd0067973a6..b5ffe1ad0518 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h
@@ -12,7 +12,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include <Uefi.h>
#include <Library/BaseLib.h>
#include <Library/DebugLib.h>
-#include <Library/UefiLib.h>
#include <Library/BaseMemoryLib.h>
#include <Library/MemoryAllocationLib.h>
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c
index bd4b35ba5793..9c63fae42678 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c
@@ -454,15 +454,17 @@ GenerateFruSmbiosData (
mFruRedirProtocol = This;
- Status = EfiCreateEventReadyToBootEx (
- TPL_CALLBACK,
- GenerateFruSmbiosType123DataNotified,
- NULL,
- &Event
- );
+ Status = gBS->CreateEventEx (
+ EVT_NOTIFY_SIGNAL,
+ TPL_CALLBACK,
+ GenerateFruSmbiosType123DataNotified,
+ NULL,
+ &gBdsEventAfterConsoleReadyBeforeBootOptionGuid,
+ &Event
+ );
if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_ERROR, "GenerateFruSmbiosData(): EfiCreateEventReadyToBootEx failed with return value: %r\n", Status));
+ DEBUG ((DEBUG_ERROR, "GenerateFruSmbiosData(): Create AfterConsole event failed with return value: %r\n", Status));
}
return;
--
2.39.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111330): https://edk2.groups.io/g/devel/message/111330
Mute This Topic: https://groups.io/mt/102638229/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback
2023-11-16 23:42 [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback Zhen Gong
@ 2023-11-17 19:25 ` Nate DeSimone
2023-11-17 19:49 ` Nate DeSimone
1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2023-11-17 19:25 UTC (permalink / raw)
To: Gong, Zhen, devel@edk2.groups.io; +Cc: Gao, Liming
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Gong, Zhen <zhen.gong@intel.com>
Sent: Thursday, November 16, 2023 3:42 PM
To: devel@edk2.groups.io
Cc: Gong, Zhen <zhen.gong@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback
Use AfterConsole event instead of ReadyToBoot for callback so the driver can update SMBIOS table before booting to setup menu.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Change-Id: Ife697f4c78449b90f17ffa7b7bc5a6a5f77d9436
Signed-off-by: Zhen Gong <zhen.gong@intel.com>
---
.../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf | 3 ++-
.../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h | 1 -
.../IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c | 16 +++++++++-------
3 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf
index 24fbc94128da..814f595b5abe 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/Ipm
+++ iRedirFru.inf
@@ -25,6 +25,7 @@ [Packages]
IpmiFeaturePkg/IpmiFeaturePkg.dec
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
+ MinPlatformPkg/MinPlatformPkg.dec
[LibraryClasses]
UefiDriverEntryPoint
@@ -32,12 +33,12 @@ [LibraryClasses]
UefiBootServicesTableLib
BaseMemoryLib
MemoryAllocationLib
- UefiLib
IpmiBaseLib
[Guids]
gEfiIpmiFormatFruGuid
gEfiSystemTypeFruGuid
+ gBdsEventAfterConsoleReadyBeforeBootOptionGuid
[Protocols]
gEfiSmbiosProtocolGuid
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h
index 9fd0067973a6..b5ffe1ad0518 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/Ipm
+++ iRedirFru.h
@@ -12,7 +12,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include <Uefi.h> #include <Library/BaseLib.h> #include <Library/DebugLib.h> -#include <Library/UefiLib.h>
#include <Library/BaseMemoryLib.h>
#include <Library/MemoryAllocationLib.h> diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c
index bd4b35ba5793..9c63fae42678 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/Fru
+++ Smbios.c
@@ -454,15 +454,17 @@ GenerateFruSmbiosData (
mFruRedirProtocol = This;
- Status = EfiCreateEventReadyToBootEx (
- TPL_CALLBACK,
- GenerateFruSmbiosType123DataNotified,
- NULL,
- &Event
- );
+ Status = gBS->CreateEventEx (
+ EVT_NOTIFY_SIGNAL,
+ TPL_CALLBACK,
+ GenerateFruSmbiosType123DataNotified,
+ NULL,
+ &gBdsEventAfterConsoleReadyBeforeBootOptionGuid,
+ &Event
+ );
if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_ERROR, "GenerateFruSmbiosData(): EfiCreateEventReadyToBootEx failed with return value: %r\n", Status));
+ DEBUG ((DEBUG_ERROR, "GenerateFruSmbiosData(): Create AfterConsole
+ event failed with return value: %r\n", Status));
}
return;
--
2.39.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111406): https://edk2.groups.io/g/devel/message/111406
Mute This Topic: https://groups.io/mt/102638229/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback
2023-11-16 23:42 [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback Zhen Gong
2023-11-17 19:25 ` Nate DeSimone
@ 2023-11-17 19:49 ` Nate DeSimone
1 sibling, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2023-11-17 19:49 UTC (permalink / raw)
To: Gong, Zhen, devel@edk2.groups.io; +Cc: Gao, Liming
Pushed as 937e87b.
-----Original Message-----
From: Gong, Zhen <zhen.gong@intel.com>
Sent: Thursday, November 16, 2023 3:42 PM
To: devel@edk2.groups.io
Cc: Gong, Zhen <zhen.gong@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>
Subject: [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback
Use AfterConsole event instead of ReadyToBoot for callback so the driver can update SMBIOS table before booting to setup menu.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Change-Id: Ife697f4c78449b90f17ffa7b7bc5a6a5f77d9436
Signed-off-by: Zhen Gong <zhen.gong@intel.com>
---
.../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf | 3 ++-
.../IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h | 1 -
.../IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c | 16 +++++++++-------
3 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf
index 24fbc94128da..814f595b5abe 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/Ipm
+++ iRedirFru.inf
@@ -25,6 +25,7 @@ [Packages]
IpmiFeaturePkg/IpmiFeaturePkg.dec
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
+ MinPlatformPkg/MinPlatformPkg.dec
[LibraryClasses]
UefiDriverEntryPoint
@@ -32,12 +33,12 @@ [LibraryClasses]
UefiBootServicesTableLib
BaseMemoryLib
MemoryAllocationLib
- UefiLib
IpmiBaseLib
[Guids]
gEfiIpmiFormatFruGuid
gEfiSystemTypeFruGuid
+ gBdsEventAfterConsoleReadyBeforeBootOptionGuid
[Protocols]
gEfiSmbiosProtocolGuid
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h
index 9fd0067973a6..b5ffe1ad0518 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/IpmiRedirFru.h
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/Ipm
+++ iRedirFru.h
@@ -12,7 +12,6 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include <Uefi.h> #include <Library/BaseLib.h> #include <Library/DebugLib.h> -#include <Library/UefiLib.h>
#include <Library/BaseMemoryLib.h>
#include <Library/MemoryAllocationLib.h> diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c
index bd4b35ba5793..9c63fae42678 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/FruSmbios.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiRedirFru/Fru
+++ Smbios.c
@@ -454,15 +454,17 @@ GenerateFruSmbiosData (
mFruRedirProtocol = This;
- Status = EfiCreateEventReadyToBootEx (
- TPL_CALLBACK,
- GenerateFruSmbiosType123DataNotified,
- NULL,
- &Event
- );
+ Status = gBS->CreateEventEx (
+ EVT_NOTIFY_SIGNAL,
+ TPL_CALLBACK,
+ GenerateFruSmbiosType123DataNotified,
+ NULL,
+ &gBdsEventAfterConsoleReadyBeforeBootOptionGuid,
+ &Event
+ );
if (EFI_ERROR (Status)) {
- DEBUG ((DEBUG_ERROR, "GenerateFruSmbiosData(): EfiCreateEventReadyToBootEx failed with return value: %r\n", Status));
+ DEBUG ((DEBUG_ERROR, "GenerateFruSmbiosData(): Create AfterConsole
+ event failed with return value: %r\n", Status));
}
return;
--
2.39.2.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111409): https://edk2.groups.io/g/devel/message/111409
Mute This Topic: https://groups.io/mt/102638229/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-17 19:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-16 23:42 [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/IpmiRedirFru: Switch to AfterConsole event for callback Zhen Gong
2023-11-17 19:25 ` Nate DeSimone
2023-11-17 19:49 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox