From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web08.6878.1661993721234459674 for ; Wed, 31 Aug 2022 17:55:21 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=IsiwGmk/; spf=permerror, err=too many SPF records (domain: intel.com, ip: 134.134.136.126, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1661993721; x=1693529721; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=MNR+irgGYyD6/UBhm+6TJgdqnVElk1+GRc5cR4ErqtY=; b=IsiwGmk/A2g2evsQQewiT/lF9mKxROhCYxL/cXdbGVk1IlL0j7WPfM9+ PyMRroJ7wJAitcurKz3zzKfMfnELfVDoRKo8hPV5RNd2CrQLrxwm093u+ yfHAYV4czwCSeGlEga4SbMa8cS3UNbRrrrsDLIScumXWHw18LeUlsjaw3 koGcz77N9EoBrKxaGe1gWG+MQarLw2dKjP60MEvLayjfhoMd1jfwvsuoo 7z9nAsvPxQ6JIJa1pne7yiSP3V9Mk9jnuWWz/f9v9KlK1hgeZ2bbhMPeV 0gXsDdfCoPjnwu8EEBychKyGpgUoSAk17X49VeuCkVzvk4jZ8jHQDOgU7 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10456"; a="278603470" X-IronPort-AV: E=Sophos;i="5.93,279,1654585200"; d="scan'208";a="278603470" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2022 17:55:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,279,1654585200"; d="scan'208";a="608366437" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 31 Aug 2022 17:55:20 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 31 Aug 2022 17:55:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Wed, 31 Aug 2022 17:55:20 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Wed, 31 Aug 2022 17:55:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nrtDeOFZ+51Gn72ELCdsA+9/Cq19ln1+/4arfRKlVkxVw8aPeTQSXIOIu0xrgfetBHmq2P4fRP+KrWht9xX2tymCBwc3Z/f0q86rskRoZV96y3AR7TMKMZmRq7hKkIY8Wm5IVHaaB7OTjs9wjlXtjinv/P5UxBpW1nCV+j04SfiA8Btp5MnWvsfnKSZCPIFhHW3cXaGH497UC9SO57gOkptWO+a+dz1hmAwM8SjaKYbleK28X4iMh1qD6MEt8G9F9sYRxKJSZUR+R0XlzgCoCxNl/u6VyuvMR1r/gM/HyM/3gSU1eGjYE3eHAoSFEdKA2/35EafJLh0wI32z8h6t+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ap20LCJR0j1tDMpsupkavBTcuLthGHXwNBYL+Igtp38=; b=DWMQMJzbuXqP3fVQgfuchF6EjvDCH+98kdueNujILkwvnic5MdXfWKphrEo+xcsR90fi1E4ew9ZHJrWQmx2x1+VxEb/KCfbBKKYxK0xJmg/ewDxrRrF1k777jqniGVbb+pHADDRuJgZ/QyC60Iw0+f39sL97uMuxdNLiTY01nCtRl3oOtrE8ujIvJF6GMpfHCUgMIQHpkTxg2tcQyaCMPXL0ToZjs0m3kOMc7kseZt+BBpSu9r7OJx8WfrTyiBypgiAU6/SPF3QPFJm4m/0fFaVZObACWIx8e1w43Ljggb/JkozOqp2rUzGzyYaek2597bPbe5IfPJAvaRy8TyKOCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by PH0PR11MB4920.namprd11.prod.outlook.com (2603:10b6:510:41::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Thu, 1 Sep 2022 00:55:18 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2c94:f950:2ac4:d92f]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2c94:f950:2ac4:d92f%9]) with mapi id 15.20.5588.010; Thu, 1 Sep 2022 00:55:18 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Gao, Liming" , "Dong, Eric" , "Chaganty, Rangasai V" , "Luo, Heng" , "Kethi Reddy, Deepika" , "Esakkithevar, Kathappan" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board porting Thread-Index: AQHYnftiACYfnP+OlU6FQGurRje+ZK3J/uVA Date: Thu, 1 Sep 2022 00:55:18 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f79379a4-8963-40f2-dc8a-08da8bb4a3be x-ms-traffictypediagnostic: PH0PR11MB4920:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HsCHXdiBLZlm16O2GpQUc8yYZHaMfVBLXyszLKu6teRrQ12L69tmVpWijTSnudeXBTyTcm4Ja4yYsKHzijl5OLF8FHTB4SXtbRVGOrHUyPNexUeET/w6lZqdAXUFcrdbOL1P25qfqWk16SjRQTRoc1NWPv1V6IeGiEi9PotCdWempgUvqvh2MBSDtkYbN01ZZwN17DTLU1XxigCvryC7CoHUIPZK6j5tIPPi0WP0bmtcX4/6Vbm1yNMGpvg6d9HkrZdvK8EemWusk96G2+RBJ8n0w2qsJNW1K+y5yjnkbDINEKiqndpoXKDb9tGDAOSC9NqqUnLSLb3DtFYvdufGwL0pYRkbPvfVzJHdMMeO4cSmVVwuZoV8e8IjVVG/cTdA3QRYhjQ3mdOMEQZpxm86YL2lZyldBRPOZuMuG/p8BCPbmtArmNNyITn9BF1X7YUCWV7B/AmXdyFcEvqjyISqOCXVFRzlKzR1vxgGM1jiS59YdKvA8rpEZ4wf5+4q+q/Z/qaUCWHJEnpYnPwpcvqcpC3XCdqlOKgXEpS49sLP3ePFuXs2zGcC3Kp4CYWEm7qXdB1F8zeOsmQmkStpBFUj9FSoJHKcNmytxaFK+rqz5dI5k8BPbbRjZS3p17GdeHDyXbrKjgzWGxaluRCbA+qRYL+YUr/c37w9yccBco8XizSEATfxB0BRc6hgYylRPktBn4SrMZ1U80d1Bes1iGOYGyzy3vXlPth9jcc0woDpmbtHKC4Y2IRervhO5V9xtpswksjWISZYmledzy0TyIt4lA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(39860400002)(136003)(366004)(376002)(122000001)(4326008)(8676002)(66476007)(66446008)(66556008)(64756008)(186003)(76116006)(9686003)(5660300002)(19627235002)(6506007)(53546011)(41300700001)(38100700002)(107886003)(66946007)(7696005)(316002)(26005)(86362001)(2906002)(478600001)(54906003)(82960400001)(55016003)(33656002)(8936002)(83380400001)(52536014)(110136005)(71200400001)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?FMP5DxxHssWFu/9jApFzcVpNTmk4eSKCxSWHFhlndsrS21KaDiEQJiJj/dj5?= =?us-ascii?Q?R6NXbxmaJ1W30o0zUvFUXk2lCkmuMv06VeQGh0DB78cm3zVA3YW9aDthSUpR?= =?us-ascii?Q?SSV/OKAJO0RonpvkZcbhEDMr+vL8oaYaduGBzQ1eP6FL/WV5mGUHOZ46CrS1?= =?us-ascii?Q?iM0C13GGIYgSqMoEekPpdh8UVXp7OgFVkzONm9WgHD/+UkD6Z4jBGccCH5B4?= =?us-ascii?Q?mQq8YVn7K6gwVQ5/hOkKm42af7VqpTPkEXwUgGntEOSfjTbfcF4ofOZSvWQt?= =?us-ascii?Q?5jw4pEZkYftRe+7uIkDQD9WXY35p0A+UD8vkKKvFi8QxpMD9izWp8I9+ORbG?= =?us-ascii?Q?IXjWECY1zE/CgPJmVJaSdMPx1fpQ5Jqoj8gDYWQUY6HJiIbRd8aUrlxX8OAt?= =?us-ascii?Q?vF6MobTeKeiURBE5KUx264sc68bU28RKwe0Zz5d5WnGnGUdMxcbawBko6XBI?= =?us-ascii?Q?Qe7/FTCVyaotHZVRKsuok2aws6DQPCfdPZYEw/t0PBYsd8L+rQQJQw2rOwiK?= =?us-ascii?Q?Oexeb4/0oq/i4jRZ0mrjIwLe2lL5ISZzfuo6EJBKugT8PQ/+D0cQOnlQ7TT8?= =?us-ascii?Q?kZS6MHOEtTpo2QByMVOCu/+/qVTxFz7c7re4Hm5/SKJp8B0NpMcWf9uIIEHX?= =?us-ascii?Q?/FYQAN5HCAlbzYffiShUcdalZlmfuUHW+B2r6+xumlokHDsHHvglyWXI4vgE?= =?us-ascii?Q?BEhjl68iEbZa729Cy2koPTOQX8BYiyPpHdUAAK1SuUB+//ARaPg8DKKIDd39?= =?us-ascii?Q?RuU1jxqAn6KtmoRlSha8maAdN9WmFNRscDOUu3Ox5I0x1cdMepmyPdZLpuXn?= =?us-ascii?Q?m5eplD/R8wqAfr4rQVVfSsX9YDjLwTXf+N93cmCb+27YrhUE7u9tCw59fb6E?= =?us-ascii?Q?PzhF2PJGptdBrLJizrlRi1xXoq2c2bTlXxI2sYO15cBAvhCp2uOyeH1oaibf?= =?us-ascii?Q?bf5gWsz4UEskR2kwwBQnW9JnTYnH6VhwuVbos2aDXJUXFj7eeQbSS68rW8P9?= =?us-ascii?Q?cVCF3qZLvGyKXUOg3Xot4tlg8XSjTj0Hrcdi9hVxlVpLrODlV/QoimBKG43W?= =?us-ascii?Q?0qg6vPWK7x6Unm/w1mHk14ppedaVE6P5YZ+DBzvhCMSPYvW/hzPu89g3sQmH?= =?us-ascii?Q?+mUGElMEB5sd8Dje4HuZJfjlcsObCBkjM7Tzex6i7nIJuYrausUsWuH7mLUM?= =?us-ascii?Q?QQDzj7eyB03t3MNZK2o8ubEgkjvKGHMTpjQY2BYLGH8+7ef9Ym6egsDRXV/+?= =?us-ascii?Q?S0oaM67k3OFizhREk3laBKgM2IhaUtfMhpU/kuT+kQSLufBQPvETQgQtp49G?= =?us-ascii?Q?u4hd8/KRJn4BYjourzTkPCDfztqlGJMkFjW9YiWQAnUERADq+z6Itqia8G5y?= =?us-ascii?Q?0gQ1skrkaTbzq+yFnt9YAK4JLXYE5H80YHWPD7Bp9Jsmpr9YXgrl1P9t13lT?= =?us-ascii?Q?X/E10TpHnWeN7yPmVEoKOWUHF8VSNdz7u4OlxjLW9sCzWAujl+XXLrwuYGOY?= =?us-ascii?Q?IlKxh+86HMH74woMJtki2d6YyJplUX52Ij4lnUKZuoVCJyPz1BpuRbGyrGlr?= =?us-ascii?Q?kD+Spny/IoPhaWig2ifx/R+m8HlJA2TJLoa5BQopx//N9R+mGWVtSJLtaF4v?= =?us-ascii?Q?BQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f79379a4-8963-40f2-dc8a-08da8bb4a3be X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Sep 2022 00:55:18.3602 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N4aXmH6rf6m7h8Il6oWZCsf3376Vjj01hCwzcYvXk9Ul496IocxMS3/rDuSE3FEDbyOYr8ZjLQtgWcTilxj3pyQzMNbTSSHLt36G3Db2AhY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4920 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Isaac, Good cleanup! For the series... Reviewed-by: Nate DeSimone -----Original Message----- From: Oram, Isaac W =20 Sent: Friday, July 22, 2022 11:46 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming = ; Dong, Eric ; Chaganty, Ran= gasai V ; Luo, Heng ; Ke= thi Reddy, Deepika ; Esakkithevar, Kathappan= Subject: [edk2-devel][edk2-platforms][PATCH V1 00/13] Simplify board portin= g These changes simplify the logic for board porting by creating common inclu= de files for initializing PCD and for some stage specific logic commonly im= plemented. Removes the PERFORMANCE_ENABLE flag and rely on the gMinPlatformPkgTokenSpa= ceGuid.PcdPerformanceEnable only. Simplifies the WhitleyOpenBoardPkg performance monitoring infrastructure. Removes gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable and disabl= e handler profiling on RELEASE builds. The net result is removal of unnecessary or duplicate options and the reduc= tion in duplicate code with increases in comments. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Cc: Sai Chaganty Cc: Heng Luo Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Isaac Oram (13): MinPlatformPkg/Include: Simplify board creation WhitleyOpenBoardPkg/Build: Reduce duplicate code Features/Intel: Reduce duplicate code WhitleyOpenBoardPkg/Build: Reduce unnecessary code MinPlatformPkg/Include: Simplify build logic BoardModulePkg/Include: Add include for stage behavior logic WhiskeyLakeOpenBoardPkg/Build: Reduce unnecessary code TigerLakeOpenBoardPkg/Build: Reduce unnecessary code SimicsOpenBoardPkg/Build: Reduce unnecessary code PurleyOpenBoardPkg/Build: Reduce unnecessary code KabylakeOpenBoardPkg/Build: Reduce unnecessary code CometlakeOpenBoardPkg/Build: Reduce unnecessary code MinPlatformPkg: Remove unnecessary feature controls .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 13 ++-- .../AcpiDebugFeaturePkg.dsc | 12 ++-- .../BeepDebugFeaturePkg.dsc | 15 ++-- .../PostCodeDebugFeaturePkg.dsc | 15 ++-- .../NetworkFeaturePkg/NetworkFeaturePkg.dsc | 13 ++-- .../IpmiFeaturePkg/IpmiFeaturePkg.dsc | 13 ++-- .../SpcrFeaturePkg/SpcrFeaturePkg.dsc | 13 ++-- .../S3FeaturePkg/S3FeaturePkg.dsc | 13 ++-- .../SmbiosFeaturePkg/SmbiosFeaturePkg.dsc | 13 ++-- .../TemplateFeaturePkg/TemplateFeaturePkg.dsc | 13 ++-- .../LogoFeaturePkg/LogoFeaturePkg.dsc | 12 ++-- .../UserAuthFeaturePkg/UserAuthFeaturePkg.dsc | 13 ++-- .../VirtualKeyboardFeaturePkg.dsc | 13 ++-- .../Include/Dsc/CommonStageConfig.dsc.inc | 37 ++++++++++ .../CometlakeURvp/OpenBoardPkgPcd.dsc | 51 ++++--------- .../AspireVn7Dash572G/OpenBoardPkgPcd.dsc | 52 ++++---------- .../GalagoPro3/OpenBoardPkgPcd.dsc | 51 ++++--------- .../KabylakeRvp3/OpenBoardPkgPcd.dsc | 51 ++++--------- .../Include/Dsc/CoreCommonLib.dsc | 6 +- .../Include/Dsc/CoreDxeInclude.dsc | 23 +++--- .../Dsc/MinPlatformFeaturesPcd.dsc.inc | 25 +++++++ .../Intel/MinPlatformPkg/MinPlatformPkg.dec | 1 - .../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 14 ++-- .../BoardMtOlympus/PlatformPkgConfig.dsc | 46 ++++-------- .../BoardMtOlympus/PlatformPkgPcd.dsc | 52 ++++---------- .../BoardTiogaPass/PlatformPkgConfig.dsc | 48 ++++--------- .../BoardTiogaPass/PlatformPkgPcd.dsc | 52 ++++---------- .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 51 ++++--------- .../TigerlakeURvp/OpenBoardPkgPcd.dsc | 52 ++++---------- .../UpXtreme/OpenBoardPkgPcd.dsc | 51 ++++--------- .../WhiskeylakeURvp/OpenBoardPkgPcd.dsc | 51 ++++--------- .../Aowanda/PlatformPkg.dsc | 3 - .../BoardPortTemplate/PlatformPkg.dsc | 50 +++++++++++++ ...blePerformanceMonitoringInfrastructure.dsc | 5 +- ...anceMonitoringIn= frastructurePostMemory.fdf | 5 +- ...manceMonitoringInfrastructurePreMemo= ry.fdf | 2 +- .../JunctionCity/PlatformPkg.dsc | 3 - .../Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 72 ++++++------------- ..= ./WhitleyOpenBoardPkg/PlatformPkgConfig.dsc | 2 - 39 files changed, 382 insertions(+), 645 deletions(-) create mode 100644 = Platform/Intel/BoardModulePkg/Include/Dsc/CommonStageConfig.dsc.inc create mode 100644 Platform/Intel/MinPlatformPkg/Include/Dsc/MinPlatformFe= aturesPcd.dsc.inc -- 2.36.1.windows.1