From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.15119.1665535076839914298 for ; Tue, 11 Oct 2022 17:37:59 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QJyOQ57S; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665535079; x=1697071079; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AnRocjs597M18gWB326NlbEwuyHgghHKBN8lFJI81Cs=; b=QJyOQ57SJZw8sODfUBdDMJLqUgcqImgivQD39++PDdjW719lLO/AUXmj HDKV5KdMrtYJI3Ig/raKy1mDoBX9Ao1l+fuW8L7P9MuiGt4ZbnRll7xmp pPnDFsqjRn1fRICjek0GvJ4jDQJjqHekDhn4JE9uSzSwAXOAGSMSfMGzq 9OU017n0SCQCqZqRb9u7CFD4BJdTCPmTiNPNISHC9kfKu3ZU/Fbea5ZgI V7SY7+MaQzzi5XN3jnFKw+amknFGZba17i6px/c4B5mj4HbiNphD3OnO/ JzJRcva2SddH9ZXENIFjZVqWfsdj4bpgMjvNsOu5xLedN8nh3H9FvPq/R Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="304647867" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="304647867" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 17:37:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="628908452" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="628908452" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 11 Oct 2022 17:37:59 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 17:37:59 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 11 Oct 2022 17:37:59 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 11 Oct 2022 17:37:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U+l1mWhY0syipEZAga6aehpmh9tE2DJNm+oYHkxTSV9WiMorBq2KpS2KpcAStAXmCdl4awjtEAOTgb5SCENk0+U7g9XOThJkGx7OoJYCZGB22Cjii58UizR9e6hzv+zONl6mZNzp/w0O9XTjVPGs/KbXfxE9smi8lPZP4dmLGGemnMOLHRH/kuok07+RATEVNAH2ugB6wRcGbcGX15FCSCmjVKQeyi4pE0FtoaFjbzrybf8E86zMPdolLriyU2PezIZG1pbjuElMwa0LkndIdxgg/jF9pLsn/got2QDSWP2uzvnH816cghGVYvVfrGh0/6YfdQxI3qeiP5qVM3Sr8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=91CwYwv+yafPUT/L1dt+n5YtqRx48JH/WvjF0BIXZac=; b=CHcx0SGxyFlNqX/MJbfqEt3X/90vhQLkeVO6iOHx3fyArqe3D+K/Vd398g6wqOT3dHhFRvgWw03lmSVAKC0wkAg0KJEYib8b4DYCQo6gUynI9vqDYUsRD7uqW0RDnqHNSuJmA/MIsf4i+cMaJkgDuIfp5fWLo80lL8mD4fKCKyuENmINmvV6LrMLUxMqHLMTghdlpmdWqWCXyvz1C5mnI1CBzxRkTXhecXN/uGU5AjD69OCCR18vd2yDX9xBh4cTwwOteTQE7UnubQJULQRxQKwciHQE3zlTW6s1Xnb5ZgbBKzTNcPH1DmEJoxESFPGljdkCTjH2VKLrVr5ciELhug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MW3PR11MB4634.namprd11.prod.outlook.com (2603:10b6:303:54::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 00:37:58 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::a748:40a8:78d3:38e6]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::a748:40a8:78d3:38e6%3]) with mapi id 15.20.5676.032; Wed, 12 Oct 2022 00:37:58 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Luo, Heng" Subject: Re: [edk2-platforms][PATCH v1 3/3] TigerlakeSiliconPkg: Fix invalid debug macros Thread-Topic: [edk2-platforms][PATCH v1 3/3] TigerlakeSiliconPkg: Fix invalid debug macros Thread-Index: AQHY2G/+rPANfxmUEk+rg+YDVZXktq4J8t0A Date: Wed, 12 Oct 2022 00:37:58 +0000 Message-ID: References: <20221005040648.4139-1-mikuback@linux.microsoft.com> <20221005040648.4139-4-mikuback@linux.microsoft.com> In-Reply-To: <20221005040648.4139-4-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|MW3PR11MB4634:EE_ x-ms-office365-filtering-correlation-id: 1f6a699c-43d3-40af-4650-08daabea02a9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5694csDR/Cx4dyoB328Da/xJBSetYch1uBqjasINsU9nrbnHf1KTQxdkRqgpeS3wK3d7HXpuoglPnzq1pTtxqwVVi4hLIfsvlDSHCedMEYOdWoaVHO3N8/rQ/b6mXdv4UIgD1Fx92spfORqRGVm7DZMEb+bGNktTMxPQ1KH77UYqWuIFqcUP+6vFPfDIJiDzKb2vSHh7vqlpxXPmiuFgNJFypZir2bkJLidKEUU3CWjTiGaOKTIvMojGgPIzoIbH9o9zX3DDYq/pswB0cnlFKphQ0BKcBg0WFLjHNrOQarvbZh9jfUF/2JXiE8YT1vb6LuGLxgZYK9Nyn1sEqZIGoR4yyKfeq+hRe/Y8shtfR0tChi3KkN6vOIHUhjCntITCfqFeCRjFsCP6juj3LP4z16DsObT02+mD53rGd/CBzNw1QQhl6kS4TKSE13o1sp4N2SwkTQaFUZEZXcIx6jKV5jpY6Vl44ZdXOgFnkMhEpz+xlZqymAJi+HDWWDb+T+Bz1bKvl/yTCgyHgGczewSNUBQoDA4aJ5NlEl2A6Devj5Vn2NVyXLmerv4ZpvVto05+BJJs0e7H0tT/dPG/UsFRwph9MFPZ5kLOd5qwae/NTe5jupfnhSgeNJLEE0paKXcJNVmAXtG7jHe9/D1o/CMVk2797IiyuBFVJxC/4+BvLVgk0yt+q3jONXENTEMt3XibN7vNsJ/Vx+gxjSHcyqa05a+orYLFH0HZSHcFDe7aygnns7P55AmYFltIarJcJ/8XH+2nmEaQN5kVAyNIP/K4g4HkAQRkD9HnQJHBFmSzsDQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(136003)(366004)(39860400002)(396003)(451199015)(8936002)(41300700001)(2906002)(5660300002)(8676002)(66446008)(66946007)(66556008)(66476007)(64756008)(122000001)(76116006)(7696005)(6506007)(478600001)(33656002)(53546011)(110136005)(54906003)(4326008)(316002)(107886003)(83380400001)(86362001)(71200400001)(26005)(9686003)(52536014)(55016003)(38070700005)(38100700002)(186003)(82960400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PLHYCgR4vTknCF1TfKFV/ShQCfX/Jip74uuYRgggYsb04aAVUToH/+YVBWFc?= =?us-ascii?Q?caIPLScf806QxUAjpxMa1tp5LZKsy85SK1R4brhgwhGGaxTB6tyhzUtk7yrk?= =?us-ascii?Q?iweFmfbopyrHu3Vw7+hZU8Gt6w8Wq+Jj+sLm1mcmO9PqJUTXzcEYL/IbemgO?= =?us-ascii?Q?XxnhV/ds8cdqWBLINS20634L+rM13Yd4hwap3BZLmioB1D4AixDXOgMip3x7?= =?us-ascii?Q?WV9mV2w3hkkizogvVoENvWkn9wzGzklQjuWSJDLJm0HGaX9uuy10scHU22Kl?= =?us-ascii?Q?WQXA3H/PR5hD5+/6Knf4GRgGDNu0qKo+1UvRIBwGAqmb7zL9qCTccPYetBY9?= =?us-ascii?Q?qvxMSKl/WPqc8K/L0buBVEC14FiqvW/mLk/3eJlSw7uyFh0wTJuEjcWwL1Lp?= =?us-ascii?Q?Jbq/F7dYNuNvf6lOHC6PjkrWpf06RhjdRjEDvc31Nj3LpKNBD0TJNc2KM8b+?= =?us-ascii?Q?zqA6Kmx7B3YmM+P4QhU0ANEQnlCKwq/fvklB7MKO9r37NowtHvnBdk32GNmm?= =?us-ascii?Q?kTLAwOlXt/rt2dbfz21f1oc0jUwkPHBndDY1iw4Dk+JXTH3ZtNXQ2vxt5DsF?= =?us-ascii?Q?ngpbroMduxAl91t9cnMWi6VMQhbo2ZmGvcQmAQKYj6kzRijA85adaE6M1el8?= =?us-ascii?Q?AEzpwCFmUfkOt6eb8+zFWNu2hCmOULy7XW/4eRfwRRPxaFOfgcelPf2wDzie?= =?us-ascii?Q?WOHRlg2F8GHOezHy296EoXmEA2I7GnROqvz903cZDpmOikgS+d4189L+6sfd?= =?us-ascii?Q?GxAh7+plgdcQKaKV969ZjZd9RYJSd38xF+gvVzoH+ZY3HmenU4t71KFS7XGs?= =?us-ascii?Q?x4uaPGMbiDbETrsPoO6QBhS3AEL3oljW2A5ontb6zZPQ29Ujg0dkXkzGDN1c?= =?us-ascii?Q?ldbt5FGuDrWWUh5KDSTC9A25st1S6cQAp6J9jNjyItUJle8gDiB20VCeOGdJ?= =?us-ascii?Q?Hsu7EJTeHKVd4O31WPvs3JhnxgwgnACYlEiQ8+04YCAa9HrexLbCbTVn10Ln?= =?us-ascii?Q?lqYClP70BqQtVNvAt6ZVAPdlGhMO8oxKe1uw4ak3nZQSFbrnedOEN65kKj3+?= =?us-ascii?Q?ZjOBRK1uC/s/DYkdbrheTAu9c4Rn1nysuHhVptn12PoOMgu9cI+tw47XjmBl?= =?us-ascii?Q?2HdCm5CbbAc3fhgXApFJ5DBZC6MU3PmEXkJx1RSRG0VdETeCZ2KHfNcOOGg0?= =?us-ascii?Q?ehDLt9jcD2Ts2J+IOqg+ufTl5BK8UxjLHlgt1pUk/RtBE1NRikzkmcVLEoHx?= =?us-ascii?Q?6zV2vhT9Yt3sBputy4Fs0n0tRtZakbKI0HvMuhLm/ltOQOQq9u9lwqwbV2no?= =?us-ascii?Q?iyGzSm+uoca5fQ1pfgoZLUYkMXWtAzzpzwy+UhBYRbSRAY30wD7ZOTmIGp5Y?= =?us-ascii?Q?dQY6QaacNcl1JzPlX0BgK6MEARM0EondvQzzblOQwJlaZ6pdYUjdihqEp1pH?= =?us-ascii?Q?NDKuWCKUWRn0nY0u9CNqmzq291lPrnLQ7/0CRXvpfLK1xYOIhqsmE05MbEoW?= =?us-ascii?Q?D9DEdzl6Y96z6O+MbPVy3a+6qky/0fLqX8Fm38RgAs35RSC40HQB2ykKjiQ+?= =?us-ascii?Q?hOwc0EU9um3/wFj3KdoTW/ZEzELRtIeqo8v/LrAxhtzsB3orv0CsBpu0aooK?= =?us-ascii?Q?Wg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f6a699c-43d3-40af-4650-08daabea02a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 00:37:58.1363 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dqGmv6eslYMiHY7pke74JSs0rEutIzG6KJruTO8RwrZwzBSH0FsIzRwRc6RmgRhlMN6p3LjuxPCmFGT8BHnoKsbjiQpYOw4lJNKcaM1WIxM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4634 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Michael, Please see feedback inline. Thanks, Nate > -----Original Message----- > From: mikuback@linux.microsoft.com > Sent: Tuesday, October 4, 2022 9:07 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L ; Luo, Heng > > Subject: [edk2-platforms][PATCH v1 3/3] TigerlakeSiliconPkg: Fix invalid > debug macros >=20 > From: Michael Kubacki >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4095 >=20 > Updates several debug macros in TigerlakeSiliconPkg to correctly match pr= int > specifiers to actual arguments. >=20 > Cc: Sai Chaganty > Cc: Nate DeSimone > Cc: Heng Luo > Signed-off-by: Michael Kubacki > --- > Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSmmGb= eMdiLib/GbeMdiLib.c | 2 +- > Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpre= ssHelpersLibrary/PciExpressHelpersLibrary.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate= /PeiDxeSmmGbeMdiLib/GbeMdiLib.c b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock= /Gbe/LibraryPrivate/PeiDxeSmmGbeMdiLib/GbeMdiLib.c > index 791747440662..01c097723083 100644 > --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxe= SmmGbeMdiLib/GbeMdiLib.c > +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxe= SmmGbeMdiLib/GbeMdiLib.c > @@ -323,7 +323,7 @@ GbeMdiGetLanPhyRevision ( > Status =3D EFI_DEVICE_ERROR; > goto phy_exit; > } > - DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision= . Overriding LANPHYPC\n", Status)); > + DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision.= Overriding LANPHYPC.\n"));; That does not seem to be what the original author intended. I suspect this = is the intent: DEBUG ((DEBUG_INFO, "GbeMdiGetLanPhyRevision failed to read Revision. Overr= iding LANPHYPC. Status: %r\n", Status)); > // > // Taking over LANPHYPC > // 1. SW signal override - 1st cycle. > diff --git a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPriv= ate/PciExpressHelpersLibrary/PciExpressHelpersLibrary.c b/Silicon/Intel/Tig= erlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpressHelpersLibrary/Pci= ExpressHelpersLibrary.c > index 401a9fbe7b8a..d1c163c50f63 100644 > --- a/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/Pci= ExpressHelpersLibrary/PciExpressHelpersLibrary.c > +++ b/Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/Pci= ExpressHelpersLibrary/PciExpressHelpersLibrary.c > @@ -1227,7 +1227,7 @@ RecursiveIoApicCheck ( > IoApicPresent =3D FALSE; > =20 > if (IsIoApicDevice (SbdfToBase (Sbdf))) { > - DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev= , Sbdf.Func)); > + DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x\n", Sbdf.Bus, Sbdf.Dev, S= bdf.Func)); That does not seem to be what the original author intended. I suspect this = is the intent: DEBUG ((DEBUG_INFO, "IoApicFound @%x:%x:%x:%x\n", Sbdf.Seg, Sbdf.Bus, Sbdf.= Dev, Sbdf.Func)); > return TRUE; > } > if (HasChildBus (Sbdf, &ChildSbdf)) { > --=20 > 2.28.0.windows.1