From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web08.6152.1644287898627717135 for ; Mon, 07 Feb 2022 18:38:19 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=AuAzaLCZ; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644287898; x=1675823898; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=miH+F6cCHwwvPUFTaVH0aPbbuX+RBrekYs7i2lugJyg=; b=AuAzaLCZhIpGHYiFMeOLE5cW+gTiLyXQGBVi1EgOqNx5RS3taDO9Ry+L MmgF7MYalbCcULDxUAVsi2wTdZljhcfPB134jIF4O/gwrOpTfrphmzZBj gDlZxY7s1wQ6UiavcEOCHaRWIbQMAWYTXWGfLsFhU/wbkeEj3tazuCrcp vWQK/TalChttMKdHckr69+YBQFi4apYb9AcBnh7dt8penWBI4VfIOVSkK jcQxt3LsHmwQGLpSE2C9M9AeCOxGXZpJ2CmkhVHZDbpLCgqSPqVGK3WAr tM320LysRkf5ZE/7T/dVywEq5b7R4dyittR5QQ8ZuPP4ifq3Rh8V47Uld Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10251"; a="246446260" X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208,217";a="246446260" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 18:38:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208,217";a="621765168" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by FMSMGA003.fm.intel.com with ESMTP; 07 Feb 2022 18:38:18 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 7 Feb 2022 18:38:17 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 7 Feb 2022 18:38:17 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.43) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 7 Feb 2022 18:38:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XdBlu93MjhPQd8tCNsc4Pg7nA2kVhFJQU2C3BDjJxxPt3ZO43ykXF4CpKTe4fXM8oa6RBbboOqpTDCKqcuEl/Z64VI2Lj6ycJF62+B4WYWEiDWN/cVLBmOEe4ovpSGB9ejiqMv6F64D3r7nSQzI6c6Yts5IA02Z/yj+BiA7FjLlIFFsLL7uQ6NjfrTYrbXTVvuaDWRlH6T6j+Tmuj/eV1imi634tp45hYbcDmbkQMiKTGIIos/8NxAW1oijHhEiMQ5PJwlJL2Mlpg5VjQlTrvZCwLg/p14IFwlzFPx9XttwcszTGbghamFFSC3nxfFFw6PBNwYRz6/WhrvBS+d2o+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rNz11BkThdpQXZ4doiZQtwCk9jAs2n5wurYrxUL3RKA=; b=Eik9lZemB2T8Toc959bcJsVGIQZB9S8GKDIpRrB2HjVTdtLrlBo3hSQpxjjls5msVONKedO27u68ZHywIUAuBPRnG3TUUmuPilBzW6qKNaKtXxA8OxN2G+RE62+md3GTmcV993/qFxO+bqYQ5U0WeW9Xxusl/cECjFyxDs3hS0XlKnkC/zhu5wqwzZu+KI1iZegdK/gpGpeAZJIGDQAq9Exc2lireOJ27c5DWrzQG3ffkGUICH8Od682HP1TWrCm53dwggwXu8xtGVbH2MmUPbVmpqAt68jmXSgzjglaIyIvGSGUgMZ00P2pnoe14wQhoYcAcKhpnozGvLYTJJNXEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by CY4PR11MB1624.namprd11.prod.outlook.com (2603:10b6:910:8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Tue, 8 Feb 2022 02:38:15 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%7]) with mapi id 15.20.4930.022; Tue, 8 Feb 2022 02:38:15 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "Chiu, Chasel" , "Zhang, Xiaoqiang" , "devel@edk2.groups.io" Subject: Re: [PATCH v1] MinPlatformPkg: Install memory relating PPIs Thread-Topic: [PATCH v1] MinPlatformPkg: Install memory relating PPIs Thread-Index: AQHYG/pgNH/YEkNYhEudw8BZndnz5ayHzMcAgAESxwCAAA+tsA== Date: Tue, 8 Feb 2022 02:38:15 +0000 Message-ID: References: <20220207081109.1094-1-xiaoqiang.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a99c6343-fc9c-4843-abad-08d9eaac0ee8 x-ms-traffictypediagnostic: CY4PR11MB1624:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y3I1rZpFIJLEcYzP5LCECDlm7MawN0yEPLo9nOLdpVkjdEK6pnDxXQd13JCgZLosj/yZkn/DjeeEL0UjFT5UjuhMktEFoURcWWcMC6zeNBChSILbk+P14VFUb1luaslOHBX2hk4Wqql40UxCrBQbH8qVHA7NFFCKhQJ2OIf0Popb25+4t8GnHjbBStHWT5qYu4BM8K/cP4Q5nZ2gEopwNuS2q+0qAB2gVaQRCQjWqQez6CHEMWTAbIePY2bfWEXUJc+HIaUoepFVngQ03Z3I7TOqucmMlUgku9cd/AOT5z4vlHJyk4vJz4jxqdziE3M95hffGEhM4mKbwZTMzYDPHU/+rCOnmaj26mI3ThIAriTeop9idMZZiB1vRCGwLxz0KvGXsAzcWOiyIlqKgK0fWLl9QBA//16taQWnw4ATOduvzpPngoCVEoH03Jn+rAjydjlFZFFsb07DECjAR25SdS4waVS4zXPhpt8uNxDeCxxEQx+YiHAVkLQhKcMWZz/sCfO9Uuy2z2dOt6KqdG43jqKWMrQWLkVz3dsd9gwwFtx80w3STS5Ngt7OivD1oUucqdrB4L9oC1jcZG8En0+NUfoJpn9CG58AnSHZy7rrciyVhvDa1ZuWWEPwMnXzDbgo+HAti1/l5R9aPFW478DpmWcuMsyqnNT4ajZNYbTSQIXr6n9ugqPVI82CmGq9E0ylxzUqt+Y2IFW/WfG1nT9NpzepeqcopXya3n0ZXdM8c36jJDdpTU7cFa6KutqVtQFgNU/euLrkxEDMVY2Em2WCXfgwesudDm8Uvqdmp2t6t/8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(71200400001)(5660300002)(7696005)(6506007)(9686003)(53546011)(9326002)(52536014)(76116006)(64756008)(66946007)(66556008)(8936002)(66446008)(2906002)(8676002)(33656002)(26005)(186003)(38100700002)(966005)(66476007)(508600001)(55016003)(166002)(38070700005)(82960400001)(122000001)(19627235002)(110136005)(86362001)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?nIUEqvwCvJ3kkQwMAQ/DUOx0uTEU7HHY02+f6I7Pe5b4wI0stgY0Xj3ZcdCj?= =?us-ascii?Q?1Tvu6KzhL6cBAD5G1lDPWOKd200GsS30+dm5uglupKFBbnITA1KEQPyaiSPO?= =?us-ascii?Q?7ywLh8OV8FM/qXyjcu4mFm5mMc4b1OUCy1SHgwJbFEgWkV7O5/NceR5hJjBV?= =?us-ascii?Q?Bw53qNoknZ4fXrbObvsuxin/AyLef5s3YmddviZxxAcdmzLW8Tqdt2T3dcoF?= =?us-ascii?Q?tCOYTEDqpv+WOi5oTHNatNPDyJvZ6oaFl22xPr4V/8NefsQD8H1RqPVwTvvr?= =?us-ascii?Q?wS36uMzUq5dEAhXENa4zCPtmvSnrVeWRv0PWhL5+EKAEALPEbJtfs2l5bsrq?= =?us-ascii?Q?08SkbpXBpVoLM+wx02S3/KFBv5ASPDgoHr7Vz7aNZ/p/FDxG8zPFuJJ2dw3b?= =?us-ascii?Q?TrQSc7c7taB0ZnF80qBLWlQHnl0IemawEdwmhKUhs10gfTERYJA1ge6VaP2+?= =?us-ascii?Q?9OI+otGp8HwTto8/WP6fGdz2iyqftLOru3yHRSO6HhX3fUduwt8COWiFPhY5?= =?us-ascii?Q?RqWA2vCnN+XI6AaMeOp3QuaW283lCQQcr8+gk/qMVb6Q7PcwqYox9WdCDqJQ?= =?us-ascii?Q?LiP0383FrxwzzZxpSK961xb4YRGrnNj68IEmObw7o/kXxdiUH1vOOxHtIomA?= =?us-ascii?Q?HkW/2J0xSih581R+ey4fsGiBWEIg++4NUukQT1EkJfPFQNnZ9HUGmK7ULTsc?= =?us-ascii?Q?hAssNKsmCQvA1A01w8chOZvhnQuko4R72RAvwTblLGNC9ruktNEKOxkKe+C3?= =?us-ascii?Q?fN/bleSLOjlx6nMK9HuT5I6dq0mx3wWD1/srpdI5DtvUXK/zb/iEBbtNejzA?= =?us-ascii?Q?Fx5eK4aOpfQEG4C9iTu9pCDK1pufICZFsAp4PzENxV99uoo+tM7lsVfGQqmA?= =?us-ascii?Q?wHoLLIWCzyMVWLJpAKM0KOJgh/oEGfCKULJuy35bJMbY6n4c0CrtbE/kbFjR?= =?us-ascii?Q?cjMLkjgSxEsCtvfIy5z9lZOb5Rp0A4iz3fEP7yuO89IVKVvT05u4+RyAyI9F?= =?us-ascii?Q?7FDEdN3AsEAW8Aeu7/7ucUzLyuzoNsib0OQ2WBtFIuVz8EqT1wL0OmyI+WdZ?= =?us-ascii?Q?lh2Myy1jKt9SNMCiGaGJyYOEiha/NcGgm+okiTmvEd6G1C+x17viTYHQmWwR?= =?us-ascii?Q?z/TDozmncqQaq4O9zeUEaH6U9J+tzS8u9EbqMOuaSOpwcbi4SlB9AM9HW7mK?= =?us-ascii?Q?7bdb3agcWcqbfxe03J5SCHOILGmv225noW/8G5VampUj6OOcTL1mZ84/UCGB?= =?us-ascii?Q?0w3HaSBdYH/V1FqIEKo07ME6B9ceZ7HMJNvJ2lDRvxE+R4Ons9mfqx2soLp6?= =?us-ascii?Q?xe9J6zcK16tNajWt/5K4bNn+9WGtqgdPgubQRAggHHpt7BKmMhgo1p9Z8WBN?= =?us-ascii?Q?mrs4U7ZPnSIT3u5wG8DOU8GyIxYc8Fs8cqYVr8Wx7++GC1G6ZAdrPYD4rXCr?= =?us-ascii?Q?bZU7brrE4Ywh9ot0gpgIAaCtj9RNzecL7/S8ea4VbnpCtXzJJDka4zAdqblC?= =?us-ascii?Q?eNsB4u/JU1mqYCeltYggZQFXkApRZyy8Y66jTEU2la+kERbL+WKPKXdDffKr?= =?us-ascii?Q?6JMB5bNjsL5nFSRqz8MqTjJ0i9egkXST/EnzQSElq5vzrmCOuXKNiEDmN7aD?= =?us-ascii?Q?Lxg4FNbG2jfx4WX5At/s7RE0flcW3aWSxOE1FZJkg+g1qO2xZgVFPqodkYqT?= =?us-ascii?Q?NLN5mQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a99c6343-fc9c-4843-abad-08d9eaac0ee8 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 02:38:15.3477 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: r6HOuu/XkXzzyqW8gOkfEO+dVmzc5Yrah+w1RprinhsxYO+rcNfU1apzaJA5vX4pHbqcJ5x+77yolWJsN0VswQvU7kzBMnbj4OG86Q2kgmI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1624 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW4PR11MB582112B0E6639F2E2A851DF7CD2D9MW4PR11MB5821namp_" --_000_MW4PR11MB582112B0E6639F2E2A851DF7CD2D9MW4PR11MB5821namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Isaac, I think you might be a little confused about how these PCDs operate. Here i= s the truth table: Mode PcdFspWrapperBootMode PcdFspModeSelection EDK II Native Mode FALSE N/A FSP Dispatch Mode TRUE 0 FSP API Mode TRUE 1 So, this change modifies the if statement to read: If (NOT FSP API Mode) Instead of: If (Native Mode) This results in the behavior for native mode and FSP dispatch mode being id= entical, which as you point out is the desired end state. The only reason w= e have a conditional statement here is to support FSP API mode, which is a = known issue and expected. Thanks, Nate -----Original Message----- From: Oram, Isaac W Sent: Monday, February 7, 2022 5:33 PM To: Chiu, Chasel ; Zhang, Xiaoqiang ; devel@edk2.groups.io Cc: Desimone, Nathaniel L Subject: RE: [PATCH v1] MinPlatformPkg: Install memory relating PPIs This has uncovered another issue that we should fix so that this isn't nece= ssary. Since UEFI native code is all about binary interoperability, there should b= e no difference between native mode and FSP dispatch mode. FV are FV, PPI = are PPI, etc. These two PCD should mean the exact same thing and this shou= ldn't be necessary. We will look at moving all the board logic use out of edk2 and into MinPlat= formPkg and board packages. Regards, Isaac -----Original Message----- From: Chiu, Chasel > Sent: Monday, February 7, 2022 1:09 AM To: Zhang, Xiaoqiang >; devel@edk2.groups.io Cc: Desimone, Nathaniel L >; Oram, Isaac W > Subject: RE: [PATCH v1] MinPlatformPkg: Install memory relating PPIs Thanks Xiaoqiang! Reviewed-by: Chasel Chiu > > -----Original Message----- > From: Zhang, Xiaoqiang > > Sent: Monday, February 7, 2022 4:11 PM > To: devel@edk2.groups.io > Cc: Zhang, Xiaoqiang >; Chiu, Chasel > >; Desimone, Nathanie= l L > >; = Oram, Isaac W > > > Subject: [PATCH v1] MinPlatformPkg: Install memory relating PPIs > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3824 > > Install memory relating PPIs for EDKII native build and FSP dispatch > mode > > Signed-off-by: Xiaoqiang Zhang > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Isaac Oram > > --- > > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPr= eMe > m.c | 5 ++++- > > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformIni > tPreMe > m.inf | 2 ++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.c > b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.c > index 6519fdd042..d8c96b52f4 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.c > +++ > b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.c > @@ -481,7 +481,10 @@ PlatformInitPreMem ( > > BuildMemoryTypeInformation (); > > - if (!PcdGetBool(PcdFspWrapperBootMode)) { > + if ((!PcdGetBool (PcdFspWrapperBootMode)) || (PcdGet8 > (PcdFspModeSelection) =3D=3D 0)) { > + // > + // Install memory relating PPIs for EDKII native build and FSP dispa= tch mode > + // > Status =3D PeiServicesInstallPpi (mMemPpiList); > ASSERT_EFI_ERROR (Status); > } > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.inf > b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.inf > index fb997838ef..86d8246f02 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.inf > +++ > b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.inf > @@ -34,11 +34,13 @@ > MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > IntelSiliconPkg/IntelSiliconPkg.dec > + IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec > > [Pcd] > gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode ## > CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit ## CONSUM= ES > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit ## CONSUM= ES > + gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection ## > CONSUMES > > [FixedPcd] > gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize > ## CONSUMES > -- > 2.32.0.windows.1 --_000_MW4PR11MB582112B0E6639F2E2A851DF7CD2D9MW4PR11MB5821namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Isaac,

 

I think you might be a little confused about how = these PCDs operate. Here is the truth table:

 

Mode

PcdFspWrapperBootM= ode

PcdFspModeSelectio= n

EDK II Native Mode

FALSE

N/A=

FSP Dispatch Mode

TRUE

0

FSP API Mode

TRUE

1

 

So, this change modifies the if statement to read= :

 

If (NOT FSP API Mode)

 

Instead of:

 

If (Native Mode)

 

This results in the behavior for native mode and = FSP dispatch mode being identical, which as you point out is the desired en= d state. The only reason we have a conditional statement here is to support= FSP API mode, which is a known issue and expected.

 

Thanks,

Nate

 

-----Original Message-----
From: Oram, Isaac W <isaac.w.oram@intel.com>
Sent: Monday, February 7, 2022 5:33 PM
To: Chiu, Chasel <chasel.chiu@intel.com>; Zhang, Xiaoqiang <xiaoqi= ang.zhang@intel.com>; devel@edk2.groups.io
Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: RE: [PATCH v1] MinPlatformPkg: Install memory relating PPIs

 

This has uncovered another issue that we should f= ix so that this isn't necessary.

 

Since UEFI native code is all about binary intero= perability, there should be no difference between native mode and FSP dispa= tch mode.  FV are FV, PPI are PPI, etc.  These two PCD should mea= n the exact same thing and this shouldn't be necessary.

We will look at moving all the board logic use ou= t of edk2 and into MinPlatformPkg and board packages.

 

Regards,

Isaac

 

-----Original Message-----

From: Chiu, Chasel <chasel= .chiu@intel.com>

Sent: Monday, February 7, 2022 1:09 AM=

To: Zhang, Xiaoqiang <= xiaoqiang.zhang@intel.com>; devel@edk2.groups.io

Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W <= isaac.w.oram@intel.com>

Subject: RE: [PATCH v1] MinPlatformPkg: Install m= emory relating PPIs

 

 

Thanks Xiaoqiang!

Reviewed-by: Chasel Chiu <= chasel.chiu@intel.com>

 

 

> -----Original Message-----

> From: Zhang, Xiaoqiang <xiaoqiang.zhang@intel.com>

> Sent: Monday, February 7, 2022 4:11 PM<= /o:p>

> To: = devel@edk2.groups.io<= /span>

> Cc: Zhang, Xiaoqiang <xiaoqiang.zhang@intel.com>; Chiu, Chasel

> <chasel.chiu@intel.co= m>; Desimone, Nathaniel L

> <nathaniel.l= .desimone@intel.com>; Oram, Isaac W

> <isaac.w.oram@intel.= com>

> Subject: [PATCH v1] MinPlatformPkg: Install = memory relating PPIs

>

> REF: https://bugzilla.tian= ocore.org/show_bug.cgi?id=3D3824

>

> Install memory relating PPIs for EDKII nativ= e build and FSP dispatch

> mode

>

> Signed-off-by: Xiaoqiang Zhang <xiaoqiang.zhang@intel.com>

> Cc: Chasel Chiu <chas= el.chiu@intel.com>

> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>

> Cc: Isaac Oram <isaa= c.w.oram@intel.com>

> ---

>

> Platform/Intel/MinPlatformPkg/PlatformInit/P= latformInitPei/PlatformInitPreMe

> m.c   | 5 ++++-

>

> Platform/Intel/MinPlatformPkg/PlatformInit/P= latformInitPei/PlatformIni

> tPreMe

> m.inf | 2 ++

>  2 files changed, 6 insertions(+), 1 de= letion(-)

>

> diff --git

> a/Platform/Intel/MinPlatformPkg/PlatformInit= /PlatformInitPei/PlatformI

> nitPre

> Mem.c

> b/Platform/Intel/MinPlatformPkg/PlatformInit= /PlatformInitPei/PlatformI

> nitPre

> Mem.c

> index 6519fdd042..d8c96b52f4 100644

> ---

> a/Platform/Intel/MinPlatformPkg/PlatformInit= /PlatformInitPei/PlatformI

> nitPre

> Mem.c

> +++

> b/Platform/Intel/MinPlatformPkg/PlatformInit= /PlatformInitPei/PlatformI

> nitPre

> Mem.c

> @@ -481,7 +481,10 @@ PlatformInitPreMem (

>

>    BuildMemoryTypeInformation= ();

>

> -  if (!PcdGetBool(PcdFspWrapperBootMod= e)) {

> +  if ((!PcdGetBool (PcdFspWrapperBootM= ode)) || (PcdGet8

> (PcdFspModeSelection) =3D=3D 0)) {

> +    //

> +    // Install memory relati= ng PPIs for EDKII native build and FSP dispatch mode

> +    //

>      Status =3D Pei= ServicesInstallPpi (mMemPpiList);

>      ASSERT_EFI_ERR= OR (Status);

>    }

> diff --git

> a/Platform/Intel/MinPlatformPkg/PlatformInit= /PlatformInitPei/PlatformI

> nitPre

> Mem.inf

> b/Platform/Intel/MinPlatformPkg/PlatformInit= /PlatformInitPei/PlatformI

> nitPre

> Mem.inf

> index fb997838ef..86d8246f02 100644

> ---

> a/Platform/Intel/MinPlatformPkg/PlatformInit= /PlatformInitPei/PlatformI

> nitPre

> Mem.inf

> +++

> b/Platform/Intel/MinPlatformPkg/PlatformInit= /PlatformInitPei/PlatformI

> nitPre

> Mem.inf

> @@ -34,11 +34,13 @@

>    MdeModulePkg/MdeModulePkg.= dec

>    MdePkg/MdePkg.dec

>    IntelSiliconPkg/IntelSilic= onPkg.dec

> +  IntelFsp2WrapperPkg/IntelFsp2Wrapper= Pkg.dec

>

>  [Pcd]

>    gMinPlatformPkgTokenSpaceG= uid.PcdFspWrapperBootMode        &n= bsp; ##

> CONSUMES

>    gMinPlatformPkgTokenSpaceG= uid.PcdStopAfterDebugInit        &n= bsp; ## CONSUMES

>    gMinPlatformPkgTokenSpaceG= uid.PcdStopAfterMemInit        &nbs= p;   ## CONSUMES

> +  gIntelFsp2WrapperTokenSpaceGuid.PcdF= spModeSelection          ##

> CONSUMES

>

>  [FixedPcd]

>    gMinPlatformPkgTokenSpaceG= uid.PcdPlatformEfiAcpiReclaimMemorySize 

> ## CONSUMES

> --

> 2.32.0.windows.1

 

--_000_MW4PR11MB582112B0E6639F2E2A851DF7CD2D9MW4PR11MB5821namp_--