From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web09.473.1635895713637971714 for ; Tue, 02 Nov 2021 16:28:33 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=sEuER/T9; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="255007903" X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="255007903" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 16:28:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="560284266" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP; 02 Nov 2021 16:28:00 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 16:27:59 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 16:27:59 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 16:27:59 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 16:27:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WV+auHb47IyvegfoGscaodJ18ewVxqydPnZqb/E9I0Anh+on5thb/ljis1V1aLBmrrPEYPUzYWQrNyerFmSrUcXeiXHJ47LFLRagUdOcy78uNxo+sfVKZHXYhdKCoAL+GegE1oDgfTpQimrVxFN0RAjRDjv8ULKYQepMMxZ4kaXm0xZ60koeNov0L4vf5sIIijs443byd+QZpCHuxjOHCeOHqQAq4YBORbdg4/KGjqgmSbezNtbRYNDSdcLB1fdwhMScC4ps3nggnnZHmC9QewKD9MUMYOf7NmQ7J+wJx0S5ByQwMozTIBLlsC6hHRWa2rHq3ZXjme8OFYrVA4xF2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YDbyPhyWn9tvB63pWHpLa251k7hFiaUqbubey2GpLm8=; b=hyp3o67uEfeiBcAypmGfS9K3y9NYZX8Ux2S/4Okuc9xtnNjhdS3SCAzcE0cWk+HEel/anNs4MKClL9GCSVbRgy6hzjVrwjXvQtI4Zcs2ICyVdA11wtVQ1FIsNPhVjxpFhTHKrGrNTMCmrKREVjRlAPYZMWh6+1RyMiGgaNElp90Uab+c+9hhUnz1hIfgjjePzExZN5GuTBZWDd5sbMrrSYRHa5IXfByvtKa7PDd/gS3I5XWuA4fZycib+OuwYXKnc2obHaUbKf7ZpYgXMhHTxz9YhI1ydyQ3qDjKCBIfxpyDdtA7IH+SNythF7bALOJeVGo9/+xIOTpP2WD2ZPlMPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YDbyPhyWn9tvB63pWHpLa251k7hFiaUqbubey2GpLm8=; b=sEuER/T9hDN/7d+rd+8c1W1BBEFCl2ZEb052MHaQIKZDlgWimKck6Ew4H/pLFylRd4KH6ijBCwt8AULJ6HkXm9yvJJVBKJp5wE4XY2Fz0mvZe8OdqbvuRMKZX0nUOi7yP0e9RqhlKg+/txMijkNeMO0aGWG9LqRKN8Mbl2TVw5g= Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MWHPR11MB1247.namprd11.prod.outlook.com (2603:10b6:300:2a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.17; Tue, 2 Nov 2021 23:27:57 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46%9]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 23:27:57 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Agyeman, Prince" Subject: Re: [PATCH v6 49/52] SimicsIch10Pkg/PchSpiSmm: Update for SPI2 Protocol Thread-Topic: [PATCH v6 49/52] SimicsIch10Pkg/PchSpiSmm: Update for SPI2 Protocol Thread-Index: AQHXzEjDx8uWwLakBkiDsylFTmXwsavw6fTg Date: Tue, 2 Nov 2021 23:27:57 +0000 Message-ID: References: <20211028220846.753-1-mikuback@linux.microsoft.com> <20211028220846.753-14-mikuback@linux.microsoft.com> In-Reply-To: <20211028220846.753-14-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b2c440a3-e08d-47d2-cf05-08d99e58675d x-ms-traffictypediagnostic: MWHPR11MB1247: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vlAHf10hl52P7/cXZAFqeN8o5E3O03f5UN8Bz1pQrj9K888C03dG57wKlFkVNTInu1oJQRw8+8oDvKWuXzJM907WvPsd3Zw4sbSoL4FXSmoQC7Zyjk4sOVJZ/fs3CxWhPBTC82hPzXAxzLKaQYMmXTKnfVmfGZzxGeUaSqt1vk1dFEPAGUirsgdK6Co34aAmulByC7uierimgLidS4yp17Et6NyIuS1Emrbj4ud4u1QHbedzxsUiDNh4kqYl0F19IDKIHl62qYcLnaDBTr2ChEm/aApimUij4Gl0owbL7a6pwhSWdutgYc7xuYMvSuEkKPEuqe9MGWWJm5IpQgRtgdDWXO1IXyQD224++IHbJd9qV7G8Zs9rLcHXThZHC52c5xWVrzOmclzjKriLkrTgyzlwiZI3uJ95fRnrHab+hPZ1VIskHYILAV/QgZXWaJDHb88GfsXzp2BIcWxx5Vlz4I6USYjSfrg1H8P9tuHIVCjnIsADB6okHqfVJNpSHfoYcXGtqN6VfsrVCe2Py/mP9/f8HY8pjIajAaAL7xVbyhzabjQXuD6Fx1FcvmlsVo2idi0nM8tM3mv0uWf7tNg93RTELwPGaFiJz90mIJ5tOeUnBjnbIg41nVxNFlq2WU0W3azhTkbxd/Ukl7hbjUUpR80yMvvuOaB1uN8vFAReCv5JmxCxMXbWWohBqT21aqj5gmYW3y3ycfQZOjgcIFBkmwHiBFEhG70WYSFDb1Gq6erzbtRtI1u0eKFS0i8h6gCy+cprd6qRlzDW/I2AGq+htWt/uo7NQ414LARho8Mqz3E= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(26005)(53546011)(186003)(6506007)(110136005)(66476007)(76116006)(19627235002)(5660300002)(66556008)(66946007)(86362001)(38070700005)(2906002)(9686003)(38100700002)(122000001)(82960400001)(66446008)(8676002)(15650500001)(55016002)(52536014)(508600001)(64756008)(4326008)(316002)(33656002)(8936002)(107886003)(7696005)(83380400001)(71200400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uDRbquCAiaghA5V2rVHYHGWogKqSaxQkBOBQi7keyrpsEBAg5Rf0mv5DLU7P?= =?us-ascii?Q?GtnWIuTIx9zgLzPxEfcNUVzjVMzdtEx6Lb+fwqbpxyU8egZGIw0DJnp5wmlQ?= =?us-ascii?Q?M0KrImi1yYhH80L4FY2HjeN5S7HV1f8kEPfpaa3Rn+4z+zjpJhcDQHKRNJXX?= =?us-ascii?Q?GOpcXmFEeymf2ZjBN83Dost7nRUz2GxLwtWHGMXwC1smDj1+iVhJUnOEGU8m?= =?us-ascii?Q?Lmmby88o3buA4ei8CKvbpP0f3Jf0d84SeyeURExseHgHzeAFdRoSivMiRxft?= =?us-ascii?Q?BJAJf+PXWIYJwuOHXPevtel7ZGutXhtpAkJwoHJBU62EMVekWquXLDuS5orj?= =?us-ascii?Q?l9UsHjzmtmBm9O7T0DASuycCKf8C+eGQnUI0Ftm2/aW7Taky55TshxcCVD7P?= =?us-ascii?Q?YHYW6G4jdD17fCXfcDEoRH0UAYJkpCVm/O9xBgaWti7qNTCX+ZFduM+McQfx?= =?us-ascii?Q?porlaKtKz6gTKFTI3DQupvxbWdgdHmfJoAard1GegO4CT3Ch2/NzK+qPJ8lX?= =?us-ascii?Q?W0KwO06X3p4JmLVuYrl3jKDWSQwdc8vq9NPiA5Foz3SDjbv+nYMOW2nbdlhY?= =?us-ascii?Q?XahwOcOJDMHCneErwbqiQdDMU5gIByNCKBTmuXxItFqPIZCh5Ya8XiGc2ikE?= =?us-ascii?Q?ROUFEELu2bhHAKWvZ+ScCBlJAkbaLOpXDkD/0kEK2OwOpGZ8MY/EihEwa2Ww?= =?us-ascii?Q?CoKvSesP4vhVG4Khx0640YUq3HI3ojacWRiXDATaLHWXOCzji6cjvITCPMa4?= =?us-ascii?Q?9USq56urdTvD1Rjd/c8t30ZaPmWY+oJ9YMhFXjJMDsBuCy9EcErpNqLaqqvb?= =?us-ascii?Q?mY7I5z3LYJq7R90TVT+TDT1jURSldm5p1PWTsEOhO8JBpTLCts8KSbJ9tVUi?= =?us-ascii?Q?STVuD2a6RZchiqMZdr03za5biIsIWQGo1Nf101eU98HTvZFfRDUMMRh0KKPo?= =?us-ascii?Q?3V7DNngUHdSDzKZ0b9TragoETfYwbeKaRuHWju391s6UtZajwCojjBtmk/Dh?= =?us-ascii?Q?PMWrF84QwIt2xT3JCikVuNENzSRgStPMACaxnyEYo7wcPd/1lI8YagmG2V7W?= =?us-ascii?Q?5tAb7finA30uJtCyXX2EgQSx+kFSCj3zCVULiWQZK+wxMUns9DctHmXDiY7i?= =?us-ascii?Q?jG5PK9s8ChMVgxhyzIoFkyUrk5ReodGbX2d72ZDQafeY2f7JrVbA2NxMUfLn?= =?us-ascii?Q?lnIIFQOCVbEoEXBAHW6NOB43boSgcjWJSqwYISBrJECCJ0nXIRImKVW1UPRx?= =?us-ascii?Q?/4DWGXuPuJ8u6ONtVZwE/iKfBX4Q9paPBWD+dYDh3myfXDdKtGnfiZGhNlVU?= =?us-ascii?Q?UgQSvlRiXw5oYwYqyTVhdZVfyX0vkDecA3j8snxgzaYylYHvT2/DzTMVjnA9?= =?us-ascii?Q?ebUXp1yNLYnGAwltOEzh+rDRjdd41IBxdddxakVUDxAiTuoId1NpJXlQgz8v?= =?us-ascii?Q?jkUHLJ9v1vcJl/u/6iXm+rNO/pvogPnW/M3L/IuijrkIoLM9KYgw/Jfpcin+?= =?us-ascii?Q?8Da0Or1umT2M5k7516gC+sA4f7Y7oEiWx/S8jTvRi3f7xToSB4bCxcWokxbp?= =?us-ascii?Q?urwmWObJihdIcCKy+/na1DR0HYRUA1rxbwKfWilgOpxPKE1tqSs4roBuZweC?= =?us-ascii?Q?tbdCLzZfEq6SJEzNh23eCnthIHFnG1Jt9EP89D9EXaN6/XJQRS0w56BqJItl?= =?us-ascii?Q?hpDp/A=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2c440a3-e08d-47d2-cf05-08d99e58675d X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 23:27:57.6614 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: a3Y+l5FU7wSPk0wOhWbH8kLg9UXVgUpqZ3DfiyJw7T148ccBoVeB0RWavE+ZhEnXlrigRg2vs55MdBN3852Ifh9f1A2zw7Mz6deTybJzPno= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1247 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Desimone, Nathaniel L Subject: [PATCH v6 49/52] SimicsIch10Pkg/PchSpiSmm: Update for SPI2 Protoco= l From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Updates references to the "PCH_SPI_PROTOCOL" to instead refer to "PCH_SPI2_= PROTOCOL". Cc: Agyeman Prince Cc: Nate DeSimone Signed-off-by: Michael Kubacki --- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c | 8 ++++---- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.h | 2 +- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c b/Silicon/Intel/= SimicsIch10Pkg/Spi/Smm/PchSpi.c index e4a81f91316c..19f1cb92c921 100644 --- a/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c +++ b/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c @@ -29,8 +29,8 @@ GLOBAL_REMOVE_IF_UNREFERENCED UINT32 mSpiR= esvMmioAddr; - Documented in System Management Mode Core Interface Specification = . =20 - @result - The SPI SMM driver produces @link _PCH_SPI_PROTOCOL PCH_SPI_PROTOCOL @= endlink with GUID - gPchSmmSpiProtocolGuid which is different from SPI RUNTIME driver. + The SPI SMM driver produces @link _PCH_SPI2_PROTOCOL PCH_SPI2_PROTOCOL= @endlink with GUID + gPchSmmSpi2ProtocolGuid which is different from SPI RUNTIME driver. =20 - Integration Check List\n - This driver supports Descriptor Mode only. @@ -92,11 +92,11 @@ InstallPchSpi ( return Status; } // - // Install the SMM PCH_SPI_PROTOCOL interface + // Install the SMM PCH_SPI2_PROTOCOL interface // Status =3D gSmst->SmmInstallProtocolInterface ( &(mSpiInstance->Handle), - &gPchSmmSpiProtocolGuid, + &gPchSmmSpi2ProtocolGuid, EFI_NATIVE_INTERFACE, &(mSpiInstance->SpiProtocol) ); diff --git a/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.h b/Silicon/Intel/= SimicsIch10Pkg/Spi/Smm/PchSpi.h index 6ada9b121d92..68388319da17 100644 --- a/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.h +++ b/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.h @@ -17,7 +17,7 @@ #include #include #include -#include= +#include #include =20 #endif diff --git a/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf b/Silicon/I= ntel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf index 35655ed5b5aa..12a21dc57a9b 100644 --- a/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf +++ b/Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf @@ -37,7 +37,7 @@ [Sources] =20 =20 [Protocols] - gPchSmmSpiProtocolGuid # PRODUCES + gPchSmmSpi2ProtocolGuid # PRODUCES =20 =20 [Depex] -- 2.28.0.windows.1