* Re: [edk2-devel] [PATCH v1 0/2] MdePkg: Add missing status codes
[not found] <1777080A4EA7576A.12785@groups.io>
@ 2023-08-07 23:06 ` Nate DeSimone
0 siblings, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2023-08-07 23:06 UTC (permalink / raw)
To: devel@edk2.groups.io, Desimone, Nathaniel L
Cc: Kinney, Michael D, Gao, Liming, Liu, Zhiguang
The series as been pushed as ~107ddf1..3c274c0
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate DeSimone
Sent: Monday, July 31, 2023 11:43 AM
To: devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
Subject: [edk2-devel] [PATCH v1 0/2] MdePkg: Add missing status codes
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4514
Upon review it has been found that MdePkg is missing two status code definitions:
1. EFI_IP_ADDRESS_CONFLICT - Added in UEFI Spec v2.5 2. EFI_WARN_RESET_REQUIRED - Added in UEFI Spec v2.6
Moreover, PrintLib does not correctly decode the follow status codes:
1. EFI_IP_ADDRESS_CONFLICT
2. EFI_HTTP_ERROR
3. EFI_WARN_FILE_SYSTEM
4. EFI_WARN_RESET_REQUIRED
These missing status codes and the missing decodings have been added.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Nate DeSimone (2):
MdePkg: Add missing status codes
MdePkg: Add new status codes to PrintLib
MdePkg/Include/Base.h | 10 ++++++++++
MdePkg/Include/Uefi/UefiBaseType.h | 2 ++
MdePkg/Library/BasePrintLib/PrintLibInternal.c | 10 +++++++---
3 files changed, 19 insertions(+), 3 deletions(-)
--
2.30.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107625): https://edk2.groups.io/g/devel/message/107625
Mute This Topic: https://groups.io/mt/100468025/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread
* [edk2-devel] [PATCH v1 0/2] MdePkg: Add missing status codes
@ 2023-07-31 18:43 Nate DeSimone
2023-07-31 20:39 ` Michael D Kinney
0 siblings, 1 reply; 3+ messages in thread
From: Nate DeSimone @ 2023-07-31 18:43 UTC (permalink / raw)
To: devel; +Cc: Michael D Kinney, Liming Gao, Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4514
Upon review it has been found that MdePkg is missing two
status code definitions:
1. EFI_IP_ADDRESS_CONFLICT - Added in UEFI Spec v2.5
2. EFI_WARN_RESET_REQUIRED - Added in UEFI Spec v2.6
Moreover, PrintLib does not correctly decode the follow status codes:
1. EFI_IP_ADDRESS_CONFLICT
2. EFI_HTTP_ERROR
3. EFI_WARN_FILE_SYSTEM
4. EFI_WARN_RESET_REQUIRED
These missing status codes and the missing decodings have been added.
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
Nate DeSimone (2):
MdePkg: Add missing status codes
MdePkg: Add new status codes to PrintLib
MdePkg/Include/Base.h | 10 ++++++++++
MdePkg/Include/Uefi/UefiBaseType.h | 2 ++
MdePkg/Library/BasePrintLib/PrintLibInternal.c | 10 +++++++---
3 files changed, 19 insertions(+), 3 deletions(-)
--
2.30.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107405): https://edk2.groups.io/g/devel/message/107405
Mute This Topic: https://groups.io/mt/100468025/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel] [PATCH v1 0/2] MdePkg: Add missing status codes
2023-07-31 18:43 Nate DeSimone
@ 2023-07-31 20:39 ` Michael D Kinney
0 siblings, 0 replies; 3+ messages in thread
From: Michael D Kinney @ 2023-07-31 20:39 UTC (permalink / raw)
To: Desimone, Nathaniel L, devel@edk2.groups.io
Cc: Gao, Liming, Liu, Zhiguang, Kinney, Michael D
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Monday, July 31, 2023 11:43 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>
> Subject: [PATCH v1 0/2] MdePkg: Add missing status codes
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4514
>
> Upon review it has been found that MdePkg is missing two
> status code definitions:
>
> 1. EFI_IP_ADDRESS_CONFLICT - Added in UEFI Spec v2.5
> 2. EFI_WARN_RESET_REQUIRED - Added in UEFI Spec v2.6
>
> Moreover, PrintLib does not correctly decode the follow status codes:
>
> 1. EFI_IP_ADDRESS_CONFLICT
> 2. EFI_HTTP_ERROR
> 3. EFI_WARN_FILE_SYSTEM
> 4. EFI_WARN_RESET_REQUIRED
>
> These missing status codes and the missing decodings have been added.
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
>
> Nate DeSimone (2):
> MdePkg: Add missing status codes
> MdePkg: Add new status codes to PrintLib
>
> MdePkg/Include/Base.h | 10 ++++++++++
> MdePkg/Include/Uefi/UefiBaseType.h | 2 ++
> MdePkg/Library/BasePrintLib/PrintLibInternal.c | 10 +++++++---
> 3 files changed, 19 insertions(+), 3 deletions(-)
>
> --
> 2.30.2
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107409): https://edk2.groups.io/g/devel/message/107409
Mute This Topic: https://groups.io/mt/100468025/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-07 23:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1777080A4EA7576A.12785@groups.io>
2023-08-07 23:06 ` [edk2-devel] [PATCH v1 0/2] MdePkg: Add missing status codes Nate DeSimone
2023-07-31 18:43 Nate DeSimone
2023-07-31 20:39 ` Michael D Kinney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox