From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6A60078003C for ; Thu, 30 Nov 2023 00:47:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=qAcgf8DnaU0v46nUJeLjFY3WUsBQ53opHUhwp1+I+58=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701305219; v=1; b=fu+G9UQKoHT78zn4nS4dSjASIvdEyM4VMVK3QCc3uTIfcfpjWxfgG0/gZBelDo9bOrL28V/l EGDzowzRGKQC4k3Jh8NlmFDAnjB1qwnHY0pDB7aO/rcrx9vyoXcMAknGH3vWUlf5pscBojMgXTI NSJeS8yoSm53RjUPHSX8cn/U= X-Received: by 127.0.0.2 with SMTP id fqZQYY7687511xqlJdQcfR1Z; Wed, 29 Nov 2023 16:46:59 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.59983.1701305218598578627 for ; Wed, 29 Nov 2023 16:46:58 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="392991961" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="392991961" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Nov 2023 16:46:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10909"; a="839625962" X-IronPort-AV: E=Sophos;i="6.04,237,1695711600"; d="scan'208";a="839625962" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Nov 2023 16:46:58 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 29 Nov 2023 16:46:57 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 29 Nov 2023 16:46:57 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 29 Nov 2023 16:46:57 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 29 Nov 2023 16:46:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B9CQsF4EqTqzUXfg4Q6SqMnlM02kHPdXjXGRKrNfWBec+mQVxdoG+gN2AFR97/JrdREBlA5Hu1+5AFoQS3XD58EVOloMJTjRKkFCJTE5t8+asM3spmqOWPOj38HP+jMMh2BZWiQUa9Y7An9zPOULg0EzohDh5kowr9NBZu4gudCJptWLWF2CvmAUOeWGuYTfQWWE77WP5DZo1IaNZxfrEPOfIYGas5KNsVlWuZAFzsa3H2/YYzSVgzeDw8B1FJ90PqUcR4Xo1QrgxUSyEZIWdcFLqW31v/BfJWkiYmuyv153/+DA/7R3WiKT0+N/PEYrF2HyGcCNpJ60qF4PADZdCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5KytIWaKgwXdx8Yxj6Vpn5n9OYJ7UWqJC+2lkJjqaYU=; b=jYcESiMdmEPysxqt1zs+nVrwHRnz2mz2hzs/Qj6r4/rAoajHt6PeuHLWWj8/fRAaBHwGIPJqEY0U7tQ/sXy2VrWe+3FFF/g8Dx/+cxfEypvJkCxS3IezbhF7CrjCMhVBUTSsEMCTOU1wpopjGqmZYlRU0V/pgPbZj9HXqszOy2KGGnJSNA4zZ3BHZic1VcTUExVYWRm95bGQFoOgGQJNLDss3bsQyPM89+d3qFqhQxgwGG5BKi7VYMfw1y1G47sgvwNRamB/la5ThRWabClMQM3+a5W+jvfkeqU0/3ngWAUtwSwQCY2CBuaSemi205RGvG9xF4Mmln+CytAdSM/6Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by SJ0PR11MB5023.namprd11.prod.outlook.com (2603:10b6:a03:2de::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29; Thu, 30 Nov 2023 00:46:54 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::ced7:2db7:4cae:ab0]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::ced7:2db7:4cae:ab0%7]) with mapi id 15.20.7025.022; Thu, 30 Nov 2023 00:46:54 +0000 From: "Nate DeSimone" To: "Xu, Wei6" , "devel@edk2.groups.io" CC: Abner Chang , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v2 edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM. Thread-Topic: [PATCH v2 edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM. Thread-Index: AQHaD/t2Ke8kiKcDVEa9+RP9orp2HbCSLVzA Date: Thu, 30 Nov 2023 00:46:54 +0000 Message-ID: References: <8594af88f257a5274215a8a31734c1097c4a8570.1699196971.git.wei6.xu@intel.com> In-Reply-To: <8594af88f257a5274215a8a31734c1097c4a8570.1699196971.git.wei6.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|SJ0PR11MB5023:EE_ x-ms-office365-filtering-correlation-id: 1e1e6133-6f14-497b-a44e-08dbf13dd91e x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: PDwzkj4Z/OP30tgNjM7S21tbw5O5ZTvMoOwO4JAHnPSN2HF6olrrUHan4gVXnSNgs2u/+SYPhtbqZfSk5rwB0D08H7sKVXy6r8UVFwYBucifIxSZ6xBr9lh6JmeE8pF1u04sgIjq+sDvZCJGgsOxLHdp19hbzCaC5nSEANbxVsbkpGbTNpGwGTk3J/FbHulFe/AkRiH6syK3CrNXsHeyxRjtKSFxInyYa2uadE/SUMYXzXATHXp5dEHiacpxdKyE44m5xH8s5nLotX2en3n8YXcUcOkaHrci9zQEnfL3FLqXyAlGUsrN31+uQ1PULJ+zB/GDbMwo9r4OHiGvSHgcAynK16BGkEXpPWu+vwkOcaH1RMAZGfP1MsdXLBS4HXah3QoRF9EOnSpGEfMhbk/2UydROCAlZkeAyvHlWQs9VaOxoaGIdEj/hWDeFrnlSikVQ1cotdzDGs9w57OU8kwk8GtvOBz//go7Qo1ax6ILlowCpJisC4lU8t8+TvXlfjXNoqCfCAU2vIPY7oJ2EspOGatuQaQue8EOnVE5UjZeMvh8ap1wDZDHUV0dL4ns2fkbC2yW8Joc9WiR4sHGHNdztw+Kt6YJM1o8yMqgxtu6zExDwsoYageIYFBiulWKw110EphkZxkQnNbXqUF84fDKQLyCoEYKkBtyBC2GY8qA0xQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4igcZ+cl/hddlVFjmSa6AxJG4aM82oZiLErJ2c1JWhf0Qmkrp4q4FhUIXJY9?= =?us-ascii?Q?Imx2uW2R9tR9AI3AFuGpX328iWFj1JbMDVw316Go+7DP7j0WHbTeO882dyAk?= =?us-ascii?Q?6xty5YONiYcUl35w9Ko1wi5DtTTG9aKy2H1fn5LW7xYMtS//0wE5Wq0+GUMl?= =?us-ascii?Q?W1GzZtKhPjG3kWcs8wMButCjmI+LwE9KTuySRgWV4kW63Zus+Dbi+TEjOYHH?= =?us-ascii?Q?+RDYUaSYlxxfD73a8uphpVuBFSy5VpqfWorM+bGxgJEOv4oWfLwu0dkE1g1M?= =?us-ascii?Q?nMmdua1r8OeNlKHbZ/u8SXEJIbG0K0uWCWc5CJ9FIGx9MJbFNfqW4aMjQtWO?= =?us-ascii?Q?1vVXdfHH/qJHPek4Jx6ZbDWyV4gJNtd4kPV8cTSeSllMT+q6KyJ/Zp1CAwHu?= =?us-ascii?Q?2TDSU/79z0smcLeOkRxySY3gfVqCwH3voQifS8dpdMpGxmcLB4WC9elvIehX?= =?us-ascii?Q?hAaQ48NPhxCX8o/dtZipq7mauBBevFegilrBIVszP8Yg3AH2dWOjRLgfUSuw?= =?us-ascii?Q?8HtsPDAJc9zFOZ6FTpQi69SVvD1CHtY1hbyc2tcOoOeqT+UM6Kv/Ebouge2M?= =?us-ascii?Q?W0D22ejO5sLh9zjwQTrddPTk5chabouyZ/3J23QZTRuc2i/17FbRpA5m0AFX?= =?us-ascii?Q?QaMr9ouU6uVB2f4jPP5ap7wOsSbF6WY61WHZZJynrPBJJsOO3/4/wtUuSU+Y?= =?us-ascii?Q?4JgA+sWLwUFfJQuwrNofFzDSow0OKqSD4T+6ZjU7nYKpWtcqPKjJLYTiO+Le?= =?us-ascii?Q?6jJJlMCjD+jN+DpEadIwJuY+wljMDdFMuY8NtzmiWzD+swZo7OTdyIylAHFF?= =?us-ascii?Q?mOfjTIkVW6b93Z+vYKuuj68nTfneO5ppJP/QgCtOZp3jDad9Rh/sMZqEnodn?= =?us-ascii?Q?BJXZEsyAU9i3EUwt117JFVBGbcLuUH0eoPxXbleAEvjkikF/mdarLcrAN4An?= =?us-ascii?Q?w3QfmvxSOxv0V8q2BCJ9iOeiBvCmfP76zMy8fZxuNUZ2fQzHuwQbJgALgN48?= =?us-ascii?Q?3Wp+X4jj+vo5x8k5HhROXy0PV83MxVuiqjuULBr8/L4i/2XOGwT8LpgujOoA?= =?us-ascii?Q?L2mSUOmoYQIcMUIo507FKLb7HEsXsrKX72Eez9f00917VIXAVSqUCw8u+6G9?= =?us-ascii?Q?0oPeYYTxR+BQE9Mlq3s2fdMrI1wqAN0xh8xDTW5GUJJvzdAj8vPq1JFJEhrD?= =?us-ascii?Q?5KENqGUU7FpTlWRf3dvhg65H2uxsPOZMlgOEE7bicMQ39Fcd94gUz+sb2EVC?= =?us-ascii?Q?jrRrqJ/rwIn6nugMZUQg1u1I9c/FRdDFAopenoxIfoeHvBozhefloVQHJQ0H?= =?us-ascii?Q?+iV5h3a7a5guIVCEF3Oh0YpiP8B4juHP8JOfp7s0clmsoVtRduxVr4Ci6Gbn?= =?us-ascii?Q?QcyN0UgevE4FY4NiLXxnYiRRAROFZAN0HfR9mMra4mJtOkPe0JyF0PUYfNrr?= =?us-ascii?Q?77MOBzP1WtFbxbLKD4FxKuxLdTkLf3AAG/OTwzTuZMc0tZBoPLBlLZ2rOdEk?= =?us-ascii?Q?SrQvKzYQGTrPhzO8w3vZ8tsVg5jb9H8zvq9qBrCWqE2flqNaaRZdu+FcHAMD?= =?us-ascii?Q?VZIxi9nMXXG+120tmwVvNi5ZOlrta4GlxX5wt153HLe9bWaJegdr8lniRfaS?= =?us-ascii?Q?RA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e1e6133-6f14-497b-a44e-08dbf13dd91e X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Nov 2023 00:46:54.0720 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QBGmlt4lvhM4ZHzwxumbuAX15ngNxaAz7QxjnZzihBIBQ0ZPCQ5wAk5zs6rRwCoIWW8+42hpBwZD1v5Cnkk4PUGyPWX5JF2jIJ6j5kr/AsM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5023 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4dSFdZ0BidqeQjq49YxXiOONx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=fu+G9UQK; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nate DeSimone -----Original Message----- From: Xu, Wei6 =20 Sent: Sunday, November 5, 2023 7:19 AM To: devel@edk2.groups.io Cc: Xu, Wei6 ; Abner Chang ; Desimo= ne, Nathaniel L ; Gao, Liming Subject: [PATCH v2 edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Suppo= rt Standalone MM. Add MM_STANDALONE type support for SmmIpmiBaseLib instance. Replace Smst wi= th Mmst. Remove unused UefiBootServicesTableLib reference. Cc: Abner Chang Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Wei6 Xu --- .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c | 39 +++++-------------- .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.inf | 7 ++-- 2 files changed, 12 insertions(+), 34 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmI= pmiBaseLib/SmmIpmiBaseLib.c b/Features/Intel/OutOfBandManagement/IpmiFeatur= ePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c index 6282adc269f8..d05798d94866 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBase= Lib/SmmIpmiBaseLib.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiB +++ aseLib/SmmIpmiBaseLib.c @@ -2,15 +2,14 @@ A Library to support all BMC access via IPMI command during SMM Phase. =20 @copyright - Copyright 1999 - 2021 Intel Corporation.
+ Copyright 1999 - 2023 Intel Corporation.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ =20 -#include +#include #include #include -#include -#include +#include #include =20 STATIC IPMI_TRANSPORT *mIpmiTransport =3D NULL; @@ -37,7 +36,7 @@ NotifyIpmiTransportCallback ( EFI_STATUS Status; Status =3D EFI_SUCCESS; if (mIpmiTransport =3D=3D NULL) { - Status =3D gSmst->SmmLocateProtocol ( + Status =3D gMmst->MmLocateProtocol ( &gSmmIpmiTransportProtocolGuid, NULL, (VOID **) &mIpmiTransport @@ -60,15 +59,15 @@ Initia= lizeIpmiBase ( { EFI_STATUS Status; if (mIpmiTransport =3D=3D NULL) { - Status =3D gSmst->SmmLocateProtocol ( + Status =3D gMmst->MmLocateProtocol ( &gSmmIpmiTransportProtocolGuid, NULL, (VOID **) &mIpmiTransport ); if (EFI_ERROR (Status)) { - Status =3D gSmst->SmmRegisterProtocolNotify ( + Status =3D gMmst->MmRegisterProtocolNotify ( &gSmmIpmiTransportProtocolGuid, - (EFI_SMM_NOTIFY_FN) NotifyIpmiTransportCallback, + (EFI_MM_NOTIFY_FN) NotifyIpmiTransportCallback, &mEfiIpmiProtocolNotifyReg ); } @@ -104,30 +103,10 @@ IpmiSubmitCommand ( OUT UINT8 *ResponseData, IN OUT UINT32 *ResponseDataSize ) -/*++ - -Routine Description: - - Routine to send commands to BMC - -Arguments: - - NetFunction - Net function of the command - Command - IPMI Command - CommandData - Command Data - CommandDataSize - Size of CommandData - ResponseData - Response Data - ResponseDataSize - Response Data Size - -Returns: - - EFI_NOT_AVAILABLE_YET - IpmiTransport Protocol is not installed yet - ---*/ { EFI_STATUS Status; =20 - Status =3D gSmst->SmmLocateProtocol (&gSmmIpmiTransportProtocolGuid, NUL= L, (VOID **) &mIpmiTransport); + Status =3D gMmst->MmLocateProtocol (&gSmmIpmiTransportProtocolGuid,=20 + NULL, (VOID **) &mIpmiTransport); if (EFI_ERROR (Status)) { ASSERT_EFI_ERROR (Status); return Status; @@ -164,7 +143,7 @@ GetBmcStatus ( { EFI_STATUS Status; =20 - Status =3D gSmst->SmmLocateProtocol (&gSmmIpmiTransportProtocolGuid, NUL= L, (VOID **) &mIpmiTransport); + Status =3D gMmst->MmLocateProtocol (&gSmmIpmiTransportProtocolGuid,=20 + NULL, (VOID **) &mIpmiTransport); if (EFI_ERROR (Status)) { ASSERT_EFI_ERROR (Status); return Status; diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmI= pmiBaseLib/SmmIpmiBaseLib.inf b/Features/Intel/OutOfBandManagement/IpmiFeat= urePkg/Library/SmmIpmiBaseLib/SmmIpmiBaseLib.inf index 7ea688fc165f..df43c81e6493 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBase= Lib/SmmIpmiBaseLib.inf +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiB +++ aseLib/SmmIpmiBaseLib.inf @@ -1,7 +1,7 @@ ## @file # # @copyright -# Copyright 2010 - 2021 Intel Corporation.
+# Copyright 2010 - 2023 Intel Corporation.
# SPDX-License-Identifier: BSD-2-Clause-Patent ## =20 @@ -11,7 +11,7 @@ FILE_GUID =3D 2B5AD78E-5CF8-45d2-B2AC-749A09425911 MODULE_TYPE =3D DXE_SMM_DRIVER VERSION_STRING =3D 1.0 - LIBRARY_CLASS =3D IpmiBaseLib|DXE_SMM_DRIVER SMM_CORE + LIBRARY_CLASS =3D IpmiBaseLib|DXE_SMM_DRIVER SMM_CORE M= M_STANDALONE MM_CORE_STANDALONE =20 [sources] SmmIpmiBaseLib.c @@ -21,9 +21,8 @@ IpmiFeaturePkg/IpmiFeaturePkg.dec =20 [LibraryClasses] - UefiBootServicesTableLib DebugLib - SmmServicesTableLib + MmServicesTableLib =20 [Protocols] gSmmIpmiTransportProtocolGuid -- 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111867): https://edk2.groups.io/g/devel/message/111867 Mute This Topic: https://groups.io/mt/102402215/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-