[edk2-devel] [edk2-platforms][PATCH 0/2] IpmiFeaturePkg: compilation fix

[edk2-devel] [edk2-platforms][PATCH 0/2] IpmiFeaturePkg: compilation fix

[Mike Maslenkin]

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119618): https://edk2.groups.io/g/devel/message/119618
Mute This Topic: https://groups.io/mt/106750820/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms][PATCH 1/2] IpmiFeaturePkg/GenericIpmi: add IpmiFeaturePkg.dec to packages list

[Mike Maslenkin]

GCC is unable to find a header file located into IpmiFeaturePkg:
  fatal error: Library/ServerMgmtRtLib.h: No such file or directory
     11 | #include <Library/ServerMgmtRtLib.h>
        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
---
 .../Library/ServerManagementLibNull/ServerManagementLibNull.inf  | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManagementLibNull/ServerManagementLibNull.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManagementLibNull/ServerManagementLibNull.inf
index 6b66b44857f3..8bde6fbaa7be 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManagementLibNull/ServerManagementLibNull.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManagementLibNull/ServerManagementLibNull.inf
@@ -27,6 +27,7 @@
 
 
 [Packages]
+  IpmiFeaturePkg/IpmiFeaturePkg.dec
   MdePkg/MdePkg.dec
   ServerPlatformPkg/PlatformPkg.dec
 
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119619): https://edk2.groups.io/g/devel/message/119619
Mute This Topic: https://groups.io/mt/106750821/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms][PATCH 2/2] IpmiFeaturePkg/GenericIpmi: add EFIAPI for driver entrypoints

[Mike Maslenkin]

Fix gcc build failure:
IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c:414:1:
  error: conflicting types for 'InitializeSmmGenericIpmi'
  414 | InitializeSmmGenericIpmi (
      | ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from <command-line>:
IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi/DEBUG/AutoGen.h:138:1:
  note: previous declaration of 'InitializeSmmGenericIpmi' was here
  138 | InitializeSmmGenericIpmi (
      | ^~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
---
 .../OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog.c     | 1 +
 .../IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c              | 1 +
 .../GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c           | 1 +
 3 files changed, 3 insertions(+)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog.c
index 0b1e2f5b1355..cd627ea799a2 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Dxe/BmcElog.c
@@ -258,6 +258,7 @@ SetElogRedirInstall (
 
 **/
 EFI_STATUS
+EFIAPI
 InitializeBmcElogLayer (
   IN EFI_HANDLE        ImageHandle,
   IN EFI_SYSTEM_TABLE  *SystemTable
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c
index 23493733178a..976bb69c956b 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGenericIpmi.c
@@ -410,6 +410,7 @@ Returns:
 }
 
 EFI_STATUS
+EFIAPI
 InitializeSmmGenericIpmi (
   IN EFI_HANDLE        ImageHandle,
   IN EFI_SYSTEM_TABLE  *SystemTable
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
index edc9eec9395a..a7faa0e1f37f 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/StandaloneMm/StandaloneMmGenericIpmi.c
@@ -330,6 +330,7 @@ Returns:
 
 **/
 EFI_STATUS
+EFIAPI
 InitializeGenericIpmiStandaloneMm (
   IN EFI_HANDLE           ImageHandle,
   IN EFI_MM_SYSTEM_TABLE  *SystemTable
-- 
2.32.0 (Apple Git-132)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119620): https://edk2.groups.io/g/devel/message/119620
Mute This Topic: https://groups.io/mt/106750822/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH 0/2] IpmiFeaturePkg: compilation fix

[Nate DeSimone]

Series Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

-----Original Message-----
From: Mike Maslenkin <mike.maslenkin@gmail.com> 
Sent: Tuesday, June 18, 2024 3:32 PM
To: devel@edk2.groups.io; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; gaoliming@byosoft.com.cn
Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
Subject: [edk2-platforms][PATCH 0/2] IpmiFeaturePkg: compilation fix

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119674): https://edk2.groups.io/g/devel/message/119674
Mute This Topic: https://groups.io/mt/106750820/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH 0/2] IpmiFeaturePkg: compilation fix

[Nate DeSimone]

The series has been pushed as 223bed9~..e70b333

-----Original Message-----
From: Mike Maslenkin <mike.maslenkin@gmail.com> 
Sent: Tuesday, June 18, 2024 3:32 PM
To: devel@edk2.groups.io; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; gaoliming@byosoft.com.cn
Cc: Mike Maslenkin <mike.maslenkin@gmail.com>
Subject: [edk2-platforms][PATCH 0/2] IpmiFeaturePkg: compilation fix

Signed-off-by: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119675): https://edk2.groups.io/g/devel/message/119675
Mute This Topic: https://groups.io/mt/106750820/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-