From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EE36AD80470 for ; Tue, 26 Sep 2023 20:39:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Cfu+4ug6tra3/GGkp4KS40YecHjMk0lxk87iOPC3g/Y=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695760768; v=1; b=iQqStYFk8OuKD/w1lTX5AaMU1NfRYqjigS5JUN/VLaK1qSr6HldOI0Fbnjtc3976CauDZN68 hJGlxpOGZsON4hVXN1MmIA/ucPmVx6/Mq7MvX4aOoHStYHN9KIAtzlrg9manNHQzN2+14Lv3geH ILCAVBYp40mkci9F4nH0Hs74= X-Received: by 127.0.0.2 with SMTP id Q5rwYY7687511xddhJPO3ZVF; Tue, 26 Sep 2023 13:39:28 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.2169.1695760767948564946 for ; Tue, 26 Sep 2023 13:39:27 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="378946232" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="378946232" X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 13:39:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="995920517" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="995920517" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 26 Sep 2023 13:39:26 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 26 Sep 2023 13:39:26 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 26 Sep 2023 13:39:26 -0700 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 26 Sep 2023 13:39:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NEat2yyZzPYAquiDEuBPyGS5/SePOCxTiViT2hg2kHWsEN79kgv6XB2pEE+JUIar/v47wfbaPJa9VD+G4+G4Vfm2x+PWP36hGu31N9YRt80M+Je4vBBBlChidIUSgX8oOwx7vvU+zU0v1OYg7JKloC0qy4HVPdvxGgy0r1SjNPSzeCj7+pgB4JDQH4wAN5TWqhVW9gg97zZJb6AwQ8jD+nnjIadvoka1A/hBCjdQFR8+nstocOuNWd56wFAn5ttrh+HJSvUl1yPy5pkaZE8qhhZwQnQbI3uHcCZ+jgyN08lS2IoLBxpm+MTvZ81JtIGwCNoybhgwBR2/Azo/DThMcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jN07W422u/DW42OybjK08rUQda+GzwhBMwX9n3nBKUA=; b=enoDEYxV3Lpw350xiHFhtxWkImlbW1DrjMKaBtNkCXh2L+yWhGxZaefWTgEgkn4FzBwU0IH2HP4ZPJRUzwsH/TU035KIpRPEqpvOG2K+dfFJXTMgYnZhbV2fNtI93UN2IaEamxafeMtajG+usNaP8sDszfKS74OAf9++SxC0AB32hXvQ6XbUD24pvtv5IOqwFXU4F75vFOSFv22ZTlR5rcXSzimHlcG11m3+YQMBhSF4yALT1KhBxzVd1CrzgePD9M+htiCvI5KUWgtkRSXsVuhbJ9/MHVxtgA8RK3BaGFufKlyIO91pKdrLmXSLj+UXxHQh2fDyBeM+35pbMPr0bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by CH0PR11MB5522.namprd11.prod.outlook.com (2603:10b6:610:d5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.28; Tue, 26 Sep 2023 20:39:17 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::89db:ecf0:29f5:9f3c]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::89db:ecf0:29f5:9f3c%4]) with mapi id 15.20.6813.017; Tue, 26 Sep 2023 20:39:17 +0000 From: "Nate DeSimone" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Andrew Fish , "Ni, Ray" , "Chiu, Chasel" Subject: Re: [edk2-devel] [PATCH v1] EmulatorPkg: Fix Terminal Issues Thread-Topic: [PATCH v1] EmulatorPkg: Fix Terminal Issues Thread-Index: AQHZ8KhcA9l2MMuSy0C673hGdEk4+rAth0pwgAAJYYCAAADRwA== Date: Tue, 26 Sep 2023 20:39:17 +0000 Message-ID: References: <20230926183601.2974-1-nathaniel.l.desimone@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|CH0PR11MB5522:EE_ x-ms-office365-filtering-correlation-id: d6c726ca-9c8a-48e7-1aaf-08dbbed0a7a5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: +AJk83t21WyT7Q7OluXTMkv6ZU7AUcbnaiufSmfShAtVQUYwSy7Pr/hAzW8FM3/A0yxcNmPc+kDkU02ZraHR9O0gG5plL0+C/FmcYxazUaKd8KFbXOaPqugbm36BX/7QPXgkOKWUOngDFrB2902bwEzvPIWWBynA2GV+pcFtCwCLO4xvAVfqTYJAkBsaVqFPCcGlqCrRnGKF2BE39I/3MA1NECIJIUPX0u3mvR9jPgtLn+S8pPGB4LAen9ghS8xY8ncwhuKAIjTphwvntM53H0Y+7+CSohoQiQI+HrfYM3ratobivuMWMv44PKZ//zxy/ZGdpylFVM3ehmgxyc9uLwbvSg5+SCvZMAWugjMEMQNW0cbXdZs5fTCC9efUiLo2ec3PTB5UD0EhMC3rg83q2z9LUHx1YP01Lw3eBrSpgkxae8g1v+vHD24VGLIul5EXmQbxDMtv+XdRL0G5Lg4Sq0j8FniTBnLivcwPUPxo9zGusz0dh60Wp9IHHUTtp6Lep9PNgyhcalHiJGqPXUrfXz7PVbvhJxcRgYEOvvcvJUlBAJ3Rzw9FAxsZay3I1JDdpUDuEzXNSS+x/Kray+a6u5HbzUtdV6Kh1DG5gwLVNO5qFIq/srpyHQhCnUK6H1u4 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hHT0dX3qxV+oOWDbmidvIlWmefFs9tX6A7xrvyyzNGVrmRyZsfs2/nPKFAZn?= =?us-ascii?Q?KOGp2ULIJC/bYTZ8iZF2R6qdKfIpiVIn6Ag7jR2U9WksdMO1AX2V7WyAM+o7?= =?us-ascii?Q?9CRdO+CcvCkbzZY+0J6ipP59/6L0mSigzaiY68aOYtPKgfe9C+NBj60Ppnx8?= =?us-ascii?Q?7efi0Xm9lIRlnxkmNyiRtNcFjaNlZxT7BUnLWXDjrK+vOxCVV+IVwRuPz7ZJ?= =?us-ascii?Q?Emo4UjhLDpZXM8jteyr6QYk5Pim8UN3y45u9t0C2PewAUIs3eGRxkqhCvVht?= =?us-ascii?Q?HIi/Jm0P4LMpHu6kWQRDgMxmrfYDoyyCsWE8ZVwyHSbRe839RDKO7jAes/I0?= =?us-ascii?Q?0brM1Gw/0OFG9QOzIJpO/Es8ecr9uyQmbnolOrL4qDO81uNYopLtnXfrUZa+?= =?us-ascii?Q?9NeJo6TdMPra8LoZLGa+aBuLTTWdYCN0TThW1NMRZrKJQ91xwzs51yow1M6f?= =?us-ascii?Q?TZR8kNcvMG8EGysD+TZwyJ+lLtwaBqRuWMPBPAjsuLnzv/QdgRi210ixW4lb?= =?us-ascii?Q?yX5Tw8NIcBGYqlJ/TgZKJEb7gv7JphAqc1u+UynKa2lg842JcsXMId4gpMnX?= =?us-ascii?Q?j9bDKee8Z7UdOfxO1jhRgCAI3/+Bj1Mw3nDshGKuUWnnyQ5/stiSYfo7eVBd?= =?us-ascii?Q?a8AKe1EAazrnqdBvaJvPnuRcWrAoZ1xpwxS5HPlMPmGJzv8brX5NbzZIzYAM?= =?us-ascii?Q?9e3CTqZQsvoCQk9MLIBvuBmsJ/sEt3Pw01GRoFef5qlZ4XCepryhqC1CiA9C?= =?us-ascii?Q?nLQnaOQFZYzV62wfQwYfYm4eEf40LYsrMY/SSV5B6RVPet9UX1Dd9kgcsbwq?= =?us-ascii?Q?+Wdb03n468EjYrWE41030fZm9ZWtSozIPwK8orsMbWGkR6ppgn63fQBwj1KC?= =?us-ascii?Q?RGAXeSLME+NMJf9nmYZ0Cqq3Dd73/lN8cTp0TSIeawFXviBQZ98QFOnJEyGj?= =?us-ascii?Q?5NWF9LYajogGpOSOpJJLlPpPkNV2PsZure65c6p1KVzh/TUpP4WaVU/R7/pC?= =?us-ascii?Q?Un8bPwptmqxHReI5cubAgvhRNc/us4ePpG82d6elo2fmSLL/GmJZq2gv/c2X?= =?us-ascii?Q?AtU5szQx5v+4iF6eDk7+Rjmq1d4FA5vcX4CRdpLfSdqG/HgNfH266NcnJiSp?= =?us-ascii?Q?THj4QluTqmPwthnuQNakodmRikLNI8eOgeulW/3F7Pl0RJL4d06ySrI3zFdX?= =?us-ascii?Q?N2S1SEd+wg0pV55kQUg5nMdzQxRD6dkrnx/ojmLc41ICKZnYx+0JWZgel7QO?= =?us-ascii?Q?vyncmOpdDRUxmWkw8/92BH8TM5cR+cvC0/h3pf+UZzlxQSGZm45K6c+UECSn?= =?us-ascii?Q?A/DE3T2A5NnUAOHsAQJLmG9X0mlMnM6AGjhn2u5M4ZQjCxkqU5Ui5jSGDZ82?= =?us-ascii?Q?TFyqVDdNqK7sRo4PdfOUSrWGb9wPEGRrwVfAivym0L/QkRtIZ0l7I9k/wT9I?= =?us-ascii?Q?NafAXFzmdC7gc39nv2a7nAUNoycZph9vWNADo0gbrWJhLR5RLbzFEJoWuPY+?= =?us-ascii?Q?yp89gM5Boxep+XhRo1XvPc/TTzwainB+SkhoHt5tq9njtSCUkNQvon9yeYOB?= =?us-ascii?Q?aOA3G7OBsDooat4+V3LQtLkcMRtHtLP9AubZV2pq0gDQVSN4dEUnSn7bQhOO?= =?us-ascii?Q?Ng=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d6c726ca-9c8a-48e7-1aaf-08dbbed0a7a5 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 20:39:17.7792 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D00UE5S/cT6kbPXTT0fjpbMaxMd/IIN8NZRtwB9U4Kxxdx/NjudN6jI1PtigBHRZG8+JBO5h7vBi5VDtv3IE+WcpKTZrmYEcLWtiS0LbAlk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5522 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: gFFhuv6JeJnQabYVl5AHsA9Xx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=iQqStYFk; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:dns request to arcselector9901._domainkey.microsoft.com failed: no records with this name}") Oh, never mind, I see you are suggesting a C99 style variable declaration. = Do we need to worry about old compiler that want all variable declarations = at the top still? Thanks, Nate -----Original Message----- From: Desimone, Nathaniel L=20 Sent: Tuesday, September 26, 2023 1:38 PM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Andrew Fish ; Ni, Ray ; Chiu, Chasel= Subject: RE: [PATCH v1] EmulatorPkg: Fix Terminal Issues Hi Mike, Unfortunately, that change will generate the following warning on GCC4.6+ warning: variable "Success" set but not used [-Wunused-but-set-variable] Hence why I wrote it that way. Let me know if you would like me to make a d= ifferent change before committing. Thanks, Nate -----Original Message----- From: Kinney, Michael D Sent: Tuesday, September 26, 2023 1:03 PM To: Desimone, Nathaniel L ; devel@edk2.grou= ps.io Cc: Andrew Fish ; Ni, Ray ; Chiu, Chasel= ; Kinney, Michael D Subject: RE: [PATCH v1] EmulatorPkg: Fix Terminal Issues Thanks Nate! I have noticed this issue for a while. One comment below. With that update: Reviewed-by: Michael D Kinney Mike > -----Original Message----- > From: Desimone, Nathaniel L > Sent: Tuesday, September 26, 2023 11:36 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ni, Ray ; Kinney,=20 > Michael D ; Chiu, Chasel=20 > > Subject: [PATCH v1] EmulatorPkg: Fix Terminal Issues >=20 > After running EmulatorPkg, one will notice that their terminal acts=20 > strangely. This is caused by the EmulatorPkg Host changing the=20 > terminal mode and not restoring the original mode, which is now fixed. >=20 > Cc: Andrew Fish > Cc: Ray Ni > Cc: Michael D Kinney > Cc: Chasel Chiu > Signed-off-by: Nate DeSimone > --- > EmulatorPkg/Unix/Host/EmuThunk.c | 16 ++++++++++++-=20 > EmulatorPkg/Win/Host/WinThunk.c | 40 > +++++++++++++++++++++++++++++++- > 2 files changed, 54 insertions(+), 2 deletions(-) >=20 > diff --git a/EmulatorPkg/Unix/Host/EmuThunk.c > b/EmulatorPkg/Unix/Host/EmuThunk.c > index 6422f056a6..e6879db650 100644 > --- a/EmulatorPkg/Unix/Host/EmuThunk.c > +++ b/EmulatorPkg/Unix/Host/EmuThunk.c > @@ -9,7 +9,7 @@ > it may cause the table to be initialized with the members at the=20 > end being > set to zero. This is bad as jumping to zero will crash. >=20 > -Copyright (c) 2004 - 2019, Intel Corporation. All rights=20 > reserved.
> +Copyright (c) 2004 - 2023, Intel Corporation. All rights > reserved.
> Portions copyright (c) 2008 - 2011, Apple Inc. All rights=20 > reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -34,6 +34,9 @@ UINTN settimer_callback =3D 0; >=20 > BOOLEAN gEmulatorInterruptEnabled =3D FALSE; >=20 > +STATIC BOOLEAN mEmulatorStdInConfigured =3D FALSE; STATIC struct=20 > +termios mOldTty; > + > UINTN > SecWriteStdErr ( > IN UINT8 *Buffer, > @@ -58,8 +61,15 @@ SecConfigStdIn ( > // Need to turn off line buffering, ECHO, and make it unbuffered. > // > tcgetattr (STDIN_FILENO, &tty); > + if (!mEmulatorStdInConfigured) { > + // > + // Save the original state of the TTY so it can be restored on > exit > + // > + CopyMem (&mOldTty, &tty, sizeof (struct termios)); } > tty.c_lflag &=3D ~(ICANON | ECHO); > tcsetattr (STDIN_FILENO, TCSANOW, &tty); > + mEmulatorStdInConfigured =3D TRUE; >=20 > // setvbuf (STDIN_FILENO, NULL, _IONBF, 0); >=20 > @@ -338,6 +348,10 @@ SecExit ( > UINTN Status > ) > { > + // Reset the TTY back to its original state if > + (mEmulatorStdInConfigured) { > + tcsetattr (STDIN_FILENO, TCSANOW, &mOldTty); } > exit (Status); > } >=20 > diff --git a/EmulatorPkg/Win/Host/WinThunk.c=20 > b/EmulatorPkg/Win/Host/WinThunk.c index 008e5755db..90a6da2ece 100644 > --- a/EmulatorPkg/Win/Host/WinThunk.c > +++ b/EmulatorPkg/Win/Host/WinThunk.c > @@ -1,6 +1,6 @@ > /**@file >=20 > -Copyright (c) 2006 - 2018, Intel Corporation. All rights=20 > reserved.
> +Copyright (c) 2006 - 2023, Intel Corporation. All rights > reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > Module Name: > @@ -30,6 +30,12 @@ Abstract: >=20 > #include "WinHost.h" >=20 > +STATIC BOOLEAN mEmulatorStdInConfigured =3D FALSE; STATIC DWORD=20 > +mOldStdInMode; #if defined (NTDDI_VERSION) && defined > +(NTDDI_WIN10_TH2) && > (NTDDI_VERSION > NTDDI_WIN10_TH2) > + STATIC DWORD mOldStdOutMode; > +#endif > + > UINTN > SecWriteStdErr ( > IN UINT8 *Buffer, > @@ -61,6 +67,12 @@ SecConfigStdIn ( >=20 > Success =3D GetConsoleMode (GetStdHandle (STD_INPUT_HANDLE), &Mode); > if (Success) { > + if (!mEmulatorStdInConfigured) { > + // > + // Save the original state of the console so it can be restored > on exit > + // > + mOldStdInMode =3D Mode; > + } > // > // Disable buffer (line input), echo, mouse, window > // > @@ -82,6 +94,12 @@ SecConfigStdIn ( > // > if (Success) { > Success =3D GetConsoleMode (GetStdHandle (STD_OUTPUT_HANDLE),=20 > &Mode); > + if (!mEmulatorStdInConfigured) { > + // > + // Save the original state of the console so it can be restored > on exit > + // > + mOldStdOutMode =3D Mode; > + } > if (Success) { > Success =3D SetConsoleMode ( > GetStdHandle (STD_OUTPUT_HANDLE), @@ -91,6 +109,9=20 > @@ SecConfigStdIn ( > } >=20 > #endif > + if (Success) { > + mEmulatorStdInConfigured =3D TRUE; > + } > return Success ? EFI_SUCCESS : EFI_DEVICE_ERROR; } >=20 > @@ -467,6 +488,23 @@ SecExit ( > UINTN Status > ) > { > + #if defined (NTDDI_VERSION) && defined (NTDDI_WIN10_TH2) && > (NTDDI_VERSION > NTDDI_WIN10_TH2) > + BOOL Success; > + #endif > + > + if (mEmulatorStdInConfigured) { > + // > + // Reset the console back to its original state > + // > + #if defined (NTDDI_VERSION) && defined (NTDDI_WIN10_TH2) && > (NTDDI_VERSION > NTDDI_WIN10_TH2) I think the BOOL Success variable could be added here and reduce the #if st= atements > + Success =3D SetConsoleMode (GetStdHandle (STD_INPUT_HANDLE), > mOldStdInMode); > + if (Success) { > + SetConsoleMode (GetStdHandle (STD_OUTPUT_HANDLE), > mOldStdOutMode); > + } > + #else > + SetConsoleMode (GetStdHandle (STD_INPUT_HANDLE), mOldStdInMode);=20 > + #endif } > exit ((int)Status); > } >=20 > -- > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109091): https://edk2.groups.io/g/devel/message/109091 Mute This Topic: https://groups.io/mt/101602599/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-