From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web12.3922.1642042055089550495 for ; Wed, 12 Jan 2022 18:47:35 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QadPnQDj; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642042055; x=1673578055; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=v1mnq/eikZcfVQ0V/OZ5d81sb3yw5cYPvpgeq+Slpqw=; b=QadPnQDjc2G3KYyDSXvohu8SvmEEfizAo1lYu5nBjq1FhpEIZkP4wX+q qL8Y2HCz2uq2ZAAJc6hllZEWDmPifx5KCAFbfhrPt5nHDDKf3/8JmtIle WS0J1g3D+id/Wbm7XYASuVgTBH6oCRC2FcemMXK00Cvj6vSFCm0enIcX1 bjFipBq2wRYiJgD+aD8JuQCpSwSyw/YBx8w37z5RJ9Xdx6kADvEGcKQJP oBntVIY96Ye8xGyn46Dc01aQku8HXzCVmSJL6fT/rLIrFSMNeGDu5jPo4 ooZO7ikUTpFNgihU0y2nxCDJZOw33sAVn6spjMw0X8Fx2ZWLCqNnz45NM g==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="243867633" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="243867633" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 18:47:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="475146722" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 12 Jan 2022 18:47:34 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:47:34 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 18:47:34 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 18:47:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cnwd0fz+ST3pIQESnJmONN8tpyQ7hRXWfGfLMUirRbQuVqDj9nz3OxBMpacCnT8lyN9Fqg6XqBxNaG5RpNnue8EagoO4KJf2qym32g1R6pxDnoz+G8KI3J3xJlEeIXzgui17ec9JOnKbxEEV7rbYimVAQQ6OcpgJVDp1rPKkmZK6meIje+fe9fpkQFGxs7He25gxfh3eoT8Qv+1Lg62E5I88mVaktMDPgBVlyU0gkz2abCz2yrNDrNT4HaN4NBthJ7TS7/4LT3JRnnQ4dTCv18x3l3dHjXChWrclEmdq2SoWVpVVR3uj77oP8s/LfB69Gvy1b9hxlcJIfnrMPfvKqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a0HX+W/TSKReigeYBC3jjYQIFpoMHd2yDT55MzGsDtM=; b=fFCxJbFwBcMBE/iayRgvO4R0bWaf5V0tKa/fzykLM+7cx3SeSvdaAUQPx7qn0hVgqsC/Ht9WRJxQ4/OXAeVESJSYNGLiqTfWKW8XsfhGxNlkOe4rRcTBiBmcsM8h5ac0Mw0BPEBfG3bmex8afaAdGvPvtM+p62vKAkKDKsynSLR6YAmv2OdNqiQGJtOz5m5xae5DHm2mPJbLd6+xShHGRv/Xa4thRFQHa3nRcSgfRqNU90iL9t9d+jxDo6dsaRH8iwlvmUUxQy5cK9zLQ8V/m8/4Z+EX1xVE/IVbupVUqGiEhEHobplB/s+kJOAmagCz6b3qKM/uC0Ypq0N+MLrd9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MWHPR1101MB2285.namprd11.prod.outlook.com (2603:10b6:301:57::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Thu, 13 Jan 2022 02:47:29 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%8]) with mapi id 15.20.4867.011; Thu, 13 Jan 2022 02:47:29 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Oram, Isaac W" CC: "Chaganty, Rangasai V" , "Gao, Liming" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 26/27] AdvancedFeaturePkg/Build: Add FDF to create FV for all features Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 26/27] AdvancedFeaturePkg/Build: Add FDF to create FV for all features Thread-Index: AQHYB1snz4zgQNNC/Uaqy0tjNYqYOKxgHJiw Date: Thu, 13 Jan 2022 02:47:29 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7e1e174f-02e1-4bec-03ae-08d9d63f0a8c x-ms-traffictypediagnostic: MWHPR1101MB2285:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lgFbLocEERtwPSvGJerZqeYM9jSLhbpaiOrP7yOxhFKihz7WjrhVQRQpreIJ7sRxZnyRmheLi52eJnmJfxkfqvtlDxNDWqIu0vCICoMcIWq4B2XrjDxfBnUjx7GILe6b5yQpLeXXuF3ynbwutGQGEjKN0PiYkiTEoaXfjJIG/MB5LYPfYq3kiPoMD+9I+lGkB0ZdHULb6Cs31hQ131+kSFbnMTdq45ebFly/KMXInhJYH/iqvql87BOR86WvPA4WeVBW0Y3hlP2OcJCVmz24iNrSw8D+FIw+n1oE97vQST0auR7LxJXAqHLOdelA2o0d/6QF75zfUERLGN0Z4IGrhAFVFkHDMNd1EvGwf6Bub/Wptf7Rj3LKrhSE/nYEMzm+W7N+5xCbuiPZ44LuDB/Slzgx6RgiNM4byhlEivsvC9XQQ2clNdK1QPYZd6n669t7KXcycpDMimWFCF31RdlCgtQP7JKd3SnCG0lkyJgqEJIVoJxansNvID9T+mXBCdJalT+cL3/fdHNGmW4z51uyyvvTYLmPSWpaJ3yXBj0NuNgC4QeLIaKTS21/A4B2QaaExRvZHJOmdRyd1405MkyLE8ESiNX9sTj+6fah37QgP6PMZDws3uEE+9TTcldGPyENdJMY2aRWKaCCM08FP2s8Z/1GuP1qqpSXAvkWPZp8np+OG7n9UbTqHMb8FMCOhfrbAU0rH+xXSO4pCu8DKKZT4bXwAetTfCKyqv4rqi5TiVeUbzxILitV5iYrf75hw/idaqLWS8yazkWvcEbnEShhUdQOm3/4Fw3dnr3m1zwhFIDTia1BpWw69TECRc9nNkVriy4KEmFHKtf7f+X3+mOSHg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(110136005)(55016003)(7696005)(66946007)(66476007)(54906003)(64756008)(76116006)(66446008)(6506007)(316002)(71200400001)(8676002)(83380400001)(38070700005)(2906002)(966005)(5660300002)(38100700002)(33656002)(53546011)(6636002)(82960400001)(86362001)(52536014)(9686003)(26005)(186003)(508600001)(122000001)(4326008)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r0/98R8GaRfu79i3b3A5G3ENC2TBkbGeNjpvJtBQ5e31wBwfdrtz5Wuo/+nW?= =?us-ascii?Q?p8jTVdHvgp/u18Y0CkKXfDtU6ZhzUC/7Esn3Q+2SsdRftlWZYNLXiTDBc7xL?= =?us-ascii?Q?1CjsITc54LLo9GjEAQBwjIWmOtyaRrp3+lZcnhAozut0DYRFs4ChGEufPqct?= =?us-ascii?Q?Ao4qRE1S3M5Q7oxLESB+mzcak3D0LhmRrcfTuU9Ukk0zj+ZV5VNn4FlOEdiQ?= =?us-ascii?Q?D9xlHuMg5wT2ZNLgNPlKvFpaY6b75BKstlVXHw4BxySXL6FULZn2CFCSB2s+?= =?us-ascii?Q?3BC74rh3a3zQTn/PUz+OqHtYF1rNcsUMYWUC+syGwi4e9apVTETvlJNZmSqR?= =?us-ascii?Q?KNylMf8CjF/FgliLikoUpRN5gunqfPQNAuy2UF+KGjMwKetvCWNI9JQcwOCA?= =?us-ascii?Q?5NglfGsgVTwD3/x7j1VvM5SDnF9HTaPndOnJYprDRFaBGg3bYsr6Nw0bRhhf?= =?us-ascii?Q?9jqR6YGcPDHIaXWR5M3buVIyx9OqR643u/S4HuwEsqjrv+zskdz+cQ+YVArL?= =?us-ascii?Q?b/yr4ET3KquCJD+4uF84w85xpL33O8u667rniHep83gM/yLSh+ox8BKGpJW2?= =?us-ascii?Q?BQaqKMLEweXRh69W/FxZLYTthqB1KCtlrEPIWgCMC9Jr/QibG03r4Kp048Ha?= =?us-ascii?Q?zXQguUtyoml4q6pVGlvRQKMknpc3YHlk98Ejx3rpAw1J+8s1PAQFmdXKif1o?= =?us-ascii?Q?S/CuK9nDQLX3T70ik1zqucAImqHitmeZ9Y6SltNGKLhZ88StSDloyYic2WfC?= =?us-ascii?Q?JY71xbIm9uSM4zRRl+Xf6S2YyTT9iJTrTjcCz4Vys/KEEoAWnI+Ax3wjheIE?= =?us-ascii?Q?iqWU6xbcpJmnzPQ6Az1hWyC0qTKQ46Lwi2SHecEXJ+lxxgnr7b25yRTslAff?= =?us-ascii?Q?AyaktauqgABj65oPklfrVsNtyOTsbGlDHqFhUxSCDfnUwY/0tWJPktyxAblC?= =?us-ascii?Q?uKeh0cAr2D3C0xe0SstAD3B1AkdJ6lMyz7JGlX1LvpVEspAS3/KYEA1TAfD9?= =?us-ascii?Q?iF/td8hOoT2qzatCIA2VsSX7lccA6LEA9yRwexVhw8YRYmQ1L8WaFySgM5sm?= =?us-ascii?Q?jGO3iyaRWUTd14YG66MhtWpOwR7LcK+bno4RA/3O6TUQS7NlV3Zff7FgM1uX?= =?us-ascii?Q?6iajDzq/e/xaiqy2pczMhk52MiVcaQdnPVK3qAY3VBNwhWrZ6A170h1U9y5P?= =?us-ascii?Q?HglfZignteHDYiHiIdtqqJUw8fXqb7eT92tfWUR4Vt6oKc3BqKUCKiNfcISW?= =?us-ascii?Q?pdd7grwqeEi3qkID2KSnfBLr9ffczWby8tWINKi/slcQEFNFvFJxMcxXafAD?= =?us-ascii?Q?+oFZPF8QuT3eM/cmL6i07mdwrghVQyLdDY9Vd0F590TVF3m7Kx0hE7SbNZks?= =?us-ascii?Q?Rzpjyli77XxoLipWReKWUPkbJVKZgmBAh/wPOj8Fi9JDqrxeQfI+rTsSX9Iq?= =?us-ascii?Q?FTSZww85Nlpn4p2wsgAmoxgILrhF/L9LzJN80LpvIEPwEPaiOdwMOrPtZz9Y?= =?us-ascii?Q?g7Fx4LdrsbtcKmGvlH6vcGtMPU0w0eezz4M8b7RW2h8KrtdtdUjg/ar3D2I+?= =?us-ascii?Q?rITDkBKYCeT2kK1tL/kAjQlPAAHlQTDHi2qtJFYZST4kNwR8puvtnXK9msic?= =?us-ascii?Q?d6SeX2jpBkEXgAJeIjMA9doqBPlA+Xn6BLScoI0w4d7XyhaYToL8Kzje9reY?= =?us-ascii?Q?JXYuGQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e1e174f-02e1-4bec-03ae-08d9d63f0a8c X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 02:47:29.7086 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KwtgU5ICO1WWYzQTbufkAIuXUDSMYF7+aNYpOZmsVTCk/fM1pMCM8ElpygTpkyHFksNGzgSzDGCeLrY7Kv3QISorTfDcDtYS+3q35aYiju4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2285 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Isaac, Since FvAdvanced is post-memory and not covered by the boot guard IBB, I su= spect we should probably also support optional signing of that FV. Thanks, Nate -----Original Message----- From: devel@edk2.groups.io On Behalf Of Oram, Isaac = W Sent: Tuesday, January 11, 2022 6:20 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel][edk2-platforms][PATCH V1 26/27] AdvancedFeaturePkg/Bu= ild: Add FDF to create FV for all features This produces three FV and no FD. FvAdvancedPreMemory.fv contains PEIM for pre-memory use. FvAdvancedUncompressed.fv contains post memory PEIM and drivers for DXE and= SMM. FvAdvanced.fv contains the compressed FvAdvancedUncompressed.fv in an FV fi= le format as is common practice. These FV are not expected to be used as is, but are needed to test the indi= vidual features for things like filename collisions. Some features require= build customization so binary reuse is not feasible at this time. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Isaac Oram --- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 1 + Features/= Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.fdf | 49 ++++++++++++++++++++ 2 files changed, 50 insertions(+) diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Fea= tures/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc index 02636da916..28530b8c67 100644 --- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -29,6 +29,7 @@ SKUID_IDENTIFIER =3D DEFAULT PEI_ARCH =3D IA32 DXE_ARCH =3D X64 + FLASH_DEFINITION =3D AdvancedFeaturePkg/AdvancedFeatu= rePkg.fdf =20 [Packages] MdePkg/MdePkg.dec diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.fdf b/Fea= tures/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.fdf new file mode 100644 index 0000000000..76a02c5d1c --- /dev/null +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.fdf @@ -0,0 +1,49 @@ +## @file +# FDF file generating AdvancedFeature FV for inclusion in a MinPlatform de= sign. +# +# There are three FV produced, FvAdvancedPreMemory.fv,=20 +FvAdvancedUncompressed.fv, and # FvAdvanced.fv. The sizes are=20 +arbitrary as these are not expected to be used as is # in today's usages. = Boards will tune FV by selecting or deseleting features and building. +# +# @copyright +# Copyright (C) 2022 Intel Corporation +# +# SPDX-License-Identifier: BSD-2-Clause-Patent ## + +[Defines] + DEFINE UNCOMPRESSED_FV_ADVANCED_FILENAME =3D=20 +6d606b5c-2d45-4705-a700-73324306be06 + +[FV.FvAdvancedPreMemory] + !include MinPlatformPkg/Include/Fdf/CommonSpiFvHeaderInfo.fdf + FvNameGuid =3D ea9da344-a7f3-468c-ae84-2d22fc03b28e + + !include AdvancedFeaturePkg/Include/PreMemory.fdf + +[FV.FvAdvancedUncompressed] + !include MinPlatformPkg/Include/Fdf/CommonSpiFvHeaderInfo.fdf + FvNameGuid =3D $(UNCOMPRESSED_FV_ADVANCED_FILENAME) + + !include AdvancedFeaturePkg/Include/PostMemory.fdf + +[FV.FvAdvanced] + !include MinPlatformPkg/Include/Fdf/CommonSpiFvHeaderInfo.fdf + FvNameGuid =3D 445b121d-28d6-4801-8958-8253cf426cf7 + + FILE FV_IMAGE =3D $(UNCOMPRESSED_FV_ADVANCED_FILENAME) { + SECTION GUIDED EE4E5898-3914-4259-9D6E-DC7BD79403CF PROCESSING_REQUIRE= D =3D TRUE { + SECTION FV_IMAGE =3D FvAdvancedUncompressed + } + } + + +####################################################################### +######### +# +# Rules are use with the [FV] section's module INF type to define # how=20 +an FFS file is created for a given INF file. The following Rule are the=20 +default # rules for the different module type. User can add the=20 +customized rules to define the # content of the FFS file. +# +####################################################################### +######### + +!include MinPlatformPkg/Include/Fdf/RuleInclude.fdf -- 2.27.0.windows.1