From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web10.487.1662764963493441697 for ; Fri, 09 Sep 2022 16:09:24 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=TIWox6ls; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662764963; x=1694300963; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=z8Ff1iwq3h7lE4HaqZrSY36byyIF99nmwqCxMbkCCSw=; b=TIWox6ls7NOpcqX5BzNuhSlndDKa0EgNsfCKPqJCaVAj/HZLEXiMnffM KsZ1qGf0lRsmdCUNgMG0tVyavPH2ksf/pQ3fOXFKa6q/8UGuv3ikTNctw 9Znu+3L5N5g1wLkB71sTOejBbt+SokmhKXb4htynDfDE1lyuh7Jw0hP2H A689bKtrcxYpnn9Kg1gND5LjMKhxil1n7gcZET9uhXSTaxTlDheJG1vW9 ZmRchtL+9yA/P32eBF8Ukd0gz2rf0vO5mtuD10scIyiglOkI7oSvJ+UWU 8/y29ijhBFrf3/9i8oRG2aTx2Luh9Jd/F0c/yac25hnaldddpvjU9esSe w==; X-IronPort-AV: E=McAfee;i="6500,9779,10465"; a="359311543" X-IronPort-AV: E=Sophos;i="5.93,304,1654585200"; d="scan'208";a="359311543" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 16:09:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,304,1654585200"; d="scan'208";a="592781278" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP; 09 Sep 2022 16:09:22 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 16:09:22 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 16:09:22 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 9 Sep 2022 16:09:22 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 9 Sep 2022 16:09:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R50UCt8SVHlkyRA14y4eM2SH31nIYwBWrxnelrw1Wuw+i32iozPfl/7G3c1OzFWJM890YlYc9YicXo0SbJzl/dDAY8RNadXxVeFw2klIHhUXt3oyY4l4W639Jl3sqCn5o09fZVkc50iv9ZztVXgPItwVW4Gvoh+bvW9dVDhYwI11ZxAkQqru1EaRrZ2P8xE1jH2gAFOhX43cATCDBXPMNPq8tD+GT4jrHXl//QPLqGl2nhXSbIbnyY0FnjRnA6AXXMtf/mPzBFfZyDOW5yv8p8MEZ9cwEh4xVrKLDwRdxYS/vD41DjF6auuYM44PxqlgRJ7IhJtR/OQMUQ7HS11/Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P0x2I0OaTH6zWKh0mI5HUCXte2aH74g5FIfaapOZ0oE=; b=ITEfv6yiv5tYljq1/s5ebgrn5jz0CxqK9S5rESEeIpwX58cZHQDAAGXJ6h1+pF7HrAE8i3f6hPA0PBBRDVy4O4+hT+by7ja/EGx2IJbdA/hej7Oh4Odr+GBoL3+iRVQTQ274dNJmFaYKX1RjtW82/bhqDGQa8yuyPXDJJijTfv/ZKua2n8WbxSZVcsspZQdWrH4vrE6HMv7Jr7znJHqDzDHQ3TBsqpc/MR3a++uC4FvbzDwGrC0FEiq9LhqEUQuoKVxYiDHbU6YISv3mkluJdva9bo6IO7FEjs+NlG1Ergsv+AZUFa4jq+F+nk6LAEmxPXsLifKU5Czbp4ZXHhvCyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by BL1PR11MB5367.namprd11.prod.outlook.com (2603:10b6:208:318::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 23:09:06 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2c94:f950:2ac4:d92f]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2c94:f950:2ac4:d92f%8]) with mapi id 15.20.5588.014; Fri, 9 Sep 2022 23:09:06 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "benjamin.doron00@gmail.com" Subject: Re: [edk2-devel][edk2-platforms][PATCH v1 0/3] Thread-Topic: [edk2-devel][edk2-platforms][PATCH v1 0/3] Thread-Index: AQHYwhX/JX8FTXDC6ku3n58y7EMirK3XucBw Date: Fri, 9 Sep 2022 23:09:06 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 90572b22-fd7c-4c21-9e25-08da92b84b8d x-ms-traffictypediagnostic: BL1PR11MB5367:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jcf5Ivc1pn4KN0sr+UzI51RVoD6RIb9g3GH2baoeJu/MGbMtepV6xougQpMCqZl/sOQ7OYnvTtHrYhTMzPshVhHhnTXduRi1EAGySb2BSNEyVRj6JEGNz+6ZEp0LK0JTa44nPBSk2YFMeoA/V3i4sCcKh84lN9HrRGIVc4XECqIFVAOEor+s78fMI/FdPUxv5ZLV7X0G4nG8Iyo2GnkAqyz+fSeY2J6vuiirAExpICPY/eJZrrR1t6+nPuYvqGG6nacROCb0RXaouTTqNTBb30dmGnA24WJxzPEaxSC2hhYOTPYX9UjKORUwovM333vTsm5X5S8uiikYo12eIQglEt9a0rGpNdqUPKRVOApJ1yi1hSG4pq0s9hIotkPl8ibkI6sdneXdNr1FXay3UGiKeBQRb8Y+Ti8Jz1gkLmVSJGoxUMw5J3i0vuHJ/1QfYJhPQVpuzT8WlaJPo1aolPy7RoHSPAg+uzhMg90nWEPdV4y1pqH6sRvlG4qLTOhxoDULC8Gz1R7aBv8eIkrYatU6zLz9ckmUjnXQntPpSt5QGbWR/lUWOCr18SiJy3AvPxEcDOKxJ+BlG1VW5QBWI3vFfc4e2aYpjvfr46A3KZBdFwOGKUChrwoYj4Pa9vISolLSNWhWsZI5SlgOlsOJhh1KzDzaEHUF35w08PboC7NZ2c6MRRZMfsePXyO29g7TUH6B9e3pfqRYzKLCkFuKeItFWx3ua1Mdk1WFLkDF+1VaUHKAfoDyakMMhml+vgxBXqlBsRfoMaeo4o9oPrqdQcBpQKUEzLHucEoGsja7m6dLIZLzzxMIpz20XRGsRaNokY0YOMfNiL5MgvGiPN5G7depuw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(376002)(366004)(346002)(136003)(26005)(83380400001)(110136005)(53546011)(7696005)(478600001)(9686003)(19627235002)(316002)(186003)(33656002)(6506007)(76116006)(86362001)(66446008)(66946007)(66556008)(64756008)(8676002)(66476007)(55016003)(52536014)(2906002)(5660300002)(8936002)(71200400001)(38070700005)(82960400001)(966005)(41300700001)(122000001)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9jBspAECRxemegyHPWshU0xvsO8hbnMgftP0RxgFbrDASlywFGb6RAlXmC1a?= =?us-ascii?Q?ZDxuLnkWo8fresy3VNqhhD+u+Eu6afvsknQqUIdiLBdpUh0SsHsunbIEmP9H?= =?us-ascii?Q?jil4hIl4fdP4lKAdG3SI7J+NecHQDHWFe9HJOlO865QQOS+U+F9zgxfcEFgd?= =?us-ascii?Q?DURt4EyPJR4OhnnhZmSTcuzuyBUkNi27TrLrgNKeHKNjlwFkaN4cGMRAlhaU?= =?us-ascii?Q?3HmX+uCobLA0PZ2Rqx2WKcpSDusNnFEmJrtML508lgCkAoSWo88RqQfzdC+W?= =?us-ascii?Q?6tKbKnPWlG0bwJwiOFDnLEPv7RVxurDbOQTtbqJdl3rqdE4S1RPm92RoXiKI?= =?us-ascii?Q?Eq2MSczMPqZFexnvnfBMH9C32leVm0I0VAKhzy1FTDj1DLoDS56FYGTnQVnO?= =?us-ascii?Q?GJWUr94+lxe+txgr8U+6q6p18nKhPqG9weKS1YadUbP7lKcAmepA3cDJrg/3?= =?us-ascii?Q?e1yWIUgbM9mysWSqQR347cUO56S7SF79HU6BBlipIgCS+EvwxC7CZuRGMh4u?= =?us-ascii?Q?aAdk+eNEmzNZGcW7bNc2CNasD4azMRmW1YcltsRbwKI3k085ti1lVBVFTwmZ?= =?us-ascii?Q?8gzoYBQNi9wqBosgwNMllfg02t01HvKOVUvN+DJU6txsYIYGnSEqyxF3RGRq?= =?us-ascii?Q?OfoWQ4iwJE3FCNimUYu1jZ33RTPnwI2hQocxAVEwFpni8X37mraE2DwrSOxk?= =?us-ascii?Q?slm2q1zDthTfcYodWYB53KpWT89H2bI/77NZE95N4piSs70a4bs+Mo1sKmdd?= =?us-ascii?Q?saxA7w0+9dOC1+qB32jo/NSzhUMsXe9qPvfO7jI3ooqiBdm6oRr5DXdWcHVw?= =?us-ascii?Q?WKDg5ZCIPfacY9UUiyqLVu3IrWxmwjw3bNi5afTytqSmjhhlrE+7TcKonvHD?= =?us-ascii?Q?kGHo5ZInMJ7GjtKY1+tKuy7NH0FUHSlHWdYG6H88q+Ty/2grs+6lpl7Y8Dp8?= =?us-ascii?Q?KqrkhIU2TbKQVrtMevYi1u7eaZsFajmylBAtbxZ8JeRm02oBWD7MXXw5Cf96?= =?us-ascii?Q?RLSfzDxkvw4wKU2j8HR3XzajmBK5lBlNQgZhqtMRxmew12igyyMC+DVfivGY?= =?us-ascii?Q?Vi6gOb65Aj626aJFNPUj7ck2B9tJQjQvKIRsgvvpHeYC4Da7PfXrKeVEKUwX?= =?us-ascii?Q?ccQgzOA7LYrj7DKxKcunCS5ye9lxgP2Wz7isZ34gOOsp9K/ykv78st/XJh7f?= =?us-ascii?Q?21wJ+4OTiNABdpFHc+YKUUeOgeqH0vPJvoEuD5WF9Oreg4KwMO6TNhMqo8Nd?= =?us-ascii?Q?CVMNI94YyT4mAjEi9Tk/b/FJ3HlfVF6BkC0Yba6Hg7TeP+DBtrj81iOcD8ae?= =?us-ascii?Q?JytJW+uJGkFfopVWdGBwuvdUPdUgTFdVB5of/sc9ryyD0u5KXRgljs4l6kpy?= =?us-ascii?Q?14sh8MtqvaljT3oBRQeTrYv4Jf7LTXGaUKRb5XBpegrwMzFF5fly54wBVa1d?= =?us-ascii?Q?Z6shIlWYhfD2x0wUIKy0VYziLxQTq3bvD9889NxX9cwDrquXW+p9ax/8s/RE?= =?us-ascii?Q?hDh6mBY5wPZVpl8kCgd3oJd5B8dGCjf+LwoGhubq+gw5n7WmsB6dfdTMM//V?= =?us-ascii?Q?4Lo0eEYRwJrFSWF1JAk/AwPS+e1Bu4sTSKim+VotaVMz+R9UFcmB7mo1eQmx?= =?us-ascii?Q?OQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90572b22-fd7c-4c21-9e25-08da92b84b8d X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 23:09:06.5400 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OCpbg4cepAkYwOS5Tl11h0H3VQkjpWh5Kcfx48pmqFbyNhi5c2QmIHIepn984D1UqG4iSrxIrdGtAWDDrMGWJs4KNEFa7pjmd45F90L8qGQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5367 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Benjamin, I have provided some comments for you on patches 2 and 3. In addition, plea= se rebase this patch series with latest as there has been some changes sinc= e my initial patch series from June. Thanks, Nate > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Benjamin Doron > Sent: Tuesday, September 6, 2022 10:27 AM > To: devel@edk2.groups.io > Subject: [edk2-devel][edk2-platforms][PATCH v1 0/3] >=20 > Enable the HDMI debug port to be used for SEC phase debug. Commit my > build configuration, which successfully ouputs debug messages in all phas= es > and boot-flows: SEC, PEI, DXE and SMM, with handling for the special case > that is BootScriptExecutorDxe. >=20 > This patch series comprises the work product for my second planned GSoC > 2022 project. >=20 > These are enhancements to Nate's series here: > https://edk2.groups.io/g/devel/message/90591. >=20 > Benjamin Doron (3): >=20 > MinPlatformPkg,WhiskeylakeOpenBoardPkg/SecFspWrapperPlatformSecLib: > First BoardInitLib > [WIP] KabylakeOpenBoardPkg/I2cHdmiDebugSerialPortLib: Commit local > KabylakeOpenBoardPkg/AspireVn7Dash572G: Hook-up HDMI debug port to > build >=20 > .../AspireVn7Dash572G/OpenBoardPkg.dsc | 85 +++++++++++++---- > .../AspireVn7Dash572G/OpenBoardPkg.fdf | 11 +-- > .../AspireVn7Dash572G/OpenBoardPkgPcd.dsc | 54 ++++++++++- > ...ptExecutorDxeI2cHdmiDebugSerialPortLib.inf | 48 ++++++++++ > .../DxeI2cHdmiDebugSerialPortLib.inf | 8 +- > .../DxeSmmI2cHdmiDebugSerialPortLib.c | 2 - > .../Library/I2cHdmiDebugSerialPortLib/Gmbus.c | 39 ++++---- > .../I2cDebugPortProtocol.c | 2 - > .../I2cDebugPortTplDxe.c | 9 ++ > .../I2cDebugPortTplRuntimeDxe.c | 93 +++++++++++++++++++ > .../I2cHdmiDebugSerialPortLib.c | 3 - > .../I2cHdmiDebugSerialPortLib/IgfxI2c.c | 9 +- > .../PeiI2cHdmiDebugSerialPortLib.c | 1 - > .../PeiI2cHdmiDebugSerialPortLib.inf | 5 +- > .../RuntimeDxeI2cHdmiDebugSerialPortLib.inf | 51 ++++++++++ > .../SecI2cHdmiDebugSerialPortLib.c | 1 - > .../SecI2cHdmiDebugSerialPortLib.inf | 7 +- > .../SmmI2cHdmiDebugSerialPortLib.inf | 6 +- > .../PlatformInit.c | 8 +- > .../PlatformInit.c | 8 +- > 20 files changed, 364 insertions(+), 86 deletions(-) create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/Library/I2cHdmiDebugSerialPortLib/ > BootScriptExecutorDxeI2cHdmiDebugSerialPortLib.inf > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/Library/I2cHdmiDebugSerialPortLib/I > 2cDebugPortTplRuntimeDxe.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/Library/I2cHdmiDebugSerialPortLib/ > RuntimeDxeI2cHdmiDebugSerialPortLib.inf >=20 > -- > 2.37.2 >=20 >=20 >=20 >=20 >=20