From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.488.1662764964247313999 for ; Fri, 09 Sep 2022 16:09:25 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=nehg4IUa; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662764965; x=1694300965; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=rKCt4KMczAok2dA7mj+6vwVn0b5A9IuEMdYoz8yUFjw=; b=nehg4IUan0364FelzGdkuCOWFUR4fUPp2a8r6q+rCX6Vk5S9/9sFOkyF Y/EGzrUZjOVoBA9uKdlQzl6EJSQzxUdbsUl30Yy2JtKGZy5dWI9H+1giG lwap5WZy7t0K0KceXrhRb54M1+PNbHlGEapmbLsJKsZsSsnzJV44tC6kz ogSZcQ4nSuXTPEzKXWw000qgC7OBJ6IeQO6/JsgDHqvwb6yR3hky/CP9U fBf6kkgneSfk/oV+qnE6ftEvoZf/rqIvubdmf/HX3MvD5SYxx9r34hOim pTm1UFMMkYNNKuZ9ommjmExUV/Qys8603rgZJDajgmh6M1Bm2enqk1eaj A==; X-IronPort-AV: E=McAfee;i="6500,9779,10465"; a="298924056" X-IronPort-AV: E=Sophos;i="5.93,304,1654585200"; d="scan'208";a="298924056" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 16:09:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,304,1654585200"; d="scan'208";a="566529235" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 09 Sep 2022 16:09:25 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 16:09:24 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 16:09:24 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 9 Sep 2022 16:09:24 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 9 Sep 2022 16:09:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GRza3pumoYPxRM9/BblZvDO5jdTOuC6ef0i0bYQqzXCcKkm6NKFNlj91iQ73livgdtPSf3Y8DGia1vb2W0XSWUwDbn39FyVS2jVW9lPJ4P+Q7odulG0y84Gzkx+GjqvCCxjA5cbPuaH1Lrortky/qhyZEKPaiHRszTuKrWhsXAo7LQKk4RTkCqbWTM8UdotWXBnx59MsmSIUMZWaj/zQdaJJBmLOqYlf9PHGNlRelYkyg1j4mCUd8kLmM8BquzuPAxSgKdl+in9ylBaGV1QK3bEuootv5DZoYBBOS9vWKzN+D+iLqp9EBOlwgbyBQ/EqgjYMQFW21sRf7YCUpJ2RTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mrGSgkyWYARxXmHGKqoqFRARpqn3W1ZQDdpuzLFuKQg=; b=ASenWTPQe2z+OAnpCQ2/gmCAUor/riMk4+xem7BKBPO9JNvm9VotJkGtvo0ZqwoKi3h/M0JiaU8tBELAEa/mFKbSsaxfjgnJDHd1rSAmR6dRD1E3/xOqGX/6GBmS1N0E7QSnrYGxPEYX6hFPc7Ih1rGhPB8OzG37Ry0LGEDQaRpTyLhOJ3OPdfwT/H5/Ahmtodkj9oT1LrH1JxR/fr3RzkZJm1CS4S4/slGVSIAlbUl8YTmXg4J2SsQRPBI5wAKLUMhdncMW2awFgpd5I7sll2LNAlYCJ/cr5N6jY/mVMSrcx1BzIhPDElF8fFhcf8TdOFA3qLwxksE7BvK5P6Pwyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by BL1PR11MB5367.namprd11.prod.outlook.com (2603:10b6:208:318::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 23:09:20 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2c94:f950:2ac4:d92f]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2c94:f950:2ac4:d92f%8]) with mapi id 15.20.5588.014; Fri, 9 Sep 2022 23:09:20 +0000 From: "Nate DeSimone" To: Benjamin Doron , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" , "Oram, Isaac W" , "Sinha, Ankit" Subject: Re: [edk2-devel][edk2-platforms][PATCH v1 3/3] KabylakeOpenBoardPkg/AspireVn7Dash572G: Hook-up HDMI debug port to build Thread-Topic: [edk2-devel][edk2-platforms][PATCH v1 3/3] KabylakeOpenBoardPkg/AspireVn7Dash572G: Hook-up HDMI debug port to build Thread-Index: AQHYwhX6aiHK9fUwZUa7m9VVfMwNk63Xp9uQ Date: Fri, 9 Sep 2022 23:09:20 +0000 Message-ID: References: <3760ced8e358f92136308754ab57938f1dd3f9e7.1662484082.git.benjamin.doron00@gmail.com> In-Reply-To: <3760ced8e358f92136308754ab57938f1dd3f9e7.1662484082.git.benjamin.doron00@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b25a1c5d-edea-47b4-1a41-08da92b853d0 x-ms-traffictypediagnostic: BL1PR11MB5367:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: lB/wL3sVmKA4FPSL9BgBeAzcp5Vo1zQLMg/gTQ5cZO1CsEKOlH5pyp4Ba+vAYUZRLn76uGNQwISiA48X5/9KgpdIy0OKZT3hTj+Aj30ZcoaDYUMKG5aJHNzs8mKkWizRcSPWWn9rlFMvd65+5YNs0Qf9PTjZ5/5np9TlL3QMSIEyibnY7qi5ONgOjQWme/A7jLLOs85LedKTu8zLDphED3pCXBZ/it7DZEIJYHABBn8ykW94gtfNFI2kTaAPaNdJmfr4fATZkNLsrHShJjuS2Fuug4t9YcRfYgO0Qee3nE/lRiImszxujYjHTxwfug2/5ck4mxyXrAlsSSbna69s0EoSdNMRUxgswXG2VwB11O6ry3pBou6XJiXCNdqhAIhtlSiJQBrMGeXdqq4sgK6dEUSWOrpPEitcaMBFLpP8fMZHx81gIY64HJx5F7C0IkkEdxhf8lH6ekIQIg/JVYzBMzam+engSUDs31Ydq/hjwX/uFvGA2kDs84YUzNJpoGdA+i89sbjFlOEqbH/ULCmmuPXcXwBdQjuAnnDn+Gs6LLe/3VjCjvPa37DjzGvTszDqWWYn5i7rMQ6b4IyaLgvX6yOCx2W9RtwNhlpn555z0up14UPNqGrbikP7y90csqtqrEv5mRz57RQ5VGGzkCzsO8KuKUll4nAJbeCoaaRPMwSxxEFZVDFWCQLnNxGDVAQYqQ5H+6o2FyGLEZ/JhdqPF5R5o6f7ktgH30RzmbRZIpOUlR91oxTzqpfzF7hkBMJpY4tNtJSDO0ZZ+mHwbT+o3W/ZiqgyqOa5B2PD+LRL3lgsyON+JxCp7lcossSxmEpNixlrxOyvCHu45XMhHYFpOQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(376002)(366004)(346002)(136003)(54906003)(26005)(83380400001)(110136005)(53546011)(7696005)(107886003)(478600001)(9686003)(19627235002)(316002)(186003)(33656002)(6506007)(76116006)(86362001)(4326008)(66446008)(66946007)(66556008)(64756008)(8676002)(66476007)(55016003)(52536014)(2906002)(5660300002)(30864003)(8936002)(71200400001)(38070700005)(82960400001)(966005)(41300700001)(122000001)(38100700002)(52103002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DjxHxVz7a5Qy31AKYIWjB5ZtUkWMMm78XwJOxrnsA7MZzUg54kJHNIU5DPi/?= =?us-ascii?Q?fPX53y81BPpqKpfjGi/l541D7kbI94q8yc26I835MftUJq4R0sxefhUJHZYf?= =?us-ascii?Q?rPc7NaiQykPKvlQykiQxJ/p0OJRNvWLTB7xmln0o8UkiBVlsN9a37hb7eekB?= =?us-ascii?Q?tt6VPz4wGPqywPgkSZCorn3aFkbhMtZ2NCt6vALwlChn/JHhlcJBU/gOQ2E8?= =?us-ascii?Q?CxiN5eWyP0MBwrbWZFJkQKjVXF2O6gVV1MWBioKXsZvd80mo+87GUPghq0PI?= =?us-ascii?Q?qEeQ3hzY1q4TWm+njI150i8bbJGcIIzJTHKrmt/dlVgKAvZbMEYGMFlURMpx?= =?us-ascii?Q?lTjZVQXKVG2Nfrayn0ufbTHA2M5VBOGngGQzknRiGtPwZoAKYWpgu8YrhOeR?= =?us-ascii?Q?IRQd3Pby2anm3FLWmQUrrFPj7ZwwT85gOHFxqddjpc5cjmjhNoF70hQJDr20?= =?us-ascii?Q?T+WiKqt6elKhm2zYNpb1fe0CySmvZRc05bwyt+uIt3BPmB4MEMC3JkrikCl1?= =?us-ascii?Q?U40lpSiZghYfjENbjMPSpu5Bgcf8ClOh0DLQJRrAigwgMPRN42bFK8OFjzco?= =?us-ascii?Q?5bFftwCbKVWvbMnUDvPLt17i2dDHpxuc+c5t41tc2CPUaYLPFSWNSN8MvJ43?= =?us-ascii?Q?iFM6NGhXuOlqyTsjCGomgD4cWOfFiKHdamN7smZUMPVnks7X6ZeRTSiXCzjt?= =?us-ascii?Q?P3PgmquQox2KkyBkvk3+dvtQC5A9YigWioZlbD902PF5E80RARAQ+GDkW9Et?= =?us-ascii?Q?mCyR55R0aYFN/wiPowD89LmIN92ZEazYmwRy4oLwxuuLbRQQaiF0fKtOZquV?= =?us-ascii?Q?Dro9idQNtLtI8ZiQ+fLNqjcUnADuVdfqetecfyua97+4lvGc2FQXzQ2h+rsb?= =?us-ascii?Q?wMtLsFvUKcxsBDRyMZLvsPz6ura2sR8epdwj9pgsVk71I/aplASMSfxNuALS?= =?us-ascii?Q?SHnmMlFIbY/eQYHRqL6R9XzeBtJOyZJzFsoE5tiuCTlC0DzrB3Zy5HPqs+NW?= =?us-ascii?Q?EbFKocKKtCsr5pWu+0COUh3+MJjYy+VsieTMQSf+Z0iePSoPGyYM6upkE3jr?= =?us-ascii?Q?MxT+/Oo6l8Mokz1QFa1e7DOVxAi/dGjW02I6LKEvatPNeGiuuqxzlW7xinpn?= =?us-ascii?Q?xAMQoC2kjPOqNSF2tgCELBnYuJa/erFaJr2I0qjcGXaPjVLMxFY41TxuEe/j?= =?us-ascii?Q?0/me7RskPfkUvuyQxYNGlBqJTRWRRgGw1Y41wHpWBgkmlVARqiitaCVJrTc+?= =?us-ascii?Q?BKwf/zvFqV2xYFzHsp11zzbwKOMiCGNPaeCoyMzG3WkQG5C2dKQmV4EcPtBr?= =?us-ascii?Q?LBfuQVG1KZPOmUR5/rK/FeZr+T9mXs2vJrls8Z1TMoREV20OsYRxGLuLCSC0?= =?us-ascii?Q?qTytMT41LfTZQpzrbi4eEXaUrI63KT3ZjYjsKAEB+yS1TW2AlDa0R/drtMN6?= =?us-ascii?Q?k6+y/glGXROZiN2rpkPuSPwJ1SNUmbUgSSqMB5B8JgPUuRfIkomyJKgoeE9G?= =?us-ascii?Q?+KUkO60j1EzRiY/5sJJYNyXulC0whuNj1B5NoNMA574rznz6BPXr01ebB00h?= =?us-ascii?Q?kpuRuo1hlS0ywGVVQgND+8pz4MvGK8yTJVnsBdD9q/LeEUThIPIsqdea2mA8?= =?us-ascii?Q?jA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b25a1c5d-edea-47b4-1a41-08da92b853d0 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 23:09:20.2256 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: v7GmgQX93Drrkk8zZleHxqGw03KZ/ZQEnCy7MM7g0dMIa3bGWwEi15XcZ0vS0k4y4vM2fP2ZUS0Wu+he11yuqTT+FSXGMM/UBH0GePX7+0M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5367 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Benjamin, Please see comments below inline. Thanks, Nate > -----Original Message----- > From: Benjamin Doron > Sent: Tuesday, September 6, 2022 10:27 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Chaganty, Rangasai V > ; Oram, Isaac W > ; Desimone, Nathaniel L > ; Sinha, Ankit > Subject: [edk2-devel][edk2-platforms][PATCH v1 3/3] > KabylakeOpenBoardPkg/AspireVn7Dash572G: Hook-up HDMI debug port to > build >=20 > HDMI port can be used with I2cHdmiDebugSerialPortLib, for debugging in al= l > phases. >=20 > Cc: Chasel Chiu > Cc: Sai Chaganty > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Ankit Sinha > Signed-off-by: Benjamin Doron > --- > .../AspireVn7Dash572G/OpenBoardPkg.dsc | 85 +++++++++++++++---- > .../AspireVn7Dash572G/OpenBoardPkg.fdf | 11 ++- > .../AspireVn7Dash572G/OpenBoardPkgPcd.dsc | 54 ++++++++++-- > 3 files changed, 121 insertions(+), 29 deletions(-) >=20 > diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBo= ardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoar= dPkg.dsc > index 261f141056f5..c71b7169a38a 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.= dsc > +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.= dsc > @@ -25,9 +25,10 @@ > # > # Debug logging > # > + DEFINE USE_HDMI_DEBUG_PORT =3D FALSE This build flag is redundant with PcdI2cHdmiDebugPortEnable. Please remove = it. > DEFINE USE_PEI_SPI_LOGGING =3D FALSE > DEFINE USE_MEMORY_LOGGING =3D FALSE > - DEFINE RELEASE_LOGGING =3D ($(USE_PEI_SPI_LOGGING) || $(USE_MEMOR= Y_LOGGING)) > + DEFINE RELEASE_LOGGING =3D ($(USE_HDMI_DEBUG_PORT) || $(USE_PEI_S= PI_LOGGING) || $(USE_MEMORY_LOGGING)) This will turn into: !if gKabylakeOpenBoardPkgTokenSpaceGuid.PcdI2cHdmiDebugPortEnable =3D=3D TR= UE DEFINE RELEASE_LOGGING =3D TRUE !else DEFINE RELEASE_LOGGING =3D ($(USE_PEI_SPI_LOGGING) || $(USE_MEMORY_L= OGGING)) !endif > DEFINE TESTING =3D TRUE > =20 > PLATFORM_NAME =3D $(PLATFORM_PACKAGE) > @@ -205,6 +206,15 @@ > ####################################### > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > =20 > +!if $(USE_HDMI_DEBUG_PORT) =3D=3D TRUE All of these would be replaced with: !if gKabylakeOpenBoardPkgTokenSpaceGuid.PcdI2cHdmiDebugPortEnable =3D=3D TR= UE > + DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSerialPort.= inf > + > + ####################################### > + # Board-specific/Silicon Package > + ####################################### > + SerialPortLib|$(PLATFORM_BOARD_PACKAGE)/Library/I2cHdmiDebugSerialPort= Lib/SecI2cHdmiDebugSerialPortLib.inf > +!endif > + > ####################################### > # Platform Package > ####################################### > @@ -277,7 +287,7 @@ > # Edk2 Packages > ####################################### > # In-memory logging may require too many services for early core debug o= utput > -!if $(USE_MEMORY_LOGGING) =3D=3D TRUE > +!if ($(USE_MEMORY_LOGGING) =3D=3D TRUE || $(USE_HDMI_DEBUG_PORT) =3D=3D = TRUE) !if ($(USE_MEMORY_LOGGING) =3D=3D TRUE || gKabylakeOpenBoardPkgTokenSpaceGu= id.PcdI2cHdmiDebugPortEnable =3D=3D TRUE > DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDeb= ugLibReportStatusCode.inf > !endif > =20 > @@ -285,7 +295,7 @@ > ####################################### > # Edk2 Packages > ####################################### > -!if $(USE_MEMORY_LOGGING) =3D=3D TRUE > +!if ($(USE_MEMORY_LOGGING) =3D=3D TRUE || $(USE_HDMI_DEBUG_PORT) =3D=3D = TRUE) > DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDeb= ugLibReportStatusCode.inf > !endif > =20 > @@ -322,7 +332,7 @@ > ####################################### > # Edk2 Packages > ####################################### > -!if $(USE_MEMORY_LOGGING) =3D=3D TRUE > +!if ($(USE_MEMORY_LOGGING) =3D=3D TRUE || $(USE_HDMI_DEBUG_PORT) =3D=3D = TRUE) > DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDeb= ugLibReportStatusCode.inf > !endif > =20 > @@ -336,7 +346,7 @@ > # Edk2 Packages > ####################################### > # In-memory logging may require too many services for early core debug o= utput > -!if $(USE_MEMORY_LOGGING) =3D=3D TRUE > +!if ($(USE_MEMORY_LOGGING) =3D=3D TRUE || $(USE_HDMI_DEBUG_PORT) =3D=3D = TRUE) > DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDeb= ugLibReportStatusCode.inf > !endif > =20 > @@ -344,7 +354,7 @@ > ####################################### > # Edk2 Packages > ####################################### > -!if $(USE_MEMORY_LOGGING) =3D=3D TRUE > +!if ($(USE_MEMORY_LOGGING) =3D=3D TRUE || $(USE_HDMI_DEBUG_PORT) =3D=3D = TRUE) > DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDeb= ugLibReportStatusCode.inf > !endif > =20 > @@ -363,7 +373,21 @@ > TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/S= mmTestPointCheckLib.inf > !endif > =20 > -# TODO: DebugLib override for UEFI_DRIVER and UEFI_APPLICATION? > +[LibraryClasses.common.UEFI_DRIVER] > + ####################################### > + # Edk2 Packages > + ####################################### > +!if ($(USE_MEMORY_LOGGING) =3D=3D TRUE || $(USE_HDMI_DEBUG_PORT) =3D=3D = TRUE) > + DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDeb= ugLibReportStatusCode.inf > +!endif > + > +[LibraryClasses.common.UEFI_APPLICATION] > + ####################################### > + # Edk2 Packages > + ####################################### > +!if ($(USE_MEMORY_LOGGING) =3D=3D TRUE || $(USE_HDMI_DEBUG_PORT) =3D=3D = TRUE) > + DebugLib|MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDeb= ugLibReportStatusCode.inf > +!endif > =20 > # TODO: Add and improve feature support > ####################################### > @@ -389,6 +413,9 @@ > !if $(USE_MEMORY_LOGGING) =3D=3D TRUE > SerialPortLib|MdeModulePkg/Library/PeiDxeSerialPortLibMem/PeiSeria= lPortLibMem.inf > !endif > +!endif > +!if $(USE_HDMI_DEBUG_PORT) =3D=3D TRUE > + SerialPortLib|$(PLATFORM_BOARD_PACKAGE)/Library/I2cHdmiDebugSerial= PortLib/PeiI2cHdmiDebugSerialPortLib.inf > !endif > > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|$(RELEASE_LO= GGING) > @@ -517,14 +544,24 @@ > ####################################### > # Edk2 Packages > ####################################### > + MdeModulePkg/Core/Dxe/DxeMain.inf { > + > + # Can debug CpuExceptionHandlerLib > +!if $(USE_HDMI_DEBUG_PORT) =3D=3D TRUE > + SerialPortLib|$(PLATFORM_BOARD_PACKAGE)/Library/I2cHdmiDebugSerial= PortLib/DxeI2cHdmiDebugSerialPortLib.inf > +!endif > + } I recommend doing this LibraryClass override more generally using a [Librar= yClasses.common.DXE_CORE] instead of overriding this specific instance of D= xeMain. > MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHandlerR= untimeDxe.inf { > > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > !if $(USE_MEMORY_LOGGING) =3D=3D TRUE > SerialPortLib|MdeModulePkg/Library/PeiDxeSerialPortLibMem/DxeSeria= lPortLibMem.inf > +!endif > +!if $(USE_HDMI_DEBUG_PORT) =3D=3D TRUE > + SerialPortLib|$(PLATFORM_BOARD_PACKAGE)/Library/I2cHdmiDebugSerial= PortLib/RuntimeDxeI2cHdmiDebugSerialPortLib.inf > !endif > > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|$(USE_MEMORY= _LOGGING) > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|($(USE_MEMOR= Y_LOGGING) || $(USE_HDMI_DEBUG_PORT)) > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|512 > } > # TODO: Still requires a little more thought > @@ -533,9 +570,12 @@ > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > !if $(USE_MEMORY_LOGGING) =3D=3D TRUE > SerialPortLib|MdeModulePkg/Library/PeiDxeSerialPortLibMem/SmmSeria= lPortLibMem.inf > +!endif > +!if $(USE_HDMI_DEBUG_PORT) =3D=3D TRUE > + SerialPortLib|$(PLATFORM_BOARD_PACKAGE)/Library/I2cHdmiDebugSerial= PortLib/SmmI2cHdmiDebugSerialPortLib.inf > !endif > > - gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|$(USE_MEMORY= _LOGGING) > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|($(USE_MEMOR= Y_LOGGING) || $(USE_HDMI_DEBUG_PORT)) > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeMemorySize|512 > } > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf > @@ -548,12 +588,24 @@ > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf { > > NULL|BoardModulePkg/Library/BdsPs2KbcLib/BdsPs2KbcLib.inf > +!if gKabylakeOpenBoardPkgTokenSpaceGuid.PcdI2cHdmiDebugPortSerialTermina= lEnable =3D=3D TRUE > + NULL|BoardModulePkg/Library/BdsSerialPortTerminalLib/BdsSerialPort= TerminalLib.inf > +!endif In the most recent version of my patch series, this has been replaced with = the more generic: !if gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable =3D=3D TRUE NULL|MinPlatformPkg/Library/SerialPortTerminalLib/SerialPortTerminalL= ib.inf !endif Please do the same here. > } > +!if gKabylakeOpenBoardPkgTokenSpaceGuid.PcdI2cHdmiDebugPortSerialTermina= lEnable =3D=3D TRUE > + MdeModulePkg/Universal/SerialDxe/SerialDxe.inf { > + > + DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > + SerialPortLib|$(PLATFORM_BOARD_PACKAGE)/Library/I2cHdmiDebugSerial= PortLib/DxeI2cHdmiDebugSerialPortLib.inf > + } > + MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf > +!endif > + > UefiCpuPkg/CpuDxe/CpuDxe.inf { > > -!if $(USE_MEMORY_LOGGING) =3D=3D TRUE > -# TODO/TEST > -# SerialPortLib|MdeModulePkg/Library/PeiDxeSerialPortLibMem/DxeSeri= alPortLibMem.inf > + # Can debug CpuExceptionHandlerLib > +!if $(USE_HDMI_DEBUG_PORT) =3D=3D TRUE > + SerialPortLib|$(PLATFORM_BOARD_PACKAGE)/Library/I2cHdmiDebugSerial= PortLib/DxeI2cHdmiDebugSerialPortLib.inf > !endif > } > =20 > @@ -589,12 +641,9 @@ > > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80080046 > > - !if $(TARGET) =3D=3D DEBUG > - DebugLib|MdePkg/Library/BaseDebugLibSerialPort/BaseDebugLibSeria= lPort.inf > - !endif > -!if $(USE_MEMORY_LOGGING) =3D=3D TRUE > -# TODO/TEST > -# SerialPortLib|MdeModulePkg/Library/PeiDxeSerialPortLibMem/SmmSeri= alPortLibMem.inf > + # Can debug CpuExceptionHandlerLib > +!if $(USE_HDMI_DEBUG_PORT) =3D=3D TRUE > + SerialPortLib|$(PLATFORM_BOARD_PACKAGE)/Library/I2cHdmiDebugSeri= alPortLib/SmmI2cHdmiDebugSerialPortLib.inf > !endif > } > !endif > diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBo= ardPkg.fdf b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoar= dPkg.fdf > index 9eb37e7d230e..864d5561d7d8 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.= fdf > +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.= fdf > @@ -353,6 +353,10 @@ INF MdeModulePkg/Universal/Console/GraphicsOutputDx= e/GraphicsOutputDxe.inf > INF BoardModulePkg/LegacySioDxe/LegacySioDxe.inf > INF MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > INF MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf > +!if gKabylakeOpenBoardPkgTokenSpaceGuid.PcdI2cHdmiDebugPortSerialTermina= lEnable =3D=3D TRUE > + INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf > + INF MdeModulePkg/Universal/Console/TerminalDxe/TerminalDxe.inf > +!endif With the new PcdSerialTerminalEnable this should not be necessary anymore. = MinPlatformPkg handles this with the included FDF files now. > INF BoardModulePkg/BoardBdsHookDxe/BoardBdsHookDxe.inf > =20 > INF ShellPkg/Application/Shell/Shell.inf > @@ -584,12 +588,7 @@ INF IntelSiliconPkg/Feature/VTd/IntelVTdDxe/IntelVT= dDxe.inf > =20 > !if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE > =20 > -INF $(PLATFORM_SI_PACKAGE)/Hsti/Dxe/HstiSiliconDxe.inf > - > -!endif > - > -!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE > - > +INF $(PLATFORM_SI_PACKAGE)/Hsti/Dxe/HstiSiliconDxe.inf > INF $(PLATFORM_PACKAGE)/Hsti/HstiIbvPlatformDxe/HstiIbvPlatformDxe.inf > =20 > !if gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable =3D=3D TRUE > diff --git a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBo= ardPkgPcd.dsc b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenB= oardPkgPcd.dsc > index a9d531a269a5..a4ea524e26bc 100644 > --- a/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgP= cd.dsc > +++ b/Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkgP= cd.dsc > @@ -228,7 +228,7 @@ > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x07 > !else > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0x0 > - gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x3 > + gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x03 > !endif # $(RELEASE_LOGGING) > !else > # FIXME: More than just compiler optimisation is hooked to DEBUG build= s. > @@ -264,6 +264,8 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > !if $(TARGET) =3D=3D RELEASE > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > + # Determine RTS/CTS requirement There is no flow control in the HDMI DDC case since the I2C bus does not im= plement any flow control mechanisms. Therefore I think we can consider this= comment resolved and always set the PCD to FALSE. > + gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl|FALSE > !else > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseHardwareFlowControl|FALSE > @@ -407,7 +409,37 @@ > # 3: DDC channel C > # 4: DDC channel D > # @Prompt DDC I2C channel to claim as the HDMI debug port > - gKabylakeOpenBoardPkgTokenSpaceGuid.PcdI2cHdmiDebugPortDdcI2cChannel|0= x00 #@todo - Set to correct value for VN7-572G > + gKabylakeOpenBoardPkgTokenSpaceGuid.PcdI2cHdmiDebugPortDdcI2cChannel|0= x02 > + > + ## Enable usage the HDMI DDC channel as a debug port - Causes the BIOS= debug log > + # to be written to the HDMI DDC channel. > + # The value is defined as below. > + # FALSE: Do NOT use the HDMI DDC channel as a debug port > + # TRUE: Use the HDMI DDC channel as a debug port > + # @Prompt Enable usage the HDMI DDC channel as a debug port > + gKabylakeOpenBoardPkgTokenSpaceGuid.PcdI2cHdmiDebugPortEnable|$(USE_HD= MI_DEBUG_PORT) > + > + ## Enable usage the HDMI DDC channel as a serial terminal - Enables us= age of the > + # HDMI DDC channel to display BIOS Setup, UEFI Shell, etc. using a te= rminal > + # emulator. Useful for cases where video is not operating correctly. > + # > + # The value is defined as below. > + # FALSE: Do NOT use the HDMI DDC channel as a debug port > + # TRUE: Use the HDMI DDC channel as a debug port > + # @Prompt Enable usage the HDMI DDC channel as a debug port > + gKabylakeOpenBoardPkgTokenSpaceGuid.PcdI2cHdmiDebugPortSerialTerminalE= nable|FALSE When you rebase up to latest, don't forget to include this from my most rec= ent patch series: gMinPlatformPkgTokenSpaceGuid.PcdSerialTerminalEnable|gKabylakeOpenBoardPkg= TokenSpaceGuid.PcdI2cHdmiDebugPortSerialTerminalEnable > + > + ## Indicates the type of terminal to use. > + # If PcdI2cHdmiDebugPortSerialTerminalEnable is TRUE, this PCD will b= e used > + # to determine which terminal protocol to use. > + # 0 - PCANSI > + # 1 - VT100 > + # 2 - VT100+ > + # 3 - UTF8 > + # 4 - TTYTERM > + # @Prompt Default Terminal Type. > + # @ValidRange 0x80000001 | 0 - 4 > + gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType|3 > =20 > [PcdsFixedAtBuild.IA32] > ###################################### > @@ -433,7 +465,16 @@ > ###################################### > # Edk2 Configuration > ###################################### > - gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000046 # 0x80480= 0C7/0x806A15CF give useful information, but is very noisy > + # TODO: Dynamic in HII I have converted this TODO into a proper Bugzilla and assigned it to you: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4056 Please delete this comment. > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80000046 > +!if FALSE > + # Filtered DEBUG_POOL, DEBUG_PAGE, DEBUG_GCD and DEBUG_CACHE > + # - Unused: DEBUG_VARIABLE, DEBUG_BM and DEBUG_LOADFILE > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x804950CF > +!endif > +!if ($(TESTING) =3D=3D TRUE && $(USE_HDMI_DEBUG_PORT) =3D=3D FALSE) > + gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x80400046 > +!endif > =20 > ###################################### > # Silicon Configuration > @@ -446,9 +487,9 @@ > # Platform Configuration > ###################################### > !if $(TARGET) =3D=3D DEBUG > - gMinPlatformPkgTokenSpaceGuid.PcdSecSerialPortDebugEnable|1 > + gMinPlatformPkgTokenSpaceGuid.PcdSecSerialPortDebugEnable|TRUE > !else > - gMinPlatformPkgTokenSpaceGuid.PcdSecSerialPortDebugEnable|0 > + gMinPlatformPkgTokenSpaceGuid.PcdSecSerialPortDebugEnable|FALSE > !endif > =20 > [PcdsDynamicDefault] > @@ -528,6 +569,9 @@ > !else > gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|L"Timeout"|gEfiGlobalV= ariableGuid|0x0|5 # Variable: L"Timeout" > !endif > +!if $(USE_HDMI_DEBUG_PORT) =3D=3D TRUE > + gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|L"Timeout"|gEfiGlobalV= ariableGuid|0x0|15 # Variable: L"Timeout" > +!endif > !if gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable =3D=3D TRUE > gEfiSecurityPkgTokenSpaceGuid.PcdTcgPhysicalPresenceInterfaceVer|L"TCG= 2_VERSION"|gTcg2ConfigFormSetGuid|0x0|"1.3"|NV,BS > gEfiSecurityPkgTokenSpaceGuid.PcdTpm2AcpiTableRev|L"TCG2_VERSION"|gTcg= 2ConfigFormSetGuid|0x8|3|NV,BS > --=20 > 2.37.2