From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web08.2744.1658351398931948703 for ; Wed, 20 Jul 2022 14:10:00 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=f87NQgz2; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658351398; x=1689887398; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uEK3mnLtV36f4J+XUYir5Ssl3zrUg28xDXZ068zg7w0=; b=f87NQgz2RDsB1WDSRdUfCYt2a6yME8z6IB6a6EBaVX76c5pFl/6WqdSQ hK7KyeLd27hi5L/hfWR7hAREuVS5QY3yOvshxTVryFG1tuJ4+NFhZT7Sv U7w8eScHCJb2Nw+tsi6Ldj3XXMg7hIKE+bguHcBKbHvU1zfVm4gwJSsIR 2fBexUp5l7bgv+7AfyDDM77AVm7CvqboultAC4Zc3dwFYc+1ydfiikt8O uAUwEw3Mxubc6IibNLaaMFOm5EllxoUj+4RBtfcuZsOSjk95xj+J0cAEu 9PUMfisk50c/NCUklzBwk+a+a7J9P4+DxgdGDncXefQOe710uDVr914J7 w==; X-IronPort-AV: E=McAfee;i="6400,9594,10414"; a="273728224" X-IronPort-AV: E=Sophos;i="5.92,287,1650956400"; d="scan'208";a="273728224" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2022 14:09:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,287,1650956400"; d="scan'208";a="774645790" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga005.jf.intel.com with ESMTP; 20 Jul 2022 14:09:58 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 20 Jul 2022 14:09:57 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 20 Jul 2022 14:09:57 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 20 Jul 2022 14:09:57 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 20 Jul 2022 14:09:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M8w4WndyP9YNTQZkVGmgE2WE4KUHf+ddEvpwqv+11Pq51fl/9XUsRAIEQgHi9zvJ9k6ygHGKNnHhTZN/6//3OfEhyMsnbOKycfiLdXG7/dhgGe4SXmP+CTPU+evZeTAstiZeSbmcao9uEIl1y49hYinVWJxtXemyCo7sXnKbFF4nVfctT1MAsIXMvuoNK7Ib65tmLk78tK0DwIuXOGp5XjFj1WWLkNADMRP7Nhfj5hiJJObfm3dzolyiI58Y+uBQ9sabRPE7is/vEbknSksJGKcEFLuZQpKfyrRrgcw00nCGDPvxcs+oI8ckVlkE79sFvP+Vp8WUcGAE+8geQyttdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m0+rwg3aTXGrh0T5kPnT5hAkFZRYVOGNTPvu+56y6ns=; b=hB5Qm8jP4TjjZQZ3fOuxthfmmXfU8PoY8Ol7QmXz+9aqUwTBoydwllg8gWitmxh0Je4I3M0rvxtglUizyteywh2AFBxh/ulqW2aP1Rzf35x5UIdD2D33blrZ42LATH2nRTLvBLsZ2J/Sg5Q08aR30GgYzZTZ16i28lZn+5tGiMTSxRzPLvINFhJ/wuiW4pNBelbb9I0lhpgkyJmrL7Jrd5jTdH6AYANHqkIVfnch3hKkPFkr4Wce0vreL9tDckKYHi5fQ/+/P4srFVpbDiC+uMn0RjenXS97bQx5+obTF1DlvCfvsDgESGyZUmWobkZ2Xpcpr6o1LSID8xnq0/EsVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MWHPR11MB0061.namprd11.prod.outlook.com (2603:10b6:301:65::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Wed, 20 Jul 2022 21:09:54 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::b4bc:a6b4:5832:5ae0]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::b4bc:a6b4:5832:5ae0%3]) with mapi id 15.20.5458.018; Wed, 20 Jul 2022 21:09:54 +0000 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Zeng, Star" Subject: Re: [PATCH v2] IntelFsp2Pkg: Add FSPI_ARCH_UPD. Thread-Topic: [PATCH v2] IntelFsp2Pkg: Add FSPI_ARCH_UPD. Thread-Index: AQHYnHx3DcV6JeyjaEWg1qdyEn/F962HwRIA Date: Wed, 20 Jul 2022 21:09:54 +0000 Message-ID: References: <20220720210524.3855-1-chasel.chiu@intel.com> In-Reply-To: <20220720210524.3855-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4bd4b534-2f85-4563-4e3a-08da6a943175 x-ms-traffictypediagnostic: MWHPR11MB0061:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nb0iqdNXlp2SkYqB2Z+6s4lP/JVpFZvk7CXjloX/628mTsZ4B0GRJGMFnPuN9sebAcbIxnUnvvA30Ww0n5I9n53CjgKLpDZUmCI4u6mzi2Kc/rVQ7qIeQGOCdYgVnFRLYnoFRmTRQMlFWx68wnD4VVAuj92eVIo8culFQb0xe6R5BXpQbqU218cnHiki4XL0gXC87/lV9I7aoTaYtp3Vz50NEqElD7Fp98zDD3Dq+6bsWnLFMczx/IC+4WWcIxfMqI6t36WRCX4MQldeW//xBNqOfV8Mze33Cq9t8JfgytzHUm82WDRUxmmjwRvfKpWZltpyItcIUO9us0pPMr2I6p1q+Z3L3IkU0DdCO2bamz67oq7YPMEWwJ4bnh1mLSsSE2WMk5KvXwgtfPq3s2A1J4/SAZsPJfnbY0NwK41R+8xyanaSy488lVIaFZ5LDkCTWXXofndQXi1EwzTDMuzw4ivT5Ps7DgySasRZqw6n1qehMJ6nQ1bUocf0i7NGF6K8cwKHi4pTgC1UNdusS8VysDn3IDlVxHr6Li2FFHJcm7dCatk6mFoLZdsfo46YK3fr7IgBuGt3KYQg5AI66NcIhON3Mr5F1oqRZaj4x6AmwF7HaXyvnpERu65+6l9N2Lj6tue1Ih9WzzedK+mkL2FO7yWRGitNzJ5OmOJ2fDBDSAP1vLduCYPapltEc6zBOMLnh812vit7d8BIRUZmucoyRtT6QL7wW2STqFPXMDxcbBQJwamjAxe4pq5ufdnpl5qk6KrirPMwLiP7ZP3mcJ4b3YlgHqXyP1kGuUmifiHIUazOdi3/YN8K6Q16O4PNYdo3V0Gt49uwoqeDx7sYZr4KPg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(136003)(346002)(366004)(396003)(53546011)(52536014)(316002)(41300700001)(26005)(966005)(478600001)(6506007)(8676002)(86362001)(107886003)(71200400001)(9686003)(7696005)(5660300002)(19627235002)(82960400001)(110136005)(66556008)(55016003)(8936002)(122000001)(83380400001)(38100700002)(38070700005)(33656002)(2906002)(186003)(4326008)(64756008)(66946007)(66446008)(66476007)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LidnjDnGPtx/yY1ccMwPRrCcpgSwx0OpfRRvJvQdwlbaz/IKnpWeEmIb69ZS?= =?us-ascii?Q?26Gy0lOnTsufnnAjaBhzRpb8+/wFGbK2WHqPeOMroU6Cuzbc5dDjqbOm1jf9?= =?us-ascii?Q?CaHbEoFEuNSJPueD9ICyM8ZF9klk6IsqobMkO82HE0x62LrvVgWRs0imeUwX?= =?us-ascii?Q?qr/bM7dbd4qbQkjOZ70hhVwVY0nnkr2bUEppP502s/Tl0HnMEHbawNbCmRB9?= =?us-ascii?Q?5Kq7iTKJtbWk65tQaWTdM1HAEGJElwI/B1wemzxGqtIOcKtMgcEP4NPbE810?= =?us-ascii?Q?I+6Fk7mk5UA41UBsacKDR24gjIulsHHVvXMf4XbtaLdbkgPn4Eoc987lxX6h?= =?us-ascii?Q?7h+edlb7Sf+hWjTFTWCsHIRMfbitoNPtYULnOwDn9p7YO4u3zOCc4Z36wy2i?= =?us-ascii?Q?pmQxo1DkQOyOpC5mS3R+0JK0Vt+0GfgbJLGvelaHahBXhPhXR08AVNrAxdo4?= =?us-ascii?Q?fVdoDwH5ApiydBK5tHZ7bV01d9oQwKpyLI+2EYXJwGzi5BCOFqV/869NhFY0?= =?us-ascii?Q?S4brZoPeI3w7kp+84Ak2xRictDYGZeFg8H8c2nZFLws2enPg2UX7VOlOig4n?= =?us-ascii?Q?DntCPm6Lprxf7boH+9wbBEH4FA39KSdnLadQODS81vdd8/iS4RJYwEcqh8hR?= =?us-ascii?Q?+SVuO5z7fgfdX3Tr85keAXjUwfh+9IqUDUsbQGr6y+Osr02j+dkycIFGfNt8?= =?us-ascii?Q?QLpJJnkf/N6jTfQMGZsfHvQ7C9YOpP+Ea3RHHjHTNJN+Ob3sdnDqqDQh5gak?= =?us-ascii?Q?eE39zTE8d1K8ROuXESRewq8jQw5EwlE0l9weh9ZnITnGHC1I2tDDndyikx+R?= =?us-ascii?Q?r+xLdlU05A1XfgzWgnvqFKXNFCzJSGvgG9OxJcuLcfKcYk4rOjUEXZ6rArb/?= =?us-ascii?Q?kPSxKfo4fpn4zJQpI3twUkyUQJVVyrHxqVTJIOPc8g2noGgTfO7VNu/YiVAy?= =?us-ascii?Q?YnfpeJKz3hJ+6Kf9FZi7Aex1O5cBJLO4UqNEtRmk1XDtq+6mHpwt9bMNpP76?= =?us-ascii?Q?EO8zxEO7x1KH1hniZEnyuqwkpKxoMwPLIvGojVu+QJjgWtw9zm0Vedb6p63l?= =?us-ascii?Q?73f1/wF7TV21DwlgnihNG/qAGCnm2TWn9Cp3m2KOCnR9vhZTLVhWRSuQd3VG?= =?us-ascii?Q?0ADhQ1uvEVC0zx8eNaOmkYhFUrHz0uOySANVSdQJ7ZbxUTF0279CJ4zByLyW?= =?us-ascii?Q?vxNvIOCEgF5EPOMHyy8PMLS7baISnoyC6a51AbmryKpeLr8jmXk3fwfO4xXj?= =?us-ascii?Q?LJmMpXXh/men/PHA7L+GhALbWDGj7eLYBUQUl1Reewhz3WrFvN0seAc8Ar4E?= =?us-ascii?Q?zUqrfkRpFyn9yftiNvg0N81kNKaaEM3tZOyqZYWd/vsA6Da6wcBYIustqvkf?= =?us-ascii?Q?0znbSYhObYUYEprjiXs5AvCBE1u8VVaW1CS++ubeONsYtO2v3duwXNvX2aes?= =?us-ascii?Q?GxYW20N4DwuZxdnmKtZutms0O6FqLq2ZXf5fnSeVwgeGDJq0E2L8XJkICcuM?= =?us-ascii?Q?Rbv+0je72YyCf9NRhDg7YLnY+VyM6eKGZ7TMk19WBcqKrzLvrOVFMSqIeGHu?= =?us-ascii?Q?ObvfdKGAA3pXOeIiME1JOo2w9eN0bqPTF7eXWauD1X1b/6f2PpkYY0Ci9BvN?= =?us-ascii?Q?zg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4bd4b534-2f85-4563-4e3a-08da6a943175 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 21:09:54.3509 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jfx9YP6GIqo91W8vvhdCcj9bXut75vD2lP/osl8La2ebw9yrBMJbqdHwpS1+O+8zucD4T3FjU9T/VVnQ8TB6GeHWzPFiZcAhqC0bIBYb+38= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0061 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Chiu, Chasel > Sent: Wednesday, July 20, 2022 2:05 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH v2] IntelFsp2Pkg: Add FSPI_ARCH_UPD. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3993 >=20 > Adding the missing FSPI_ARCH_UPD, FSP_GLOBAL_DATA_VERSION > bumpping up, and some comments for clarification. >=20 > Cc: Nate DeSimone > Cc: Star Zeng > Signed-off-by: Chasel Chiu > --- > IntelFsp2Pkg/Include/FspEas/FspApi.h | 71 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > ++++++------- > IntelFsp2Pkg/Include/FspGlobalData.h | 2 +- > 2 files changed, 65 insertions(+), 8 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/Include/FspEas/FspApi.h > b/IntelFsp2Pkg/Include/FspEas/FspApi.h > index bf46f13f73..3f368574e8 100644 > --- a/IntelFsp2Pkg/Include/FspEas/FspApi.h > +++ b/IntelFsp2Pkg/Include/FspEas/FspApi.h > @@ -1,6 +1,6 @@ > /** @file Intel FSP API definition from Intel Firmware Support Package > External- Architecture Specification v2.0 - v2.2+ Architecture Specific= ation > v2.0 and above. Copyright (c) 2014 - 2022, Intel Corporation. All righ= ts > reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent@@ -100,13 > +100,14 @@ typedef struct { > /// "XXXXXX_T" for FSP-T /// "XXXXXX_M" for FSP-M /// "XXXXXX_S" f= or > FSP-S+ /// "XXXXXX_I" for FSP-I /// Where XXXXXX is an unique signatur= e > /// UINT64 Signature; /// /// Revision of the Data structure.- = /// For > FSP spec 2.0/2.1 value is 1.- /// For FSP spec 2.2 value is 2.+ /// = For FSP > spec 2.0/2.1, this value is 1 and only FSPM_UPD having ARCH_UPD.+ /// = For > FSP spec 2.2 and above, this value is 2 and ARCH_UPD present in all UPD > structures. /// UINT8 Revision; UINT8 Reserved[23];@@ -134,= 7 +135,7 > @@ typedef struct { > } FSPT_ARCH_UPD; ///-/// FSPT_ARCH2_UPD Configuration.+/// > FSPT_ARCH2_UPD Configuration for FSP 2.4 and above. /// typedef struct { > ///@@ -196,7 +197,7 @@ typedef struct { > } FSPM_ARCH_UPD; ///-/// FSPM_ARCH2_UPD Configuration.+/// > FSPM_ARCH2_UPD Configuration for FSP 2.4 and above. /// typedef struct { > ///@@ -209,6 +210,13 @@ typedef struct { > /// UINT32 Length; ///+ /// Pointer to the non-v= olatile storage > (NVS) data buffer.+ /// If it is NULL it indicates the NVS data is not a= vailable.+ > /// This value is deprecated starting with v2.4 of the FSP specification,= + /// > and will be removed in an upcoming version of the FSP specification.+ //= /+ > EFI_PHYSICAL_ADDRESS NvsBufferPtr;+ /// /// Pointer to the temporar= y > stack base address to be /// consumed inside FspMemoryInit() API. ///= @@ > -232,7 +240,7 @@ typedef struct { > /// This value is only valid if Revision is >=3D 2. /// EFI_PHYSIC= AL_ADDRESS > FspEventHandler;- UINT8 Reserved1[24];+ UINT8 > Reserved1[16]; } FSPM_ARCH2_UPD; ///@@ -265,7 +273,7 @@ typedef > struct { > } FSPS_ARCH_UPD; ///-/// FSPS_ARCH2_UPD Configuration.+/// > FSPS_ARCH2_UPD Configuration for FSP 2.4 and above. /// typedef struct { > ///@@ -285,6 +293,40 @@ typedef struct { > UINT8 Reserved1[16]; } FSPS_ARCH2_UPD; +///+/// > FSPI_ARCH_UPD Configuration.+///+typedef struct {+ ///+ /// Revision of > the structure is 1 for this version of the specification.+ ///+ UINT8 > Revision;+ UINT8 Reserved[3];+ ///+ /// Length of th= e structure in > bytes. The current value for this field is 32.+ ///+ UINT32 = Length;+ > ///+ /// The physical memory-mapped base address of the bootloader SMM > firmware volume (FV).+ ///+ EFI_PHYSICAL_ADDRESS > BootloaderSmmFvBaseAddress;+ ///+ /// The length in bytes of the > bootloader SMM firmware volume (FV).+ ///+ UINT64 > BootloaderSmmFvLength;+ ///+ /// The physical memory-mapped base > address of the bootloader SMM FV context data.+ /// This data is provide= d > to bootloader SMM drivers through a HOB by the FSP MM Foundation.+ ///+ > EFI_PHYSICAL_ADDRESS BootloaderSmmFvContextData;+ ///+ /// The > length in bytes of the bootloader SMM FV context data.+ /// This data is > provided to bootloader SMM drivers through a HOB by the FSP MM > Foundation.+ ///+ UINT16 BootloaderSmmFvContextDataLen= gth;+ > UINT8 Reserved1[24];+} FSPI_ARCH_UPD;+ /// /// > FSPT_UPD_COMMON Configuration. ///@@ -393,6 +435,21 @@ typedef > struct { > FSPS_ARCH2_UPD FspsArchUpd; } FSPS_UPD_COMMON_FSP24; +///+/// > FSPI_UPD_COMMON Configuration.+///+typedef struct {+ ///+ /// > FSP_UPD_HEADER Configuration.+ ///+ FSP_UPD_HEADER > FspUpdHeader;++ ///+ /// FSPI_ARCH_UPD Configuration.+ ///+ > FSPI_ARCH_UPD FspiArchUpd;+} FSPI_UPD_COMMON;+ /// /// > Enumeration of FSP_INIT_PHASE for NOTIFY_PHASE. ///diff --git > a/IntelFsp2Pkg/Include/FspGlobalData.h > b/IntelFsp2Pkg/Include/FspGlobalData.h > index 697b20ed4c..cf94f7b6a5 100644 > --- a/IntelFsp2Pkg/Include/FspGlobalData.h > +++ b/IntelFsp2Pkg/Include/FspGlobalData.h > @@ -12,7 +12,7 @@ > #define FSP_IN_API_MODE 0 #define FSP_IN_DISPATCH_MODE 1- > #define FSP_GLOBAL_DATA_VERSION 1+#define > FSP_GLOBAL_DATA_VERSION 0x2 #pragma pack(1) -- > 2.35.0.windows.1