public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Replace Python Interpreter Name
Date: Wed, 29 Nov 2023 00:03:12 +0000	[thread overview]
Message-ID: <MW4PR11MB582132EF3F7AF37C40EF2EBDCD83A@MW4PR11MB5821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1798A43863B4D009.26894@groups.io>

Pushed as 15e9fae

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate DeSimone
Sent: Friday, November 17, 2023 10:36 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>
Subject: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Replace Python Interpreter Name

Removes the assumption that the python interpreter will have the name python.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 .../PurleyOpenBoardPkg/BoardMtOlympus/build_board.py   |  8 ++++----
 .../PurleyOpenBoardPkg/BoardTiogaPass/build_board.py   | 10 +++++-----
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/build_board.py b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/build_board.py
index 2ba615d3e4..ffe762e289 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/build_board.py
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/build_board.py
@@ -1,7 +1,7 @@
 # @ build_board.py
 # This adds additional functions to the build_bios.py  # -# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2023, Intel Corporation. All rights 
+reserved.<BR>
 # SPDX-License-Identifier: BSD-2-Clause-Patent  #
 
@@ -48,7 +48,7 @@ def pre_build_ex(config, functions):
     print("AML_FILTER= ", config.get("AML_FILTER"))
 
     # build the command with arguments
-    command = ["python",
+    command = [sys.executable,
                os.path.join(config["MIN_PACKAGE_TOOLS"],
                             "AmlGenOffset",
                             "AmlGenOffset.py"), @@ -110,7 +110,7 @@ def post_build_ex(config, functions):
         print("post_build_ex Error")
         sys.exit(1)
 
-    common_patch_command = [os.path.join(config["PYTHON_HOME"], "python"),
+    common_patch_command = [sys.executable,
                             os.path.join(config["MIN_PACKAGE_TOOLS"],
                                          "PatchFv", "PatchBinFv.py"),
                             config["TARGET"], @@ -131,7 +131,7 @@ def post_build_ex(config, functions):
             print("Patch Error!")
             sys.exit(1)
 
-    common_rebase_command = [os.path.join(config["PYTHON_HOME"], "python"),
+    common_rebase_command = [sys.executable,
                              os.path.join(config["MIN_PACKAGE_TOOLS"],
                                           "PatchFv", "RebaseBinFv.py"),
                              config["TARGET"], diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/build_board.py b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/build_board.py
index 46fd389ef1..3b66df7115 100644
--- a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/build_board.py
+++ b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/build_board.py
@@ -1,7 +1,7 @@
 # @ build_board.py
 # This adds additional functions to the build_bios.py  # -# Copyright (c) 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2018 - 2023, Intel Corporation. All rights 
+reserved.<BR>
 # Copyright (c) 2021, American Megatrends International LLC.<BR>  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -49,7 +49,7 @@ def pre_build_ex(config, functions):
     print("AML_FILTER= ", config.get("AML_FILTER"))
 
     # build the command with arguments
-    command = ["python",
+    command = [sys.executable,
                os.path.join(config["MIN_PACKAGE_TOOLS"],
                             "AmlGenOffset",
                             "AmlGenOffset.py"), @@ -111,7 +111,7 @@ def post_build_ex(config, functions):
         print("post_build_ex Error")
         sys.exit(1)
 
-    common_patch_command = [os.path.join(config["PYTHON_HOME"], "python"),
+    common_patch_command = [sys.executable,
                             os.path.join(config["MIN_PACKAGE_TOOLS"],
                                          "PatchFv", "PatchBinFv.py"),
                             config["TARGET"], @@ -132,7 +132,7 @@ def post_build_ex(config, functions):
             print("Patch Error!")
             sys.exit(1)
 
-    common_rebase_command = [os.path.join(config["PYTHON_HOME"], "python"),
+    common_rebase_command = [sys.executable,
                              os.path.join(config["MIN_PACKAGE_TOOLS"],
                                           "PatchFv", "RebaseBinFv.py"),
                              config["TARGET"], @@ -161,7 +161,7 @@ def post_build_ex(config, functions):
         print("Patch Error!")
         sys.exit(1)
 
-    common_patchbfv_command = [os.path.join(config["PYTHON_HOME"], "python"),
+    common_patchbfv_command = [sys.executable,
                                os.path.join(config["MIN_PACKAGE_TOOLS"],
                                           "PatchFv", "PatchBfv.py"),
                                os.path.join(config["BUILD_DIR_PATH"],
--
2.34.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111827): https://edk2.groups.io/g/devel/message/111827
Mute This Topic: https://groups.io/mt/102862606/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      parent reply	other threads:[~2023-11-29  0:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-18  6:36 [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Remove usage of PYTHON_HOME Nate DeSimone
2023-11-18  6:36 ` [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Replace Python Interpreter Name Nate DeSimone
2023-11-28  3:20   ` Chiu, Chasel
2023-11-18  6:36 ` [edk2-devel] [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: " Nate DeSimone
2023-11-28  3:19   ` Chiu, Chasel
2023-11-28  3:17 ` [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Remove usage of PYTHON_HOME Chiu, Chasel
     [not found] ` <1798A438690A80D8.26894@groups.io>
2023-11-29  0:03   ` [edk2-devel] [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: Replace Python Interpreter Name Nate DeSimone
     [not found] ` <1798A43863B4D009.26894@groups.io>
2023-11-29  0:03   ` Nate DeSimone [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB582132EF3F7AF37C40EF2EBDCD83A@MW4PR11MB5821.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox