From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EC4EA74003A for ; Fri, 3 Nov 2023 21:09:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6tpkEhnqDRRf5dGkg5gCuH+4BhhqD5xudrP0iJSNQvQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699045767; v=1; b=aub8jrIsSCYoijgg9b8e1uCp+2O23JUH+MkZzH5MxOy28jF/jZ1IC+uvb3L4Go/G9RWPSqrB jpl4PTUpSdbG1ucpY7yAI/dPuJIblL67rbNgRvK56TsjIAY6bxFPHlOGqRV0lT6Dmx6Ud7wrBlY bQ8bkJaMflPBdb0i0nsdXJiY= X-Received: by 127.0.0.2 with SMTP id N9SJYY7687511xJzpFNJej5v; Fri, 03 Nov 2023 14:09:27 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.64821.1699045766681848287 for ; Fri, 03 Nov 2023 14:09:27 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="391894639" X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="391894639" X-Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2023 14:09:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10883"; a="827621700" X-IronPort-AV: E=Sophos;i="6.03,275,1694761200"; d="scan'208";a="827621700" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 03 Nov 2023 14:09:09 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 3 Nov 2023 14:09:08 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Fri, 3 Nov 2023 14:09:08 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Fri, 3 Nov 2023 14:09:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aqHh45A/YxEyxab3k5XSSuU1/fu1EiXtbWCSvdVQbrLJgrkaI3FweaV1wLIHS08v3EehMvZfFgwJdjqqb3nUP9m2EsvIIBJgjw7cTeo1uctrhPs6MigTo3xekfBAxjFRkeqckICvfbJKTcTbZ0KsA1BeqzMqa6IOaCawfGczrgy4Eud9xD2zNwZdu2Ge+L6OxD5pSmhEXWuOp3aQWJAM8S1dHvqbZJj7ywXD1PGsRbk3jvodJXIgdFMweFidPYGcIwQgXZwbycX1wdI1y+9q8pOoeimoarRr024/YB+r1zXBbIP1BWoJ/uBFIrEsvukmxLWkdxrszcPO6U9IoL35ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/8YxMklBdb+uLk5zFc+rI5Es25zI9I6/vlfRFkBshzM=; b=KJEvJsbKTfM77AQbPE8+5PXKr7bdxshevcNvD+gAqQKmKT2FchAU4xzV3mkbpOyo+wBDPEkAwsxLugTksoiL+tZATJr15Vb51BWApKC4oAPQzJiZlegPM6JBHYFWpF7wB2JfM6AyLDIMA3nrzbYwr/MZBAke+V/5qo1i3RqN3JOOtSdXQhb8WVHQjzqLuoiHrhHARckKQub4FMw7JMqiSOo6kuz9s89m2QtKnHXLgfCSTPPe3BRtgjvgt59/flDBLlR9vK+0BvQ8J8UheU7ierEWkdz7WCBQkBmrTmuvSh0VllzTFwnWT+j7oEP3ZaLM/UlcurgqBBNWHdNYlwdL7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by BN9PR11MB5289.namprd11.prod.outlook.com (2603:10b6:408:136::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.21; Fri, 3 Nov 2023 21:09:05 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::c90f:1f62:c3fa:3ac8]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::c90f:1f62:c3fa:3ac8%6]) with mapi id 15.20.6954.019; Fri, 3 Nov 2023 21:09:05 +0000 From: "Nate DeSimone" To: "Xu, Wei6" , "devel@edk2.groups.io" CC: Abner Chang , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM. Thread-Topic: [PATCH edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM. Thread-Index: AQHaC6d2kosbhECAN0yeJQ+AuLkjnbBpG5BA Date: Fri, 3 Nov 2023 21:09:05 +0000 Message-ID: References: <84314c396de63fbd86a8bbd2dc1493d602c44535.1698720712.git.wei6.xu@intel.com> In-Reply-To: <84314c396de63fbd86a8bbd2dc1493d602c44535.1698720712.git.wei6.xu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|BN9PR11MB5289:EE_ x-ms-office365-filtering-correlation-id: 8cc7fd8e-5124-4f24-aa1d-08dbdcb11c9a x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: D0zkCCFeI4XF0AtrlDQiEpeUzFiL6YgoZ0AJsYyZy/SPMep8DhO3Wo5Ktbi/uhEnfhy/lkILk5Nj7MrfSdIZJkCOBztB+lqHn6fr9RevKo3Z4CpgMoNw4ujAEGtpF2JczgdzQVzThTFs/bS3qK5vHCk9kSQgP10bJEapEnDSkOv5n0mI9X6unEFibD8O9Qn78w60RAqLU/EkbzEE2pZu3TcvxIJl+cJgCeS5sjVkDv6keTKMmQ1wNNJNRQEE/koJPPzedtdJNSnoikaKz3P4kYfNXPV1IEgI/fqA9DZUpn09a4aVzQmC0BWwMED2i1VLGDC9M/n/mBRAnYW9ri/2L9IPWSOm+gEqTcekYhpBFZj49iyWMUzmUXW4Vt7hO1obhnkFFFEeME3hvR6DXM1pQXc4ygUI4ZmnE+dFfLAK1A7b7j+K+dbiDVZcwRuqz9KfBJoGV9XStx2WbmjADCNb8aMgSjqkUbzK2+9tTfki4WjhLJVtmB97pgLYifRqvEQsCG/JoJP8MMFfEuF3JYJcUvfK0EgSSBZHHQAqJgnD5jbIGZYpYumVXuG4xP2mJB4LVXraeVOsszoDdKsVsK5dPTc7VsItp7uxE8pY5Z0mON9+MJ08Ty4SpKlm+UzgYPO0 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?TXfBTDbrhxsVUxa0sNLlXyg//1fwQ3SOywQbOCRaSrrJx0j8d0ERE2bAd69t?= =?us-ascii?Q?On4JDvbNRwoeBw1Mtg3M5ZU4qdKM8TrTc/FUhZ5XhnarhUY6JGSNzeF4mygl?= =?us-ascii?Q?2C+hF3/wCU8pIZ3OGCCT3oIRhsy1o5vuWh3UvCekN4RLsdGfj6Gpu4CbMB/w?= =?us-ascii?Q?7mJfvq6Vrjm9wMCBZXR1OR1BC3e6yfg99ncwF/MRbmK17xFJfWDWXQMC0hPI?= =?us-ascii?Q?wqco5st3GQyAmzbzqqZEPtulPlMvQIpbCSE5P8k/jf8oYziYin+ZFY7ITwgl?= =?us-ascii?Q?XRyV2OOiHqPkfKRXmDQ4glO0CAdXh3vuWb1Gb+C+ZJAw/rJWHnb7k6Q6l35b?= =?us-ascii?Q?fx+52Nys2dibd8nMj1UaVVKfDUmhhAfVBDfZmC2M9npKUgKTQmQcLsaAdOlD?= =?us-ascii?Q?AoseHxzsIDRz/WIySibHGMa3qVR4boRiMEwoBoS/CvhFwsX8Wz2gTqVvpdsU?= =?us-ascii?Q?/cHVECffMqFIkbsNTex2gr2++Hjn81ewmyxRDzFdQjTza3EvS3tKMCEy7mzv?= =?us-ascii?Q?a48vI+zA5rCXVkyjEqPM9xrx6wlPmjQEBYY3VMDo2Tte7w7lE5UAX+hDHmBc?= =?us-ascii?Q?sUawtZjkEaDrG35okq7WoP1IBs+2zBje5QEIoATLFbizdHMv9j53TRdCTY/S?= =?us-ascii?Q?THLmAdNsfbnUQvT5ys5V5tYi0o4aPrCVO4U5S4TzcGXcmeogPq5MAdmpINJD?= =?us-ascii?Q?9LM9vrb/55kuDQ4zdc/A1Lal312rnsmA9v3pM6CPMWpmtYDYzBjiHfNybiF0?= =?us-ascii?Q?+iIffFLhEPzCLzU4rArGvqSPZyU4frcp12/+LmPbER36Wpxw9LWmCp5Ladoc?= =?us-ascii?Q?j6qMhYz7gRvYl2TJk4DZeLsyoMw4YkM43BksdE8io2DteEG/nJJab1hQOFpC?= =?us-ascii?Q?aA8fUEtBbWOf+mkNpwpVeI0x72RUf+U7USstesbPinhiY+EZK219B6xVQo6V?= =?us-ascii?Q?bVgAoEBhi07nUCUpNGE5Ud/i0NxLtgYeAljyhb5UNlTE01JlUpWRlPM3Gcro?= =?us-ascii?Q?MQ5R8gY+BLd6ykt7HsBqohTqoYRdf93S3kiA+rDIqIwioJdSXyjNR7FqGjnf?= =?us-ascii?Q?8kAjPWQHNV5TOgom4JeaR11Za55fAgPEGxfg+2eGSr97ekm/1I5jYQ/mJVEN?= =?us-ascii?Q?YnNZ73xlSNmcIUPd7HYBXRblgueTilbRvMsV7LFvVdRR7WJbE5nbenoMYD7r?= =?us-ascii?Q?w2UgS6+Pn5TIKqW+iP49qPOFcIGD2ibB6TjExKsn/1JDJOOw1RpkVykh0q8t?= =?us-ascii?Q?EakjI5BoNqo+Qzawkg3UGZcaOihrzFAky7F/EpxtD+4l0HbTDFFk0okRgUCB?= =?us-ascii?Q?UA/YkWo3yDcir8QEXv2XB7KELVHUK5Zd13KIdaDCwAEvwxUtvazV2ZJeHqyS?= =?us-ascii?Q?r+gjyP+TUUU2VcJntLCvVCbtpiut3Mu37/7KW0tt3rO36bsp88Nwy/tTxgfe?= =?us-ascii?Q?UiRj5RFZDpyhZ7V4je4O/aiUfOcwGYBLgDsHSGgygmcYwyFkICBbJ4u+X2is?= =?us-ascii?Q?WzmooxRkw5b+v3kxYSydgluNcZ8r1zA7jOJ/d/PxD8GDzcf2TAfQ3OCZea8G?= =?us-ascii?Q?GZjwp+3N/8C1CeJpwrfuYM5odosH6cY6ZaPg12GW9CX8cGBMnY7gKkf40TL/?= =?us-ascii?Q?lA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8cc7fd8e-5124-4f24-aa1d-08dbdcb11c9a X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2023 21:09:05.0239 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W1eA+7KykvuxY0Ioi8yEzVprw17c7Ba/vNv5zl2IEbwUlpRdZdaKTbJ2qRY2r+xCM98grX9isnNU3Uimr75fnlxW5UaK+shicUg8xJH3hVQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5289 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QoBpxHHCTYszHPKJuvfzJNlIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=aub8jrIs; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Wei, - Please update the copyright year on SmmIpmiBaseLib.c + SmmIpmiBaseLib.inf - Please remove the duplicate old-style function comment on IpmiSubmitComma= nd() - Additional feedback inline. > -----Original Message----- > From: Xu, Wei6 > Sent: Monday, October 30, 2023 8:08 PM > To: devel@edk2.groups.io > Cc: Xu, Wei6 ; Abner Chang ; > Desimone, Nathaniel L ; Gao, Liming > > Subject: [PATCH edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: > Support Standalone MM. >=20 > Add MM_STANDALONE type support for SmmIpmiBaseLib instance. Replace > Smst with Mmst. Remove unused UefiBootServicesTableLib reference. >=20 > Cc: Abner Chang > Cc: Nate DeSimone > Cc: Liming Gao > Signed-off-by: Wei6 Xu > --- > .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c | 17 ++++++++--------- > .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.inf | 5 ++--- > 2 files changed, 10 insertions(+), 12 deletions(-) >=20 > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.c > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.c > index 6282adc269f8..1c618e48abee 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.c > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > B > +++ aseLib/SmmIpmiBaseLib.c > @@ -6,11 +6,10 @@ > SPDX-License-Identifier: BSD-2-Clause-Patent **/ >=20 > -#include > +#include > #include > #include > -#include > -#include > +#include > #include >=20 > STATIC IPMI_TRANSPORT *mIpmiTransport =3D NULL; > @@ -37,7 +36,7 @@ NotifyIpmiTransportCallback ( > EFI_STATUS Status; > Status =3D EFI_SUCCESS; > if (mIpmiTransport =3D=3D NULL) { > - Status =3D gSmst->SmmLocateProtocol ( > + Status =3D gMmst->MmLocateProtocol ( > &gSmmIpmiTransportProtocolGuid, > NULL, > (VOID **) &mIpmiTransport @@ -60,15 +59,15 @@ > InitializeIpmiBase ( { > EFI_STATUS Status; > if (mIpmiTransport =3D=3D NULL) { > - Status =3D gSmst->SmmLocateProtocol ( > + Status =3D gMmst->MmLocateProtocol ( > &gSmmIpmiTransportProtocolGuid, > NULL, > (VOID **) &mIpmiTransport > ); > if (EFI_ERROR (Status)) { > - Status =3D gSmst->SmmRegisterProtocolNotify ( > + Status =3D gMmst->MmRegisterProtocolNotify ( > &gSmmIpmiTransportProtocolGuid, > - (EFI_SMM_NOTIFY_FN) NotifyIpmiTransportCallback, > + (EFI_MM_NOTIFY_FN) NotifyIpmiTransportCallback, > &mEfiIpmiProtocolNotifyReg > ); > } > @@ -127,7 +126,7 @@ Returns: > { > EFI_STATUS Status; >=20 > - Status =3D gSmst->SmmLocateProtocol (&gSmmIpmiTransportProtocolGuid, > NULL, (VOID **) &mIpmiTransport); > + Status =3D gMmst->MmLocateProtocol (&gSmmIpmiTransportProtocolGuid, > + NULL, (VOID **) &mIpmiTransport); > if (EFI_ERROR (Status)) { > ASSERT_EFI_ERROR (Status); > return Status; > @@ -164,7 +163,7 @@ GetBmcStatus ( > { > EFI_STATUS Status; >=20 > - Status =3D gSmst->SmmLocateProtocol (&gSmmIpmiTransportProtocolGuid, > NULL, (VOID **) &mIpmiTransport); > + Status =3D gMmst->MmLocateProtocol (&gSmmIpmiTransportProtocolGuid, > + NULL, (VOID **) &mIpmiTransport); > if (EFI_ERROR (Status)) { > ASSERT_EFI_ERROR (Status); > return Status; > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.inf > index 7ea688fc165f..cf6b91c471fc 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > BaseLib/SmmIpmiBaseLib.inf > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmi > B > +++ aseLib/SmmIpmiBaseLib.inf > @@ -11,7 +11,7 @@ > FILE_GUID =3D 2B5AD78E-5CF8-45d2-B2AC-749A0942591= 1 > MODULE_TYPE =3D DXE_SMM_DRIVER > VERSION_STRING =3D 1.0 > - LIBRARY_CLASS =3D IpmiBaseLib|DXE_SMM_DRIVER SMM_CORE > + LIBRARY_CLASS =3D IpmiBaseLib|DXE_SMM_DRIVER SMM_CORE > MM_STANDALONE This should be: LIBRARY_CLASS =3D IpmiBaseLib|DXE_SMM_DRIVER SMM_CORE MM_S= TANDALONE MM_CORE_STANDALONE >=20 > [sources] > SmmIpmiBaseLib.c > @@ -21,9 +21,8 @@ > IpmiFeaturePkg/IpmiFeaturePkg.dec >=20 > [LibraryClasses] > - UefiBootServicesTableLib > DebugLib > - SmmServicesTableLib > + MmServicesTableLib >=20 > [Protocols] > gSmmIpmiTransportProtocolGuid > -- > 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110670): https://edk2.groups.io/g/devel/message/110670 Mute This Topic: https://groups.io/mt/102290796/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-