From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.419.1635895447762430231 for ; Tue, 02 Nov 2021 16:24:08 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=J50voQG4; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="228837781" X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="228837781" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 16:24:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="500801694" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga008.jf.intel.com with ESMTP; 02 Nov 2021 16:24:07 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 16:24:06 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 16:24:06 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 16:24:06 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 16:24:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k6yE1E/KTiRC1HFUSM07nWTxyxzfA7tzBpFFsCE69sbN9kS9LA406ffquoSPE20lwufizMXcT4/PxQVaZTxGxZtq+l5JTiLoJk1XIQeoQmk9C6hBCXh34r/pGbUPWmLvvAZcfKLHKN48Te9e08cyse3d/A9Fjaw+pyryOuybWFcnbmSaokUaeJwHvVrsTHAnDBkTLrHt2io47gR5uDn8vPEOZJXHSrqJYXDlJK5vvlFke5mmOd8HPcesAjFJLkXvZjFeUNm2MbwVPjOEGWBV9BzbtC5K8Dp5jIMkZtXADaO7m8p9dONqXzEPIei4wQGZP9fA824PmSzbfDNbwSy4jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=32JRB8arL5qs8WF01aR8JXtaKxxgrFyDAMu+6Fh0Lqg=; b=HWyRXQDbU+CJoBVInNuOisM/CprhO+tqvgwCYPTvgdDkj/uimxpOZq2v9QjVR2EiGJs6MSm6d98GG9G5OrKCXTADncRsoDaasWI5gfyIdwu4PeyXxvEbpB5DSIyQLm/nFTGf42s1nUdk62LaRzUlJHdpAi2zViGOhyIwaSiuj6jfswtrBMPbValXaPK+C50xCbAqLekPrrD1uwi60rCu290kFWUa/HzF7CyYXis9YGP/Td7hBBgTIO4p/KzpU34pVjW3yH82d8ck9J5cIMr1hMzyf5tP0jogR71iT+nC7hBdlu2MrNf16bK5hS+djLlhtJExOofwCb0Zi3uF+JalMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=32JRB8arL5qs8WF01aR8JXtaKxxgrFyDAMu+6Fh0Lqg=; b=J50voQG4ItyFKA2gJBvKl+4yE+NvHZU4eZPKc7ztS+YwvRiFazHdQDFeZoCv4CZCNH7C30/rPZ4hAwlQg8sEQHIWp7VHHlTpHRSRCWNDJhPKuaHh5ImvNJ/jMGTTfqm8qun2ESel9AF/jUF/bYw4Pvdam8cMp2BPU7gk4AQhEVs= Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MWHPR11MB1693.namprd11.prod.outlook.com (2603:10b6:300:2b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.17; Tue, 2 Nov 2021 23:24:04 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46%9]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 23:24:04 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Chaganty, Rangasai V" Subject: Re: [PATCH v6 42/52] CoffeelakeSiliconPkg: Update for SPI2 PPI and Protocol Thread-Topic: [PATCH v6 42/52] CoffeelakeSiliconPkg: Update for SPI2 PPI and Protocol Thread-Index: AQHXzEifhyWW9sxHq0usFnTZcnAmJ6vw6N5g Date: Tue, 2 Nov 2021 23:24:04 +0000 Message-ID: References: <20211028220846.753-1-mikuback@linux.microsoft.com> <20211028220846.753-7-mikuback@linux.microsoft.com> In-Reply-To: <20211028220846.753-7-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a4dd4090-253e-4b85-a59f-08d99e57dc70 x-ms-traffictypediagnostic: MWHPR11MB1693: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QRmw2wfiexW34ytt8WM9lAU4mFtssVmBqBwSzUyc8I9Voqi6YWqNOZIH1bZC9eFAhf1DiQsb2e/Xf7/cSMiOikGQyt+leyxW/hFKNci3zB+R05DeFkmLLMYG3+wSNQFCcB2pZPnluf8KigsWLZD0duBLLE4LhxoYpiMh9UPzaPoJ1Vl0+q08OqHcyxckQHzkPxGlEdbBrhgHH5/zWfhw/+WRw3XzgcvwyC7uH+ypy0OutQSN/+NGmy29BRcoOIUkWqSlmxdZzr12s5KkYsSdlniMWL5phr1yQvsmTi895I1mMDipoLLBpxW5tmwIlH3Gy6JNeloUjq2dJYQRiRWs3dWrpbQviuiYLsnG5IFJUfRMCodNPnS5qnj4HJ9K9DY3K5dN2eNlwzFGh5zCVfYc4FmE5H69JFlcUO3TL6OQ6tskhBe/URpbbtUlCY5DNvg/0GFE78aPzEklV6YuteH+QSa+157bd4UICWtiizUCrDumpZ5Y7Rg8bCEAfA1hpvr6mDDLK+ruTgWKX0HPHNf0ayiBfBmI2ff3ThQ/1pc9XQ2gR5U+E0VNPaJ3T1a+ZVrYJlAWAjDZGLInBpGVNM7cHQDEvEzo1EmaMsm9ZovvEy8BfMd3OtTAPzrvGPCkiMD//7w2RBr/QdIOCBi6b0kCwzCvsgmkIaN4L9w0gz2SQfkM9ay2JqjtJfWUKbNgg8Nrn177xQbiEMdHTP/++qyT5qtszpAtLpevQgymjpfaMQAtVGusokE5OmEQAyjaVoN5SxylmrrOcGQZyxVgV5xeDAln8KnosGGx5VnqV0GGYnA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(53546011)(19627235002)(122000001)(38070700005)(15650500001)(33656002)(82960400001)(107886003)(71200400001)(6506007)(8676002)(5660300002)(86362001)(8936002)(316002)(110136005)(7696005)(26005)(54906003)(76116006)(66946007)(66476007)(66556008)(4326008)(508600001)(2906002)(186003)(52536014)(83380400001)(64756008)(66446008)(55016002)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ROY0+mmzsAa4MG8/E/crtZa1dRExunNqvJl4Uf5T4+Xsf7aC6H1hf51acsHk?= =?us-ascii?Q?QC2KOqO5KDXlXRItOR0dA9Xi3IQlGxGl2KSDAN9h0ijqQQNPRVCTpkZB98To?= =?us-ascii?Q?eITkO9szChiVh618J1rEUbuGf+mh34yqxJKD6G3ijhK6K5ZmfEYV79eFAf32?= =?us-ascii?Q?FJ5dyMJP2oCZnPES37MBZfdYjFjUR+TA7/AadwDbHjrHDQdGKohUJGibZPhQ?= =?us-ascii?Q?X0+3J4JBFvx6UwXijP2K+n974Xwp1ttzEXxOG+CoO9tFTTLbvcGTpdZrIF4U?= =?us-ascii?Q?H3f2oX3rsaAVNUu5ffGYbRQGE/fcL6cWlKO4NL9Z52qP0wMWG0JbXXL5FL8V?= =?us-ascii?Q?kUPB+m5QuwULpm5lodkHkmtRJN+0WibDClNbzZhWjC34I9HLA67yEhb9U7cA?= =?us-ascii?Q?n89ienddBb6SMCXGFn1wVUn5guVhYVzFY2ef8YErIN3IEJXUwN1pEzKzjQsj?= =?us-ascii?Q?r1WVUfvGnbD2CiXHkyYe59FK4D02Hlcp5V9XqzYYgCf3LNED1ySqgWR9ZQkN?= =?us-ascii?Q?5INMLzCH2UmQWmevNZny2HkK+KltOWvTMsBnesB/0ixYmyX3zuOTSgu6KKGw?= =?us-ascii?Q?dFZ//BJ6JtIRGIkdlr6TA2r84BMSqtKrgHInjM/Ahv+US3nJOPXMAdX0Y/gf?= =?us-ascii?Q?zUaRwbVShkP7C1frfcU2gbJbQBKddWKpWRpKJ35GblOjMuDo/vYoAVzXJt9n?= =?us-ascii?Q?dugZUuZ1gNMVAeAIysClfq8NM5yc2pPw3sjX8q+yXKpvelRnYqH8lZNtWe+W?= =?us-ascii?Q?cp8Ggua1UNTboc2HLcvaXgRcRb9Hd+gLmj8J4AgxbsxZ3h08ntwXS6OiR+Y6?= =?us-ascii?Q?eLYJBXH+jArH++DHGZUGfwd4wd4TVhaG/MqZZG9y6ubJONQfdSs+V2d0oK7M?= =?us-ascii?Q?xnlOYGRmT1Lie8uR4C6LDXVrOnXcK0dWaoWcmZ+wcETOwBtoJXAnxOftIuiR?= =?us-ascii?Q?L/Emgl1xFWUTm+blta2cHTYeWV3HbxTgeLqBhpw1QD/mua2nusSc1ZHUuxeW?= =?us-ascii?Q?3p0SPZXBWh3zpGJQAbghj8dfXY9lOc8DH5K0xcFBf4BGb9GKc1WGL5qc2ETQ?= =?us-ascii?Q?f01FHSIl5+/pzoqRwgqthNX9TccEni4nPTWqjr2V+dUPcnwa/2Q0IZWMdhcS?= =?us-ascii?Q?jWP2KY0nc0ZGy7fW9gTkaZbKR4/bNdfZZangCp3/cXebGCV5oJ6IP/8u4Uyy?= =?us-ascii?Q?bsFZPmUDao0gp37q48J51iM3Ppvnq5t7Solwc5WyyKYbKYNeKCZIlCN0C+4n?= =?us-ascii?Q?MHNQdhsQ6zm0pb39tLG5w9pTm0PAsTn+nNRyQ+m6qUAiIlo7vlUDDEKH3Il1?= =?us-ascii?Q?LDhak7ZgeoIdV4BxbtNfBPJwgX97a3btGnFebZ35ZI+CKYSIMD1ZfkdfwLP3?= =?us-ascii?Q?ZmMYIQ6johB8Uox0YmPb72KKSzJZmJ+hDtD9PESeqUyLMij/ab/oZ28PNUtu?= =?us-ascii?Q?+p7URWch4fcygPwt21Ym9l30lTp3OAj4bwdp4Z3FBy4xGfi1N6x+A5T2IvGF?= =?us-ascii?Q?OWaFaPl0+kzPzZUCtza364XKqFSJImTVApTPn5MXjSlFJHmlLWynaD0JP2Kt?= =?us-ascii?Q?xWItWHD6CXKx7jFj/R40uYZX6DUUQh485gHKTPqsRVPsoyMW1K2hZJGhQWi6?= =?us-ascii?Q?JjMBVIB2itn2V5SnWLI4iE02yGiePG3l91sP2yHoDOQYAyiMBCYR3Ezw8l+A?= =?us-ascii?Q?Bx7oRA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a4dd4090-253e-4b85-a59f-08d99e57dc70 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 23:24:04.6433 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7wzdy8Wp5EsZoB/qyOHRK/XIC86XwfLx+UOJoJS8LrtkFCZHhIHProo0Jb8Y8pnIhCEz6/uKbe9eb7DlZ+GzfNszRQBbFqoizA9/9qZiJTk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1693 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [PATCH v6 42/52] CoffeelakeSiliconPkg: Update for SPI2 PPI and Pro= tocol From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Updates references to the "PCH_SPI_PROTOCOL" and "PCH_SPI_PPI" to instead r= efer to "PCH_SPI2_PROTOCOL" and "PCH_SPI2_PPI". Cc: Chasel Chiu Cc: Rangasai V Chaganty Cc: Nate DeSimone Signed-off-by: Michael Kubacki --- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PchSpi.c | 1= 0 +++++----- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpi.c | 1= 0 +++++----- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.inf | = 2 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf | = 2 +- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PchSp= i.c b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PchSpi.c index 1a5db7f24a49..543e42973ae9 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PchSpi.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PchSpi.c @@ -11,7 +11,7 @@ #include #include #include -#include +#include #include #include #include @@ -62,13 +62,13 @@ SpiServiceInit ( EFI_STATUS Status; PEI_SPI_INSTANCE *PeiSpiInstance; SPI_INSTANCE *SpiInstance; - PCH_SPI_PPI *SpiPpi; + PCH_SPI2_PPI *Spi2Ppi; =20 Status =3D PeiServicesLocatePpi ( - &gPchSpiPpiGuid, + &gPchSpi2PpiGuid, 0, NULL, - (VOID **)&SpiPpi + (VOID **)&Spi2Ppi ); =20 if (Status !=3D EFI_SUCCESS) { @@ -90,7 +90,7 @@ SpiServiceInit ( SpiProtocolConstructor (SpiInstance); =20 PeiSpiInstance->PpiDescriptor.Flags =3D EFI_PEI_PPI_DESCRIPTOR_PPI | E= FI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST; - PeiSpiInstance->PpiDescriptor.Guid =3D &gPchSpiPpiGuid; + PeiSpiInstance->PpiDescriptor.Guid =3D &gPchSpi2PpiGuid; PeiSpiInstance->PpiDescriptor.Ppi =3D &(SpiInstance->SpiProtocol); =20 /// diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpi.c b/Sili= con/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpi.c index 458d137e4fa2..a5518a606db7 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpi.c +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpi.c @@ -14,7 +14,7 @@ #include #include #include -#include +#include #include #include #include @@ -45,8 +45,8 @@ GLOBAL_REMOVE_IF_UNREFERENCED UINT32 mSpiR= esvMmioAddr; - Documented in System Management Mode Core Interface Specification = . =20 - @result - The SPI SMM driver produces @link _PCH_SPI_PROTOCOL PCH_SPI_PROTOCOL @= endlink with GUID - gPchSmmSpiProtocolGuid which is different from SPI RUNTIME driver. + The SPI SMM driver produces @link _PCH_SPI2_PROTOCOL PCH_SPI2_PROTOCOL= @endlink with GUID + gPchSmmSpi2ProtocolGuid which is different from SPI RUNTIME driver. =20 - Integration Check List\n - This driver supports Descriptor Mode only. @@ -108,11 +108,11 @@ InstallPchSpi ( return Status; } /// - /// Install the SMM PCH_SPI_PROTOCOL interface + /// Install the SMM PCH_SPI2_PROTOCOL interface /// Status =3D gSmst->SmmInstallProtocolInterface ( &(mSpiInstance->Handle), - &gPchSmmSpiProtocolGuid, + &gPchSmmSpi2ProtocolGuid, EFI_NATIVE_INTERFACE, &(mSpiInstance->SpiProtocol) ); diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSp= iLib.inf b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiL= ib.inf index 4e4b456574f0..46f10368d19e 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.in= f +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib +++ .inf @@ -39,5 +39,5 @@ [Sources] =20 =20 [Ppis] -gPchSpiPpiGuid ## PRODUCES +gPchSpi2PpiGuid ## PRODUCES =20 diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf b= /Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf index 231929151222..0fc8ea7b376a 100644 --- a/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf +++ b/Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf @@ -38,7 +38,7 @@ [Sources] =20 =20 [Protocols] -gPchSmmSpiProtocolGuid ## PRODUCES +gPchSmmSpi2ProtocolGuid ## PRODUCES gEfiSmmCpuProtocolGuid ## CONSUMES =20 [Depex] -- 2.28.0.windows.1