From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.34780.1658188368795265362 for ; Mon, 18 Jul 2022 16:52:49 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=O5aVfI0/; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658188368; x=1689724368; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=zmBs9bdHGMIs/02KMgl3LsjD9e50KhZGmxkY6pjQ6yY=; b=O5aVfI0/N3UnbnAQXP13tTjfg9yeP+cCagsVhgrqaL09BPOHHGbFIXxs HaEZCwcE6W7G//RZ2gY4Cu5rsHQd64l111H+Wa9zZpX3Hjks8NnCtvS43 19zLBqoe/1nv0Ujbu3wPdoWF8CpCYksn/e6XniM3KmMht8M+HYIpQlVh5 ayIrh/f/JrhyRrvsamSPq/rNEFWo6anoT+UUZY2+UOTGuLMsU+HE+bSY3 g4Kevv1pYkXuPWNgSIZShmXUHTnSecuShHw1hdGfYYJNll3o6LEseC+DA WjZj0blLIqc/4bTz3+ltntjzSb3cw55dNn6pKQjrkjwD2S3QM8zPKYiP0 g==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="273177308" X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="273177308" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jul 2022 16:52:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,282,1650956400"; d="scan'208";a="655499886" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 18 Jul 2022 16:52:47 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 18 Jul 2022 16:52:47 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 18 Jul 2022 16:52:47 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 18 Jul 2022 16:52:47 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 18 Jul 2022 16:52:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eVl9/QKyhA9dHev7ZL3SyST7qu8PcrQLsWNpIjpASuRBoPiCMrsCsICv3qsX7LrSWeC7h2WfMRhI1BudW0Ei0dAJWSIipjQDm1Qr2ANgrGPWzDBOOeNVUAYrOinaDtLgUThEvElUJ01HJ47eAUmzm8cIwCUXzzrVFyq7/it1ze3lOe2zBcL8/7V3bNONsI/CBzdlYaAmzG/tYQ0iD47ymCpxwGvTCayrqtph5lfRPMGIGsYaJFDT9E756I6Xx00uNVL2VuKMqm3yvuZ45CfCaVF8Mw5/QyrTP36Graz19sb9EjXIidxIfs2sEgqnjEytzhR+gZpK5ONytaaOEaOfPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pKhHLgzDHquxEUC2TCyqoif1eMZB76mG2own6TDDTfs=; b=U5CQy69eivIyICEPTIy5tVzam7YFn8VqcElK8Qejrukt2Z8lIOKYBVT11ErwTVdokJBUHMVk4+2z7oq+boA+u81FugRG2qj8wqRKkMQtyYV5MrYoyysAXOxDJcXx5kU8s7Oyt8BAwhGZkL+eYe6hhjOmYETaYfCWKlZ+b3KjHOe2FV15vJGKaamNjhWDFg6783e/gBBx4FstVl5b1uVdQ9MTw2tw5waKSZM9q+7xbfs4r6va3/OGlf/as268mFXOuVoxE7AB4r2YAl3dweZSYWjQ3xDxF+bgL2Oj+G2SuArwdiZXs7SbGV7imFk8UDUj8Y1eHGEK4RAUnJxIAPnZ0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by BN0PR11MB5725.namprd11.prod.outlook.com (2603:10b6:408:16a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Mon, 18 Jul 2022 23:52:45 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::f59c:6174:7737:9179]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::f59c:6174:7737:9179%4]) with mapi id 15.20.5438.017; Mon, 18 Jul 2022 23:52:45 +0000 From: "Nate DeSimone" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" Subject: Re: [PATCH 0/2] MinPlatformPkg: FspResetType support for X64 build. Thread-Topic: [PATCH 0/2] MinPlatformPkg: FspResetType support for X64 build. Thread-Index: AQHYmvOXHpiZfryPY067oQW/NHPlca2EzDkg Date: Mon, 18 Jul 2022 23:52:44 +0000 Message-ID: References: <20220718221257.1318-1-chasel.chiu@intel.com> In-Reply-To: <20220718221257.1318-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3e731da0-c16f-4cca-1cf5-08da69189c53 x-ms-traffictypediagnostic: BN0PR11MB5725:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +m5hLzOBHICokmwfYzUZkIBPAgj/kNO/A43jrWyxVrN5C/nyRHoseMKnMCJV+Jr1f4k+79kAnTvf75WMz/wOZ3p/cGVQZwWaBcxx7ctrQ7+iR8z9Ou84w8NZYwPJMTx3yFzNgWhpJzG3vj64SkpAz7muTfYg0wqne5d5tnJdNH7QFE/MJyYwol30cs2ChmpXeKaC1iedTVF4HkaWwzgGrQyYnOvQYqMQ233O2WvirHFpgr05lxzJ+YHQFVCpxc/0Ya6Ul/rod4J7KJ1d3imf1ZJxG5KZr2xnRiFMwAK/ao1ABOBEmbz5rr9L/Q0gaXwSH/8dTKJ1TGyp6HPbOhFfkdWOAtlEmcv5Kn+o9xn+giIWws2mTOFgmMaRjkdUpYPaeszZ2683bAycqSY/PSIYOz1kbcPw9IZyjBmXwzDEMEd4cMmdvrv/UUSpcCrK9V6gMRTXTj39LJYQtTzjDIFuDGHPVzy9ZdpezV56/jYeyaGTMMXiIrw18bYv0IryREOiAxETP3eEuvFXHlqfqoHsc794/+Ni5FP1g65ah+jko11CfO4xYMjyxqC4uz4RAueuxXXxaD6esWIwXG3o328j96iaMom46QdDszwKfqxSLN4wXylWLup2dHh7LRYvK+IJSUr6KdJoBYJFeUsnOb8FZXD2yBXCcY5+B5qqkhfGlg3JhXE1u87Cvt88XQ1/izMZJuYolRS62Z9kpcFUPUa7hFMvx8IG5P+Kw60Xuq8zEZ2M+JkwvSnQl8H+lMOIgEohyR70oFWr7jNJ3843fv+EdsH7zUx+qXqkEiLIt79sYtOV0i4FzRmrB8TdRui47qCo x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(136003)(39860400002)(396003)(366004)(53546011)(26005)(9686003)(107886003)(110136005)(33656002)(41300700001)(54906003)(7696005)(55016003)(71200400001)(6506007)(478600001)(38070700005)(38100700002)(82960400001)(122000001)(83380400001)(2906002)(52536014)(86362001)(8936002)(186003)(5660300002)(66476007)(64756008)(66446008)(76116006)(316002)(66556008)(8676002)(66946007)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qoy2OndC27HVbdgHQ3X3ciDcrnUgZLAkUa5RPi55DX6YydtfaM+WAknkBavX?= =?us-ascii?Q?XbxBQS+PaFVEck1EcLPCTqjIRPOXWOpEzmc89tCyd5o0HE/9mn303K4wfltq?= =?us-ascii?Q?ARPNJV1pFjMFABFErk6TZhZSpEqNw+uhUCG5Fisl8HwUANyXdwAoNlwYvFus?= =?us-ascii?Q?lP3xsBt5K3dlpNfgFlK8vq7dBaUtNpDbzDhake4iiDWywicQ75tFfpC6E8Sy?= =?us-ascii?Q?1wllX/48wIvfZU0Dzwbcx9PpY4El6q52xn61ZJailkoJvloYeHBFd4cM49IN?= =?us-ascii?Q?o+lC3NCeh6VNNPh8wvsev3v71vefN/fb3+56JCGI6beEL8jJK7q6YWzz07Fj?= =?us-ascii?Q?dv3eqVOyUdkLBvK1Aj1EWUKoauAy+y9kAM5NGcBmHx3EjmusPsv1tkzYhFGD?= =?us-ascii?Q?R3WXjFAJ1TxwU5/iLO936iLUnSVyq7drCew4sF8KRWGRu1Aiu/A3dJ3Mz2Fx?= =?us-ascii?Q?KS+5SJP9AQAACKWhKjlvESuNjxejUHL6qCvVwEQ49VeDEGJQGGJHlho8t8cX?= =?us-ascii?Q?xIs0iGnDoukZ7qaZhtsy1OcUA+ndPeKoa88HqDvq3Hnmv3o39sEswD7Fv5E/?= =?us-ascii?Q?h1roqhL8C16lQX5t/y8b5Uy4AQYO95sfSex2aDLo/nrR48eJ6Pjye9HiF6Hn?= =?us-ascii?Q?bGOooAeeQkuMJVz2KbpEsSfCb8NwZIUXIfJe2lT7i7p4+Fje0zmUI8oooiSG?= =?us-ascii?Q?xNwYCDVLw9JOc4EW6YOE+38jh+s16gKi60t4uUKvr5M4+9la6V/Ady4bG2L4?= =?us-ascii?Q?btyV/2t7WOhpHulR+bAJDD7jMTijfXzgFfFQl4MWZtWS+QDXW4Czl3Te7MDk?= =?us-ascii?Q?05iteQiyF6cHWmAJqkjSrsu6OZ8w6r0TgIYyep+5lHYoSNwFPXxTdVIKWa62?= =?us-ascii?Q?Uh7Q2hkOrDMAbyXhnNXwgGbiE4wabGb0Sx8YPj6mim9Q5w50QUEJrO7TSBE5?= =?us-ascii?Q?Y+FFOHb/0leW+3qsVPsaC7Xp+mOZMAigmtVF3cFmiXiw2PoEwKic8m22leo+?= =?us-ascii?Q?OpdXqpfcg9lC4xU+rr3rQ6SdSXlqQL5Mc3IDl0md7NSTj2eH9H0ZiC64rIf/?= =?us-ascii?Q?shoDPrVJu5h+nYOAIjYqJopvC0rFeQq/9nLJ4LzlyLAmISkrS+/87a5MWVJ6?= =?us-ascii?Q?slA4Cod+fYk7hnf8wUnJkmASfGJ38clD4QsNkH6RehJxDQgxw34+rQeq/HjI?= =?us-ascii?Q?WGi+ep6zfgx91I1HD/reQCXudT1vAOTsdjqIaluhO+Gn+VEekgn6oYbBMy6+?= =?us-ascii?Q?kNaTqUNEnzy7DH1BqEsV3LIavxvvodb0aa1lxaT5lZJB6Qvkl0kdtkBecFpN?= =?us-ascii?Q?8qZOyIcayrcthduhBfWQuX/A1P2ZqccWdWqxP4dPwY5Bg14n6+gUq793Rh/4?= =?us-ascii?Q?mWJPfnIX1+8rz8nnzX6OWL+Hh/RsD4dZYLr/ykygDZFcG2nfD1CFNHdgJfcf?= =?us-ascii?Q?c9hWdBr6gvtLL5F5p8rFj9V4++RmcLRcApJlwyrtA83K/91KaplOy3Nsa10f?= =?us-ascii?Q?9HFcR3DScoCLNOgROc7Q4Xmp8GBX+dgAxjzZ5crwhqWHnk4UeOoXg6Cp5LtQ?= =?us-ascii?Q?0OTLG0uS1WmrRqE8T8hvqPGmrCWEsne+SZm8lyWJ/cHzYgnAzocWXxnFPu4x?= =?us-ascii?Q?BQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e731da0-c16f-4cca-1cf5-08da69189c53 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 23:52:44.8702 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QNZMPOOQjHdr+/cyufSlPc8fNqYu1UHzcr7lJVNdgd/LrlpaaVA/0lyGCsLUDm7uwRHH0ho6wEF30IFSYbqchQiJns1v5wTyt0e00pHB3Do= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5725 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Chasel, Please change the function signature for CallFspWrapperResetSystem() to tak= e a EFI_STATUS as input. UINTN is certainly better than UINT32, but the act= ual data type defined in the FSP specification is EFI_STATUS. Also, that is= the data type that FspmWrapperPeim.c and FspsWrapperPeim.c is passing in. = Using EFI_STATUS instead of UINTN would prevent us from having to do CallFs= pWrapperResetSystem ((UINTN)Status); in those 2 files. Thanks, Nate > -----Original Message----- > From: Chiu, Chasel > Sent: Monday, July 18, 2022 3:13 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Oram, Isaac W > ; Gao, Liming ; > Dong, Eric > Subject: [PATCH 0/2] MinPlatformPkg: FspResetType support for X64 build. >=20 > FSP_STATUS_RESET_REQUIRED_* will be either 32bit or 64bit basing on the > build and this patch series extended the support for 64bit build. >=20 > Cc: Nate DeSimone > Cc: Isaac Oram > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Chasel Chiu >=20 > Chasel Chiu (2): > MinPlatformPkg/FspWrapper: FspResetType support for X64 build. > WhitleySiliconPkg: FspResetType support for X64 build. >=20 >=20 > Platform/Intel/MinPlatformPkg/FspWrapper/Library/DxeFspWrapperPlatfor > mLib/DxeFspWrapperPlatformResetLib.c | 4 ++-- > Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatfor > mLib/PeiFspWrapperPlatformResetLib.c | 4 ++-- >=20 > Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapper > PlatformLib.c | 4 ++-- > 3 files changed, 6 insertions(+), 6 deletions(-) >=20 > -- > 2.35.0.windows.1