From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.3918.1642042027244836517 for ; Wed, 12 Jan 2022 18:47:07 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=WJZ31GRs; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642042027; x=1673578027; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=DJULSrG5KtshNGSl0eg8SQUG6ys9NM2rQ8imePk7dao=; b=WJZ31GRslTb5KvtNXDqmofXkWx0IdQTqF6jynoKKOYMjG119D5i76RiY WiRhNdf46tw+STbEA0RGJcv9TrDjmC8T0bfqJkZSMfqix1LX7rXLK8p0H oCu3vBAZjaa63YTHT4Etse4PSMb/qua5TdtIXVIjjRQcHfPFXiqDHeeu8 6uKAaztTXTAb/IM/YjAcdHS7S4BrKRW07DCTacSha0MyGgi5UZwynIqWG BoKdItfRnKpHoVJd/ZdpoQu/ZFqjPMODbUsPnAFdL58TFtDU4IF6YShMT iIyMc/POBq7tr2AfsOjZnUcdsmxxzvjU/JWjLl09BF/TEQ7CypytFlcNa A==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="244117230" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="244117230" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 18:47:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="670367722" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 12 Jan 2022 18:47:05 -0800 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:47:05 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 18:47:05 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 18:47:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H0mr+McxqnlUPunKg7DNrMw3dCp/b10svbNv/Nt6w0jS+a/aAghLsC4Y2mhIa+Du/wbCWBJPbkUbp96FCOiG5DyVkiQ2vs5Oe71PHZ4HNXTL9vygBCJBr0v2gZc+y64bhzj+Gz1VfaG85xiYz1eUFG+Kw8XaHnHbvEyF0daLeIyBbOopNpYcqaSz0gE28amPl6O15619lgGgLWifWMeauhuIvvI5C9NUsosX0YgAdkCPxs9mDr9P7ln+Xl8Yt8LUQPnzaOiJy/I8rF7uzLOgz198ZB/MXksslwPsjJbV9c8LEYHhtQ8U+XKcHJFQWHRfnuyh7jFpSWpQJ+N10+tXOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1QIhOg94+ebxRFdC+XPzEpVqt99ySs4dDDYXl+Z7kWg=; b=HNHWTnDgaZBaIKIa/gZPh6YrJ8ell9HTMkGrzo7CapDauet1vH+N8EISpVzF1ROtHd0/8T3m2IJF9En0ZdWBo4jMIp0pJHU+ElDGnAe4zbCj65qtzWXG6+uonpglD+RWnHdwXdJDYQATPKnj/sCSbA3m0af35+Kdqlz7lkFrx/EFCPPkSdIxg32tmnXXYOqGa0IjIW/MVNDXlcEKlCiXZATXjmB/dxAMtK868S5UxW2R97NrKU7nuaIq5TSTrfeyZihqP5SlKk9xwBE2PvJT2sqwiYAJrVMc/snp/4zpIfHfgXqwei+B13M2e1kyrhJqwEnDLCcuNdFY99k28DKmlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MWHPR1101MB2285.namprd11.prod.outlook.com (2603:10b6:301:57::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Thu, 13 Jan 2022 02:47:04 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%8]) with mapi id 15.20.4867.011; Thu, 13 Jan 2022 02:47:04 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Gao, Liming" , "Dong, Eric" , "Tan, Ming" , "Chiu, Chasel" , "Bi, Dandan" , "Shindo, Miki" , "Abbas, Mohamed" , "KARPAGAVINAYAGAM, MANICKAVASAKAM" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature build consistency Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature build consistency Thread-Index: AQHYB1sISarRaTwIlUi+MdpsUKVHSKxgJu7A Date: Thu, 13 Jan 2022 02:47:03 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b3aefa8f-746b-4178-e97f-08d9d63efb45 x-ms-traffictypediagnostic: MWHPR1101MB2285:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d6O1iya9m4oxaQR0XHdVBx/fYVnip3jR+8oFlYfc0UE8LVafv/1VFj7aMJhwgmtkwrzB46nWfA8kJdu4ieFkNLW07OvE6JdpCxAGq4BiO+ndEHnKoj3/WDtxyzC7VvIl9PZlhOSEd1V7PPFNiwV/dOiEe62j7cTgU+LoBLw+FWb+bZPlXzASeY8DQqoFedD3FKeOfQ7ldOsJtdkWEN8QRcgdXMFusniPWcYgmaz/1QDOtI21lFHEoAAbAnO+PudKl+5BV3Y0O7mpg8pzNioqIcsqh7Qy5dsg0z3gKgbM3Fo7ZYNfBivnslL6KYwkTCq8/4AqNSUvne2YedaR1Qc07gVXegmwH/OvlaU1GfdgO3o3+GGWolgdoVPw1gMENS9yeZ07gdKjI8QXBmYAh1MEP+RyTMJMZ6MbAd0z9Y735Wma/EvqmYJzrUslTRK5KvApm7+EL85Y2qcBpOjhGS78ylSZQoyd0QzWS9c5oONepkv3Yolw9p41QJPFliNa0fMc2IfQhLgJLTgDZOGMt7lE7K0xrHxcoHfd/NiT/6GYINKmshILrPfx+AXYsUMK2YKHdqjSB1DcXc5ezoqISY0jOUjn96YrGZWz+/JsXYnjLGGJiccozYl9wjpj3nzDH4L50JKE62TKLy/jdQVIw7QHZafs/f0pY+y1BcaaDOUEeJjX3yq2AEeRRn6QsrVxljJHBmYciesZMu9XQJLqr25MUQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66556008)(110136005)(55016003)(7696005)(66946007)(66476007)(54906003)(64756008)(76116006)(66446008)(6506007)(316002)(71200400001)(8676002)(83380400001)(38070700005)(2906002)(5660300002)(38100700002)(33656002)(53546011)(82960400001)(19627235002)(86362001)(52536014)(9686003)(26005)(30864003)(186003)(508600001)(122000001)(4326008)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?//Po6ZiTHHDAykWoRinCWo934atjlLvxgrGqoEVVlgivQT6L3sKaBqt5G0i7?= =?us-ascii?Q?7pcn1NKXQp8XlgXXm5PpBjotMILU9GYUJjZ7eR4VKZ/3uIcAtncaRLguFFtG?= =?us-ascii?Q?4x+1/Gm9TCoRUzlDvv1x1BcGpXjMP7zCcNx1xAzudZgEZs8ucVBW8vATsai6?= =?us-ascii?Q?nOCKVloR7FzhbC4Xc+OLOs3n6NuHfXVak3OYt6oKCNEVkG1BD0dqX3vm1n1l?= =?us-ascii?Q?y/RRcehZVfaZg2II5G97zui0pjk9s/5i12+EjndSZfefEFhXjahUyip5gJO0?= =?us-ascii?Q?CCcMgxV/y7LUvZ05/aVWwy3hTjb3VdeGTZNJwjCElmW0vhgaR82PvcHBLZbA?= =?us-ascii?Q?2aAIXeZQg1NFuLTy0Tpxb621K/yrtBJhI964wIIFxL+zvC6gdqZlxRBkkiy4?= =?us-ascii?Q?MtBs66JRGl1/F2Qr6+KvN/PvUabqIxqwfDbM25SO2QnZW+tDK+GPljiIzA/y?= =?us-ascii?Q?Wltho4YWOaUsb92rW2D86YPGWIVfpBQ43ZFz7JxfAGdzz6+2geq/rbGY8kwB?= =?us-ascii?Q?cz5tkvTmGjZ3zWOGGuXiLpiaIM6j38MQxMoMNOvI/FWIeL2MSXGgdZ9LWzPj?= =?us-ascii?Q?7+rzrqA2su9P3/UL1CrJypaSfFmGM5om+4xhIrckGGRgp7Ra4J0CAz7engVj?= =?us-ascii?Q?bqUPWVkUkxtQsBUvvEnpurlspr67Rrr35LC9b+9i8itdSDy3wqaERCyt+jya?= =?us-ascii?Q?LXxh9sGclwyu7w0ZE/O/5X/Gfjgovj7kqXPTmYkYX+nb65IRRI74gg2obNWB?= =?us-ascii?Q?2SIFe9aJvnpvYQsM0AGAZTOcB+rU66l28bIacRHUgKCCB4ThraXfWF/6Rl9Y?= =?us-ascii?Q?y9tKW/pDTbpOTGf2r7Egmw+qpEotxH7yCE7XIjxErY12KPAT+lp2mwkBsyHF?= =?us-ascii?Q?WNyV1rP7Q2AZ+FwmgJOu9NILz3kCwY5MXQGHp/u3o0s0I8iWB25q7SDnapil?= =?us-ascii?Q?stfmLj+qXnbC7X/hjr2iTiQYFbX5KHR6TDCH3bcovQVfeFw2YlRv/B3z4W3Z?= =?us-ascii?Q?0jZt1ef3pB+h6TjQzmvdRrieToY1xwWlTDHyWkP2FZd1BwYn4WVkmnJsx08h?= =?us-ascii?Q?uRMvtgu/DFr5awLu0WKA6IFJhFAhvJwRiZtE6+boSHCJOFwla4dGG3r+8oov?= =?us-ascii?Q?coR6OXYmJuPyWt6FD5+WYd8ZIjRYTngX4kB/byhENALSpIcbHkxhS2rRNMOk?= =?us-ascii?Q?tyLXsoXjtqemzv6OhnrDIEhj+aCY7KsOjSgn+5BNz2K6c/RMDGfvWGvSooQ9?= =?us-ascii?Q?lS0+ANgSGDdiSBPKiF8238X8ewVdg+qjJ34EdFgImWxTl+9M1HJye3iS/Ueg?= =?us-ascii?Q?chs4sP2gXpxdod7YzANrswTDCgrYhgwiYuEm0OyV2a3r+KJRQl4VCu5Iqskj?= =?us-ascii?Q?/5vgBdg6VnZzOseATI8Bkf69+SOxFN0YLwJbz1q8LNiKMFYX8L36y48wKnBD?= =?us-ascii?Q?q7bjUFO/AmYganwh+8tQF+GyApO9I+Cl2IVbZIfKPO2VbKzZkkExJGQhR49V?= =?us-ascii?Q?5R8uh0vXac6DaXlEe/+/VMsRH1d4ND0ATd9km0tt4BRZOxeotCzfeu+Buu+l?= =?us-ascii?Q?SZgXaAKlAvZF/xr8meWej7SFez3AUEWs7iqjEFdqU0OjwPAL+bsn46YHisgr?= =?us-ascii?Q?649ufEyY9Fx200onL0+tAZHWQzPgjr44TN+NmbYjFYJIV62KImHPoTpPDMg8?= =?us-ascii?Q?roTobA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3aefa8f-746b-4178-e97f-08d9d63efb45 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 02:47:04.0053 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Wvz0wMPKspPdB6VN5vAVTKK3rjE37hl/PXgxLxHzmO4ZSUOvaIFT86HypyPDYCd/HBZC3i/ivZDVYcp6oaYK/8SVjTfO85t6ZtEj+ofpaCk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2285 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Issac, Thank you for doing this cleanup work. I have some comments for you. I have= provided a summary of my feedback below: PATCH 01/27 * Features/Intel/Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc Line 69: [Components.IA32] should be changed to [Components.$(PEI_ARCH)] Line 83: [Components.X64] should be changed to [Components.$(DXE_ARCH)] Note: These comments can also be addressed by restoring the @todo comment s= tating that these changes still need to be done (which you deleted.) PATCH 18/27 * Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc Line 33: [PcdsFeatureFlag.X64] should be changed to [PcdsFeatureFlag.$(DXE_= ARCH)] Note: This comment can also be addressed by adding a @todo comment stating = that this change still needs to be done. PATCH 19/27 * Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc Line 35: Typo here. Usb3DebugPortParamLibo should be Usb3DebugPortParamLib. * Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dsc Line 40: Did you test compilation for the Usb3DebugFeaturePkg? I've general= ly run into issues when a components sections does not specify a machine ar= chitecture through some sort of means. PATCH 26/27 Since FvAdvanced is post-memory and not covered by the boot guard IBB, I su= spect we should probably also support optional signing of that FV. Thanks, Nate -----Original Message----- From: Oram, Isaac W =20 Sent: Tuesday, January 11, 2022 6:20 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Gao, Liming ; Dong, Eric <= eric.dong@intel.com>; Tan, Ming ; Desimone, Nathaniel L= ; Chiu, Chasel ; Bi= , Dandan ; Shindo, Miki ; Abbas= , Mohamed ; KARPAGAVINAYAGAM, MANICKAVASAKAM Subject: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature build= consistency This series addresses inconsistencies in feature implementation and use. So= me inconsistencies are just conventions of the feature design/template/conv= ention. Some are inconsistency with feature design intent that negatively = affect the usability of the features and the amount of work required from b= oard porting engineers. Some features were missing feature enable flags. Some features had non-functional standalone builds. Many features were implemented to include common core build content in thei= r feature include files. Updated some of the Readme content. Added AdvancedFeaturePkg.fdf to build all feature content to support verify= ing no build time issues between features. Removed duplicate and unused content from build files. Modified the TemplateFeaturePkg to use the common MinPlatform include conte= nt. Removed all instances where features were relative to Features/Intel and ma= de them relative to the package roots. This does mean PACKAGES_PATH may need to be extended for all the feature do= mains. Debugging, PowerManagement, etc. However, it should enable packaging tools to function properly as the relat= ive paths violate spec. Use of the common MinPlatformPkg build includes does increase the build tim= e for each individual feature in standalone build modes. It does not negati= vely impact board or AdvancedFeaturePkg builds as the common content is onl= y built once. Part of MinPlatform arch intent is to reduce cognitive comple= xity, so the simpler build is more valuable than fast build time. Cc: Sai Chaganty Cc: Liming Gao Cc: Eric Dong Cc: Ming Tan Cc: Nate DeSimone Cc: Chasel Chiu Cc: Dandan Bi Cc: Miki Shindo Cc: Mohamed Abbas Cc: Manickavasakam Karpagavinayagam Signed-off-by: Isaac Oram Isaac Oram (27): BeepDebugFeaturePkg: Use MinPlatformPkg build include files BeepDebugFeaturePkg: Fix all relative package paths AcpiDebugFeaturePkg: Fix all relative package paths IpmiFeaturePkg: Fix all relative package paths IpmiFeaturePkg: Fix build errors S3FeaturePkg: Fix all relative package paths S3FeaturePkg: Use MinPlatformPkg build include files SmbiosFeaturePkg: Fix all relative package paths SmbiosFeaturePkg: Use MinPlatformPkg build include files UserAuthFeaturePkg: Fix all relative package paths UserAuthFeaturePkg: Use MinPlatformPkg build include files VirtualKeyboardFeaturePkg: Fix all relative package paths VirtualKeyboardFeaturePkg: Use MinPlatformPkg build include files VirtualKeyboardFeaturePkg: Add feature enable PCD NetworkFeaturePkg: Use MinPlatformPkg build include files LogoFeaturePkg: Use MinPlatformPkg build include files PostCodeDebugFeaturePkg: Complete as an advanced feature AcpiDebugFeaturePkg: Use MinPlatformPkg build include files Usb3DebugFeaturePkg: Align with feature design guidelines SpcrFeaturePkg: Use MinPlatform build include files TemplateFeaturePkg: Use MinPlatform build include files AdvancedFeaturePkg: Fix all relative package paths AdvancedFeaturePkg: Add missing features MinPlatformPkg/Build: Add an include file for the common SPI FV info WhitleyOpenBoardPkg/Build: Use common SPI FV Header include AdvancedFeaturePkg/Build: Add FDF to create FV for all features WhitleyOpenBoardPkg/Build: Enable Features/Intel features Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc = | 67 +++++- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.fdf = | 49 +++++ Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc = | 49 +++-- Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc = | 64 +++++- Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf = | 49 +++-- Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf = | 49 +++-- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.= inf | 2 +- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.= inf | 2 +- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec = | 2 +- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc = | 21 ++ Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc = | 74 +------ Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf = | 4 +- Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dec = | 7 +- Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dsc = | 28 +++ Features/Intel/Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc = | 222 ++++++------------- Features/Intel/Debugging/BeepDebugFeaturePkg/Include/Library/BeepLib.h = | 6 +- Features/Intel/Debugging/BeepDebugFeaturePkg/Include/PostMemory.fdf = | 14 ++ Features/Intel/Debugging/BeepDebugFeaturePkg/Include/PreMemory.fdf = | 13 ++ Features/Intel/Debugging/BeepDebugFeaturePkg/Library/BeepStatusCodeHandler= Lib/PeiBeepStatusCodeHandlerLib.inf | 5 +- Features/Intel/Debugging/BeepDebugFeaturePkg/Library/BeepStatusCodeHandler= Lib/RuntimeDxeBeepStatusCodeHandlerLib.inf | 3 - Features/Intel/Debugging/BeepDebugFeaturePkg/Library/BeepStatusCodeHandler= Lib/SmmBeepStatusCodeHandlerLib.inf | 3 - Features/Intel/Debugging/BeepDebugFeaturePkg/Readme.md = | 91 +++++--- Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PostCodeDebugFeat= ure.dsc | 231 +++++--------------- Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PostMemory.fdf = | 14 ++ Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PreMemory.fdf = | 13 ++ Features/Intel/Debugging/PostCodeDebugFeaturePkg/Library/PostCodeStatusCod= eHandlerLib/PeiPostCodeStatusCodeHandlerLib.inf | 2 +- Features/Intel/Debugging/PostCodeDebugFeaturePkg/PostCodeDebugFeaturePkg.d= ec | 11 + Features/Intel/Debugging/PostCodeDebugFeaturePkg/PostCodeDebugFeaturePkg.d= sc | 30 +++ Features/Intel/Debugging/PostCodeDebugFeaturePkg/Readme.md = | 31 ++- Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc = | 131 ++--------- Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md = | 50 +++-- Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec = | 14 +- Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dsc = | 18 ++ Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc = | 89 +------- Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dsc = | 18 ++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/GenericI= pmi.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGener= icIpmi.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGener= icIpmi.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc = | 90 ++------ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf = | 16 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf = | 6 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc = | 18 ++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.inf= | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.inf= | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/Ipmi= BaseLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLibNull/= IpmiBaseLibNull.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/I= pmiCommandLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiPlatformHook= LibNull/IpmiPlatformHookLibNull.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseLib/P= eiIpmiBaseLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/S= mmIpmiBaseLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStatus.inf = | 2 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/SpcrDevi= ceLib.h | 2 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PostMemory.fdf = | 13 ++ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMemory.fdf = | 11 + Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc = | 62 ------ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md = | 12 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dec = | 6 + Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dsc = | 18 ++ Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf = | 2 +- Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc = | 74 +------ Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc = | 18 ++ Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf = | 2 +- Features/Intel/Readme.md = | 49 +++-- Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemory.fdf = | 2 +- Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.ds= c | 54 +---- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBas= icDxe.inf | 2 +- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec = | 10 +- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dsc = | 18 ++ Features/Intel/TemplateFeaturePkg/Include/TemplateFeature.dsc = | 2 +- Features/Intel/TemplateFeaturePkg/TemplateFeaturePkg.dsc = | 18 ++ Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc = | 69 +----- Features/Intel/UserInterface/LogoFeaturePkg/LogoFeaturePkg.dec = | 2 - Features/Intel/UserInterface/LogoFeaturePkg/LogoFeaturePkg.dsc = | 38 +++- Features/Intel/UserInterface/UserAuthFeaturePkg/Include/PostMemory.fdf = | 6 +- Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.ds= c | 92 +------- Features/Intel/UserInterface/UserAuthFeaturePkg/Library/PlatformPasswordLi= bNull/PlatformPasswordLibNull.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/Library/UserPasswordLib/Us= erPasswordLib.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/Library/UserPasswordUiLib/= UserPasswordUiLib.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dsc = | 18 ++ Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/U= serAuthentication2Dxe.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/U= serAuthenticationDxe.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/U= serAuthenticationSmm.inf | 2 +- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/PostMemory.= fdf | 2 +- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/VirtualKeyb= oardFeature.dsc | 64 +----- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardFeat= urePkg.dec | 7 +- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardFeat= urePkg.dsc | 18 ++ Platform/Intel/{WhitleyOpenBoardPkg =3D> MinPlatformPkg}/Include/Fdf/Commo= nSpiFvHeaderInfo.fdf | 2 +- Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.fdf = | 48 ++-- Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc = | 44 ++++ Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf = | 54 ++--- 96 files changed, 1159 insertions(+), 1334 deletions(-) create mode 10064= 4 Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.fdf create mode 100644 Features/Intel/Debugging/BeepDebugFeaturePkg/Include/Po= stMemory.fdf create mode 100644 Features/Intel/Debugging/BeepDebugFeaturePkg/Include/Pr= eMemory.fdf create mode 100644 Features/Intel/Debugging/PostCodeDebugFeaturePkg/Includ= e/PostMemory.fdf create mode 100644 Features/Intel/Debugging/PostCodeDebugFeaturePkg/Includ= e/PreMemory.fdf create mode 100644 Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Inclu= de/PostMemory.fdf create mode 100644 Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Inclu= de/PreMemory.fdf rename Platform/Intel/{WhitleyOpenBoardPkg =3D> MinPlatformPkg}/Include/Fd= f/CommonSpiFvHeaderInfo.fdf (88%) -- 2.27.0.windows.1