From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web10.488.1662764964247313999 for ; Fri, 09 Sep 2022 16:09:24 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=XP7b76Cv; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662764964; x=1694300964; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=QR2p3slPm4Y+ANtVFMBgpN8wpD8GNacJYbbtDKNaFxk=; b=XP7b76Cv9DaxsbC+r9nC+RVZiBgkKKswX+VcTzmmKO9t78WEupwohJUX aA8CgTnfOsHPZmXV5QXk53RQTh2kno2XldjF9ss8Z22FjPrFZLOyli/H/ s0yN+YSYyMAoEhaYryieq+v6RFUpodICN1vm9AFdQ6jh7oEwhflHbapfi Yi1ZIJ8Eghu/StnsZL2oq2bdhwUb80lS2vbLdWrDvkapn5aXd/YwPSBE0 cqJaYvSjVyHFl3vDW/U4TZId+M3o4ttnJDwGMUU5/thIZId0UE3RoUAVB VQ8yEqoYqXrAaUQYoM3BEFkGUUsud64i+e4Yq5PsUkIyDl5aBGvAMgKzJ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10465"; a="298924044" X-IronPort-AV: E=Sophos;i="5.93,304,1654585200"; d="scan'208";a="298924044" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2022 16:09:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,304,1654585200"; d="scan'208";a="566529224" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 09 Sep 2022 16:09:23 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 16:09:23 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 9 Sep 2022 16:09:22 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 9 Sep 2022 16:09:22 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 9 Sep 2022 16:09:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hMCRq7hl00ezcCkiCkaCxa/pnuytVal4+ZRUiuVq54/UqQpeYIqoPS3jusbA/Io3tKG8QxXrjF9XWKgglno8D+yOmvIXRzY2D4vOnZYAqn223AFzZ+TUqtdK/GO0mehqljkek60/HbUz8Lj3h3BUjXr/XVCbpM24rVa66Vw58fGv8Gmcv14mKoAarwpRA1t0fs6FOkeZZHsilNecxc3MTjKEXVIfl/FGvqeNO78LcZElCAE8jFXo8zm41jHC/pcaMPz1HqMgubJr44SWHw2oNC555V1h/wsIMpFzoCY/eFobeu621N5PzeM6NlmyIwhjMey4cm0mJqcZfkbqB/JUgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F59IYAOYP0m7LOzK4D0DorhNQ51/0+HH3Zof09PwH3U=; b=ifAQbuq0/dGYUxq111hXdw80XlGYlCCptqmm+SDGa4mc9hpfodRwQnagHZ2hvkX+2ECjNPqIjKEb3T88YmndJttKJ3oVnNiNfUIJoHOJT10Pt9gS8BQdYODF4ybc/9P/oejdSjF2iQyHGfp6ldlRKilS6E3zNM8DmMhSTayYhDDlaapwNzLnCygel4BLDcB7LJx/LszBpmNLEQlREPIjovqrc/W/TL6A/zDm3YKTK7yIvtX3/ic/utI/6ZV0xC+vipsRFbDYcP0qlbYJ+cSrjVCaslAe1DGiSG/xCmAk6pvaRrk6D2Jtm/VtdiqA50C18o5i7thEpnwWfFnO0sF5MA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by BL1PR11MB5367.namprd11.prod.outlook.com (2603:10b6:208:318::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Fri, 9 Sep 2022 23:09:17 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2c94:f950:2ac4:d92f]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2c94:f950:2ac4:d92f%8]) with mapi id 15.20.5588.014; Fri, 9 Sep 2022 23:09:17 +0000 From: "Nate DeSimone" To: Benjamin Doron , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Oram, Isaac W" , "Sinha, Ankit" , "Chiu, Chasel" , "Gao, Liming" , "Dong, Eric" Subject: Re: [edk2-devel][edk2-platforms][PATCH v1 1/3] MinPlatformPkg,WhiskeylakeOpenBoardPkg/SecFspWrapperPlatformSecLib: First BoardInitLib Thread-Topic: [edk2-devel][edk2-platforms][PATCH v1 1/3] MinPlatformPkg,WhiskeylakeOpenBoardPkg/SecFspWrapperPlatformSecLib: First BoardInitLib Thread-Index: AQHYwhX1ikB1BniCBke6tZtuaG89kK3XsBWw Date: Fri, 9 Sep 2022 23:09:17 +0000 Message-ID: References: <0a6dd32438d554e03fa222a70593f7a99cfc19d1.1662484082.git.benjamin.doron00@gmail.com> In-Reply-To: <0a6dd32438d554e03fa222a70593f7a99cfc19d1.1662484082.git.benjamin.doron00@gmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7c0b327b-a01e-4adf-8b1a-08da92b851f5 x-ms-traffictypediagnostic: BL1PR11MB5367:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N0RROTYjpoACfCgvokkTeOBl+U4j9AliG+Akbv4Ewn2STmfyaonjCCk5tAJnFc8tflejHUtAe0PJABrZ3fSs+hdaIiW6HVtwKaLHNqwVCj1IZcJFbZZ72WgLC0ADmhuEp4LT3fKxDaVfxsh9A7drRGhkwPS8Kfqgr+PIWyFwPw1MQetComO+NMGFR9paCNpWbsWkeQRBXruBI2flRuLRx/xcOUAKQD4xipCbgp1Zst1DGCpTqrl1XPbmE5MLs/ZEkx+0N9BxEYScXr+ylL/XdGQ82nYLDfLt9KqMNC3yO83J3MmjKUh0yaGv+tfs6fcENcq44XPTudqPuUg5LU5CahRUfxAEbz1B6s+hl4Tg/bere2gHZ/I+2XwNas7zgYO9bVwjOghODqsms5DQkKp9E4gaTleCUkzah1vUhiI0D3TqHLgvyk92rm/fn3twDATvNodLgXNznEgJQuEmCZtrUkRjKSE4KpKtxKhRWdPLpIUbSnyWzQ0oJxt25l3xmTGmoMsNTU/NF0KPIVC2hF2l5FECkjNbRxnRXXLKdUmJ34Y/CbhXl2AevWdgzu+r3J1xaqvN+eheJcsVCqeMt0GMUNytKzhu1SriNv59wp6Wm2AY3oobLfV/gV+jZ99H1siSrE3EfVNxhGEL2LGvYyyfAmzZhUCu9U8qoo6hschuppwMZceKHrYwJAFC+nVRcj9Rs4YdUzhx2NrELMWBp5nv0klbCzTVM1SkXVCI7tgYxbi1W1AiqCLG2Lw+aIWhBaEcQiiagfA1Y7EkQZnOCbfs+OagY0q4p1o/7IbXg7LyCwQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(376002)(366004)(346002)(136003)(54906003)(26005)(83380400001)(110136005)(53546011)(7696005)(107886003)(478600001)(9686003)(19627235002)(316002)(186003)(33656002)(6506007)(76116006)(86362001)(4326008)(66446008)(66946007)(66556008)(64756008)(8676002)(66476007)(55016003)(52536014)(2906002)(5660300002)(8936002)(71200400001)(38070700005)(82960400001)(41300700001)(122000001)(38100700002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tUHY+4YBL+i4jlQQxsWpWEXzXOyck3okiO6vVYv+pea/C/i0eDJWh9yVKeuR?= =?us-ascii?Q?uJvdKnaJB3dHU4pm2uRuXV0Qy5bbTchH40gLhkLrsD9r5WY+w0f8VlFRVaDI?= =?us-ascii?Q?z+6ANH4H7QY1NIvnJJCHxnpGTKUmSy1f7fAJOB9JsXRdfi/33qxbgXIZV/L/?= =?us-ascii?Q?D6treY+LdM/HvvQpq36shODfY6yjW8e+TnJxsq0JiCNULNz2yZoE/iQq/Cfn?= =?us-ascii?Q?9INJo0ciqHqIBUMMGmM29vLWZqmgdXv8QwbP1EiAcj7+Osg9RrXHo5csrHht?= =?us-ascii?Q?gP88EEJNWlCgppFTlBRD8bdubCHL7K2IjoCjqVco/3YmOQGvQr8/eir9KGxQ?= =?us-ascii?Q?Xsz5VM8SyIh/qBXCQJ90XGs1Y1nSA06Zeai6keroptNLGa3TYxNQ/zw4GMZg?= =?us-ascii?Q?njQOuy8L0ubhwMjgga3uM3SnYsE/2wNJdS5XsdnLVLiedffZqtK7YJuGxGF/?= =?us-ascii?Q?9wGoeQmISeamRRii3dP+y7DLLe2Hhl9vI5+ynz2fJeAJdZ2/XiIC8+KaKrB2?= =?us-ascii?Q?LKAUVhS1/jovm9RWSy/q3g+9xuLOSbSJMCeDYgdVvyUFguHpn3/xGqloNN5d?= =?us-ascii?Q?8i9udJYDX3p4+6KsBnuuKjVaf1Cz/I1JENBiCzQo8Bj+QYk+KTMG9a3K6LZ6?= =?us-ascii?Q?iXTFe3PKxLMNe9vM7hGnPMakdtOlfpNyc+4boHp/5p6EUy7aCpNxurYpa2cs?= =?us-ascii?Q?JPiVFrOKMAZIiCCaTRPCuPAorcrCMzJhBnOlS8mI+Gwx0C4DHgjtZpdN/N5+?= =?us-ascii?Q?XTKVgmKlbjt4DJ5UnQwiHsojpyfaTIx8d07wymKQgWDUQHjzYWlGP6X//g/q?= =?us-ascii?Q?XX75U694IRfth9A/fQ1+raoQ+781MV64m6aHCP2LOd/TdqFgQ/O+RNo7+DP5?= =?us-ascii?Q?zumEMEjQjPT1JnyDOClMh4TvbRF+08KGXfGrMZLEtVNzlknMUh6AfYOjDXjS?= =?us-ascii?Q?J5uGvkDXIWdUwT8dqmcGhaxYk87CZ8nVCrnwxQ3OdG7+hYuGbrFFy/Ze4E0M?= =?us-ascii?Q?60ecm7Fvt//iWLQjX++fYePSilKaFREwnyXXPwmduAHS9+wd0slNdxaf9ljC?= =?us-ascii?Q?UDAVdiJrTUL8Rbh/o/M0XtnHCboUCFkh/+rbqd42XSNQw90C0jvnqAL5JRfo?= =?us-ascii?Q?txEU/Su7EOuSQ5CtJ97zC7Wn949DuyEmqwS0XDJcfbxo2sXl6ZsW8xcBrGRV?= =?us-ascii?Q?HAUK50ta0pdRPtfGi6Q4jzLbg/aFBZTlrTxJyoljCzOe93RfRnSaCLa4r9gA?= =?us-ascii?Q?Hf4lZbPSseFjt+IEq0lZ6z6TV3vkua2DvP9TVh8qEJtwX0svLn5DVY6mXlZA?= =?us-ascii?Q?mh8Pta9vt3rtovO11L/OxwtGQnk1UD2SCLgGtfYyfoQkKNRRlwibd8MIi/1U?= =?us-ascii?Q?qHMYL6SD2D/p1JNUGno76Smz2lUGF70UlaitFb8m1MQzj4DIen1dRpedkAQQ?= =?us-ascii?Q?P1Pv1INZvzkKY6aqYejlbeiV3ac/jJBu8sToegZifI7exGSkyPoXCudNNz9G?= =?us-ascii?Q?STIQ22OUoIHxF1i/YGS33ivVyP8TYRJSMPAe7PhbS+dODlkILLdd3GIr3Dgw?= =?us-ascii?Q?GrXUfIu7IABBLMlnUtbuMyBM/MXTkzdWwitjK6HtgYIwrsimNtDYQpB09Rvk?= =?us-ascii?Q?bw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c0b327b-a01e-4adf-8b1a-08da92b851f5 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Sep 2022 23:09:17.2405 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 691J+644dPxLCwzEecDYCBT0MOGpQY6ztlkHk8bGh1GUFrwM6UE7CVl5zegkM9cm3kUnER18ZRxKRr648YP1tb8LuuKBJrWzoDzwVh2zauM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5367 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Benjamin Doron > Sent: Tuesday, September 6, 2022 10:27 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Oram, Isaac W > ; Desimone, Nathaniel L > ; Sinha, Ankit ; > Chiu, Chasel ; Gao, Liming > ; Dong, Eric > Subject: [edk2-devel][edk2-platforms][PATCH v1 1/3] > MinPlatformPkg,WhiskeylakeOpenBoardPkg/SecFspWrapperPlatformSecLib: > First BoardInitLib >=20 > SecBoardInitLib is called to enable serial port before SerialPortInitiali= ze and > DEBUG(). >=20 > This is strongly assumed to be necessary for I2cHdmiDebugSerialPortLib in > SEC phase, which presently initialises this way. >=20 > No testing was performed before, it's assumed too risky unless the GPIO > happens to have the desired default. Presently, DEBUG() works in SEC > phase. >=20 > Cc: Sai Chaganty > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Ankit Sinha > Cc: Chasel Chiu > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Benjamin Doron > --- > .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++-- > .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++-- > 2 files changed, 12 insertions(+), 4 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatf > ormSecLib/PlatformInit.c > b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatf > ormSecLib/PlatformInit.c > index ef89e3f31018..d74b07bc062b 100644 > --- > .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++-- > .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++-- > 2 files changed, 12 insertions(+), 4 deletions(-) >=20 > diff --git a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapp= erPlatformSecLib/PlatformInit.c b/Platform/Intel/MinPlatformPkg/FspWrapper/= Library/SecFspWrapperPlatformSecLib/PlatformInit.c > index ef89e3f31018..d74b07bc062b 100644 > --- a/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatf= ormSecLib/PlatformInit.c > +++ b/Platform/Intel/MinPlatformPkg/FspWrapper/Library/SecFspWrapperPlatf= ormSecLib/PlatformInit.c > @@ -28,6 +28,12 @@ PlatformInit ( > IN VOID *EndOfRange > ) > { > + // > + // Board/Silicon initialization > + // Prepare controllers before enabling serial port > + // > + BoardAfterTempRamInit (); > + > // > // Platform initialization > // Enable Serial port here > @@ -41,7 +47,5 @@ PlatformInit ( > DEBUG ((DEBUG_INFO, "StartOfRange - 0x%x\n", StartOfRange)); > DEBUG ((DEBUG_INFO, "EndOfRange - 0x%x\n", EndOfRange)); > =20 > - BoardAfterTempRamInit (); > - > TestPointTempMemoryFunction (StartOfRange, EndOfRange); > } > diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/L= ibrary/SecFspWrapperPlatformSecLib/PlatformInit.c b/Platform/Intel/Whiskeyl= akeOpenBoardPkg/UpXtreme/FspWrapper/Library/SecFspWrapperPlatformSecLib/Pla= tformInit.c > index 486c8c72616e..53f95c29bde5 100644 > --- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/= SecFspWrapperPlatformSecLib/PlatformInit.c > +++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/= SecFspWrapperPlatformSecLib/PlatformInit.c > @@ -28,6 +28,12 @@ PlatformInit ( > IN VOID *EndOfRange > ) > { > + // > + // Board/Silicon initialization > + // Prepare controllers before enabling serial port > + // > + BoardAfterTempRamInit (); > + > // > // Platform initialization > // Enable Serial port here > @@ -41,7 +47,5 @@ PlatformInit ( > DEBUG ((DEBUG_INFO, "StartOfRange - 0x%x\n", StartOfRange)); > DEBUG ((DEBUG_INFO, "EndOfRange - 0x%x\n", EndOfRange)); > =20 > - BoardAfterTempRamInit (); > - > TestPointTempMemoryFunction (StartOfRange, EndOfRange); > } > --=20 > 2.37.2