From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.1030.1634949129740481713 for ; Fri, 22 Oct 2021 17:32:10 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=vg1CT4i/; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10145"; a="216330286" X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="216330286" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 17:32:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,173,1631602800"; d="scan'208";a="535286020" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga008.fm.intel.com with ESMTP; 22 Oct 2021 17:32:08 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 17:32:08 -0700 Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 17:32:08 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 22 Oct 2021 17:32:08 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 22 Oct 2021 17:32:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jREzYyqnJfHD8xkuj81/eeNBoOBAnXPpbRaDQoSrOONMNzwgp2wEQ2JMvUe5QeMVEb4gecr2Dg/ho9HNMX0UChXlnvfTK0q04ezDwbuAUtwTuWtLd+0ORbo4QxbpS8sSCUuwowHT2BNCX9l5/YSZ/8JHIGCg8o7wIw5x20wjAnXQ3T1QXbgWbAsC7mYnreuoebn5aPL0SCJLSdZ/KiE9wkjsgK/gX1MF0deMc68PHBk/Vojk7WhxlVAFf4uJsmEQT8JrhI92l5lQnJnKDC96sl3XOj1Qrt1g8Y77UNKBzOc9bl8oqC48Sohn04YF5wz6v3NJ3pcVZCuV341TeGiKTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I0WKHNKETHWyvCWLuTHwDUi/Wqivl1c1JW+L/i6hRRk=; b=ZBHbOav4rdPA+GqBwxRnfsZOvjA5SYF2uS+92Ik6X/koD+ISH18U67Gn/w6upZYe3f8lZWcTybCPJCBAKtm4985BjxnkaucxMBzGDxyBE1dwaYt7C+BsrcopHUwzNbAx4rLqDpCrLHk+woZOzBtP5Av6eSugxk8vLdmjYSHVFHjV2DU45m62kSkgTZ4piB1Pf32b27QX/8sgAW3MevDWYBGkJ0TFXVqonVzn4JKbbCJDd+huAeYUIZxyVKj9G0ovqHxKJE/vQ+JquOyh9I0S5WOIY/GPleuUMf6kYtE0jdZOqjVAe+wdmF362wz1gGKtEdSED+PBFvBVxKk6NebErA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I0WKHNKETHWyvCWLuTHwDUi/Wqivl1c1JW+L/i6hRRk=; b=vg1CT4i/SKVUh8I1uMl9znmkFrgnQ7H4W6k2F2z65WSHqMJx18pfXzIjwW3hZxE6p2E9o7OkDcLxG/InRikULb7t3AzlwYpZUzFdiparAdHw+bUYeFcF4ry6NlDwGq40kFIAexMx9ZCiRtNnNme03Jt8tiNhyFklzWRZLRWHmys= Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MW4PR11MB5824.namprd11.prod.outlook.com (2603:10b6:303:187::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Sat, 23 Oct 2021 00:32:07 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46%9]) with mapi id 15.20.4628.018; Sat, 23 Oct 2021 00:32:07 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , Liming Gao , "Dong, Eric" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 10/11] MinPlatformPkg/SpiFvbService: Reduce duplicate code Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 10/11] MinPlatformPkg/SpiFvbService: Reduce duplicate code Thread-Index: AQHXwgs9sXSRURzxsUSkeRqFPFXIzavfv7xg Date: Sat, 23 Oct 2021 00:32:07 +0000 Message-ID: References: <9db0b794a840f862b848c99167b83f2633200ed8.1634331939.git.isaac.w.oram@intel.com> In-Reply-To: <9db0b794a840f862b848c99167b83f2633200ed8.1634331939.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f3a4de3d-0e8e-4dbe-0274-08d995bc8b3a x-ms-traffictypediagnostic: MW4PR11MB5824: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BySwVQZ6+LCAwUiLs/xbU5ApYGM6atpPPVaPqaHvLS6MxVmrqZJ0FN3ABMssy4ZsYOl41FQ7seIav5/iFczyjMNNpp5zCK6RSCVo4nBuOFpdJDAapCI8HDjknm7JBMvDxtBHMsxUk3pkUBCUDOtFFsWnf/95gXs+zj0yjTDeC9RgN9BupMTKU+77Cm/U09suROk7Q4PHbx+UkWVtd0XXkNQcGabEdboLmp6waH7qypW/sRpstmeRqjyDVOwiJ7WoH/EovK1P60+Y3MA+a3MQ+kpYwkkYrP3MxSgDtSu1E34smBE2WTGUocjBHL8FinLND9c/3IqZTr0CYRdvNX2itz/IMghd924+TYzlTv/tbzMnH5zyuxTj12oi0yYxK0CoeL/jQvdhYaEbVgdv89oN+G6e0F8ySpcJ6S5oxwNj1u+TFznvgy6Ry5XHOX06QOCbR7b9EQ4720x1Zv0X8Y6rreH9S2AQTA8ip0mZ+JXn9zteUfDZ988CQMDJwU3GWyu57Udp9I7JJA52pprAQYhNQ43A+ghPRMbyCXYEzaKE1NzlIVpKqtyhh4A8F828lpLhuQDqwIw+HMFYvFGzAqj19m36VdX67NHdxqgQdHI4vqB00PWCYGNaEZGtjhMbl9/j0EhO8XMJkAv3WLcsyL5VEPpj4NuCPNdooTLqrpw6TP97o7iIvG5hntd70+Hb2konWKpRBmeCYYoydu4nr7yi4w== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66946007)(66476007)(66556008)(64756008)(52536014)(66446008)(26005)(186003)(6506007)(53546011)(71200400001)(76116006)(8936002)(8676002)(107886003)(508600001)(4326008)(45080400002)(54906003)(38100700002)(110136005)(33656002)(55016002)(83380400001)(9686003)(5660300002)(86362001)(316002)(2906002)(82960400001)(7696005)(38070700005)(122000001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wLd9kQK9ltRqb/5XKFUmgc/iHAVBEXWvKnB39CUBDL7nlDi1Ly8MbTNLVTfK?= =?us-ascii?Q?CiKLxDwH+LQCAOn97+mQWqt9U2ryNWBeWuTHmj6V09juhXFLz9/yXpd7IOGI?= =?us-ascii?Q?972At0qFSCDFHAlwUY0EBuhUeR42sAtvlE+31Vzx5UakfLjeQ7KiUTBI5ST7?= =?us-ascii?Q?NQuWC/2DCM14+6NcMOERlSyd0fGsIK1Nxzb8QEP2VcvNngR2mi2/afNyjaSk?= =?us-ascii?Q?pXkM2lE7UTVvyCh2gEP5+3XbUwBDOwBYTYVZ+Il1Md0qoc6rLnszp6fEgh6V?= =?us-ascii?Q?uBxmIVmB3mUHDi8dvRFJb7aWW2PzwYTluN2yLBqg+1rc1MYQZ+dLbO67yJrD?= =?us-ascii?Q?x1XrAo5VEFWrBV9T8bPKefH0yQRgD230b2rxs9cpr6I0zopAjtXGIu5AbQm4?= =?us-ascii?Q?6ie1caXMSa1vJc01qIb2fVMcH48tizhJp1AZhiPV4Yp2BD/oCaz86zCTKAGb?= =?us-ascii?Q?19GER+Y7WYfHejH2cibHDwyAhEt2zFXXdnW04vH3/FCJwInjxUYcpVYR8ve5?= =?us-ascii?Q?W3vVbczeyVATviNSPMhgWF2OpaKz+1bXj2r4HNe6VS2EBbxNoqGBmfD5GUBc?= =?us-ascii?Q?pPsS5uG0pfkeXPX/lpQfFPjkbkHOJGXNEuNUUH4JDGExgXPDsEtKMVrbYQkl?= =?us-ascii?Q?G9YalRd/zm28bIQitpl0TuR5XMBjRiBbZKIw6rqow0N9Ds/FAzKnAhMvGDMI?= =?us-ascii?Q?2gf+mURkP448PBnl0CkI2a02YOBE6LdRbJN+jamnjkW6SMImw7nELxambwg9?= =?us-ascii?Q?vaafeq94kep0nysgTjIawUjBQ1Pz3rbGWgnf9kctGs6st/t0DLX5wuL7ASBR?= =?us-ascii?Q?AKM64oepOjhnh+GUAetS7oGdMthP6dUVfQALyBudHrwDFp3D2UK1IufTerMb?= =?us-ascii?Q?+rsTkXdx5jCnItEtNKvOB7e/xDzjEG/dawpRJvBYy7/0FWBM3iZjGdnIDXu3?= =?us-ascii?Q?rN5ioZrpSggmmIfsZbEfiBmpD6nEnLZVW99O2hV6V1BB1iNhzU8P/apGRGbh?= =?us-ascii?Q?jV0LJOGirrXbx4vjLgHVf1H7+3wZIU5hX/a7ibiFIEzVSkO8iWtEWzt6sRD4?= =?us-ascii?Q?HW9qBkb6p7hDL54XvKGoH81mIMwpwuS7EUSygLg0Ylm9NpfRiNdD6+LPWBZg?= =?us-ascii?Q?EraiyBGVemRk7qvrIiVI1NlcuPREwOOx8TXLAfQf4CdJNs4j0WIMJWwSsRvw?= =?us-ascii?Q?hHruzdi07pJIlbKsw7Xuz/VBKqJyoUBmCSxAcAGclvBwRDX1QsWJhSzc5HoU?= =?us-ascii?Q?xDVcs083S6VSMDlQUOJMp2oaFkvjyXdBIeRP0zl8sDO8m8zjAUamli9IZTUu?= =?us-ascii?Q?MH4j6ebijyyaK1xJq6kNO8kNHsTqJ7aic0O2yqVdyItJ9gQC+LXJqCWa3h5c?= =?us-ascii?Q?orpIxhLzPVy+TowdSJ8QmzANxHGd2dU6EKfHOgNfSSA4PII034vJ3IJldef4?= =?us-ascii?Q?kXMBK+h97VDNt0nBiUV6ebJ3bE6QEww6rQvvSj+FFpGkv2U9p4UhGbKGNrX0?= =?us-ascii?Q?nEHSxq72wEHjY2YE6weDHZC9/UPFxtVI1p4ZtfSudeV0HQm3scAEzFzpHxW9?= =?us-ascii?Q?YKd2pmm9SxzgkXssRQY8TgYbfmM1514HHMJtXptFgAWQ6G5W0FD7q0VeaHsI?= =?us-ascii?Q?FrNslPILsJugMMsPP8BsSABVnrN3FDNKVWT9eHucgGge4o5XK/rwLYmig6mM?= =?us-ascii?Q?7WgJLw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3a4de3d-0e8e-4dbe-0274-08d995bc8b3a X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2021 00:32:07.0885 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5j3CGoamu1KtJ9eVdWiaCdMQ2T4+jCJ7w5XRWQlL/ka3qVBuJmh85dC1xqy9uU5XDSC/oOOSwfk5U/+41dGUp0Zj38GYpdKY5YaWnFwhngo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5824 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Isaac, Please see feedback inline. Thanks, Nate > -----Original Message----- > From: Oram, Isaac W > Sent: Friday, October 15, 2021 2:26 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [edk2-devel][edk2-platforms][PATCH V1 10/11] > MinPlatformPkg/SpiFvbService: Reduce duplicate code >=20 > Consolidate all the entry point functions into SpiFvbServiceMm.c This > reduces the number of files and makes the code easier to understand. >=20 > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Liming Gao > Cc: Eric Dong > Signed-off-by: Isaac Oram > --- > Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceMm.c > | 42 ++++++++++++++++++++ > Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.inf > | 1 - >=20 > Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceStandalon > eMm.c | 32 --------------- >=20 > Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceStandalon > eMm.inf | 1 - > Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceTraditiona > lMm.c | 32 --------------- > 5 files changed, 42 insertions(+), 66 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceMm.c > b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceMm.c > index 1d8d55b8f2..cc9310023e 100644 > --- > a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceMm.c > +++ > b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceMm. > +++ c > @@ -278,3 +278,45 @@ FvbInitialize ( >=20 > return EFI_SUCCESS; > } > + > +/** > + The driver Traditional MM entry point. > + > + @param[in] ImageHandle Image handle of this driver. > + @param[in] SystemTable A pointer to the EFI system table. > + > + @retval EFI_SUCCESS This function always returns EFI_SUCCE= SS. > + > +**/ > +EFI_STATUS > +EFIAPI > +SpiFvbTraditionalMmInitialize ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_SYSTEM_TABLE *SystemTable > + ) > +{ > + FvbInitialize (); Now that FvbInitialize() returns an EFI_STATUS code. It would be good to ad= d a DEBUG print here in the case where an error is returned. I understand t= he hesitation to return it back to the core since this would not necessaril= y be a fatal error. > + > + return EFI_SUCCESS; > +} > + > +/** > + The driver Standalone MM entry point. > + > + @param[in] ImageHandle Image handle of this driver. > + @param[in] MmSystemTable A pointer to the MM system table. > + > + @retval EFI_SUCCESS This function always returns EFI_SUCCE= SS. > + > +**/ > +EFI_STATUS > +EFIAPI > +SpiFvbStandaloneMmInitialize ( > + IN EFI_HANDLE ImageHandle, > + IN EFI_MM_SYSTEM_TABLE *MmSystemTable > + ) > +{ > + FvbInitialize (); Now that FvbInitialize() returns an EFI_STATUS code. It would be good to ad= d a DEBUG print here in the case where an error is returned. I understand t= he hesitation to return it back to the core since this would not necessaril= y be a fatal error. > + > + return EFI_SUCCESS; > +} > diff --git > a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.in > f > b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.in > f > index 7b69bedcdc..600ad32d9f 100644 > --- > a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm.in > f > +++ > b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSmm > +++ .inf > @@ -55,7 +55,6 @@ > SpiFvbServiceCommon.c > SpiFvbServiceMm.h > SpiFvbServiceMm.c > - SpiFvbServiceTraditionalMm.c >=20 > [Protocols] > gEfiDevicePathProtocolGuid ## PRODUCES > diff --git > a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceStandal > oneMm.c > b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceStandal > oneMm.c > deleted file mode 100644 > index 252c818d65..0000000000 > --- > a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceStandal > oneMm.c > +++ /dev/null > @@ -1,32 +0,0 @@ > -/** @file > - MM driver source for several Serial Flash devices > - which are compliant with the Intel(R) Serial Flash Interface Compatibi= lity > Specification. > - > - Copyright (c) Microsoft Corporation.
> - SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#include "SpiFvbServiceCommon.h" > -#include "SpiFvbServiceMm.h" > - > -/** > - The driver Standalone MM entry point. > - > - @param[in] ImageHandle Image handle of this driver. > - @param[in] MmSystemTable A pointer to the MM system table. > - > - @retval EFI_SUCCESS This function always returns EFI_SUCCE= SS. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFvbStandaloneMmInitialize ( > - IN EFI_HANDLE ImageHandle, > - IN EFI_MM_SYSTEM_TABLE *MmSystemTable > - ) > -{ > - FvbInitialize (); > - > - return EFI_SUCCESS; > -} > diff --git > a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceStandal > oneMm.inf > b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceStandal > oneMm.inf > index 1dfb2520e7..4e056466a1 100644 > --- > a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceStandal > oneMm.inf > +++ b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceSta > +++ ndaloneMm.inf > @@ -54,7 +54,6 @@ > SpiFvbServiceCommon.c > SpiFvbServiceMm.h > SpiFvbServiceMm.c > - SpiFvbServiceStandaloneMm.c >=20 > [Protocols] > gEfiDevicePathProtocolGuid ## PRODUCES > diff --git > a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceTraditio > nalMm.c > b/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceTraditio > nalMm.c > deleted file mode 100644 > index 1c2dac70e3..0000000000 > --- > a/Platform/Intel/MinPlatformPkg/Flash/SpiFvbService/SpiFvbServiceTraditio > nalMm.c > +++ /dev/null > @@ -1,32 +0,0 @@ > -/** @file > - MM driver source for several Serial Flash devices > - which are compliant with the Intel(R) Serial Flash Interface Compatibi= lity > Specification. > - > - Copyright (c) Microsoft Corporation.
> - SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#include "SpiFvbServiceCommon.h" > -#include "SpiFvbServiceMm.h" > - > -/** > - The driver Traditional MM entry point. > - > - @param[in] ImageHandle Image handle of this driver. > - @param[in] SystemTable A pointer to the EFI system table. > - > - @retval EFI_SUCCESS This function always returns EFI_SUCCE= SS. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFvbTraditionalMmInitialize ( > - IN EFI_HANDLE ImageHandle, > - IN EFI_SYSTEM_TABLE *SystemTable > - ) > -{ > - FvbInitialize (); > - > - return EFI_SUCCESS; > -} > -- > 2.27.0.windows.1