From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.3893.1642042189133884065 for ; Wed, 12 Jan 2022 18:49:49 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=m4o+K5n2; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642042189; x=1673578189; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fCJMddJjCO3ZwhT8QY+SpDru2ENUpbRk4wEnmXEqtc8=; b=m4o+K5n2pQkXGvyXEbjgt0Hxd/NNohkGciC/cn57vO+GuQjZQuyjvm4s uI+/Tf08XRKVNdJpIQI0BTtCpEAF3RmL+nVknpowO1xQGpfAjJ992hnwd R261CEWZGM85jW9EICFm+y5e8Am62dEOlSDrdNyNnEND9MKXgsgHsiQk1 VouqaTFfBEZG2Nx3bWpWNwe+K/+v5H+5x1uc5X9LHTBBIYeuWbOzyIk8E lFwFIvKzfJa4ZSMvs5bec9k9GdcwnIA0Zd2LQfddHbz18Dg7BXobAuAbv qbb+q5kjZYXwJaXpUxDSH2dMyp4yweCcyaTkrPUDiQeNwnolxWC2TiT4U w==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="224604530" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="224604530" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 18:49:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="593214473" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga004.fm.intel.com with ESMTP; 12 Jan 2022 18:49:48 -0800 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:49:48 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:49:47 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 18:49:47 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 18:49:47 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lL4irq8b1ucBqwo2+XiFTfcQvrEuUr/EdEM2XleYrYl3Qr9P4Wcft8RcCnZ4pPnF9BowscOP0N7yPqyhatavxebaTgIBfQnaqlxzlyC30V5BuM9us9N4Ao+mAj/oF6jylPo/Y1UIdBaeR3ZRLD9N3tOX30Uhe/Y5nlir/cB+hV82+Rfoy6a8yEYUySFYWh7Pr5qagjRJ2PB9DeUi6NZPw6Kk/ueXPVSlUfBJwUPRLtYan7Z/tgAywkiDaDfiAmo+ASzLuCcg1SNXc6E8dULc/FoqLH0SMbUoWgRY4BHt5rcXZTTzkeHQTcnaMVJmVFzW5bC8kJaNIUAT3hVsG8LTpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ApS5IrXzfcIg/18QpbXFYQp0Z/+h5srepbINMqrAhhY=; b=Ig4x9Uhg5v3CqNG163ASGjyNWijb/s/t12M6ciDVLRhk9RLsO4B+yjOZJSc99LPQLlHeurDNMuJt/OM9oN1LGZUoxYKENiWD0iKYcskAep7nxT5zdrgZrq+84rl/vtDwi+urNd6fMaBIY2xI4OJ0HJswi12pSRREE8IybcQaaElnIvJ+PxHviYizloTTGy3t/1NDYCjQJyNo55oQ5y4UegFdSGvhL41D3c1ODdWTbE5PES7vcwIMg7/IWRHkNOHHI+NmBhh+9fs+WRiUEAevd+CDsjk4UyQuL/WM2Vit2VwZa8GNyyP05gZoKxICQbaH2FsoUSDYZbTDiYRWWxKmYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MWHPR11MB0063.namprd11.prod.outlook.com (2603:10b6:301:6c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Thu, 13 Jan 2022 02:49:44 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%8]) with mapi id 15.20.4867.011; Thu, 13 Jan 2022 02:49:44 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Oram, Isaac W" CC: "Bi, Dandan" , "Gao, Liming" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 13/27] VirtualKeyboardFeaturePkg: Use MinPlatformPkg build include files Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 13/27] VirtualKeyboardFeaturePkg: Use MinPlatformPkg build include files Thread-Index: AQHYB1suvR236nJkwUKJor9jP5zlf6xgQbYg Date: Thu, 13 Jan 2022 02:49:44 +0000 Message-ID: References: <6f4fd8cd087394fbe9b7a0ba101a5a9eb9e578ab.1641953242.git.isaac.w.oram@intel.com> In-Reply-To: <6f4fd8cd087394fbe9b7a0ba101a5a9eb9e578ab.1641953242.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 798b206f-dead-4769-a700-08d9d63f5add x-ms-traffictypediagnostic: MWHPR11MB0063:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2bkkDEeroelMtlvRpjXaE+79yms2E3IA2XanaoMrJ0NDETRc9ltWXqSFUYBFf/DYa0RJSMw5WR0SF0rgyDwpUcCJxintaq6/Ju8kmVW5/vbatg4gBRaMcwwf3Lg+ItpyB3zx9nFUNiqcfD215o90QSYNeEhdvsI9gMKINofeVv/2S6800ZCq/n+xyPMr+dOiQr18XornCWY34cXAoA4O3wVwEqUPbTpVbpw94teWZqrhgvYkrWeO4KQ8xPJgaR7WNPveZQpQMJaZz1Z/DAIk/NILSbgZGot2c/3O1kg8YQVF6btKr8Yj2ytDYSR25hzLKQ7aN2k0bxSO6Gv67ns553IWDFgkx7xLQ4EABTgsaJXQHFz/kiXR20zfpDTkdAgqkf8R3yUBMNAPyirrW1Q+Qae06+kqKDZzTMKSxTqnfp81I8c1lZEz0Ng0XapV3wqkf8iR1B7hqTLGRM41aQUDDVnK14VISSrv1F4EnCmEOtgN3o0J9618+cwfFpSpITTMA/68fPVplnCIlbrxkkdFAaJcSSTJGY/roUBJdrv9rSLwvIyKWyHl0R+EWBSTNxxsWaUTL4QXezCBu11OOLffW8ONQPwktPAchic+7xWmvPh+/rt0mjtMmEsENxWB3wy7E5m2W6bslapRKwS0ThqKDpZYBxZjHJqeZihGwMyIRL4dg5ZHSXxKQdOdARmwAZlm4ulJ7ZdecqKV7sekXkY4LGhOlioMTqCnWUOI/fkp93X/dD+0AiE16vuKVaF4dDOhXpvcWbV723+sDOYMGSnybb95YT7mRBOj+O/FHL+STDsMJVRyyoBpDRDAprbljWafiKHODAU4g0RqHn87neMHKw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(64756008)(5660300002)(508600001)(122000001)(86362001)(4326008)(186003)(38100700002)(54906003)(110136005)(9686003)(316002)(55016003)(7696005)(33656002)(26005)(66556008)(52536014)(2906002)(71200400001)(66446008)(6506007)(8936002)(66946007)(38070700005)(82960400001)(8676002)(6636002)(53546011)(76116006)(83380400001)(66476007)(966005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?f5k5k5UdOOSvzQZkXFpcWu3qnlb+t2mFwtREsUF5LHkq/Eh1utbg2oJ6QGib?= =?us-ascii?Q?CuBShn/dF5sx3PzyCkBjmySbRvsT5rIGNN/U6de9xiWMe7apVjNa4eU2sxXU?= =?us-ascii?Q?TUomd3gb/jGO2rSSi/teU+/C5A3BAJiKnfWYZcb84bWLG7txA3MqEEsb7FnI?= =?us-ascii?Q?J5J4BTk11N0z5HjLv858onThT5BJOcY+2THVl4ja6XM7akONdZoUWa04Z1gI?= =?us-ascii?Q?7Nmc8Dwt8szVqmQ5qcs1hDJL3eyZAju1BgqHyJEnaaICU+WLhLqxE8a5FzWM?= =?us-ascii?Q?b84Qwzj2kZ8dy4SqF6p1LukSBZ4ShbomAKBDbIxqjg5QW3mn0gvVuPOK5RE0?= =?us-ascii?Q?dEViIZcxle9XONjKM2p4qyMWqq8i+oXOQO828AuKqp1AxyEWy0eWRPYaLcf4?= =?us-ascii?Q?y1Hr2P2NrWwf6eH7SlVlT8kqHNDX95KqpqlcxTPmeY/8X+Bu2yGqpfAKbDB/?= =?us-ascii?Q?mzb+siYLS6jJc6FiVB30AAHCct00mFVcR7oGX3xXI8qBUw2m9acS8aSVqatQ?= =?us-ascii?Q?Ge5lvEp9+VJZYTc/JCJEqYK3CVOw5Y+Nk9VRo7uoJOydC6JM2eYyJE3LG/pT?= =?us-ascii?Q?Rs+kW4WZYNSDoifw08AHidFSqW8WShruUIPIlZeFC10tHQ+PRmq3/PXIX14j?= =?us-ascii?Q?BCPfVcSny7W9SgtYZbFyFelXsTEQC7sSZnxgXT1GflHXaQG8W+L2KxXfkV7P?= =?us-ascii?Q?tVBlUP163r4ESBx7XY/B6Zk/4xGcHllJfwylDK+3SizY730DD4w1Vh8dmIDD?= =?us-ascii?Q?dSn1g70fOuDLv8p6UsR5sd5mL8/+cRGwOXEG0vyKo7fhqRuI58EzYCXmmZBp?= =?us-ascii?Q?cos5HycSvaPV+dpYbt+RifA/m4YbCTwPCkYNly+WFx/pZ6n8RMaw/DuVCklc?= =?us-ascii?Q?2IHrxRk43XGOTQ3O88GYuG+tiWlmHaUod+eInKGdLK7p//Y++BiJtJfInuH/?= =?us-ascii?Q?rcd+8hEjxB2wzQQf2c45JYQ9525caquE1LAFI78/WPV0cUE7evASkb2SG77o?= =?us-ascii?Q?CNSmCUQdHfVPucQhsKB6JutFnoLKNsKHqXEhBv6YqKy6qVZLTLzhc0eVtP/7?= =?us-ascii?Q?SCQDgZzrtOEis1KW6H7R9eTPkOVfKvCVF3HuWf0s6INmo8nk+FfnLRbZjhdX?= =?us-ascii?Q?cQOORjFIQHKdkg6sDUkTfc7q8u8UB1Xhs518OyxGHe3E9BVV+aAhj89v9Dub?= =?us-ascii?Q?fJZw5k/LXUDTR0tCF87SADD+9+QuIXMgr2gC3vWx4miYB09Fe4zcHTl3DBQk?= =?us-ascii?Q?NkzR1eLJ5XJI/NbvLIYnWfpwl14qCsXGkShOwDLeBLAafaSoefCNNMRzCKPd?= =?us-ascii?Q?7nQr9zILb9AdrEUTPxgWwRWgw1eyo/p1BNUutTsHccX/K3kUPjJs3Tmc5ZHS?= =?us-ascii?Q?MnJJ+NYq3gaU+pUtYppbtFf9GjxqmlNKXa/x2TOswKtCLzzobKJTHqjvr8lJ?= =?us-ascii?Q?6g+JdK6QoLAVTJ/OBAMewGLjm5ms80K5qWZiMcf+ePPUHYxCehhHvs8GjRgn?= =?us-ascii?Q?Cn4OoBPAQrotetA6huFnDGEYBj1y/2VrYyX3MC5E1Da22PyJc6Bk27BrMVkb?= =?us-ascii?Q?jClLbPEq6QUWWsGIAWgk68VMMre7jcPNCgrvWWm6iBn+LzEx6Rg0kDY4cKBO?= =?us-ascii?Q?MM12ohWXoVPkir5gJgbxOlxZiNO8u9GVTV+r//4u52bLzS2eDGx/b6AXu035?= =?us-ascii?Q?T6nZtA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 798b206f-dead-4769-a700-08d9d63f5add X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 02:49:44.4771 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: fsrGbZuVvZXMMrdeYGFeNJ3oin9pUTF8OhsPKTbf7Npg9FKjpBTje6egFX2k0HDIKoabazzKyD12viGhF5E6d3dBpLImAlipfQlga7S897w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0063 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Oram, > Isaac W > Sent: Tuesday, January 11, 2022 6:20 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Bi, Dandan > ; Gao, Liming > Subject: [edk2-devel][edk2-platforms][PATCH V1 13/27] > VirtualKeyboardFeaturePkg: Use MinPlatformPkg build include files >=20 > Use the MinPlatformPkg common core build files to build libraries needed = by > this feature. >=20 > Cc: Dandan Bi > Cc: Liming Gao >=20 > Signed-off-by: Isaac Oram > --- >=20 > Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/VirtualKe > yboardFeature.dsc | 62 +++----------------- >=20 > Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardF > eaturePkg.dsc | 18 ++++++ > 2 files changed, 25 insertions(+), 55 deletions(-) >=20 > diff --git > a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/Virtual > KeyboardFeature.dsc > b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/Virtual > KeyboardFeature.dsc > index 8179f70c80..0d4f14a412 100644 > --- > a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/Virtual > KeyboardFeature.dsc > +++ b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/Vir > +++ tualKeyboardFeature.dsc > @@ -18,43 +18,12 @@ > # >=20 > ########################################################## > ###################### > [Defines] > -!ifndef $(PEI_ARCH) > - !error "PEI_ARCH must be specified to build this feature!" > -!endif > -!ifndef $(DXE_ARCH) > - !error "DXE_ARCH must be specified to build this feature!" > -!endif > - > - > ########################################################## > ###################### > -# > -# Library Class section - list of all Library Classes needed by this fea= ture. > -# > - > ########################################################## > ###################### > - > -!include MdePkg/MdeLibs.dsc.inc > - > -[LibraryClasses] > - ####################################### > - # Edk2 Packages > - ####################################### > - BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > - BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > - DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > - > UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBo > otServicesTableLib.inf > - > UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry > Point.inf > - UefiLib|MdePkg/Library/UefiLib/UefiLib.inf > - PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > - HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf > - DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > - PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf > - > UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiService > sLib.inf > - > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib > /UefiRuntimeServicesTableLib.inf > - > -[LibraryClasses.common.UEFI_DRIVER] > - ####################################### > - # Edk2 Packages > - ####################################### > - > MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemo > ryAllocationLib.inf > + !ifndef $(PEI_ARCH) > + !error "PEI_ARCH must be specified to build this feature!" > + !endif > + !ifndef $(DXE_ARCH) > + !error "DXE_ARCH must be specified to build this feature!" > + !endif >=20 >=20 > ########################################################## > ######################################### > # > @@ -74,26 +43,9 @@ > # generated for it, but the binary will not be put into any firmwa= re > volume. > # >=20 > ########################################################## > ######################################### > + > # > # Feature DXE Components > # > [Components.X64] > - ##################################### > - # Virtual Keyboard Feature Package > - ##################################### > VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/VirtualKeyboardDxe.inf > - > - > ########################################################## > ######################################### > -# > -# BuildOptions Section - Define the module specific tool chain flags tha= t > should be used as > -# the default flags for a module. These flags are= appended to any > -# standard flags that are defined by the build pr= ocess. They can > be > -# applied for any modules or only those modules w= ith the > specific > -# module style (EDK or EDKII) specified in [Compo= nents] section. > -# > -# For advanced features, it is recommended to ena= ble > [BuildOptions] in > -# the applicable INF file so it does not affect t= he whole board > package > -# build when this DSC file is active. > -# > - > ########################################################## > ######################################### > -[BuildOptions] > diff --git > a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboar > dFeaturePkg.dsc > b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboar > dFeaturePkg.dsc > index ea2005c6d2..6717c892f1 100644 > --- > a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboar > dFeaturePkg.dsc > +++ > b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyb > +++ oardFeaturePkg.dsc > @@ -24,6 +24,24 @@ > PEI_ARCH =3D IA32 > DXE_ARCH =3D X64 >=20 > +[Packages] > + MinPlatformPkg/MinPlatformPkg.dec > + > +[PcdsFeatureFlag] > + # > + # PCD needed for MinPlatform build includes > + # > + gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable > |FALSE > + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable > |FALSE > + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable > |FALSE > + > +# > +# Include common libraries > +# > +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc > +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc > + > # > # This package always builds the feature. > # > -- > 2.27.0.windows.1 >=20 >=20 >=20 >=20 >=20