Re: [edk2-devel] [edk2-platforms][PATCH v1] Intel-MinPlatform: Fix DxeCore Build Failures

Re: [edk2-devel] [edk2-platforms][PATCH v1] Intel-MinPlatform: Fix DxeCore Build Failures

[Nate DeSimone]

Pushed as 2e880c0

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nate DeSimone
Sent: Thursday, November 30, 2023 4:06 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>; Taylor Beebe <taylor.d.beebe@gmail.com>; Kubacki, Michael <michael.kubacki@microsoft.com>
Subject: [edk2-devel] [edk2-platforms][PATCH v1] Intel-MinPlatform: Fix DxeCore Build Failures

Commit 7284c44 in edk2 introduces an incompatibility that causes any project that uses DxeMain.inf to fail to build. This is due to the addition of ImagePropertiesRecordLib, and a new added dependency on that library in DxeMain. Platforms will not have this LibraryClass defined in their DSC yet and hence currently fail to build.

This changes addes ImagePropertiesRecordLib to CoreCommonLib.dsc, which will be picked up by all platforms that adhere to the MinPlatform Architecture. This will fix most Intel platform builds in edk2-platforms.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Taylor Beebe <taylor.d.beebe@gmail.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
index 300b7d7652..e40b2ff6e1 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
@@ -174,3 +174,4 @@
   VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
+  
+ ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib
+ /ImagePropertiesRecordLib.inf
--
2.39.2.windows.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111930): https://edk2.groups.io/g/devel/message/111930
Mute This Topic: https://groups.io/mt/102906021/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [edk2-platforms][PATCH v1] Intel-MinPlatform: Fix DxeCore Build Failures

[Nate DeSimone]

Commit 7284c44 in edk2 introduces an incompatibility that causes any
project that uses DxeMain.inf to fail to build. This is due to the
addition of ImagePropertiesRecordLib, and a new added dependency on
that library in DxeMain. Platforms will not have this LibraryClass
defined in their DSC yet and hence currently fail to build.

This changes addes ImagePropertiesRecordLib to CoreCommonLib.dsc,
which will be picked up by all platforms that adhere to the
MinPlatform Architecture. This will fix most Intel platform builds in
edk2-platforms.

Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Taylor Beebe <taylor.d.beebe@gmail.com>
Cc: Michael Kubacki <michael.kubacki@microsoft.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
 Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
index 300b7d7652..e40b2ff6e1 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
@@ -174,3 +174,4 @@
   VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf
   VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
   VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
+  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
-- 
2.39.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111925): https://edk2.groups.io/g/devel/message/111925
Mute This Topic: https://groups.io/mt/102906021/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [edk2-platforms][PATCH v1] Intel-MinPlatform: Fix DxeCore Build Failures

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

Thanks,
Chasel


> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Thursday, November 30, 2023 4:06 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Ni, Ray <ray.ni@intel.com>; Chaganty,
> Rangasai V <rangasai.v.chaganty@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Taylor Beebe <taylor.d.beebe@gmail.com>; Kubacki, Michael
> <michael.kubacki@microsoft.com>
> Subject: [edk2-platforms][PATCH v1] Intel-MinPlatform: Fix DxeCore Build Failures
> 
> Commit 7284c44 in edk2 introduces an incompatibility that causes any project
> that uses DxeMain.inf to fail to build. This is due to the addition of
> ImagePropertiesRecordLib, and a new added dependency on that library in
> DxeMain. Platforms will not have this LibraryClass defined in their DSC yet and
> hence currently fail to build.
> 
> This changes addes ImagePropertiesRecordLib to CoreCommonLib.dsc, which will
> be picked up by all platforms that adhere to the MinPlatform Architecture. This
> will fix most Intel platform builds in edk2-platforms.
> 
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Taylor Beebe <taylor.d.beebe@gmail.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
>  Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> index 300b7d7652..e40b2ff6e1 100644
> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc
> @@ -174,3 +174,4 @@
> 
> VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVari
> ableFlashInfoLib.inf
> 
> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
> 
> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Variabl
> ePolicyHelperLib.inf
> +
> + ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib
> + /ImagePropertiesRecordLib.inf
> --
> 2.39.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111926): https://edk2.groups.io/g/devel/message/111926
Mute This Topic: https://groups.io/mt/102906021/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-