public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Hsueh, DoraX" <dorax.hsueh@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>,
	"Chuang, Rosen" <rosen.chuang@intel.com>,
	"Kasbekar, Saloni" <saloni.kasbekar@intel.com>,
	"Tang, Haoyu" <haoyu.tang@intel.com>,
	"Chiu, Chasel" <chasel.chiu@intel.com>
Subject: Re: [edk2-devel] [PATCH] Readme.md: Update AlderlakeOpenBoardPkg known limitations.
Date: Thu, 2 May 2024 23:43:44 +0000	[thread overview]
Message-ID: <MW4PR11MB5821415B4C839F89A23163B0CD182@MW4PR11MB5821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <a3fde69e47fce0c3671a0e444c16ec9f47bffbcb.1713774874.git.dorax.hsueh@intel.com>

Hi Dora,

Feedback below.

Thanks,
Nate

> -----Original Message-----
> From: Hsueh, DoraX <dorax.hsueh@intel.com>
> Sent: Monday, April 22, 2024 1:39 AM
> To: devel@edk2.groups.io
> Cc: Hsueh, DoraX <dorax.hsueh@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Chuang, Rosen <rosen.chuang@intel.com>;
> Kasbekar, Saloni <saloni.kasbekar@intel.com>; Tang, Haoyu
> <haoyu.tang@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [PATCH] Readme.md: Update AlderlakeOpenBoardPkg known
> limitations.
> 
> From: DoraX Hsueh <dorax.hsueh@intel.com>
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4667
> 
> Updates Alderlake P Rvp details to the Readme.md.
> 
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Cc: Rosen Chuang <rosen.chuang@intel.com>
> Cc: Saloni Kasbekar <saloni.kasbekar@intel.com>
> Cc: Haoyu Tang <haoyu.tang@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Signed-off-by: DoraX Hsueh <dorax.hsueh@intel.com>
> ---
>  Platform/Intel/Readme.md | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Platform/Intel/Readme.md b/Platform/Intel/Readme.md
> index d29a9072..652b4ec5 100644
> --- a/Platform/Intel/Readme.md
> +++ b/Platform/Intel/Readme.md
> @@ -410,7 +410,9 @@ For PurleyOpenBoardPkg (TiogaPass)
>  
>  **AlderlakeOpenBoardPkg**
>  1. This firmware project has been tested booting to Microsoft Windows 11 x64 with M2 SSD Disk and Integrated Graphic Device.
> -2. AlderlakeOpenBoardPkg/Acpi/MinDsdt has been modified from MinPlatformPkg/Acpi/MinDsdt to avoid hang on boot to Microsoft Windows 11 x64.
> +2. Since the FSP binary is incompatible with the latest Edk2 version, a working edk2 version needs to be kept
> +   EDK2 SHA-1: e10f1f5a043a402fb2daf2091b8f725fd2951743
> +   EDK2-Platforms SHA-1: fc6e3523d868650ad4f8aaac0ccdd8f138370341

It is non-sense to list a required SHA for edk2-platforms when you are modifying a package that is inside edk2-platforms. This act of modification will result in a different SHA for edk2-platforms.

>  
>  **WhitleyOpenBoardPkg**
>  1. This firmware project has been tested booting to UEFI shell with headless serial console
> -- 
> 2.26.2.windows.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118541): https://edk2.groups.io/g/devel/message/118541
Mute This Topic: https://groups.io/mt/105666152/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2024-05-02 23:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22  8:38 [edk2-devel] [PATCH] Readme.md: Update AlderlakeOpenBoardPkg known limitations dorax.hsueh
2024-04-22 17:47 ` Saloni Kasbekar
2024-05-02 23:43 ` Nate DeSimone [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-02-15  7:22 dorax.hsueh
2024-02-07  5:55 dorax.hsueh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB5821415B4C839F89A23163B0CD182@MW4PR11MB5821.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox