From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 46192740032 for ; Wed, 10 Jan 2024 01:27:49 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=vbo+I0aZq32JRmL3zc9BHkP/PMnUx2sK/mwCKE3Yt8I=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704850068; v=1; b=wZ9m0mukmmFQiASusjws5QyxXFbH8aCRYjr35QKsGgAp3zszCSanW+5vwQM1TTHHIo1A3kUn 9DecHmWQi8QbEZb+iiSg7243nbQkh1SS4kQzHNJMHO7cZ+ADv865nMTFUcPH0CCQklybsQAsCt+ WCbmLRGEh8w81U/kJm7TR4K0= X-Received: by 127.0.0.2 with SMTP id sKodYY7687511xdCcTckeWul; Tue, 09 Jan 2024 17:27:48 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mx.groups.io with SMTP id smtpd.web11.2136.1704850067350357970 for ; Tue, 09 Jan 2024 17:27:47 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="5128153" X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="5128153" X-Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2024 17:27:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="905351020" X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="905351020" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 09 Jan 2024 17:27:46 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 9 Jan 2024 17:27:46 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 9 Jan 2024 17:27:45 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 9 Jan 2024 17:27:45 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 9 Jan 2024 17:27:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g+HKKs58JR9KCHeelcoAUHJTd91ZTow2wX4x5DGyCxUpkOe5EbPv5HkSgzn6LaCBfGLCk35ttZV96ikAUnTsxquhVerRodLqL2ulES918JBH6IO7i0IIQiRfBIXZ8w/o+ZvxtVB1jM44ROwoKgTf7amGvLxctLfs68a1u3jxVGG96LUJs7jvWo7quqbKfVW4dKgecuv459UzH7NT62ZTcElNCvkn94MyfcobQ3NsGokUJoo2HibSpyH4+PYAxzYHSgQCzMZYUXQ4p0k0srjFsMrFiB8JX8Mpsln6nZMRB+cCDdf4+C0RMGLm26nfKwNwg1mmFj0vcQ1FHkAd489Rmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jlXbOYbNJPH3V62A2Lm+RKL9qwhZ8WKsCtbVWyCjkrc=; b=P6LPgZvEj6YYBKHCwDPLvw/Czt9twPfd7x/YBKJCW5MdCtcO4/jQYVmXuw32T6d0AOZinTFMFF1n600vlEPiibiUu9VSc3daqBhr0u8ez/i5LOzqYvVGwkjxT4IueekF7ioV7Ob/5enzzkjeOML8kd+9qryPvjSZCSMviLjTW48NSsjwmupML0gipE0bjM7PDwuv2MYQUx/9GWJqrwIR2+elW03b7XfC8C+1AlG5z3vjOdDlS5H3iQLdTno9AcuUhRQBeG667wxUJarQ9Qk5QCohKErsVKq6VVoxssWGeG87fZhRspaR1ZVaM66DUeQjbzXyHX6I/ubc+exfcWFEDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MW4PR11MB6909.namprd11.prod.outlook.com (2603:10b6:303:224::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.23; Wed, 10 Jan 2024 01:27:43 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::7d4f:b2b0:e284:aeff]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::7d4f:b2b0:e284:aeff%4]) with mapi id 15.20.7159.020; Wed, 10 Jan 2024 01:27:43 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Ma, Hua" Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to enable selection of timer Thread-Topic: [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to enable selection of timer Thread-Index: AQHaP5mK+P6mTiiuH0iyu3DdXHNU37DSSOKw Date: Wed, 10 Jan 2024 01:27:43 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|MW4PR11MB6909:EE_ x-ms-office365-filtering-correlation-id: 28c071f0-17f1-4933-c094-08dc117b57f0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: LaIz7F+/R2z4b0td6fbNCwuN0hqq/9O/6T797BYqOsAegkv+Qo/0ii3TNcs+9VJWQVOfonNq/BF/pz3ZSskGSs+hgg40oz6pF5oiCkfkLX4X8U+08oVpA5iZycNL3H4P5idJj7jSjDaswXl1+V9ftPEdkfPO+GIgOhKmSEFbmWGJOgq8/ot9+pYKNHoBG5nekuHao1eekxWmhQCGn00nixDshLwZUhgTlWmyJzomZ+6gHV3zqldI6ZT9LOdsso4521sNcz0TFskfWY5PpiNdTLyC+YJu86Q/Xc+DNIs7wEv15HlIcvtSXnzIb6E4FQGAc7kW0TYxBh2KLK36rQ9dQcqb5vj2s4+pLQ8uUvBiO0OfdFH4A9cSkNlPm5+oC786md5DLS6gPEl0rI7FeZSsmeCUC3VUywzOYfScnukCr002sK54w5yhy5dHnKhkQMx2cBcAkMqa6qpe8a3TCHS99VCCjhDSFGuALd0mcyL4+fZDGQCAMNzTMqeS1IEuvz9EyjfrbZD1MhDkY50IdoXev3OYzEhXSGrQP92+xOyETyr6Rf476ZHC70wUsU5WGeSS1P02kYV/mC2AlG0h6sZ2olvVnPrr8hn4Qc5WEpi5eYk= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JzJx3tKINBY1Hgp/2rg89V7DdgolORyNP1RgYiHL5Z+MtcPoU3trBvk1Kyrb?= =?us-ascii?Q?rhrOigqrWC838NgEVjMzDfZIki8s91o3e4nxa7a4c4r4sVkqVLPGvk8wiB3o?= =?us-ascii?Q?PPcS5qDq2mY2VvOtORmYqDrv3TUV6blUK6vmhycVJ2qjehrDoh7jAFEK+nCx?= =?us-ascii?Q?lzN7OYgWjRY7ytuF/IiRdjC9fXk2xgOevqCSNhZCEgniRbPikh6aT/0lxLKQ?= =?us-ascii?Q?xDDWUkd8L+3gM55jSWenNIAHGRC5MvJuq4bB+7FILPC8fXnQNfNpee69eEvq?= =?us-ascii?Q?ya2LuqBZ5kOvg1FmSXhTNGRSQm4hX/0pwSC9FbZoUllidFMPnqH1e1LUk5p0?= =?us-ascii?Q?FsUh+8YF+8B6SuuTFYrBmfKvO/qfTm2ju13LlxtInC5vhepAZlOEBi/VYJj8?= =?us-ascii?Q?8YtbHFSMTsu4kADO6sogESR0JboGelY1EkTRtpMxxrrw10GZjM1Ge1BWou3o?= =?us-ascii?Q?T9ybaG1ji0WdsshV2ftOxj5WEXyikjZvu68lWEaL0HLuAi67Ls96JUVeuooZ?= =?us-ascii?Q?MYdobw4xJI7dU8tNB9vxmvFuoWmfO/B7YkD5sEk2UWGC0dt4RWZzKVgqixv3?= =?us-ascii?Q?tLtv37WMGHM6GGlVB+gMJqo5Tpe5GN2xwJdYEIuSxLWzTyD1cuUw+NpsuuLG?= =?us-ascii?Q?ExSDtRHqVf+ICwEWoFmTuM4wBzGPQorxGYkVxD2xwGGJ4uFwVgMhumnxee6R?= =?us-ascii?Q?1FSRrfh/rErWXs95INCDl6xlg1yGXIE64reMe1tpWPM9BupN8mTYfLWMOQ3T?= =?us-ascii?Q?OA45059ebc8z3Pg3LUl+3th+kUjRoZD21bvHZalTpEaUs7x9/eFn3ly8xY+R?= =?us-ascii?Q?cKgroBv+PVOJjI+qDJFS+Fv7BBIYcJjfN7OVWoalF0y/uuKH3xBRicSJPVS6?= =?us-ascii?Q?z3Y/ghIIeje8fDNZL5Fu5V3RbYbUnLZ1I6dglPtY217t5cP47hJqzS27/X4H?= =?us-ascii?Q?nRSl7vpCT2JUm3Rv5FbtKYVRsQ95OtSWwAg1CLmSos4GZVcEAaeZsdbcIifh?= =?us-ascii?Q?CqdQ9bvJ/AMDuqGrUDDH1Q4LUL/74tEv4UoD3PFtnDrwLoDK/gHzZdlRSqMF?= =?us-ascii?Q?HDERacV2OJutECF2/IHcThjKAJvncQIjvQiomfflE3a9z/BtB9AU5TuUU/6T?= =?us-ascii?Q?VRKWFeQJGB2EUp2/RdQPGEGzAL8m9ZdRyMjoC3Fnb5uuSLS8lt5sF/IT0mWW?= =?us-ascii?Q?0wdDGCDm8DtaLbBn8DBJkLYDOR1iAvxypF/ebq8N4owoH0HRhzLnPwIUJtdI?= =?us-ascii?Q?ZOMraz3OtkynrMRKPWlQl/FnmWNpwVHJhggMgU8qKstuEId6ajbG3m3Pk5zQ?= =?us-ascii?Q?y7vdiQe9VuvsYWYvjCbIhHn32D6DDDl1G2/jzKFqGioewfbxi6glqxEzePeR?= =?us-ascii?Q?oSQPX6d7ouv0OeyWOMGtk8lE3uAZ64ge77FQfQgEKM4NLIa1nnle9MRVsml6?= =?us-ascii?Q?MpDd+BEkq/dnp7uGOACyHZ+8lLbTSkp3JmVql6rB9wL3KNftmzyz4pNmaj63?= =?us-ascii?Q?8zio0btawFiMOoqyiKYNlOJZGCA8EnxxG705gUedhuN2BgXnxyGZaCYDTtd1?= =?us-ascii?Q?//WZidgWJshR5RJAmcUta/jwOFrf66FMPFbxpQWWn0uzSvcMxEJzjgh8Q8fS?= =?us-ascii?Q?lg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28c071f0-17f1-4933-c094-08dc117b57f0 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2024 01:27:43.3225 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6I6iC2eBAIOE1sLxsXQYnwIMa3MnHMJ7QZFweo1VFxn22TtekmwA/GVUIr5cpbe8akISY74ONMRmK3yi8bDFbASmTIJjjfr1eINbQe5es5Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6909 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JPutg8FSoM8SbRaz5vxPkoSJx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wZ9m0muk; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Hi Hua, Please make TIMER_SUPPORT a FixedAtBuiildPcd instead of a build flag. Somet= hing like PcdDxeTimerSelection or similar. Thanks, Nate > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ma, Hua > Sent: Thursday, January 4, 2024 9:39 PM > To: devel@edk2.groups.io > Cc: Ma, Hua > Subject: [edk2-devel] [PATCH] UefiPayloadPkg: Add macro to enable selecti= on > of timer >=20 > Add macro to enable selection of timer >=20 > - HPET: UEFI Payload will use HPET timer > - LAPIC: UEFI Payload will use local APIC timer >=20 > Signed-off-by: Hua Ma > --- > UefiPayloadPkg/UefiPayloadPkg.dsc | 16 ++++++++++++++++ > UefiPayloadPkg/UefiPayloadPkg.fdf | 4 ++++ > 2 files changed, 20 insertions(+) >=20 > diff --git a/UefiPayloadPkg/UefiPayloadPkg.dsc > b/UefiPayloadPkg/UefiPayloadPkg.dsc > index b8b13ad201..4f195c1e52 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.dsc > +++ b/UefiPayloadPkg/UefiPayloadPkg.dsc > @@ -139,6 +139,12 @@ > # Note: for emulation platform such as QEMU, this may not work and sho= uld > set it as FALSE > DEFINE CPU_TIMER_LIB_ENABLE =3D TRUE >=20 > + # > + # HPET: UEFI Payload will use HPET timer # LAPIC: UEFI Payload will > + use local APIC timer # > + DEFINE TIMER_SUPPORT =3D HPET > + > DEFINE MULTIPLE_DEBUG_PORT_SUPPORT =3D FALSE >=20 > [BuildOptions] > @@ -676,7 +682,17 @@ >=20 > MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuAp > p.inf >=20 >=20 > +!if $(TIMER_SUPPORT) =3D=3D "HPET" > PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf > +!elseif $(TIMER_SUPPORT) =3D=3D "LAPIC" > + OvmfPkg/LocalApicTimerDxe/LocalApicTimerDxe.inf { > + > + > +NestedInterruptTplLib|OvmfPkg/Library/NestedInterruptTplLib/NestedInter > +ruptTplLib.inf > + } > +!else > + !error "Invalid TIMER_SUPPORT" > +!endif > + > MdeModulePkg/Universal/Metronome/Metronome.inf > MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf > diff --git a/UefiPayloadPkg/UefiPayloadPkg.fdf > b/UefiPayloadPkg/UefiPayloadPkg.fdf > index 835798be1c..7d04a8cffd 100644 > --- a/UefiPayloadPkg/UefiPayloadPkg.fdf > +++ b/UefiPayloadPkg/UefiPayloadPkg.fdf > @@ -161,7 +161,11 @@ INF > MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > !endif > INF UefiCpuPkg/CpuDxe/CpuDxe.inf >=20 > +!if $(TIMER_SUPPORT) =3D=3D "HPET" > INF PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf > +!elseif $(TIMER_SUPPORT) =3D=3D "LAPIC" > +INF OvmfPkg/LocalApicTimerDxe/LocalApicTimerDxe.inf > +!endif > INF MdeModulePkg/Universal/Metronome/Metronome.inf > INF MdeModulePkg/Universal/WatchdogTimerDxe/WatchdogTimer.inf > INF MdeModulePkg/Core/RuntimeDxe/RuntimeDxe.inf > -- > 2.39.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113503): https://edk2.groups.io/g/devel/message/113503 Mute This Topic: https://groups.io/mt/103538255/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-