From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.282.1635894686247227126 for ; Tue, 02 Nov 2021 16:11:26 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=uc2xZFSj; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="231641312" X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="231641312" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 16:11:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="667303993" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 02 Nov 2021 16:11:25 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 16:11:24 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 16:11:24 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 16:11:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NjMMynO2TaV9t2UxskaF0fJVmtPqDfF7WwFM6UJl2YCGnYQrdpmGZRM+NhrzNzTzl1WXpPgQ8znbG8f3Gcfd7H11sfebXlZFtHuzQaKQbWpclqblYVZHBYX06Df0Hsoj48seYZW8UDxSZQn7Jni6+SYTVgdc7WHvqoSNs1wiKjpemyogiTX5wHxuz3AdgkQ3I6yPZcI7f4ymZk0qPZEl532fQJY8VQeow3k+qXkAeXdUhr0Hl4+2Kp+qbIz6jXajQLwZu/k7D8wdQR/mqePeXP60Y06xEHD9NPLylcTVjT8MUQENXfjPbkCZWI4BnX1y5Zqm9Ax69CwYIpEXloh1sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Boyw7+9axamuErVFpJDA42wwZfigl19S9pCwjmIVxGM=; b=eXHWbCgKAR5ZbMJA5BelrTmfHy5GtXSqTtISA9nLk9nRWyfwzHvDxCj04pA3585ZJa9Za+GwyDTxo6mOtIKOhl5cmR512bDq/5ce+Oem2cvE3xDQbQJNEiFSfHQw/VPkQhPIc3YIT+fgpy/nNBizjlkGGVW3zf/5NFHDUerTjiIVp+PLlIlD0D/XlACD19RIX/MSz5x52rMlXqVVHPTald97nWal98nO/VFREPXJfmUF4d+i6KSEA1hWAGQVvDzCNhFEqTb0bZ27SmVA+3+8SBVGL2c4yM81fm94gkeUniBlz0PEiBUnXPuuU9ckK7FbmFSS0mHAolPfdo53gQL5rA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Boyw7+9axamuErVFpJDA42wwZfigl19S9pCwjmIVxGM=; b=uc2xZFSj5hSCxoK6qkM7wBNwsqMG9BBzrtdFvEvPV2/Nmywp3U9W4DBgonSmtu+q261R+Q559j58ADPpJQgFDWzAkwEuJ0bleD/EOYmkAfZo+KJkf940XoAgHk868Mmjc2VH8Aih/VgZuSyyJAeKNDprN9S3c+g5BZELuKSveso= Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MWHPR11MB1503.namprd11.prod.outlook.com (2603:10b6:301:f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Tue, 2 Nov 2021 23:11:22 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6140:8298:9d5a:df46%9]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 23:11:22 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [PATCH v6 25/52] PurleyOpenBoardPkg: Use IntelSiliconPkg SpiFvbServiceSmm Thread-Topic: [PATCH v6 25/52] PurleyOpenBoardPkg: Use IntelSiliconPkg SpiFvbServiceSmm Thread-Index: AQHXzDzMdIv6BiRe206mpF+Pgs7dv6vw5Wig Date: Tue, 2 Nov 2021 23:11:21 +0000 Message-ID: References: <20211028204326.645-1-mikuback@linux.microsoft.com> <20211028204326.645-26-mikuback@linux.microsoft.com> In-Reply-To: <20211028204326.645-26-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ad4e1f51-8804-415e-6998-08d99e5615e3 x-ms-traffictypediagnostic: MWHPR11MB1503: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Wa5hd/H2uOPa3+B4JC9XdEJoXxIMFzPTzYEEGoziRrhBmMUc0aFsAKtDB+JjdZVWJfRzjuuxjIMsc1hFDfQ6eo1F8gl/pQsj6VEumGT4R94ISruOUGCa8kzSAM85c8YOm7WqzumeB1NSlbIS917NNXyq47Ixrb/wpKiDTi8tihMBFTewCL/+nqJKqmyly27goBnVdxRm5+yVyGbZi25TtMTuntMd5p2OBmKUN3WkmPOuO5ILLWaFCfmRlP/U/Dk+G8Y6oLIh5EzFYvig70M3fL6Om6tCwCY29agC44xOeuxo21RLAYBNZUgTWrGFHdsdD0WkGqD3hR3xBtKAj3y3xzLwqqsR9W6yLShSkisoWlnofvhHdX/tf3vHH2zfXH7xLjdSTXGIAAF8300jOcv4yqwgpOHXdwUNvjfLYnSC+J1aAwlxG3NMuuJQcjxdJVBVNs4JJKiph/yfQiehNRmQmRhmeHQdAWdSwqBw5d7GeILOm3Y0cre9KwIFe9FrOlwzstbVynf7DpFAdkMUfrDyYj9ixLeaMJ7GaZrJsBXY8e2AfXgdvBjg6KjgcGcosaVXUnJrB4T6OxAgJ63YvhneR580bHNYKWGCF9WMvTU4z2sHRPkAWuBztVWp/Dn2UcTWPfDn9KhChDGyBxguvF1UhFNTpr619Kl/xgQctWfjzivRtB9xf+6ZnsFWzUEn4s9TBzXHoDVE+XZDYNmvbeSzM4ThVigsgJuG1mhFfsKN6nTU2ChgYHb0AHfsmHns3PnQcBCWetAH3sFvEqhH2r/63tHoE9bVLrEa7/eA4y7LxhQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(83380400001)(66476007)(64756008)(53546011)(66946007)(76116006)(66556008)(2906002)(6506007)(66446008)(508600001)(7696005)(38100700002)(86362001)(110136005)(122000001)(316002)(9686003)(38070700005)(55016002)(52536014)(33656002)(71200400001)(4326008)(26005)(8676002)(186003)(107886003)(82960400001)(5660300002)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uK+Td6xiV96EBUTjJhn6PPRa6JQTIVZY5B+KzE0fvMCOcH3J91yFgiGRJIhR?= =?us-ascii?Q?jHG44Dye+v8u1sJocpMmePHt4C+CPYa8s+Yz6HFuHKCfDOqh2p5po9xZuEt4?= =?us-ascii?Q?xSrRhiX5yXO7vT8RFHok938LeJm6citsJTzF+CoGI5ATHC8ryxcIH9XcI4AX?= =?us-ascii?Q?RKPeBpDt2WHtGSFcAPm/HIInI5dwtb3K6DliytzSDqO3LBePYgTxb/Tji1sL?= =?us-ascii?Q?JyRRTQlcjK0UYD0rvlfKt8GhCSVNSYiV5M1szBxAvRIJgvf1rcNcMQfdXXQk?= =?us-ascii?Q?/Oe1DP0DC3viBVEwys3hLa1cO4mV87A2s5ki7NxkQRzpz9DiWq0VZDGw7Zcb?= =?us-ascii?Q?+lqhhAPYF6x/6ARS3Obd5qhJAVxwubUJ1dY83hhrbm9NB7m9zEJ5WajltZJg?= =?us-ascii?Q?vf29jZZ356Oz+CX6h5c55JK7ALGwfo7AcgSQYbmn5isakhGQSJ27s+46hUKW?= =?us-ascii?Q?1BI42OmJbHPXswuTt0UoeIAxC8yFJxjU0gTwU+2xucerMNIYW8CsiBuvJgNv?= =?us-ascii?Q?aMheu6mHfA7tbR9NtnkxxxmTVhaT61jE3HPZKEeVQB6BCgihT02tFsczj5bP?= =?us-ascii?Q?bpXn64rKqVaN1aSqIHmR2hED7bbyG/5/RDWM1t7rqjG83ujeUtawTMR60FL8?= =?us-ascii?Q?pWHWsyuO73HtDf0UB62IaGDBf+1W6NvsS8cMgVBmHbbJDOPmDAfPCmR+ul12?= =?us-ascii?Q?ox3PSLZUQkl/hfxUVUekErFkWTqfIt0PApv2QFYEPlpnxaVKWAimNm+P72qN?= =?us-ascii?Q?HZVwHhV/ZE5RSH/l+u/oW+P5AhQtXyTlUxno/UdE+s/rNV+sx/nHQxKb6zU7?= =?us-ascii?Q?5bS0YfpXxFQ6JoIZvFEVnvFchZh4h2zXk96s778VAvcgjkdg6wWSoOsxvGtq?= =?us-ascii?Q?89tsZbde6f0UcHhz8yLDmiB/w0URX3oOI7v37UW4clCun+LCd1KA94ewtwJs?= =?us-ascii?Q?kOep5gRNXVOYgCMGa/F6mGq2sHFGPz2tWzRnzNuC18IpEydqPgWdBzxBVMtb?= =?us-ascii?Q?pkd8BIuY/60m5zoGpzV3vrsNJMWCLkkuHLVvGXeJQh4W8KHKh3tSaU2UzwLX?= =?us-ascii?Q?tn5LtISNg1E+SJnIFhS/ML2wpjV1JK3lYhIWDV07dEGOMDPRg7Xnq1f+riKw?= =?us-ascii?Q?v3aHrleX+4qnnUVlQms1pem9cgCsklMjGaOCtS37SHvVyt7q8tMHIChibMfr?= =?us-ascii?Q?1rsEmfQwpz458AJEPdKhROn2tBMyHmI87JaqMW5iLgZ+J4PfmdObN8wxJ8uC?= =?us-ascii?Q?2rQ2D5jujgQN//ErJoYqCD6rnO0v85MCUIyNJT1I6C7nd61j29qlm1Mh86SX?= =?us-ascii?Q?fEy98SSloGchEFv2q6yd7uKlgiMPX+Jgi7E6C0GSRoEQNUk/9K1NezGDBZRE?= =?us-ascii?Q?sgK7IfwibbcpC1NW3Dx+cAztjuITTTo/ItSu7Nn3vHtb8bRVxtwRb5/2nH6W?= =?us-ascii?Q?mEi+TRONTUall+sU1iBjwBuaQYw/iess023Q3DRXEcrwrJvceotCfnpoWSuZ?= =?us-ascii?Q?yAZgo6HgilEuvnsfRZvpa3NMRuw4Rzvh+cKMV+YDO7nqN3k8EjRGlSyXwFJ3?= =?us-ascii?Q?uqRT22TPO08kAhV8cxFf0Ae1fYZZtArzL1nvnU0Q4gd/QNjl5xB8Bj8IvRJH?= =?us-ascii?Q?ZvAmu2FDzB9+mrL/BUA19UBFm3f2lRBfuzrOix+kkqH/AKYLSG21kv8SwXZ2?= =?us-ascii?Q?Wm/Alg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad4e1f51-8804-415e-6998-08d99e5615e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 23:11:21.9952 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CrGNb9oXEtpjRRhnXvMATYRMiH5BdegaghNiEzeXoLIzQVMOxmFeb9Q8ca/GNAYGi5mPgQF2A9Y2Dugs8xanBpjFaSxJa9WYQD5cTWa2aEs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1503 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH v6 25/52] PurleyOpenBoardPkg: Use IntelSiliconPkg SpiFvbSer= viceSmm From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307REF:https://bugzil= la.tianocore.org/show_bug.cgi?id=3D3307 Updates the boards in the package to use SpiFvbServicesSmm from IntelSilico= nPkg since the MinPlatformPkg driver was moved there. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Michael Kubacki --- Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.dsc | 2 +- = Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.fdf | 2 +- P= latform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc | 4 ++-- = Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.fdf | 5 ++++- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.= dsc b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.dsc index 98e02f35e7db..39c5cf78abc9 100644 --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.dsc +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.dsc @@ -184,7 +184,7 @@ [Components.X64] GCC:*_*_*_ASLCC_FLAGS =3D -D PURLEY_FLAG -D PCH_SPT } =20 - $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf + IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf $(PLATFORM_PACKAGE)/Acpi/AcpiTables/AcpiPlatform.inf $(PLATFORM_PACKAGE)/Acpi/AcpiSmm/AcpiSmm.inf { diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.= fdf b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.fdf index 7a3ffff7ff08..413d98a07065 100644 --- a/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.fdf +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.fdf @@ -343,7 +343,7 @@ [FV.FvOsBootUncompact] =20 !include $(PLATFORM_PACKAGE)/Include/Fdf/CoreOsBootInclude.fdf =20 -INF $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf +INF IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf INF $(PLATFORM_PACKAGE)/Acpi/AcpiTables/AcpiPlatform.inf INF $(PLATFORM_PACKAGE)/Acpi/AcpiSmm/AcpiSmm.inf =20 diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.= dsc b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc index f2a028d18310..3bac6d394e4c 100644 --- a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc @@ -89,7 +89,7 @@ [DefaultStores] [Components.$(DXE_ARCH)] #TiogaPass Override START : Added Board Specific changes in core drivers = #!include $(PLATFORM_PACKAGE)/Include/Dsc/CoreDxeInclude.dsc -!include CoreDxeInclude.dsc=20 +!include CoreDxeInclude.dsc #TiogaPass Override END =20 ####################################### @@ -210,7 +210,7 @@ [Components.X64] GCC:*_*_*_ASLCC_FLAGS =3D -D PURLEY_FLAG -D PCH_SPT } =20 - $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf + IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf $(PLATFORM_PACKAGE)/Acpi/AcpiTables/AcpiPlatform.inf $(PLATFORM_PACKAGE)/Acpi/AcpiSmm/AcpiSmm.inf { diff --git a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.= fdf b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.fdf index 3c05b744141b..b162483c44cc 100644 --- a/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.fdf +++ b/Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.fdf @@ -167,6 +167,9 @@ [FD.Platform] SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase =3D gEfiPchTo= kenSpaceGuid.PcdFlashAreaBaseAddress + gCpuUncoreTokenSpaceGuid.PcdFlashNvS= torageMicrocodeBase SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize =3D gCpuUncor= eTokenSpaceGuid.PcdFlashNvStorageMicrocodeSize =20 +SET gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvBase =3D gCpuUncor= eTokenSpaceGuid.PcdFlashNvStorageMicrocodeBase +SET gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize =3D gCpuUncor= eTokenSpaceGuid.PcdFlashNvStorageMicrocodeSize + SET gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress =3D gEfiPchTo= kenSpaceGuid.PcdFlashAreaBaseAddress + gCpuUncoreTokenSpaceGuid.PcdFlashNvS= torageMicrocodeBase + 0x60 SET gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize =3D gCpuUncor= eTokenSpaceGuid.PcdFlashNvStorageMicrocodeSize - 0x60 =20 @@ -395,7 +398,7 @@ [FV.FvOsBootUncompact] =20 !include $(PLATFORM_PACKAGE)/Include/Fdf/CoreOsBootInclude.fdf =20 -INF $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf +INF IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf INF $(PLATFORM_PACKAGE)/Acpi/AcpiTables/AcpiPlatform.inf INF $(PLATFORM_PACKAGE)/Acpi/AcpiSmm/AcpiSmm.inf =20 -- 2.28.0.windows.1