From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 79F40D80225 for ; Fri, 5 Jan 2024 20:57:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CV6Dac/f1fpAJGph8P/5ZlPPeHziuJDVT2Gx26MFmUU=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704488277; v=1; b=ewGUDsYDAjpWFWKLNn2zQ5vO2+TWEuAWuRn5QmRhTbWQGUBQI3E9IRRdEpWQ8Cn0NXQOXadm h3LTR7n+Jqd3OKbCDSxLw2Qlv130hW5fCq9AckQe3PS91dZ4+HE9gENk7OdnG5qi3Togtxf3w6X MBOF92FKUlsHdEHXRbRlAaH0= X-Received: by 127.0.0.2 with SMTP id TELuYY7687511xbiv9m92UJX; Fri, 05 Jan 2024 12:57:57 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mx.groups.io with SMTP id smtpd.web10.34748.1704488275688824330 for ; Fri, 05 Jan 2024 12:57:56 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10944"; a="4346177" X-IronPort-AV: E=Sophos;i="6.04,334,1695711600"; d="scan'208";a="4346177" X-Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2024 12:57:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10944"; a="773936598" X-IronPort-AV: E=Sophos;i="6.04,334,1695711600"; d="scan'208";a="773936598" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 05 Jan 2024 12:57:42 -0800 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 5 Jan 2024 12:57:42 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 5 Jan 2024 12:57:41 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Fri, 5 Jan 2024 12:57:41 -0800 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 5 Jan 2024 12:57:41 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mW4ypcQ+1d5Cm6FiV6uEClzEb8GJg9n4g7qUxZFS5UwBV9P+eLpmkuFq5setZOWTRH0s+Wic7HQ07NqgkerQFAXCMnP0mkgCNFtbgNrWy0YGc8OirA4HGLqM8/tOW4q6s21IVP0XSvOTCXUBbXgz9ipqytV9d/oMy2bdXzflgaXKAoPjhttFGAYl5TxLq2m9oOH38vkFmpWBESs8Rd9k5FQZZhSQGFHhcKhwwJ9q9vOvwV4sjjH53Prib0sdkob4Sc6sz/9LxeJDz51PS9th5o8ZraX0aJsczPCyK89OWqpTxyh620lghYj+P0cUuXVT1wafxSye0EfXMUONZ03ahQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v4WTp47wlo+Z9DxHpHCOaYpObuj88Zg9hLt9aCq8u+s=; b=Hc7Jz6Jf5AflLvwVJY/PF9WIPSUFt9t8hO1JgRsIJTQ4DIzrhFmFgnXfk3I2RPNHIAfko03MQ9TVu7Jk0TFb3wg4jwFqg7D+JVR4jdIjkkM+KcKzpfU/VFEACMSiRNh+WBfkRrb7ABKEfdBakoxOlUI3okEt/ftKPs8hs9yS/dFEHrkNel7h3AwinLUjwy3bbfZ33Y/exsK/J9Di/zqOcHoNSaDYABR7SrDM8qIFuYAXtp31VO96k66U/Cc41h82D7Nk5xp/dHGCbmaeZ4+W+wV1FkvbvTQiDNhrBDn0NvW3B/EO8EwMSNRq2qlMWjOAe9lsf475n3aS6RPDtAa5Fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by SN7PR11MB7138.namprd11.prod.outlook.com (2603:10b6:806:2a1::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.16; Fri, 5 Jan 2024 20:57:38 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::7d4f:b2b0:e284:aeff]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::7d4f:b2b0:e284:aeff%4]) with mapi id 15.20.7159.013; Fri, 5 Jan 2024 20:57:38 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" , "Desimone, Nathaniel L" CC: Andrew Fish , "Ni, Ray" , "Kinney, Michael D" , "Chiu, Chasel" Subject: Re: [edk2-devel] [PATCH v2] EmulatorPkg: Add EFI_STATUS return to EMU_THUNK_PROTOCOL.SetTime() Thread-Topic: [edk2-devel] [PATCH v2] EmulatorPkg: Add EFI_STATUS return to EMU_THUNK_PROTOCOL.SetTime() Thread-Index: AQHZ8yIEllxd8PD1RkuhgWcmk7rwXrDMTVcw Date: Fri, 5 Jan 2024 20:57:38 +0000 Message-ID: References: <17897E3A091481E6.9230@groups.io> In-Reply-To: <17897E3A091481E6.9230@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|SN7PR11MB7138:EE_ x-ms-office365-filtering-correlation-id: 0469cd52-7a9e-409b-abdc-08dc0e30f345 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: phkdDdUdobmqPKLByRk70EcrMIlEp4SbDB2zNOboO/aUUBTqjaaXc7qdx1gEDPUgfrcf3mR4nvD1yXdd0lZ27Q2MLL3b4Zy0hqaLAmc3iHQJPu3IYPQSvFJLkO5DQUHK/J81GFpl3yZ7D77nqjmVGgfxbEI4oPgst6fn8WiGtJjEtJch3u3H/yc0ZJPFSk5M3f8ZMMuWfje1Et5ymFONzVeqJ7oPM2+pqBkAlnCSjmmOkp2au9jBC0KKqSQkQL7YDmoLzhlXWhjRuktnygiV4keDuRdqKfRcBNs5VjAD+0OjvAv0Bx1A0FxoN9QzRQ9BjZYv1PNXhkWx6RkpxmavHphwJivvmEEorNTJUOFTvs5qqEtZDVEcQjug8LSy7vCE9bh2XVSV8sM+YVtdqBue7BmfQpJ22hkIgUifMy4ZSyj1qqLsnR3Wfaq0pyud2wbxM7Pk20uyZgt2kN4Abwd9idJa+kvQz3BWdGod75ysIyvp0wyi9hbotESDFSARdpIrhCxjGiZSH3ZMNGTmKWXgg9fSaVcoKWclwC7X/Tqzeg8ndn7MkRpzpWGFbVtup6tTZSJk7igaGstWpsAUbc+EjaCvfrdJm2O9XkeqQue30cA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PYw/zhFeihDWxp2mrqnGV2FfYAsQd82jUJhDJy0PmDA509s3WpzW0TXUy+7s?= =?us-ascii?Q?eZflNpaKfpfBRxiZczwj4QaYBCO/B/pNZFLy8le9gRpAKnN4Xf6M98FwcoCl?= =?us-ascii?Q?qBor6hP/D0Mt2BcrA5f6l1SBk+GGG81g75gG/49DbwXhOuvk1g3E0Y9dr/Aj?= =?us-ascii?Q?owwDtCg3I5nVfyFavKuWbi3z7mtpMgNOqUixwbDhxOctpb0G7P+nDh5Z7Rmv?= =?us-ascii?Q?ejYF1oW0FdrICbaVfCOPGE9CK4V7bQlWY6fGwIVqtlMzJdoJh846zvvFE1cU?= =?us-ascii?Q?VF3i6q3DzxHxREKyrvsA65XQIzTuEfRA9OB13N2VV2IFmVk4bLgd+JieGmtT?= =?us-ascii?Q?3wqEc3Bnm/WqAFi7yONkbBY4897mbce8qhchFS1B2CFIYHyZlObTapUY58Ah?= =?us-ascii?Q?mk1yXxyZ/o0RJ2kOhXuTxbQSbY5Kde8b7L8wugKycmVafGjOgDhKxsf/rGTE?= =?us-ascii?Q?1jlWTcf6y7qKHtUbv6uhoURgsdriklb99+So5AyKJmVWnQkydN03Z25Z5NqF?= =?us-ascii?Q?IIgTujR2iW1QLuc7FUSiYY23aBlgJ7wi0jnFtKsPsohB36WhOLYJdJwHN+8U?= =?us-ascii?Q?tjIp0ooy3m5skNuxPx2RM7y298DTHufQ8j7w+f7OCnIS+MTn0N0bzWi2DOrB?= =?us-ascii?Q?SCZV95+TlR9tfqNexrXb80hin2b0dAiFWhRi0lH/4vRPLwCAddku1jYkm6Hl?= =?us-ascii?Q?S80vRorYvP0ByBM4SytRXHy6RS5kFYDnsLtwwQSPwKh+SmazFL4/OfvjtLVi?= =?us-ascii?Q?GB6IZFrb9c/SBMayfmbUJkKAWfADNCtsEiTOF+qwv6TR2jGQOjVcdLH3nQ+d?= =?us-ascii?Q?ehpPaGoNs0bs3ZAyAZjHs+0dcF9Kp6P3WUMwuPubtiJFwDC5fSvwKt/NlKiy?= =?us-ascii?Q?QSbpNQr+GajVrWXs6q3p7HHQ3ue7rxRQ2lAONEgRj2UEZ5Ysonkl9tSe8dvc?= =?us-ascii?Q?aWCvsOJsVJENV1ucs/U55agktJGQOffk65/2lb9IcOy2Pv46afjPA03MnkI2?= =?us-ascii?Q?6XF99abifiJQ2UtbDq8bEC4EQSQwsYFMKz1UWq0kCAQgoj0kusaBQDgVk9yg?= =?us-ascii?Q?QwQJlLi3zGp+ntOhQT0PYdPEIDJMtqAPhUzaMQ+Qh0k7EMr6fRrQ/QP8IXMb?= =?us-ascii?Q?+Swcqhv+gpGKIfVvA0mYie2RIjoaZz7RVYaWYYaEt5W9lci6FOEWIEF70jt5?= =?us-ascii?Q?9CvK6bMnhT04QZp+Efc8tpG64hlAo1SJPdH/JXaNUcpnQBpG7HUhXsE09E/7?= =?us-ascii?Q?XAyBIXXLPxycrjK/Yy1M/c1NHuxHaOnwvI8Sukth6r+O0Dxw5lnxWrKQSs5A?= =?us-ascii?Q?VVQG8keF/k0hdrJiItBeAreoqY1zalcdFoA4q+U8JpftZSgZOSc+qnwGoLwm?= =?us-ascii?Q?wgB/+9/3CIQxtF1S8da+4Lj/Uk/9dPoGqGNNV0BPYm8mjz3ogk/dXTZBWfSy?= =?us-ascii?Q?SIt9sNbdZCYcW6YWdqsYUmQszonMmAkBTEokDLEePA22umoS76aYr8HoLUvp?= =?us-ascii?Q?54I837UWZua/LxrHnRYfLvK/9hGB3TILMj8w1ib09uIvsk4fHrHVoI/FgwKj?= =?us-ascii?Q?m++qZPMSJadcJqw1CXQ315ycUCJXdgUJN5WgoOzZKl+T53w1teesds1FNtAM?= =?us-ascii?Q?Cg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0469cd52-7a9e-409b-abdc-08dc0e30f345 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2024 20:57:38.2227 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WLk5qyh4NdZ44FQLvBvSYAD0Hg+R5RuICSensWDE6u60e9J+z0p1hBSI1Xlg7eL9kQQAZDlfbaQ2+BMEJFZUm3zXuSV+JIikpe7GHshCWEY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7138 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: G8l0dKKv7QbNLFpA3iGpzbkgx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ewGUDsYD; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Pushed as 9cf1d03 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Nate > DeSimone > Sent: Friday, September 29, 2023 3:12 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ni, Ray ; Kinney, > Michael D ; Chiu, Chasel > > Subject: [edk2-devel] [PATCH v2] EmulatorPkg: Add EFI_STATUS return to > EMU_THUNK_PROTOCOL.SetTime() >=20 > There is an inconsistency between the UNIX and Windows implementations of > EMU_THUNK_PROTOCOL.SetTime(). The Windows version returns an > EFI_STATUS value whereas the the UNIX implementation is VOID. However, > the UNIX implementation is an unimplemented stub whereas the Windows > version is implementated. >=20 > The current EMU_THUNK_PROTOCOL function pointer definition specifies a > VOID return type. However, EMU_THUNK_PROTOCOL.SetTime() is close to the > spec defined gRT->SetTime() except for missing the EFI_STATUS return type= . >=20 > Therefore, I conclude that the most sensible reconciliation is to add the > EFI_STATUS return type to the protocol definition. >=20 > Cc: Andrew Fish > Cc: Ray Ni > Cc: Michael D Kinney > Cc: Chasel Chiu > Signed-off-by: Nate DeSimone > --- > EmulatorPkg/Include/Protocol/EmuThunk.h | 5 +++-- > EmulatorPkg/Unix/Host/EmuThunk.c | 4 ++-- > 2 files changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/EmulatorPkg/Include/Protocol/EmuThunk.h > b/EmulatorPkg/Include/Protocol/EmuThunk.h > index c419d0a677..bdd57f410b 100644 > --- a/EmulatorPkg/Include/Protocol/EmuThunk.h > +++ b/EmulatorPkg/Include/Protocol/EmuThunk.h > @@ -2,6 +2,7 @@ > Emulator Thunk to abstract OS services from pure EFI code >=20 > Copyright (c) 2008 - 2011, Apple Inc. All rights reserved.
> + Copyright (c) 2023, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -148,12 +149,12 @@ VOID > typedef > VOID > (EFIAPI *EMU_GET_TIME)( > - OUT EFI_TIME *Time, > + OUT EFI_TIME *Time, > OUT EFI_TIME_CAPABILITIES *Capabilities OPTIONAL > ); >=20 > typedef > -VOID > +EFI_STATUS > (EFIAPI *EMU_SET_TIME)( > IN EFI_TIME *Time > ); > diff --git a/EmulatorPkg/Unix/Host/EmuThunk.c > b/EmulatorPkg/Unix/Host/EmuThunk.c > index ee0843eebf..c57c105a53 100644 > --- a/EmulatorPkg/Unix/Host/EmuThunk.c > +++ b/EmulatorPkg/Unix/Host/EmuThunk.c > @@ -387,14 +387,14 @@ SecGetTime ( > } > } >=20 > -VOID > +EFI_STATUS > SecSetTime ( > IN EFI_TIME *Time > ) > { > // Don't change the time on the system > // We could save delta to localtime() and have SecGetTime adjust retur= n > values? > - return; > + return EFI_UNSUPPORTED; > } >=20 > EFI_STATUS > -- > 2.39.2.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113320): https://edk2.groups.io/g/devel/message/113320 Mute This Topic: https://groups.io/mt/103312902/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-