From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web08.3892.1642042319499292489 for ; Wed, 12 Jan 2022 18:51:59 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=hkXqp8zT; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642042319; x=1673578319; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=TP//dtsDjMVhKdcbPEcvbNT735oNKvaR8Z0HSjbFXQM=; b=hkXqp8zTyoayppwrw4XierqaRmNp/QOHmvYQuHST3f8/NibklAJBoqc0 2tEwEW1jYbY81WG6JCwVWLOqICjbFIlnjuUg11vh1a1XIc0Hcgp8t/IxO 9wVSqdUru3UpaiS0K4tEY2PChzSEGxhEp2AtIKygqPvxo+5f3ah7RyX1N MM3AWitF4b2HpH9T4oUs1CZMm/dZDlLGA7+sDDkngJnzIwOsYu7p7VB8E caQFpzp1+emW3DdFyH5zrljOIQSQvZvaFtb8v7WlTzvMW6bjwIcgvf3bk bDEE6KOfxtBRoP//2hWCIvMpznaUUgxXGcgvDiAEI5xDSghTDwt9fo9FG A==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="243709005" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="243709005" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 18:51:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="515754332" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 12 Jan 2022 18:51:58 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:51:58 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 18:51:58 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 18:51:58 -0800 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 18:51:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q1hQopqajJzG+ux2jCdMQX+GlNpHqkQEI4NILy1ryTBDxAWWmFmyxU40Mmw5QLAVGhM43uAXzQHLOQ+urbpzQAMf7brXxwoakoC1m+KVsJRjQJf07P/DduWzFOMdpKwjV+XLwjzJz7Px+hv4kA7bW6kpu39BFJ3UFKo788lue2QhdQEa4o0bcMwdgMnTExmtJxwX3mpb+95p1Ru/TmW5H6ScDgGXlJxCTLaOFQuGJIp6wIPYaBZjPbaoR/JSbQnaqOyzoEOZWgIpG+5ad8LKxHJOUA/n+4RAiHf/bvVNYqB8szb0Xbg7oFd7wp+nlLLPqUa3GlDiXj4xnrIOqVj38g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E1cYq5FzR78fo7sJW52Zi5AlVWMruMd3A5wKFC7kPu8=; b=EMDcfWl0pQle6DEPBbURHHEe5+PyS7ROKBTiKvYvI/F5ejeMcoQgisoJ1yuMbBcnlM2FL2t0hbLi+jwAuj8q4LQd8nrfxU8qXWiHW3hllC7Vh+5L2rRQTbEhZZDPWe8F6gcTvgYMycg6npq1kXmQwMgqqaGKfqdPDrJg+Lmj6+COhFlIkrUxWpNYSNLF/sTQ5eapAOD5p9XcWLOuBxlQsLYBsXkTgU7z9h27tfWhaVkDtSD9Wb7ghRN8qqHxvJdy2yP+SBAYcf9qqXJXbRquU1KNhGPYZUlnbB5xMnrx6H6r6J3KujLBt1r4e3AIcNadTXwGwwhJytxq2jsJUFALBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MW5PR11MB5764.namprd11.prod.outlook.com (2603:10b6:303:197::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Thu, 13 Jan 2022 02:51:55 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%8]) with mapi id 15.20.4867.011; Thu, 13 Jan 2022 02:51:55 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 27/27] WhitleyOpenBoardPkg/Build: Enable Features/Intel features Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 27/27] WhitleyOpenBoardPkg/Build: Enable Features/Intel features Thread-Index: AQHYB1sL8LyEYEKMrUmgmUsouVhu8KxgQlMA Date: Thu, 13 Jan 2022 02:51:55 +0000 Message-ID: References: <1fb46d33fe8bdc97b85f3c1da21eae2dc783f273.1641953242.git.isaac.w.oram@intel.com> In-Reply-To: <1fb46d33fe8bdc97b85f3c1da21eae2dc783f273.1641953242.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3b54031f-50cb-448f-ae55-08d9d63fa913 x-ms-traffictypediagnostic: MW5PR11MB5764:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m14bOxQn8DXoh+LDaJBDW0wn0ibgq8yNvGvpUR9yKzHEm0meHGeV4umqcDnBdu//Dc0RkrIzJVSwSHRGMXlJjVOYHS8WULYKS0+39XbEvdruj3t+xhmHXQwZT6MjFeTE7K2utNcF2dTUE1w/eSO06FblRdmEW72/5PuHCa/qMIWrlni5k/tmNA9ZvJ8sFwMZY9M2z+cdPcHyRwfAUH7Fj/Q2ger/yktMuqBUO88jrDQiJGe9OZbg2VdR3+eoyOWbW8FpumNhxAV+dQRP+pjTa6hWztinZOmhaqn5hekxsI4zsCn5PCZNc2Rd40TXUyExlrTEs2zsHVu0kjO/tXmuHwZ46HfomPQNmoF7Ky/gipGOrwtGVHVuLkO9gzk51cO0I+jH5epz6izKq7oyb8QRbIgJ3uy2+vvm/c2ML8a+C5QO5Mc34HVe0T4FbvyzKEG3JnRjEnLqhOpiX8DmC+Pd8ceIXeyEQf2ApoVhwx5qHkgcotMvATN1ORDQ+QnKFbELKSs2KSmqKxXvlaHTAu1A6cdEnDJWMd2EwKhEsABYsDwId0CH7rti18DBsEcMrNPk4OaUPTCUCOKD697UelfcZTaHzcRENZ6CLs3wBqe/pU5/3Qi0a2wSCnsjQ/N8iuXMSjng+5it0qq/5wGpWCemOHVQwFTBJpD2GbHJcsnn6QAIxyRx8FUMPOOk90WqV6PHz5EtShrbKJ0fHi625ClEZg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(2906002)(71200400001)(9686003)(316002)(52536014)(26005)(107886003)(33656002)(19627235002)(38100700002)(122000001)(38070700005)(110136005)(186003)(55016003)(7696005)(82960400001)(8676002)(508600001)(8936002)(83380400001)(86362001)(5660300002)(76116006)(6506007)(66446008)(64756008)(4326008)(66556008)(53546011)(66476007)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CLK+H8rshn7sWR1M3+4ZHHMbZKx6XF6VX49fBUzmwV0ngtovnroReVdp+hPY?= =?us-ascii?Q?hkW4CoMxgSAezQoUDq8c/NsEnC5j8OiAicaxv9f5Zd4JmsPI2WPpGzpeozBY?= =?us-ascii?Q?ZCJX0WCaPoor1cRlWGX+7ezNwokLKguPvt0LCpB+uUQha65JxhBP1ZLE+bqX?= =?us-ascii?Q?EiORr8xPFohKnr6NN8lKBL7Lyt6ThCVW94rORimucokvlG/D/lYTUaxmqbIh?= =?us-ascii?Q?uFggNzbWjNtmfqmOCYUCU2fK63i4CBISQFOuIw9kIcWOTP9YCSLZt7o80s8c?= =?us-ascii?Q?QATc1aDm3C+GUdwZGJUaWwDmRSGrJ5j2CNDcfGHDq/SUuqbydVuOU6jXjJow?= =?us-ascii?Q?sNxzrHjoFzwvgnSvYDnf/q2J/Vi/4twKuaw3HkH53Fl8lP969czDWiMP9pbe?= =?us-ascii?Q?VulbSOPRQ9VR/1e31tXiqY8B9g+xBS1kWaEov8nDiVj06oJtB8XWcTnQ4+ys?= =?us-ascii?Q?wuSCSQPZMA+cWNLxTC4W5LTHLRcEJp9ZHvwRcySW1e6t4l2KCPR1rHTvJq97?= =?us-ascii?Q?XTzaUTzm1TeEQSSaToXTjOn/lsxOes/35HxOuJFP2KczUN8B1m43WveNCtT0?= =?us-ascii?Q?QYTQ7nmw+lKQ7VUo9F0ZBTS4ai8c3gf39Aa8VMBZ9yvGWDD3rbMLB+z5llDZ?= =?us-ascii?Q?wUyRtbslOI869yRTyVQTX/B90GoxDMLydfxi6UW4mLb5k7QZPWx92jouAal4?= =?us-ascii?Q?VkXHLPpKlfs+WVq474xBCUihBaCD8EuWa02ncNPZKjiAo1aLhAgHmaT2Wz4i?= =?us-ascii?Q?qPKji+hx9zTTxVtl8IiVboTAKcKXW1s0kZzHRVIqUPuxcJLEAkpTsHe2oFTu?= =?us-ascii?Q?PL7toWyZdOD9/4ZOLNhBhmSL3E27ntw87UPj37t2zBhjftaQwbn/CRbpGvP1?= =?us-ascii?Q?qRSNMGLlz8Q4EoBCudLNOqEGx9UWTZGp9VyBItpzouuWajc6WQUmiuHnbumy?= =?us-ascii?Q?YtJw9RYgxYWg1HW22Ijmp3L4pbXqaBcwYVgmbfKklf/1UiilVuOgFDSEZOcW?= =?us-ascii?Q?h8yUSabIAExnzPzz6vd7Rl029VZFRDXUco43KScliDhJoW3pwc+ZKYydAyZV?= =?us-ascii?Q?G/cGUOTkR2QnGzKXzpKpgJ39wxrHV9/O9IF9JUbApEbB3mf/bjPHMv2++URy?= =?us-ascii?Q?u1FWr5L/zUyVafVADN9SnF90nGJy4xLuWplCk+RxqRu3XuL7fYpybWo2qLfW?= =?us-ascii?Q?tRA0zTizA/cGgwxUl6yxo/d4oq5i7NnKHpx8iUCntiNZGe/rTz7zAvGYXEt8?= =?us-ascii?Q?9dvnCX1xZvxZEkDkqApFA585MwlhpiprDnp1rzZWkulzqrza4y7GBerBNZ0m?= =?us-ascii?Q?ZNN3fVaUW6uhz7+P6iutG+5wzJ5jswbsZzyP0Zaq9QkfW1gHtr1CaSLZixh3?= =?us-ascii?Q?RU/3xXotJDNO4FzzhBMm6zx1LxEaR6PxT6Wv1P5fPKwgQnkV4n/DgBYwfob4?= =?us-ascii?Q?VoAH/hRTktzrSRRkGqfguLB6wrsv9zzXJ5iD+m0DmO9eQvk+tdto1mRo3plz?= =?us-ascii?Q?S127oUEbB/Uzdwk9pwZ4rHoRnYeHBhVaRRH1koC3VqP5cUntrzGNUkYzXiqm?= =?us-ascii?Q?kL5HPKRcQbKNth+p8sP3WVPFbKzedWNU6fSTgcOozaTGDipiZPPy+iArwSa0?= =?us-ascii?Q?GJPMV4MRPqdqXaf5oxpG4WJjiN9F6i9gKUvpBvdi81bH2HePXmbO53wnQS02?= =?us-ascii?Q?N6EVoQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b54031f-50cb-448f-ae55-08d9d63fa913 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 02:51:55.6777 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g3MdtvcPKZ1lOYCy0DigWR1goTU64UTv6GQ/lITYn9Z3juht5j499NzbQmxeNOlz/BoOHAoDnOtddyVofVqoRXQeDgb6xgippH7ag+AMbUU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5764 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone > -----Original Message----- > From: Oram, Isaac W > Sent: Tuesday, January 11, 2022 6:20 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; Chiu, Chasel > Subject: [edk2-devel][edk2-platforms][PATCH V1 27/27] > WhitleyOpenBoardPkg/Build: Enable Features/Intel features >=20 > This enables Whitley as a test vehicle for features. > These are not expected to be fully functional at this time. > Specifically UserAuthentication causes a boot failure and the others have > only been verified to be built and dispatched, not ported to the Whitley > reference platform hardware. >=20 > Cc: Nate DeSimone > Cc: Chasel Chiu >=20 > Signed-off-by: Isaac Oram > --- > Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc | 44 > ++++++++++++++++++++ > Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf | 6 ++- > 2 files changed, 49 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc > b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc > index f07b0a8ccf..42680254d1 100644 > --- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc > +++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc > @@ -39,6 +39,50 @@ > DEFINE IIO_INSTANCE =3D UnknownCpu > !endif >=20 > +!include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc > + > +[PcdsFixedAtBuild] > + > gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortLibInstance|1 > + > +[PcdsFeatureFlag] > + # > + # Debugging features > + # > + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdAcpiDebugFeatureEnable > |FALSE > + gBeepDebugFeaturePkgTokenSpaceGuid.PcdBeepDebugFeatureEnable > |FALSE > + > gPostCodeDebugFeaturePkgTokenSpaceGuid.PcdPostCodeDebugFeatureEn > able |FALSE > + gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugFeatureEnable > |FALSE > + > + # > + # Network features > + # > + gNetworkFeaturePkgTokenSpaceGuid.PcdNetworkFeatureEnable > |FALSE > + > + # > + # OutOfBandManagement features > + # > + gIpmiFeaturePkgTokenSpaceGuid.PcdIpmiFeatureEnable > |FALSE > + gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrFeatureEnable > |FALSE > + > + # > + # PowerManagement features > + # > + gS3FeaturePkgTokenSpaceGuid.PcdS3FeatureEnable = |FALSE > + > + # > + # SystemInformation features > + # > + gSmbiosFeaturePkgTokenSpaceGuid.PcdSmbiosFeatureEnable > |FALSE > + > + # > + # UserInterface features > + # > + gLogoFeaturePkgTokenSpaceGuid.PcdLogoFeatureEnable > |FALSE > + > gUserAuthFeaturePkgTokenSpaceGuid.PcdUserAuthenticationFeatureEnabl > e |FALSE > + > + > gVirtualKeyboardFeaturePkgTokenSpaceGuid.PcdVirtualKeyboardFeatureEn > ab > + le |FALSE > + > +!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc > + > # > # Platform On/Off features are defined here > # > diff --git a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf > b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf > index 7e2a8b1b9f..45460570d9 100644 > --- a/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf > +++ b/Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf > @@ -84,7 +84,7 @@ SET gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize > =3D 0x01000000 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize =3D > 0x00040000 # Size must match WhitleyFspPkg.fdf content > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize =3D > 0x00221000 # Size must match WhitleyFspPkg.fdf content > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize =3D > 0x00006000 # Size must match WhitleyFspPkg.fdf content > - SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvBspPreMemorySize =3D > 0x00001000 > + SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvBspPreMemorySize =3D > + 0x00010000 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPreMemorySize =3D > gCpPlatFlashTokenSpaceGuid.PcdFlashFdSecPeiSize - > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvBspSize - > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemorySize - > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize - > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize - > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize - > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvBspPreMemorySize >=20 > # > @@ -481,6 +481,8 @@ SET > gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize =3D 0x01000000 > !include MinPlatformPkg/Include/Fdf/CommonSpiFvHeaderInfo.fdf > FvNameGuid =3D 09f25d44-b2ef-4225-8b2e-e0e094b51775 >=20 > + !include AdvancedFeaturePkg/Include/PreMemory.fdf > + > [FV.FvBspPreMemory] > !include MinPlatformPkg/Include/Fdf/CommonSpiFvHeaderInfo.fdf > FvNameGuid =3D e6c65995-8c2d-4119-a52d-7dbf1acb45a1 > @@ -710,6 +712,8 @@ SET > gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize =3D 0x01000000 > !include MinPlatformPkg/Include/Fdf/CommonSpiFvHeaderInfo.fdf > FvNameGuid =3D 70aeaf57-4997-49ce-a4f7-122980745670 >=20 > + !include AdvancedFeaturePkg/Include/PostMemory.fdf > + > [FV.FvAdvanced] > !include MinPlatformPkg/Include/Fdf/CommonSpiFvHeaderInfo.fdf > FvNameGuid =3D f21ee7a1-53a9-453d-aee3-b6a5c25bada5 > -- > 2.27.0.windows.1