public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: Laszlo Ersek <lersek@redhat.com>,
	edk2-devel-groups-io <devel@edk2.groups.io>
Cc: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
Subject: Re: [edk2-devel] [edk2-platforms PATCH 4/6] SimicsOpenBoardPkg: fix SEC ProcessLibraryConstructorList() prototype
Date: Fri, 9 Feb 2024 22:53:09 +0000	[thread overview]
Message-ID: <MW4PR11MB58215A74AF81268E460E0BCCCD4B2@MW4PR11MB5821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <49518316-09b3-69ae-8acd-ef4ff4471873@redhat.com>

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Friday, February 9, 2024 1:24 AM
> To: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; edk2-devel-
> groups-io <devel@edk2.groups.io>
> Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
> Subject: Re: [edk2-platforms PATCH 4/6] SimicsOpenBoardPkg: fix SEC
> ProcessLibraryConstructorList() prototype
> 
> On 2/9/24 01:07, Desimone, Nathaniel L wrote:
> >> -----Original Message-----
> >> From: Laszlo Ersek <lersek@redhat.com>
> >> Sent: Tuesday, February 6, 2024 5:09 PM
> >> To: edk2-devel-groups-io <devel@edk2.groups.io>
> >> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chaganty,
> >> Rangasai V <rangasai.v.chaganty@intel.com>
> >> Subject: [edk2-platforms PATCH 4/6] SimicsOpenBoardPkg: fix SEC
> >> ProcessLibraryConstructorList() prototype
> >>
> >> The current declaration of, and call to, SEC
> >> ProcessLibraryConstructorList() in SimicsOpenBoardPkg matches the
> >> PEIM entry point parameter list. Fix the call, and rely on AutoGen for the
> declaration.
> >>
> >> Untested (no idea what hoops to jump through to get this built).
> >
> > Laszlo - This can be built using the following instructions (tested on Rocky
> Linux 9.3):
> >
> > First Time Setup
> > ================
> > sudo dnf install python3-pip git
> > sudo dnf install make g++ acpica-tools libuuid-devel sudo dnf
> > config-manager --enable crb sudo dnf install nasm wget
> > https://github.com/tianocore/edk2-edkrepo/releases/download/edkrepo-
> v3
> > .1.3/edkrepo-3.1.3.0.tar.gz tar -zxvf edkrepo-3.1.3.0.tar.gz
> > --one-top-level cd edkrepo-3.1.3.0 ./install.py cd ~/src
> >    --> Or wherever it is you like to store code edkrepo clone intc
> > Intel-MinPlatform
> >
> > Building
> > ========
> > cd intc/edk2-platforms/Platform/Intel/
> > ./build_bios.py -p BoardX58Ich10 -t GCC5
> >
> > --> You can see a list of all available Intel platforms by running build_bios.py
> without arguments.
> 
> Thanks!
> Laszlo

Oh, and if you would like to try running it. The software is available free-of-charge here:

https://software.intel.com/content/www/us/en/develop/articles/simics-simulator.html

> 
> >
> >>
> >> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> >> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> >> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> >> ---
> >>  Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> >> b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> >> index 39e879e9223e..09d43c6bf63b 100644
> >> --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> >> +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> >> @@ -9,7 +9,6 @@
> >>
> >>  #include <PiPei.h>
> >>
> >> -#include <Library/PeimEntryPoint.h>
> >>  #include <Library/BaseLib.h>
> >>  #include <Library/DebugLib.h>
> >>  #include <Library/BaseMemoryLib.h>
> >> @@ -738,7 +737,7 @@ SecCoreStartupWithStack (
> >>      Table[Index] = 0;
> >>    }
> >>
> >> -  ProcessLibraryConstructorList (NULL, NULL);
> >> +  ProcessLibraryConstructorList ();
> >>
> >>    DEBUG ((EFI_D_INFO,
> >>      "SecCoreStartupWithStack(0x%x, 0x%x)\n",
> >



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115337): https://edk2.groups.io/g/devel/message/115337
Mute This Topic: https://groups.io/mt/104210908/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-02-09 22:53 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07  0:50 [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules Laszlo Ersek
2024-02-07  1:04 ` [edk2-devel] [PATCH 00/11] " Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 01/11] OvmfPkg/Sec: Use correct prototype of ProcessLibraryConstructorList() Laszlo Ersek
2024-02-14 14:27     ` Ard Biesheuvel
2024-02-07  1:04   ` [edk2-devel] [PATCH 02/11] OvmfPkg/RiscVVirt/Sec: don't #include <Library/PeimEntryPoint.h> Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 03/11] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 04/11] ArmPlatformPkg: remove SEC ProcessLibraryConstructorList() declarations Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 05/11] ArmVirtPkg: remove SEC ProcessLibraryConstructorList() declaration Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 06/11] EmulatorPkg: " Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 07/11] IntelFsp2Pkg: " Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 08/11] OvmfPkg/RiscVVirt: " Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 09/11] OvmfPkg: " Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 10/11] UefiCpuPkg: " Laszlo Ersek
2024-02-07  1:04   ` [edk2-devel] [PATCH 11/11] UefiPayloadPkg: " Laszlo Ersek
2024-02-07  1:09 ` [edk2-devel] [edk2-platforms PATCH 0/6] clean up SEC ProcessLibraryConstructorList() declarations Laszlo Ersek
2024-02-07  1:09   ` [edk2-devel] [edk2-platforms PATCH 1/6] ChachaniBoardPkg: remove SEC ProcessLibraryConstructorList() declaration Laszlo Ersek
2024-02-07  1:09   ` [edk2-devel] [edk2-platforms PATCH 2/6] BeagleBoardPkg: " Laszlo Ersek
2024-02-07  1:09   ` [edk2-devel] [edk2-platforms PATCH 3/6] QuarkPlatformPkg: " Laszlo Ersek
2024-02-07  1:09   ` [edk2-devel] [edk2-platforms PATCH 4/6] SimicsOpenBoardPkg: fix SEC ProcessLibraryConstructorList() prototype Laszlo Ersek
2024-02-09  0:07     ` Nate DeSimone
2024-02-09  9:24       ` Laszlo Ersek
2024-02-09 22:53         ` Nate DeSimone [this message]
2024-02-07  1:09   ` [edk2-devel] [edk2-platforms PATCH 5/6] LoongArchQemuPkg: " Laszlo Ersek
2024-02-19  2:21     ` Chao Li
2024-02-19 20:08       ` Laszlo Ersek
2024-02-07  1:09   ` [edk2-devel] [edk2-platforms PATCH 6/6] SG2042Pkg: clean up SEC ProcessLibraryConstructorList() declaration Laszlo Ersek
2024-02-14 14:25   ` [edk2-devel] [edk2-platforms PATCH 0/6] clean up SEC ProcessLibraryConstructorList() declarations Ard Biesheuvel
2024-02-07  1:16 ` [edk2-devel] BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC modules Michael D Kinney
2024-02-07 15:40   ` Laszlo Ersek
2024-02-08 16:40     ` Michael D Kinney
2024-02-15  7:57       ` Laszlo Ersek
2024-02-15 17:29         ` Michael D Kinney
2024-02-16 14:16           ` Laszlo Ersek
2024-02-16 17:21             ` Michael D Kinney
2024-02-24 18:02           ` Laszlo Ersek
2024-02-24 18:37           ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB58215A74AF81268E460E0BCCCD4B2@MW4PR11MB5821.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox