From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Duggapu, Chinni B" <chinni.b.duggapu@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
"S, Ashraf Ali" <ashraf.ali.s@intel.com>,
"Kuo, Ted" <ted.kuo@intel.com>
Subject: Re: [edk2-devel] [PATCH] IntelFsp2Pkg/PatchFv.py: FIX for GCC 32BIT build error
Date: Fri, 3 May 2024 20:10:09 +0000 [thread overview]
Message-ID: <MW4PR11MB5821610A037963F10D8D0617CD1F2@MW4PR11MB5821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240423040248.1901-1-chinni.b.duggapu@intel.com>
Pushed as 248aa15
> -----Original Message-----
> From: Duggapu, Chinni B <chinni.b.duggapu@intel.com>
> Sent: Monday, April 22, 2024 9:03 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Duggapu, Chinni B
> <chinni.b.duggapu@intel.com>; S, Ashraf Ali <ashraf.ali.s@intel.com>; Kuo,
> Ted <ted.kuo@intel.com>
> Subject: [PATCH] IntelFsp2Pkg/PatchFv.py: FIX for GCC 32BIT build error
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4762
>
> Map file generating 8 byte address offset is not matched with the pattern
> defined in patchFv tool resulting build error.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> Cc: Ashraf Ali S <ashraf.ali.s@intel.com>
> Cc: Ted Kuo <ted.kuo@intel.com>
>
> Signed-off-by: Duggapu Chinni B <chinni.b.duggapu@intel.com>
> ---
> IntelFsp2Pkg/Tools/PatchFv.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/IntelFsp2Pkg/Tools/PatchFv.py b/IntelFsp2Pkg/Tools/PatchFv.py
> index bd9aa71e3c..d35aa1dc9f 100644
> --- a/IntelFsp2Pkg/Tools/PatchFv.py
> +++ b/IntelFsp2Pkg/Tools/PatchFv.py
> @@ -432,7 +432,7 @@ class Symbols:
> if reportLine.strip().find("Archive member included") != -1:
> #GCC
> # 0x0000000000001d55 IoRead8
> - patchMapFileMatchString = r"\s+(0x[0-9a-fA-F]{16})\s+([^\s][^0x][_a-zA-Z0-9\-]+)\s"
> + patchMapFileMatchString = r"\s+(0x[0-9a-fA-F]{8,16})\s+([^\s][^0x][_a-zA-Z0-9\-]+)\s"
> matchKeyGroupIndex = 2
> matchSymbolGroupIndex = 1
> prefix = '_'
> --
> 2.44.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118562): https://edk2.groups.io/g/devel/message/118562
Mute This Topic: https://groups.io/mt/105684430/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-05-03 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 4:02 [edk2-devel] [PATCH] IntelFsp2Pkg/PatchFv.py: FIX for GCC 32BIT build error cbduggap
2024-04-23 5:53 ` Ashraf Ali S
2024-05-03 0:06 ` Nate DeSimone
2024-05-03 20:10 ` Nate DeSimone [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB5821610A037963F10D8D0617CD1F2@MW4PR11MB5821.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox