From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.3485.1654725201746434932 for ; Wed, 08 Jun 2022 14:53:22 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=hL4GLvvD; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654725201; x=1686261201; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=hzyHW+qHy2Yk/9VGrNK/GBPcHDEtd+dpXDaU2gy7RrU=; b=hL4GLvvD8NjoLT4I9TGfVcXlAtPqCkfRgbYdUGZKk8idtbPHpqwDONLD Y5VnM1kTg+5g5+FLTTfVzqx0H6u1L4X4iQZzddu5aPolJksOHboOVYi6e OqyHmUpnz70cGiEzwyDP3ZFQZpPTG6zy1MsWxB77PvY5D7eNnd0HOvNzq 8MkwPMpCSczRxEDT9XSLqsAHBXWtTJihdCqoOF3Qjosk+jkYYw1CTN7yH wq6j0sMvac8VQrOsBcgui1J2I1dV727ndh0OQeBbMTCK1dAcCC+1R4cSu Nse2TSQH/4GyDXuF1Ldqqvu98AZouuW+bHA146YDtX/bO/BA2YRFP2QEc A==; X-IronPort-AV: E=McAfee;i="6400,9594,10372"; a="256888680" X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="256888680" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2022 14:53:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="637083800" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 08 Jun 2022 14:53:20 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 8 Jun 2022 14:53:20 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 8 Jun 2022 14:53:20 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 8 Jun 2022 14:53:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aZbufsZd2ESYCG9eaO1jsLX2l7V64qo3vMnXJh3U/VGl8fR2r2bI/5AJtDMNP3US+LbU9GrZlNTKOd7Pkdu2oCjDS4I/StJ1DEeQk2HDkP1aaOJoKBKW58aUxiDHEhlw5zuRSFXUiet82H8WICjo9sE+QRD492HMDIJdTUzQuur5mUTOqTbOxfNdieg0ieKyWJvISDL/yCFSSk+woxAmIKh9O4fB7qkM4mFptC31XXm/UPO7+bvZZJnHoEE5O3EvBfjkyztd7GD9TDt2mbSmS5xf4xZD8/eTVxVkK3QJSQ6B2KwPSDx008ZubDI5sQMEXAfq10cWgfXE78JZh0r16w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xctIqSo4ectx1cuHjlseM6TCh5jjtixlNrjJPl1vQVA=; b=KgkorI/2woSp85S31ciFeIYv8GUtIvqugF2oWFv4OjfLKIWOH3WWCnDiWeZVZTUS9bOdoOH/RYaXt/BxLrdMSCyu67vCaofh9pwTIvUfykUiyZJk7Vj8w80TEgBqYfIX+F0+x9uJION7Cn62STDcTIOBIErpz9Hl75+GVAnH0dJdelEo4TcGqXSTIZTDw8GUoz5v95luyUCtVQFg8vpwUeaYYC/YoPyulj1myP5QpuKCSDsCSu10zN/1z13071bfaeyZbFCLob7K/JpRXQWQ/ep7dfU7O4vMwBlcSj0DuuJ3eMYKLPpkAxB+pQYAQDDspzGqQKP2KrPpKXWQygyWAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by BN6PR1101MB2244.namprd11.prod.outlook.com (2603:10b6:405:52::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.17; Wed, 8 Jun 2022 21:53:18 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::190c:c119:21b7:7589]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::190c:c119:21b7:7589%5]) with mapi id 15.20.5293.019; Wed, 8 Jun 2022 21:53:18 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout Thread-Topic: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout Thread-Index: AQHYesi2nYimHWmowUqtTpvkzc6OBa1GDsAA Date: Wed, 8 Jun 2022 21:53:18 +0000 Message-ID: References: <75465408b8a1cf0d269a2b1d2ea7707b6731893e.1654645346.git.isaac.w.oram@intel.com> In-Reply-To: <75465408b8a1cf0d269a2b1d2ea7707b6731893e.1654645346.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 50e440df-420b-494b-b290-08da49994c35 x-ms-traffictypediagnostic: BN6PR1101MB2244:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PXJQIX5wwpjAC+qUvdThGz+v0HKl0j3K5dbixlKTR3jZgwSg0H7kXobYOtbE/Wp9FTy+agxf+guJKwfjCMXWaGm2NWq1Ea8dZNaopkhfQB5SqN44R6NsA1mkzUEn4v0ir7MVocOoKW3jEO62mmOWFj+qqeBiFAhTwFxMDGiiFO4btMKfJitqCcjOoEvGJyDQAC2QR2J3pE0iEAqC6mh6z/7XmW4IEgkM2O6BRHiokI20wDqQq5bf0SG8LJ+8Z4bHqsPcNh2l6qfJVaTJ87yL7FNO5F/SeVpO2tnSENIKmtCuPgpHF4bkQEzD8QyBtcUGcMPZHUIvl/24x7FxpHIRbm58eBN/XjhcrvHCekj0Y8dEDG/bp06QYfTthBjwsP8C77HUXhk9huWomWYTNSyxNggcADj+3FQZbydZwsTT7ttPJKYPM1L+RWN67eSdxHoUANjbXypISDNNduaILCYutMVFFSOOoIdOsYyRu9veWeZipYaTZMr68TaMT1NgRY0WE4FWfeIEWe3RkX29NMPbQvdfZd87Er0SH0phETwuUGCYjELoAvoMbYazW/Y1zb8FNLRArX0LxayTR9e+cJgEPpXf3X2hvRAJSgRk8wBhDmwmwzN6vUkthWnecQ8DBZn6DFbw0eis8AkwHoo7Px1qjIKG0wnbcikpz1s1hwML35Gy1kxKTXjPmvbPHbRP4xRL2XpKtD4LhUSNRWAXlHr7+A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(83380400001)(186003)(71200400001)(107886003)(122000001)(66946007)(38100700002)(5660300002)(52536014)(508600001)(8936002)(33656002)(86362001)(7696005)(76116006)(2906002)(82960400001)(26005)(9686003)(53546011)(64756008)(110136005)(316002)(66446008)(38070700005)(66476007)(4326008)(66556008)(8676002)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2TIoulmszCWfbhZh0gEjwxpRdzeMUH/Oap5FABQxOxlE4NISNVJw1lDuJjL2?= =?us-ascii?Q?NKO4geOGANIZNyKHJ2fHHhEI4DYYpbNdK7iu/Wexgl+l8nN5JzMxixRQTFvF?= =?us-ascii?Q?ZjI7PBTzpMPPO8qH5WEgXJlrUvTEgtOH3ZxiyHzBRXM3izsqQcOz0eRm4Nux?= =?us-ascii?Q?FuOJX2mqY381yLbm6s8Gmsjz3CcZ98/OXUnYJx00nS0JX4rWytQ3o9lKKvrL?= =?us-ascii?Q?WnLs6ImjHyK7o3t8t9BAqLme8gZWf3fWqTtyiGs2K2yES1C4+3CpuODcWeka?= =?us-ascii?Q?7bf9JQvOv6dcYVRVa/nNJNgJfqsCF4q7W6IIcCgKCLB6OWKzLQHikxGVDff2?= =?us-ascii?Q?pMTQT0pLYksp1+9nLc2/p47A6eX/Q5nUM+dx4vHMyZ2UGRPVimbN3+DuexiP?= =?us-ascii?Q?EqxJSgPECj/0KsClBNBpmu/oIsiWOPuHcoBPdJ7104j1wjDcyiMTv+y2YOAQ?= =?us-ascii?Q?ibYeobesdkPHu4n+qHOmICQonVO0pOi0i/JQk8uuLala8ZTsiusWHfaoR/2w?= =?us-ascii?Q?WxxGE/m0UbB21VHhxBaIulr3GiWdU+TlAxSX9khR/jiCq4iQ2DK5Gm6/mnay?= =?us-ascii?Q?32WcAW7BZzcoKXkFP+oQrMnGmiJk87mXrW22AXLEIDspiegKKwv8EafPWgbm?= =?us-ascii?Q?eOAbIK8DkU18FGhEJUKKMkRJtiPRDe9CmnCvNYcSjJTRWDoFEJOtztsz4OXe?= =?us-ascii?Q?Ebx63xMNhXWAqu40imugz1pE7In3ekzqs3S+gYM5A+bFMTnViBHzmYX9QbWi?= =?us-ascii?Q?NyR3CFfpnByrlRRDxSr0sxWMVvQ4KaP2+rT0Ii181lcAL2srykwTz0fzvw5E?= =?us-ascii?Q?DnlrEipA1zLpkPqi/g2+7oAJfL7aDjpwrEqoX4aECzM3otqFNErVuJyjoYUp?= =?us-ascii?Q?fnmpIw/DSkz0Npgx0BKaxWrgpftL5eHStToKcWr9k4xMFY74RxVZuVL3in9T?= =?us-ascii?Q?vzx62Xyc6+Riw8lolO4nD9121mjGi3nWK9XYtSYDHaW+WvmLWp9rSl3J/GfR?= =?us-ascii?Q?S9XohApXUthQaK32jbE3K83WWExcrhEimX5AvnA1oAqxwiMnVFr7mQETgV5j?= =?us-ascii?Q?JWCcLnAGXeWh2YMlmIxD3GWv9wpPNm0UtTdJuMjRZJudTUjG2sQaNPIw+P2A?= =?us-ascii?Q?USAIA/L/wCRsET+VpxY3dUbTjgWnbn5UdKdpULPXjEer04WQW7FaW2l5nw6p?= =?us-ascii?Q?+8qoETF8s/RGaBKEkW5HKN3yBW22uTm1ecDhooTtO5Idj1P0WIRzGVeEDWf+?= =?us-ascii?Q?bfWP6IcaJmUUjIIxyT5t4ep/q/8DtDrDfhXY9mfov09Os9oaSNVskOPTrmNz?= =?us-ascii?Q?9sf3WPzVGDhlY7PfgbJNLtw9rUGRo4bKiuEQIhTUKh43smqChjlmTp+SGxDl?= =?us-ascii?Q?x4ImYR2Adgd1xK1+ti/tTPVFJEvdvrAkyr1UhXp8jl1NqKPSsrZWsvp6krIP?= =?us-ascii?Q?g0NR5n3gq+fpkXi7cgZ8Hu81Nw5QkQGiM5liJRRHiM/RsFMe8THCY2ETDW54?= =?us-ascii?Q?+wTapNtRZQtd0Z5t3AvDOBzkaPFhqwLMNtlRM66NSi08lm9BYPNjMKI5hf8M?= =?us-ascii?Q?EhzwUYZaWA0altfvgb4zKyv8H91rH1ZjKWhL0lCPJfV1PVWgRjciVSWBYxU/?= =?us-ascii?Q?HOxMmEoCE836KZNCrJFt1a+uf3YqjKxFB7CHf8z/CeEpkgdnVJofl9+s2sEC?= =?us-ascii?Q?wDZEqd0L+VFLE+4gzgfJB3boVOAMESKmrVqqYbw6E14Zf4rt88nlUzmkTYsd?= =?us-ascii?Q?9Nxk8WtYd8Iihtgoq7tsk6wVs6AwFAQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50e440df-420b-494b-b290-08da49994c35 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2022 21:53:18.3602 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3OJXUcd++SqCngE1jqM40hd2ZWxGp/AWPl2eni0WchfLiZPYEVS3aHBzWoRSGBfYiYANqrDUsZoL6JrqL1iFInP8KXshA0vaE7QK2W3ni84= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2244 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Oram, Isaac W =20 Sent: Tuesday, June 7, 2022 4:49 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPo= licyPpi: Fix binary structure layout V2: Use UINT8 instead of BOOLEAN for DmiStopAndScreamEnable and Rsvdbits2 V1:=20 Disambiguate the PCH_DMI_CONFIG and PCH_TRACE_HUB_CONFIG structure definiti= ons such that compilers generate same binary layouts. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram --- .../Pch/SouthClusterLbg/Include/PchPolicyCommon.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/Pc= hPolicyCommon.h b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Inclu= de/PchPolicyCommon.h index 0e10d0b8f0..11057a3ace 100644 --- a/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPolicy= Common.h +++ b/Silicon/Intel/WhitleySiliconPkg/Pch/SouthClusterLbg/Include/PchPol +++ icyCommon.h @@ -1351,7 +1351,9 @@ typedef struct { **/ UINT32 DmiAspm : 1; UINT32 PwrOptEnable : 1; ///< 0: Disable; 1: Enable = DMI Power Optimizer on PCH side. - BOOLEAN DmiStopAndScreamEnable : 1; + UINT32 Rsvdbits1 : 30; + UINT8 DmiStopAndScreamEnable : 1; + UINT8 Rsvdbits2 : 7; UINT32 DmiLinkDownHangBypass : 1; UINT32 Rsvdbits : 29; UINT32 Rsvd0[6]; ///< Reserved bytes @@ -1447,6 +1449,7 @@ typedef struct { TRACE_HUB_CONFIG TraceHub; UINT32 AetEnableMode : 2; UINT32 PchTraceHubHide : 1; + UINT32 Rsvdbits : 29; } PCH_TRACE_HUB_CONFIG; =20 =20 -- 2.36.1.windows.1