From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web12.20032.1654815176964679260 for ; Thu, 09 Jun 2022 15:52:58 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=h+s5ypV3; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654815177; x=1686351177; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=6zpYsrFX35LTTR8tP7XOMs7ESQC8FO5xzhTNDsrgUj0=; b=h+s5ypV3pZiWcMlop3rlLCwvPDJEuWTDC9CdXMlzm8VQWDeMbAYUc0hv 9CsIG85GQXgaV6jDCpZocwLLPTygh7UbUm2hoYIo3LFu1FQppHKIfxFqt 3tFoThNwZlWXhoXZYpQw8QkcdAK6UPumU4q7zU4mTjYwiUYFBC/bFLtG9 3NyWMJeEL7Y32tU4hMUzhMla0C3rK9LnlymV3OcSSp5dEvkXMwcXFroOR 4AoiQ/OUZMR0WJFEAEG9AfNZDw9xZgtvUZ1Xuw6NXEMSx5e38OdjjLxX4 kzT1BSQfMQAhNEsN9jxTbPErhxvqZt5/+69wixgGo/J60uQ4bHTnDxo3r g==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="363772312" X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="363772312" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 15:52:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,288,1647327600"; d="scan'208";a="827867800" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga006.fm.intel.com with ESMTP; 09 Jun 2022 15:52:56 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 9 Jun 2022 15:52:55 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 9 Jun 2022 15:52:55 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 9 Jun 2022 15:52:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A63Wkfzug4b2VrYiMHEpn7hPa0cGHl7WQyjB1hfUhFbXaoxey7jWjAGu9EdRpmuEf5A4y8000VUfB7U2Vb1Ca7o32uupiKi9xKSVKmZvHzAocETdNxYv2Gn3s3psNwtdzCQLZlO0a3ErYzoHkCg7PwoEwZbXBUhBMGI5uMLsKk5PyRz0GkMO1pjRkKw03dSer+FOQbboqxUMa/pJXIJdZ2r1cJ9LlQg/kZf0r2kwHB3ZvGVDa8r+nKpdyo/G5HUDfnKzIQNd+pmZu9hWjbp+b/m3S2dYMYmy+VlE/9lKqWnltXIATROYRlaALAeMIdX/HSJJcvLhUEAVPChlr5pX1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=udldDUeD6H3B5SV8pEBExm+iN3ejW+Y6SyUhQx7+DuA=; b=RpyMr9JQi8FMFo7QIWTbMyuQVETtNoD709M69kGAAAAsuIwWQntWoXDNFM0V1lwz/g41meQH9Vv89s6yR8M9H9RZCfX92eygq82GuaeG2d9+Ct4q3KLkZCGgn1eoe3FKn5RWrrLU06Vj3t+4JWxvrKlu9XUppT2NsVmm2R9eG2B5ZBL5ZStsyZpA1yFGDmVOxSAx3LAMwCPPt3Jc5GnkzjqKTsF8YyIoJ92+4Zo4a9Y9n3eD20CoUxe606ktuNA59Jt8gsUdxtZFJS571BA7dBitAauDWHbXPLuju5Q0TG6ZfUDgeyzNPeE2HSMkLC9S91nfUfk35L9RFmR8y5Qcrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by BYAPR11MB3157.namprd11.prod.outlook.com (2603:10b6:a03:75::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5332.13; Thu, 9 Jun 2022 22:52:52 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::190c:c119:21b7:7589]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::190c:c119:21b7:7589%5]) with mapi id 15.20.5293.019; Thu, 9 Jun 2022 22:52:52 +0000 From: "Nate DeSimone" To: "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Sinha, Ankit" , "Kubacki, Michael" , "Soller, Jeremy" Subject: Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/GalagoPro3: Add FSP Dispatch Mode PCDs Thread-Topic: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/GalagoPro3: Add FSP Dispatch Mode PCDs Thread-Index: AQHYefr7oRnw08bs70ygdjm9rZ2f0K1Hs0oA Date: Thu, 9 Jun 2022 22:52:52 +0000 Message-ID: References: <16F62ACD7FE7D32D.3657@groups.io> In-Reply-To: <16F62ACD7FE7D32D.3657@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d5684e7a-78e4-4958-1dc2-08da4a6ac8d8 x-ms-traffictypediagnostic: BYAPR11MB3157:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i0HK7BZYyYNC3laibZ2zIlyGSwis+wrWhphStHTVPbHHhfCxxyBPhPAid23lVpKIoA8UAKGAh+VA9hxV99TIy2imyLBUyYBCSG46l/xmE61ZtEa+7polC2XqjTfA7C8BaQ4TL35WSuuxNPrDGWZJawRjdJqlPDrI4yCjLzceEdAWIzBojDHEtmR+E5Wt6QORJcpothQmU0Jcpn0/EaNRwisp8XdCk5FCKdojIzp15B86gUNqlpgbvcTZ1HZA9Wvz8e3jPxS1TbE76DlOePMU80UrvsjwMg12UcPXfuRhxSf4u3+Sv4Afig/KP48HhHEoY2HBXPgPWxpIqwasIGgSP75lgz9LKpIAD4ojYlT5BZN3Rw4t2xccJ+1iqNTllcUHgJDjRPZokaRZhCgtpEDb5lbV4S3j91JqOxuURiiqcLN7gzHdvHZ1oBE92Ofp7hZnGHVH+2E6YlOZqTsc1AAHEl9gVwfcuaLJ8DDcPolIrPjBMfaZBBjScM8E9u6FnaneOSM6wPsyLpohpwNTXTX/S7rYpUwoD/Z8m7P6DJKD+HnTrdxqcaRZpDcOpwMzLUZ0iLf27rF+kv06b4c/zXt+Gy6d7MCOWmGL8rABELsD9O2WpogD/jhSY2ntLblpbKAJIIFBWWK923CRa1ImxSpsqh5ogapH8L3jvQjXgizQbumP24lOh6YmIy6wStQM/2VDLqotslfWqnBta3B9I+5OpR77EwpHjmOMrQDl5UvCBKZcb4KomklkzTNegVu7X/3ZV3/Ju75Bdy68n5sXXaiad/phCPn/EVOLusXq1NRL0tgxqclq6vo8iAySeKCm6KKkZmArsDHebiUzSE6NyINzyQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6916009)(54906003)(186003)(71200400001)(83380400001)(5660300002)(38070700005)(7696005)(53546011)(6506007)(8936002)(33656002)(9686003)(26005)(86362001)(19627235002)(52536014)(966005)(2906002)(82960400001)(508600001)(316002)(55016003)(38100700002)(66446008)(64756008)(122000001)(66946007)(66556008)(76116006)(66476007)(8676002)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vAMPiD1YixlcqkOQGYiLXBnI3tsnrdsOSXbmx/wCBi7k/kjFC5tTad5msEVT?= =?us-ascii?Q?9aJJGIJftJVTDdcpNyyTZb7BAYiKtO0eOTH8aAaHM2u43QE/BLKfGYZWWNPI?= =?us-ascii?Q?QxftL5Tgt3V4zlX1A3nCZeWPg4G5nLtfkWS5dE4pREC1vtaHk7G1eAbyg2PT?= =?us-ascii?Q?Y12mc4gkArMR80hhbwIPPr5W/GOK77s0tw7ZPbijy/iWuZY3wVdkX5x29Ken?= =?us-ascii?Q?UUyss2R8kzS/9sjJcCgqUfnXhHpzbKoX/KzeRbNJHg18Puy5vYgHBVGUlier?= =?us-ascii?Q?40+LtANXiDriMTHgmh0UwcKPvFJ+LomLqXCdwDAvW2fK7dOvGhfIXYOX6Sgl?= =?us-ascii?Q?2W2jq0A85+2fxhnqOh5DOhAKXC7Vm3MIXs4/oZWICM3X7WkYQX9ba+SLR6vw?= =?us-ascii?Q?cxvlF+z1jd8v4Eqqw9nRLanURJeykRdfNsZIqaRf3uD236mtiwCgznumNLvF?= =?us-ascii?Q?OBUWVRnthkbOK1jRDXYc+RrLpSTJncxBBM62mfFkKK40Rb4UI/pfqoU3iFJI?= =?us-ascii?Q?vm5yTqzDLKtwh9yg4vSmk0151tGFHpJWGvPWnqVkqbVmYLMrnitBL2+kLmRG?= =?us-ascii?Q?iAvJv54QqGzLu18PQTNm6RNXktt3s7VsDI20u/vRSsogcXSP2/3u/k/tid77?= =?us-ascii?Q?6giPYGjgGnDJQcZOq317z4zTBLDp41p4Sggf63XLtx45u6Jfgi1y1B2MJWOc?= =?us-ascii?Q?B1yqZO+YOXIpk5qjjaLhtHZh8mKleplp4P1+G2CtKmx6+6rJ4NTIc7rcQ+GN?= =?us-ascii?Q?AY7ieLRnY1F/roCOD4tX5rHTPOqHWQStpsH4ecaNz8ga2g3ZrST66YgcmWVo?= =?us-ascii?Q?K7ZhnaD2FptXavXQsXAPDgbHKQT018RoMENCajOExV4NvaYYGG8JB60QnTwd?= =?us-ascii?Q?5MJUnG2IgTWbHaw+pl+u5PNfbg6fH3W49LA/YEzA714u+qjl5XrPXlqwr3+2?= =?us-ascii?Q?2Yoqoagg68c/d/ykOtUC0ruOjYiQCVOvQrM1sQCbLUIEmQEh6aFNiGWqsVYn?= =?us-ascii?Q?mT2b8i0oZ2QQEbnj+QJS3vIul+o7SdeRl5EqJjy7t7hG/cDgQWN5Hlya3zxz?= =?us-ascii?Q?gNPEGYosvQgya5L3FK6HjTP6uqAjA6SZQVGTz6qbViigUwiy1w2nShgj5aIG?= =?us-ascii?Q?QCtiyFPO3adxkJS68vHlFfiI/mOiqwSEuPOnZeEdSV6Ost9bJQQRi3VvgoQN?= =?us-ascii?Q?HtYgDsspN+HkeCaUt3GWNkrA85H8BsRY3BrrgJHYOMLthCw5Z8eT2oR+Bp4r?= =?us-ascii?Q?sIbuvNU9I/9fO0V9k3lj7NABVNTdORfoDDi00OgKrGsla6qF6J83kDbyEF6w?= =?us-ascii?Q?dwVxBlAtQVvY9de32Yv8tt2g+V2Vm2AQ5cyE+AnUm+RGB1+h+9das79aFG5Q?= =?us-ascii?Q?eERr9Lrh3xpdk7k2KKc0G6XK2GkgXKRQUFh81R+H3kh8m5GW/5BrPtI0ZO22?= =?us-ascii?Q?ZcC8hcHByeRudsJ5D4GWgzsl7Q6pwVIB76Jqx5jx3ka8UX01eZsPRZe77nC+?= =?us-ascii?Q?LO/glw9iJ9noWdf1mPwuhr+ugpTJzVZ7r7gWba92JnAIeDjH5KONTmJ9jjfD?= =?us-ascii?Q?WTR5FHuHK/5k4/+thIod5fj2h3KHDhzFk/86YhYGv68tsZ3fxfrve8jx8NQs?= =?us-ascii?Q?FlwziT43SNADYhf/aoizq9P0NJ4igpGUmIrxmEh8e2dYu+v3yoEGFu4G0zzc?= =?us-ascii?Q?wD+hZtVWpcV3V7FjxTWdvCMgX38yg2t1+hTswY53UyrLQ0tui0UywmLdo7zP?= =?us-ascii?Q?6w23W28nt7gVsEAhkJEg64bXqQ1K8YI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d5684e7a-78e4-4958-1dc2-08da4a6ac8d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2022 22:52:52.2784 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nVJN/RrDPVNV4s/yo9R8XPNfV92f2zpExho8kNTM0U29G6mmvWbwcCKf+EPtAR3V/NtAh+ayY1bwuI3Xj7dZJi3IYyKK+F+pFa0ifd8zdmQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3157 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed: https://github.com/tianocore/edk2-platforms/commit/499011f -----Original Message----- From: devel@edk2.groups.io On Behalf Of Nate DeSimon= e Sent: Monday, June 6, 2022 4:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Sinha, Ankit ; Kubacki, Michael ; Soller, Jeremy Subject: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/Gala= goPro3: Add FSP Dispatch Mode PCDs Adds missing FSP dispatch mode PCDs to the Galago Pro 3. Cc: Chasel Chiu Cc: Ankit Sinha Cc: Michael Kubacki Cc: Jeremy Soller Signed-off-by: Nate DeSimone --- .../GalagoPro3/OpenBoardPkgPcd.dsc | 46 +++++++++++++++++-- 1 file changed, 42 insertions(+), 4 deletions(-) diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd= .dsc b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc index 44dacdf082..28f044df5e 100644 --- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkgPcd.dsc @@ -1,7 +1,7 @@ ## @file # PCD configuration build description file for the GalagoPro3 board. # -# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.
+# Copyright (c) 2019 - 2022, Intel Corporation. All rights=20 +reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -40,6 +40,26 @@ # gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode|TRUE =20 + # + # FALSE: The PEI Main included in FvPreMemory is used to dispatch all PE= IMs + # (both inside FSP and outside FSP). + # Pros: + # * PEI Main is re-built from source and is always the latest v= ersion + # * Platform code can link any desired LibraryClass to PEI Main + # (Ex: Custom DebugLib instance, SerialPortLib, etc.) + # Cons: + # * The PEI Main being used to execute FSP PEIMs is not the PEI= Main + # that the FSP PEIMs were tested with, adding risk of breakag= e. + # * Two copies of PEI Main will exist in the final binary, + # #1 in FSP-M, #2 in FvPreMemory. The copy in FSP-M is never + # executed, wasting space. + # + # TRUE: The PEI Main included in FSP is used to dispatch all PEI= Ms + # (both inside FSP and outside FSP). PEI Main will not be include= d in + # FvPreMemory. This is the default and is the recommended choice. + # + gMinPlatformPkgTokenSpaceGuid.PcdFspDispatchModeUseFspPeiMain|TRUE + # # FSP Base address PCD will be updated in FDF basing on flash map. # @@ -52,6 +72,7 @@ gSiPkgTokenSpaceGuid.PcdTemporaryRamSize|0x00040000 gSiPkgTokenSpaceGuid.PcdTsegSize|0x1000000 =20 +!if gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1 # # FSP API mode does not share stack with the boot loader, # so FSP needs more temporary memory for FSP heap + stack size. @@ -63,6 +84,24 @@ # since the stacks are separate. # gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x20000 +!else + # + # In FSP Dispatch mode boot loader stack size must be large + # enough for executing both boot loader and FSP. + # + gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize|0x40000 +!endif + +!if (gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode =3D=3D FALSE) ||= =20 +(gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1) + =20 +gSiPkgTokenSpaceGuid.PcdSiPciExpressBaseAddress|gEfiMdePkgTokenSpaceGui +d.PcdPciExpressBaseAddress + =20 +gSiPkgTokenSpaceGuid.PcdSiPciExpressRegionLength|gMinPlatformPkgTokenSp +aceGuid.PcdPciExpressRegionLength +!else + # + # FSP Dispatch mode requires more platform memory as boot loader and=20 +FSP sharing the same + # platform memory. + # + gSiPkgTokenSpaceGuid.PcdPeiMinMemorySize|0x5500000 +!endif =20 [PcdsFeatureFlag.common] ###################################### @@ -222,7 +261,7 @@ gUefiCpuPkgTokenSpaceGuid.PcdCpuApInitTimeOutInMicroSeconds|1000 gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmApSyncTimeout|10000 gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmStackSize|0x20000 - +!if (gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode =3D=3D FALSE) ||= =20 +(gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection =3D=3D 1) # # In non-FSP build (EDK2 build) or FSP API mode below PCD are FixedAtBui= ld # (They will be DynamicEx in FSP Dispatch mode) @@ -242,6 +281,7 @@ # 3: Place AP in the Run-Loop state. # @Prompt The AP wait loop state. gUefiCpuPkgTokenSpaceGuid.PcdCpuApLoopMode|2 +!endif =20 ###################################### # Silicon Configuration @@ -251,8 +291,6 @@ gSiPkgTokenSpaceGuid.PcdHstiIhvFeature1|0xF2 gSiPkgTokenSpaceGuid.PcdHstiIhvFeature2|0x07 =20 - gSiPkgTokenSpaceGuid.PcdSiPciExpressBaseAddress|gEfiMdePkgTokenSpaceGuid= .PcdPciExpressBaseAddress - gSiPkgTokenSpaceGuid.PcdSiPciExpressRegionLength|gMinPlatformPkgTokenSpa= ceGuid.PcdPciExpressRegionLength =20 ###################################### # Platform Configuration -- 2.27.0.windows.1