From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web09.6690.1642846099753236248 for ; Sat, 22 Jan 2022 02:08:20 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=jusDrgxT; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642846099; x=1674382099; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=B8RhdwHXal+rLJrNMu3XYUHZWMua3u36ngwEX8LcgeQ=; b=jusDrgxTwlmm69XvcucyMOvG+aAiCB2zwytEXc3hrHwNxMRsFp+CCsxz /hNBk80l095xcvyg+KaMAV9oos+cOXCHzWedLADWCIsXJBGwtHFsbHbr0 hcJZ47VNt/k29jn4vYKFpEQslrfyPS3QrooIxasiaElYqg+ytKhdydHKo BkouJN/sUF3SbA1/mv+HUYfV7rx0dNxzUiGGpe/Zgq/G65zlGy3Lq4sQ+ FzEr6gHRUS9/XprkaZI0L39G59y/NyY6xlB1y2r+KOtfKfli1aIeb2OcS ZQPebNFnmDhZoMWHt1qmIQK840tk8EstmjTclNOh1Cnj3TKZNSwdYVYwM Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10234"; a="332164920" X-IronPort-AV: E=Sophos;i="5.88,308,1635231600"; d="scan'208";a="332164920" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jan 2022 02:08:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,308,1635231600"; d="scan'208";a="626994568" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga004.jf.intel.com with ESMTP; 22 Jan 2022 02:08:18 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 22 Jan 2022 02:08:18 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 22 Jan 2022 02:08:17 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sat, 22 Jan 2022 02:08:17 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sat, 22 Jan 2022 02:08:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dq66SJZfQwd9BzBzipoXTKNg9y9Hj4bE00WDzayaIgLK2KT47fA8sCYjCLjPdS+FjxKmnCEdSnBTMSKb3jmFIkLo67WmNcyirRRv9cNJMENNastCKwjd5omMLGw7Pu9gpwvZMexfu+dR7iSYBOl+ZYTE1olGMlJ0tdRiw7a7pHw7Ez9omIMImRsAgc62+Uo9fgd1y4SlKoM7GBSYaiRFmgq/96aA8VKVOtHNJi725MPJQbL4JTOBwHqkfA0g1fU/+wsr9pm0TuRbljxOmCVAy3nCDCjwcCjtduplKRWu1Uvn9LbhkCCB7wVoKobl04c/bZD24d7FtE9Sjq2hJGRecA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NMuneUXe9lN2Tt6L9ZNknYvw8SafGdxb/qY9BqKzQvU=; b=jcZIqUBBzhsydbGopnMLAdNpuyBS3rwNazs8Jih8b3BpESheydquFwK+VkpfWYpFoA9AIhSZRL32vehZ0juYZvrDBstD0IK5gaIEtgDJuDaVv3PqjDYYEnMiAl5SQdc7Lc9eMBoCMrwX7g5hcB2iDugZVqlGc70KM/QeRCXUG3+CkzAU2f1ON58habRYvQ6q012eSCro0NpTMHFWHaPKMEDIVTxrxVRylUJWgU/iGIa/RU/K2aenI5Y1j8Kz9onaNIHkZmzIDz1wfTW+QHZc0j5P3vkLF2TgokNSitIiAKJGsaDWzv9sJ2UZkX3K+fvzAG729vx8IaKzwzh/DrARTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by SN6PR11MB2910.namprd11.prod.outlook.com (2603:10b6:805:da::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.13; Sat, 22 Jan 2022 10:08:15 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%7]) with mapi id 15.20.4909.012; Sat, 22 Jan 2022 10:08:15 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 2/2] WhitleyOpenBoardPkg/PlatformInfo: Add board ID vendor range Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 2/2] WhitleyOpenBoardPkg/PlatformInfo: Add board ID vendor range Thread-Index: AQHYDy6EmIWzsFYw6Ui+Qg7/2rRhO6xuziig Date: Sat, 22 Jan 2022 10:08:15 +0000 Message-ID: References: <5de1209eb6bac59291b886fb99871c516ebdb62a.1642813621.git.isaac.w.oram@intel.com> In-Reply-To: <5de1209eb6bac59291b886fb99871c516ebdb62a.1642813621.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7959bbde-88ce-4160-cb1d-08d9dd8f1b0b x-ms-traffictypediagnostic: SN6PR11MB2910:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sxWo8EEFMB+M51+H7gRKEEwJspzisna1UsRYfmmrue1Ov8Msvha/S5UBFgdD4ehcSHZjT2Q+NABR2Jvmk3yRhjCIzZLrQaTzEo0mCV0Dmc1ktHuL6LJkhaHDeu1A8uig42fK3AUsZWhrgFK1iO1NU72YM0RIGZxE6zledGFKr23vITluXkzTVWmfG7nN5UcdPh7i95pasXj9AQs0568TCd0L2rwxZNydLsN+2vN7fg9mHhz1WSUqjuVKipisw+R1o0edlhxuqoNkjoCwSSZ4+O3KPDxUexUUGkoBFOZ1XMYE0CEAIuzyqYrRCx4ROsdIRiInZucwVURshsor7OPccZn6UjX3RVacNurY/7qwJ1nITxb5aboSYdyYB1pJDhhPD23ER7ViToBwk11FvPKxK1NHM34FGugxQJXSYmW9dhKY88O676zJSA8JLWnCV5h+tfaKoHsNSA6ezzEN38q5rYURUM/rInKDmTRWmeCUwQz1d+xkyKguH57tJdrJPJ17Jkbb2lTrBuTIzS5uDlMpKxmSwaPTd9TBo/E9jbi3MPTTzliIu2jUmqMs5Onk3YlM1Bgf8kS+gEJWCy3COmLLyIOZOl1+InJa6labHzgvz05kuxZSaVo3zeIBSm3Q0S4yx/GHiPMfwolsyfmZOa5TJitbx5bUMcwYJz6kPkKSzMZS10eMtgRIoYxcAqOLcfYBz7vacTOfTIMCcGdOcaScvg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38070700005)(8676002)(508600001)(66476007)(26005)(9686003)(86362001)(186003)(64756008)(66556008)(55016003)(52536014)(66446008)(19627235002)(7696005)(71200400001)(82960400001)(107886003)(76116006)(2906002)(33656002)(83380400001)(4326008)(8936002)(6506007)(316002)(38100700002)(122000001)(5660300002)(110136005)(53546011)(66946007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WQrh0LcKb2xIK8noH0Ow5SBMRwCKMQEgKALOWoI2bIMG8rTaND27BZuJYOoH?= =?us-ascii?Q?rOwJ8521zzdZSPSzJGMjWSAMmgO/EOzv70e+IZYajxbK6Ptgy0OJHiGoea/0?= =?us-ascii?Q?JRHf4Q0pgg4eMuM9VVOwFM39og7xM2T/PGKw29lyqjIOSEmMP+y6Hu6PMg28?= =?us-ascii?Q?vGzaC/AZ8HA1tObOcyXu2osOuEKLkawx+nX3+y/qlZnPLTJ+Dg3KdQfaFH8s?= =?us-ascii?Q?GY1dIoRH7pGnJ58mUh7k9JQTDfBPgaHdTHEzGy7oCMJQ+mWh0exjAVxKorNo?= =?us-ascii?Q?zv12/tfjpHDmUbia4AG71Ky4AOh59apScyIS++1+7+85j/wbbFUril83ddwr?= =?us-ascii?Q?BlwdGp8JxV8qacL1MXplp6V/wF84syHkOF4esaWXtkF814OBCThs3fx0Ru0H?= =?us-ascii?Q?iu7OmR4Zs2voJlSTGa7MxT4sQZCaIl093EIxbeGdqnH3m9e6/nJhsXe5IuLL?= =?us-ascii?Q?41BejemwR/Ay188Zu7CMyxQ42LsQ1vYSq1qbqVrfVhm3ECLx2+EEf1XRJsFD?= =?us-ascii?Q?FPJ2HzTEJ8AhyHW1dacCZh2VfigOydzlU96IFFsCj4CWA2qu6TyJUC1ktZci?= =?us-ascii?Q?oGk5i2oJqA+CPyZskDaWLbgYH5l3l1FyLpQkS23HdVGVngCz2szfOx6E31Fl?= =?us-ascii?Q?fXjAFWvk921HU/wKMvTgY/A/LwdJJ72BkBHll8gqwgifkuTH1+wiubes68va?= =?us-ascii?Q?ZkOXX0A+UA41luw9rNwVZ+ENLo6d4CrmAlRnOah5/oBLcDGdm8tfSF8+6vq+?= =?us-ascii?Q?3y4A84U0TecTKmnTapmGjXMwxPXH3wcZZNeT6xEXkc1ORjdWOk0MpP0kpZCX?= =?us-ascii?Q?7ZKoJarC1ypotyXNtyva+xEQ9p/qQVVa7nDPpdUUtaYqxhoxLxwpWZYLNWg6?= =?us-ascii?Q?yrrN5UzYs+XkKofUBpA9Cp25uTOKoCO3nzxS6uxeK2CBOQx9lBiV/QBFUOtJ?= =?us-ascii?Q?WINuAw6s7MjRHMc/c0eU+G7cxpZJVDKRCP0Woz2rip4HxTIDFKFzW9S9E5oW?= =?us-ascii?Q?xdK1dHWbi1wlKS8+KD6RbnToRudY46XFr03OZ83eaXw33XU82k/ZOpsEU/SV?= =?us-ascii?Q?Ib390ouC+yhEVRTxEDmO2V/duBwlWyEn3eThFIzvgIKlO/Ok2vbwhRNvtxM2?= =?us-ascii?Q?qfUusFjgxwXU3MAyQqIDZRlD9KhuZ1yHQAPcWFbsRNHM3KtHyFSJV+0er7fk?= =?us-ascii?Q?j0cOKwAU4qtObHeCybMwdnZyASeG6PgF+CZ6kAwR1+D62e8OGNypcJvEM++q?= =?us-ascii?Q?X+RwjhWYdUCRpmweJ1zYEj8+mOO9CN9oRTjcfDbyjHphPqTMTumzdKo92Iob?= =?us-ascii?Q?8/AXClXtNmvCVJTFDPl8NmvuZS6krtmcK4DmeHxJMX7atxpcwj0RShJPN3Xu?= =?us-ascii?Q?dnQfKzRjr41jV7CJ+g8s/kSyQ+M4/Xmt4nuNTnY/T/EgVIRqds+Yp+QhKU+L?= =?us-ascii?Q?L6ky20N4R9bd1NKy9U38qSQ0/9q+aMgZdwp5t+Fligi1DQXZnYfN9XmHwJsG?= =?us-ascii?Q?lsWhAuWRAMjvmzYRNnBpXKcAMRIZbxeCVMDFwhvG9GNwyrFvV+mCMQcqVvj3?= =?us-ascii?Q?PYnoq1qIal3tqfQaQMHPBZ1giB7rLXTP1b4na0MIMqSamKyHO0Cfbs0YMay1?= =?us-ascii?Q?+XW/ujBb+esCD5+qh/z8v8Ak6MPwOxL7DYBSUegLzZJ74XAqoldVUVocQpQV?= =?us-ascii?Q?sS9QFA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7959bbde-88ce-4160-cb1d-08d9dd8f1b0b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2022 10:08:15.2674 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nGiM2B05JDoTrN2s4bydtB+V76RqeHb7DBdwxxVmI1sAK+PqOJPLnT7Ic2wzvbVyxwHCti7ZaA7TV3eG94a40EW1jJ1lCk4FmbQvrGmzcfs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2910 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Isaac, Please see feedback inline below. Thanks, Nate > -----Original Message----- > From: Oram, Isaac W > Sent: Friday, January 21, 2022 5:22 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Chiu, Chasel > > Subject: [edk2-devel][edk2-platforms][PATCH V1 2/2] > WhitleyOpenBoardPkg/PlatformInfo: Add board ID vendor range >=20 > Add a vendor reserved range to avoid collisions with Intel reference boar= d ID > future use, if any. >=20 > Cc: Nate DeSimone > Cc: Chasel Chiu > Signed-off-by: Isaac Oram > --- >=20 > Platform/Intel/WhitleyOpenBoardPkg/Platform/Pei/PlatformInfo/PlatformI > nfo.c | 3 +- > Platform/Intel/WhitleyOpenBoardPkg/Readme.md = | 118 > ++++++++++++++++++++ > Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h = | 8 +- > 3 files changed, 127 insertions(+), 2 deletions(-) >=20 > diff --git > a/Platform/Intel/WhitleyOpenBoardPkg/Platform/Pei/PlatformInfo/Platfor > mInfo.c > b/Platform/Intel/WhitleyOpenBoardPkg/Platform/Pei/PlatformInfo/Platfor > mInfo.c > index 87b4e57803..0065819d83 100644 > --- > a/Platform/Intel/WhitleyOpenBoardPkg/Platform/Pei/PlatformInfo/Platfor > mInfo.c > +++ > b/Platform/Intel/WhitleyOpenBoardPkg/Platform/Pei/PlatformInfo/Platf > +++ ormInfo.c > @@ -413,7 +413,8 @@ PdrGetPlatformInfo ( > return Status; > } >=20 > - if ((PlatformInfoHob->BoardId >=3D TypePlatformMin) && (PlatformInfoHo= b- > >BoardId <=3D TypePlatformMax)) { > + if ((PlatformInfoHob->BoardId >=3D TypePlatformMin) && > (PlatformInfoHob->BoardId <=3D TypePlatformMax) || > + (PlatformInfoHob->BoardId >=3D TypePlatformVendorMin) && > + (PlatformInfoHob->BoardId <=3D TypePlatformVendorMax)) { > // > // Valid Platform Identified > // > diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Readme.md > b/Platform/Intel/WhitleyOpenBoardPkg/Readme.md > new file mode 100644 > index 0000000000..cc9f9a208f > --- /dev/null > +++ b/Platform/Intel/WhitleyOpenBoardPkg/Readme.md > @@ -0,0 +1,118 @@ > +# **Board Porting for Intel® Whitley Platform** > + > +## Overview > +There are currently three board ports: > +* WilsonCityRvp > +* CooperCityRvp > +* JunctionCity > + > +There are corresponding binaries in edk2-non- > osi/WhitleyOpenBoardBinPkg. > + > +And there is a template for board porting, BoardPortWhitley. See below = for > detailed instructions on creating a new board port. > + > +## BoardPortTemplate > +This template profides basic instructions for how to customize the > WhitleyOpenBoardPkg for a new system board. > + > +## Board Naming Convention > +The current board directories are named arbitrarily and do not conform t= o > code. The above sentence has a somewhat antagonistic tone. Please modify the pros= e to be a little more impartial. Perhaps something like "The naming of boar= d directories is unaffiliated with naming used in code." > +Within code, the key is "TypeBoardName" which shows up in code in key > ways: Please remove the redundant "in code" from the above sentence. Perhaps some= thing like "Within code, the key is "TypeBoardName" which shows up in the f= ollowing principal forms:" > +* EFI_PLATFORM_TYPE enum, e.g. TypeJunctionCity > +* UBA Protocol, e.g. gEfiPlatformTypeJunctionCityProtocolGuid You need two new lines here. Otherwise, the sentence beginning with " To fa= cilitate future convention..." gets rendered as part of the "UBA Protocol" = bullet point. > +To facilitate future convention, "BoardPortTemplate" is used to increase > consistency. > + > +## Board Porting Steps > +It is desirable to pick a fairly unique name as WhitleyOpenBoardPkg UBA > feature is designed to make it easy to support many boards in a single bi= nary. > +For the purposes of this example, "MyBoard" is the board name in code an= d > filesystem. > + The numbing of the steps listed below is off. It goes 1, 2, 5 > +1. Copy WhitleyOpenBoardPkg/BoardPortTemplate to > +WhitleyOpenBoardPkg/MyBoard 2. Rename > +WhitleyOpenBoardPkg/MyBoard/Uba/TypeBoardPortTemplate to > +WhitleyOpenBoardPkg/MyBoard/Uba/TypeMyBoard > +5. Search and replace BoardPortTemplate with MyBoard in > WhitleyOpenBoardPkg/MyBoard. Do not search and replace at a higher > scope as you will break the template examples. > +6. Add a new EFI_PLATFORM_TYPE enum in edk2- > platforms\Silicon\Intel\WhitleySiliconPkg\Include\PlatformInfoTypes.h, e.= g. > +``` > +TypeMyBoard, // 0x80 > +``` > +Please update the comment for TypeBoardPortTemplate to match the new > maximum used, e.g. > +``` > +TypeBoardPortTemplate // 0x81 > +``` > +7. Update the PcdBoardId for your board in the > WhitleyOpenBoardPkg/MyBoard/PlatformPkg.dsc, e.g. > +``` > +gPlatformTokenSpaceGuid.PcdBoardId|0x80 # TypeMyBoard ``` 8. Update > +each INF in WhitleyOpenBoardPkg/MyBoard/Uba with new GUID filename > 9. > +Add a DXE UBA protocol GUID to WhitleyOpenBoardPkg/PlatformPkg.dec, > +*with a new GUID* ``` > +gEfiPlatformTypeMyBoardProtocolGuid =3D { 0xa68228c5, 0xc00f, 0x4d= 9a, { > 0x8d, 0xed, 0xb9, 0x6b, 0x9e, 0xef, 0xab, 0xca } } > +``` > +10. Add your board to the switch statement in BoardInitDxeDriverEntry > +(); in WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c > +``` > + case TypeMyBoard: > + Status =3D gBS->InstallProtocolInterface ( > + &Handle, > + &gEfiPlatformTypeMyBoardProtocolGuid, > + EFI_NATIVE_INTERFACE, > + NULL > + ); > + ASSERT_EFI_ERROR (Status); > + break; > +``` > +11. Add the gEfiPlatformTypeMyBoardProtocolGuid to the > +WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.inf > +12. Add a build option to edk2-platforms/Platform/Intel/build.cfg. e.g. > +``` > +MyBoard =3D WhitleyOpenBoardPkg/MyBoard/build_config.cfg > +``` > +13. At this point, you can build from edk2-platforms/Platform/Intel, e.g= . > +``` > +build_bios.py -p MyBoard -t VS2015x86 -d ``` 14. At this point, > +customization is not scripted. The following are common customization > areas: > +MyBoard/Uba/TypeBoardPortTemplate/Pei > +* GPIO > +* VR, IMON > +* SKU info > +* Board layout, sockets, memory > +* Soft straps, PCH, config, USB OC > +* PCI, KTI, IO port bifurcation > +MyBoard/Uba/TypeBoardPortTemplate/Dxe > +* IIO config update > +* Slot config update > +* USB overcurrent update > + > +## Board Builds > + > +**Building with the python script** > + > +1. Open command window, go to the workspace directory, e.g. > +c:\Edk2Workspace or ~/Edk2Workspace in the case of a linux OS 2. If usin= g a > linux OS > + * Type "cd edk2" > + * Type "source edksetup.sh" > + * Type "cd ../" to go back to the workspace directory 3. Type "cd > +edk2-platforms/Platform/Intel 4. Type "python build_bios.py -p > +TARGET_BOARD" > + > +* build_bios.py arguments: > + > + | Argument | Function | > + | ----------------------|-------------------------------------| > + | -h, --help | show this help message and exit | > + | --platform, -p | the platform to build | > + | --toolchain, -t | tool Chain to use in build process | > + | --DEBUG, -d | debug flag | > + | --RELEASE, -r | release flag | > + | --TEST_RELEASE, -tr | test Release flag | > + | --RELEASE_PDB, -rp | release flag | > + | --list, -l | lists available platforms | > + | --cleanall | cleans all | > + | --clean | cleans specified platform | > + | --capsule | capsule build enabled | > + | --silent | silent build enabled | > + | --performance | performance build enabled | > + | --fsp | fsp wrapper build enabled | > + | --fspapi | API mode fsp wrapper build enabled | > + | --hash | Enable hash-based caching | > + | --binary-destination | create cache in specified directory | > + | --binary-source | Consume cache from directory | > + | | > + > +* For more information on build options > + * Type "python build_bios.py -h" > diff --git a/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h > b/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h > index fae3101336..bfc6a49138 100644 > --- a/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h > +++ b/Silicon/Intel/WhitleySiliconPkg/Include/PlatformInfoTypes.h > @@ -65,13 +65,19 @@ typedef enum { > TypeBigPineKey, > TypeExperWorkStationRP, > TypeJunctionCity, > - EndOfEfiPlatformTypeEnum > + EndOfEfiPlatformTypeEnum, > + // > + // Vendor board range currently starts at 0x80 // > + TypeBoardPortTemplate // 0x80 > } EFI_PLATFORM_TYPE; >=20 > #define TypePlatformUnknown 0xFF > #define TypePlatformMin StartOfEfiPlatformTypeEnum + 1 > #define TypePlatformMax EndOfEfiPlatformTypeEnum - 1 > #define TypePlatformDefault TypeWilsonPointRP > +#define TypePlatformVendorMin 0x80 > +#define TypePlatformVendorMax TypeBoardPortTemplate - 1 >=20 > // > // CPU type: Standard (no MCP), -F, etc > -- > 2.27.0.windows.1