Re: [edk2-devel] [edk2-platforms PATCH 4/6] SimicsOpenBoardPkg: fix SEC ProcessLibraryConstructorList() prototype

["Nate DeSimone" <nathaniel.l.desimone@intel.com>]

> -----Original Message-----
> From: Laszlo Ersek <lersek@redhat.com>
> Sent: Tuesday, February 6, 2024 5:09 PM
> To: edk2-devel-groups-io <devel@edk2.groups.io>
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chaganty,
> Rangasai V <rangasai.v.chaganty@intel.com>
> Subject: [edk2-platforms PATCH 4/6] SimicsOpenBoardPkg: fix SEC
> ProcessLibraryConstructorList() prototype
> 
> The current declaration of, and call to, SEC
> ProcessLibraryConstructorList() in SimicsOpenBoardPkg matches the PEIM
> entry point parameter list. Fix the call, and rely on AutoGen for the declaration.
> 
> Untested (no idea what hoops to jump through to get this built).

Laszlo - This can be built using the following instructions (tested on Rocky Linux 9.3):

First Time Setup
================
sudo dnf install python3-pip git
sudo dnf install make g++ acpica-tools libuuid-devel
sudo dnf config-manager --enable crb
sudo dnf install nasm
wget https://github.com/tianocore/edk2-edkrepo/releases/download/edkrepo-v3.1.3/edkrepo-3.1.3.0.tar.gz
tar -zxvf edkrepo-3.1.3.0.tar.gz --one-top-level
cd edkrepo-3.1.3.0
./install.py
cd ~/src
   --> Or wherever it is you like to store code
edkrepo clone intc Intel-MinPlatform

Building
========
cd intc/edk2-platforms/Platform/Intel/
./build_bios.py -p BoardX58Ich10 -t GCC5

--> You can see a list of all available Intel platforms by running build_bios.py without arguments.

> 
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=990
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>  Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> index 39e879e9223e..09d43c6bf63b 100644
> --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
> @@ -9,7 +9,6 @@
> 
>  #include <PiPei.h>
> 
> -#include <Library/PeimEntryPoint.h>
>  #include <Library/BaseLib.h>
>  #include <Library/DebugLib.h>
>  #include <Library/BaseMemoryLib.h>
> @@ -738,7 +737,7 @@ SecCoreStartupWithStack (
>      Table[Index] = 0;
>    }
> 
> -  ProcessLibraryConstructorList (NULL, NULL);
> +  ProcessLibraryConstructorList ();
> 
>    DEBUG ((EFI_D_INFO,
>      "SecCoreStartupWithStack(0x%x, 0x%x)\n",



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115286): https://edk2.groups.io/g/devel/message/115286
Mute This Topic: https://groups.io/mt/104210908/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-