From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web09.14906.1665533091748593532 for ; Tue, 11 Oct 2022 17:04:51 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=HZ+w8CVf; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1665533091; x=1697069091; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=knpuGpZIsww2ofk96lwg90DfkHaF9X02y9js1RsBPGU=; b=HZ+w8CVfTSAY1HfNn8aRm3v3ViGizek5gRqglAv4cLIo8J6JFwFTE1h/ l6iXY0RV3DuAC4nJ5z8ArlH+z9Hk/3loBlWCG/HEwhzMIROnaSB9HAvDK +DoqFepSxE8xPFNyR6guUF+6yfCCQhojAnl8LlZ2xHkgvHbSNiQOJodUY fbUTThtZnoBzibKDqLSZUaCHqiYLfcr4y8F+zYO5/LtsojrV7FNPvkRFH KPOyqqif/5PAi70dXgmZH57Bwj3wRxG7YbdUp10jCrKg0AuPSFG8lS8/n lpi8xmj2GZ3UwdGNnnKpuVCLn4oAROaqxVp+n/Eb7H0EvnupJg0H7IXax A==; X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="304643038" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="304643038" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2022 17:04:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10497"; a="715713684" X-IronPort-AV: E=Sophos;i="5.95,177,1661842800"; d="scan'208";a="715713684" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 11 Oct 2022 17:04:51 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 11 Oct 2022 17:04:51 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 11 Oct 2022 17:04:51 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.105) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 11 Oct 2022 17:04:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T9kjSJ4BE0HqkBcVQpGkmGvEpZNSUEgzMa2Oq2N0ZpftirUzhyr0hIF7Jdj8kIenZMRACSz4h/yGZFakh+Jn0aFxiv3LceQ5CLNQLrOKrPMyXVLiCqZVXlMq69Wv0MBa72z/z1ZEbpK1/fzLJM2MFhWHk41JhFhol60MoYRRC0csWyAOvyCwEAskZNUVPQozjNZ8zc3aF08thxcWxiBXu1G8VZ3Asz8t4Q7InlCmaOOCETT9zaNcTSK+oX1fhgYy9OUnXqmIDprNII55iAi6xqvcaASPWTzWLysk80KOUZOD79XOtod/WmOodhHnVPUxhctir6V6bJR1zekDLT5iOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jl0O6lV4hpmlzuv5xiaCf+Zxu3gkIRjH3RP0fXc9U9E=; b=TeQNFwNOSWch6Gi6zoPCv3f9mrU2yGSY1V6b/Josi4JoYV/Z8iuKIuzv3UH4YKaB5cvymjRLQqGW/lmByN38ItOiwrxWz3hi9vOt1+CwZc1GU/TK6O5hzPT3jmD54twRnoqpQHy+BO1E/AoJKXdlTbBYyLX07+aEuZcVbzNvBtxbwTt6wF8m8c545ov3/x+10CXl3PTqRv2FDG2btXXgGdGmH2IR+/AjH6unuMElwVUrkDoBDk8HCIDdzygoXp+WniB6Gmjh0Fo36SPdKlAXz1V5Nb2B3pnEAlXa6GOQam14GrfFpXhYFUPk7YkvVSJlJYqS+yVePspKkeK24zOw+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by DM4PR11MB6190.namprd11.prod.outlook.com (2603:10b6:8:ad::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5709.21; Wed, 12 Oct 2022 00:04:49 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::a748:40a8:78d3:38e6]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::a748:40a8:78d3:38e6%3]) with mapi id 15.20.5676.032; Wed, 12 Oct 2022 00:04:49 +0000 From: "Nate DeSimone" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic Thread-Index: AQHY3PESuDhePnTsYUyh16wTWqICrq4J4ocA Date: Wed, 12 Oct 2022 00:04:49 +0000 Message-ID: References: <1b764cb06aeea4b029e2b2c4b3d14fbcf7dbdef3.1665437608.git.isaac.w.oram@intel.com> In-Reply-To: <1b764cb06aeea4b029e2b2c4b3d14fbcf7dbdef3.1665437608.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|DM4PR11MB6190:EE_ x-ms-office365-filtering-correlation-id: 6ff4c1c4-40e0-4d98-2bcc-08daabe5610f x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dnLfFUBEYBhp9jOvLXA4kS+iwPNqKoEeAmuyD2XeWiZFC46YOw2xdVHd3qGDWPsVehdz1xag1JBnAAXJC+5a+VePO9o6MRnUyKqft5HTP10hLNSA6WvUH8dlzSJw/ISnKm1kISG4uB364nsUF5B7u0TgQ/un38TOlOxDS7+iiM9pWx86BTS7GT2q/L/UUEeVgiu0nBQpALoLvuHgSt6GW3o3hw3j8sbotYS9N5EqODQ/cb6uOms91Qf/IGb8H2ZS6WcjnfPOGHCkMtSPtAbkOwuvvgdYu9Fo8BoCw0EYjEqKGgo8S99ntEOMpUqeKzHWAj14RaIPZwSlXI/mKHDyEVY4bFXolX2+mDUsn5Xbyva6CbEovpFtiTRbtwIH1FZ2kqJAHDgHEWmVfHYvlFxcJ6woY8Kytc7Yz8UIQYx3Y1l7sCJH7bSOboe26qzfmDIUH8CRtLB2uAwlvSojeDarlSQrwvEJheCsiFoCdhhUGASnjXiL/1pwtiMfrpr1uD+FVY3hdONoVqHae4hmvTbEdXdwwwGY6YAu7+N+qQyuZxExtkogx/QEpwnfhcKzIwK3M8DxDFsFDvkTo8b8fOgea8oBOyrV4j7gAZ5xUB8hw6Z51x0nbqnK1AujN0UxHZAUKGGzYwXsV7K2WDLXMU9ECiV0sY+JVnfN5e5ErTsqVeU0dpDdmDr83QRJhp9alLDi+oxefLMGg0teRTH6dMWAJyJLk7SfNG45uTw2MdlNDv8R2YrUxp7RXUOTWATHI05SX3wg33GTEiLXzlaqlLFgUg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(376002)(396003)(136003)(39860400002)(366004)(451199015)(478600001)(71200400001)(2906002)(110136005)(316002)(76116006)(66946007)(66556008)(66476007)(66446008)(64756008)(33656002)(83380400001)(107886003)(8676002)(4326008)(82960400001)(6506007)(41300700001)(7696005)(38070700005)(26005)(52536014)(53546011)(9686003)(5660300002)(8936002)(38100700002)(186003)(122000001)(86362001)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aa5rsc5bgXu8EP62LcxaHqyEKxoNb7PNHpMYLibhJskkYWE63ADWEi7J+0py?= =?us-ascii?Q?kYoXYKFmLtNZQs/MKm7ZQebbQ2K1GUDAcPPa7LNRSuGnSZSP4zi4PFMWQu2X?= =?us-ascii?Q?SQHuvWRk+VFAh+zdN+/MKZwcpRJnPLBqLvYNbGUZuHNnrb+H4hyfP778uko6?= =?us-ascii?Q?74c4jHH9HK/LugOyjEO9AY9OCaDUptm62R8k9uET503cVISghJk9Tb9mrP6E?= =?us-ascii?Q?0ISTTqFXtO5ukpHMX5WDeHkPDLyDAHxi6QJEKeWtwxvtHiUioulhU6WCku/J?= =?us-ascii?Q?Ppqa0ZnlNchMoevAZdmA1z22w3esLsgEYRP72e0IvpC1BtvlW4cx65WtN0rO?= =?us-ascii?Q?puWuGsIIbXYf1+bknOGKksj19XyyBH8kIGQfKtCdXjj3fj6CIomWRCD4OUBc?= =?us-ascii?Q?MWdrlw5RQMdyiN8KI6pjmy3X3EG7IWvGDrYM7pp+fTmtq3oLJmV1AEu6mGbX?= =?us-ascii?Q?6XVq5nEX2Lb3Wk8fTLfxQgdt6lCImpJgLeNHCt15XfF4KYWwunmc/zHbVLHY?= =?us-ascii?Q?ATp9PwlRisJyYXcqvHXnboeZJ87BNBd5X7a+226GW6bpe2XQof2Mqa3qGgNw?= =?us-ascii?Q?vtu0RpCZfVjNNSdy0I3VXqyenzzr2e3GMmE8elgwqhdgK8cuJvW0suBtQ+aQ?= =?us-ascii?Q?Hf7WrdzcW9ihkiMxyrUik2Yi+J8IxEi3dVZNGa+eUSJ7ZqdVu0U8tlAjOx8M?= =?us-ascii?Q?8pVfDOGkXelI5Pepd3LjfXUHNRedLpY09jEhmMvjHuQxiJzmTkMk0CcgMzZH?= =?us-ascii?Q?eU+bVFzCZtLKfR+LktIIbZS755e+oaJWQYz4yWlDMhqbSEeZT8p6ALEb3MyI?= =?us-ascii?Q?c1pouKq4gtDqYGU+jWoS9Os7HoM9gRqQI5zFVkKjQxOqZNqWzDQ8hNq28lkY?= =?us-ascii?Q?7cxGHSwoWD3GETfJN5JYTL6h5QxS9POKlcjFay+YFcdjSD863lDSBGNYErdv?= =?us-ascii?Q?mdMUk+pA6FSx2Dx0Sn3nS7g2h+N4fzt1tiWTRzgv/HMvpeWb3MLWkaL7CgAz?= =?us-ascii?Q?DmF5Yew06jJwhpTC+q+Pkq1bEQDxb8KAMjNykH6CA1r3EqQeStYmd72P1xF+?= =?us-ascii?Q?4Kt5iFZ99b81W2Tf0y9kqfIuFIXqqqjgNB5eZRfJ9zxvT4Y3YIGBMR8VjBx0?= =?us-ascii?Q?WHSyl65eVWsy7QGNIFZi6LaRXTKfeiVyolmlYrrAXloZvW2EnnUtxaq1mKhW?= =?us-ascii?Q?76JeuSmKYwmrG9Y2GWBAnhpL4v6uVXDGV4RoWeR+5YDr3S9XTlrOfH84GmRg?= =?us-ascii?Q?kSg5QiCvQHot/CIhIjJgPL4ifgYlYQMgDboYlft8uYIGOVrO6+a8hlQ4qwfz?= =?us-ascii?Q?AVZZYyXHuMlr5+OteuoYpXCPqnUFx5cDdLXsWxzkbF39kno9qIqoIx+8UpBw?= =?us-ascii?Q?nSKn+4Tq0ToK2MLmEprDpVbqQ2elkA+UeQF9iqiQFgWKc5+0L2PZ7YTDXrTV?= =?us-ascii?Q?Ta8TmlYpiGLjdfS+0skT8k8pRO3CClMj3qT9XDm7hHutoPKfcqU2Cwu8YCx7?= =?us-ascii?Q?8EYFerq1m7mZY1iUn7kycVaPKw9sXvalom3OrmGcHpeLrvv6GCFnw8Uhf2Le?= =?us-ascii?Q?U5zTvzafqKpuQDHuIlkJs8GtT8KbapiHGa/pCmbyXyrUeWa633JaMdjwG+EM?= =?us-ascii?Q?Aw=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6ff4c1c4-40e0-4d98-2bcc-08daabe5610f X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Oct 2022 00:04:49.0278 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ffsMxBimaOB6IG6+yFP/atyM92PkAgos1qF9dmeqM64gEG5EvPq9lOUF0qNPVAkfy1dABpT9SD+k9+ZSlX4AJjj04SIcP9bRSXr6gjz5+oA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6190 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Nate DeSimone -----Original Message----- From: Oram, Isaac W =20 Sent: Monday, October 10, 2022 2:41 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/Acp= iPlatform: Fix table install logic Fix ACPI table install logic issue introduced by incorrect fix in 4c9b69e59= 0cf81f2b9af9e17243a422798833b0e that prevents some tables from being instal= led. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram --- .../Features/Acpi/AcpiPlatform/AcpiPlatform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/= AcpiPlatform.c b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatf= orm/AcpiPlatform.c index 28117ad460..a884c9745f 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPla= tform.c +++ b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/Acpi +++ Platform.c @@ -475,7 +475,7 @@ AcpiPlatformEarlyAcpiTablesInstall ( // Install the table // AcpiStatus =3D AcpiTable->InstallAcpiTable (AcpiTable, Curre= ntTable, CurrentTable->Length, &TableHandle); - if (!EFI_ERROR (AcpiStatus)) { + if (EFI_ERROR (AcpiStatus)) { ASSERT_EFI_ERROR (AcpiStatus); return AcpiStatus; } -- 2.36.1.windows.1