* [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic [not found] <cover.1665437608.git.isaac.w.oram@intel.com> @ 2022-10-10 21:41 ` Isaac Oram 2022-10-12 0:04 ` Nate DeSimone 0 siblings, 1 reply; 3+ messages in thread From: Isaac Oram @ 2022-10-10 21:41 UTC (permalink / raw) To: devel; +Cc: Isaac Oram, Nate DeSimone, Chasel Chiu Fix ACPI table install logic issue introduced by incorrect fix in 4c9b69e590cf81f2b9af9e17243a422798833b0e that prevents some tables from being installed. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Chasel Chiu <chasel.chiu@intel.com> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com> --- .../Features/Acpi/AcpiPlatform/AcpiPlatform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c index 28117ad460..a884c9745f 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c +++ b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c @@ -475,7 +475,7 @@ AcpiPlatformEarlyAcpiTablesInstall ( // Install the table // AcpiStatus = AcpiTable->InstallAcpiTable (AcpiTable, CurrentTable, CurrentTable->Length, &TableHandle); - if (!EFI_ERROR (AcpiStatus)) { + if (EFI_ERROR (AcpiStatus)) { ASSERT_EFI_ERROR (AcpiStatus); return AcpiStatus; } -- 2.36.1.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic 2022-10-10 21:41 ` [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic Isaac Oram @ 2022-10-12 0:04 ` Nate DeSimone 2022-10-12 0:10 ` Isaac Oram 0 siblings, 1 reply; 3+ messages in thread From: Nate DeSimone @ 2022-10-12 0:04 UTC (permalink / raw) To: Oram, Isaac W, devel@edk2.groups.io; +Cc: Chiu, Chasel Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> -----Original Message----- From: Oram, Isaac W <isaac.w.oram@intel.com> Sent: Monday, October 10, 2022 2:41 PM To: devel@edk2.groups.io Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com> Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic Fix ACPI table install logic issue introduced by incorrect fix in 4c9b69e590cf81f2b9af9e17243a422798833b0e that prevents some tables from being installed. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Chasel Chiu <chasel.chiu@intel.com> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com> --- .../Features/Acpi/AcpiPlatform/AcpiPlatform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c index 28117ad460..a884c9745f 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c +++ b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/Acpi +++ Platform.c @@ -475,7 +475,7 @@ AcpiPlatformEarlyAcpiTablesInstall ( // Install the table // AcpiStatus = AcpiTable->InstallAcpiTable (AcpiTable, CurrentTable, CurrentTable->Length, &TableHandle); - if (!EFI_ERROR (AcpiStatus)) { + if (EFI_ERROR (AcpiStatus)) { ASSERT_EFI_ERROR (AcpiStatus); return AcpiStatus; } -- 2.36.1.windows.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic 2022-10-12 0:04 ` Nate DeSimone @ 2022-10-12 0:10 ` Isaac Oram 0 siblings, 0 replies; 3+ messages in thread From: Isaac Oram @ 2022-10-12 0:10 UTC (permalink / raw) To: Desimone, Nathaniel L, devel@edk2.groups.io; +Cc: Chiu, Chasel Pushed as 66cef08cde..ee8d078e39 -----Original Message----- From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com> Sent: Tuesday, October 11, 2022 5:05 PM To: Oram, Isaac W <isaac.w.oram@intel.com>; devel@edk2.groups.io Cc: Chiu, Chasel <chasel.chiu@intel.com> Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com> -----Original Message----- From: Oram, Isaac W <isaac.w.oram@intel.com> Sent: Monday, October 10, 2022 2:41 PM To: devel@edk2.groups.io Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Chiu, Chasel <chasel.chiu@intel.com> Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic Fix ACPI table install logic issue introduced by incorrect fix in 4c9b69e590cf81f2b9af9e17243a422798833b0e that prevents some tables from being installed. Cc: Nate DeSimone <nathaniel.l.desimone@intel.com> Cc: Chasel Chiu <chasel.chiu@intel.com> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com> --- .../Features/Acpi/AcpiPlatform/AcpiPlatform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c index 28117ad460..a884c9745f 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/AcpiPlatform.c +++ b/Platform/Intel/WhitleyOpenBoardPkg/Features/Acpi/AcpiPlatform/Acpi +++ Platform.c @@ -475,7 +475,7 @@ AcpiPlatformEarlyAcpiTablesInstall ( // Install the table // AcpiStatus = AcpiTable->InstallAcpiTable (AcpiTable, CurrentTable, CurrentTable->Length, &TableHandle); - if (!EFI_ERROR (AcpiStatus)) { + if (EFI_ERROR (AcpiStatus)) { ASSERT_EFI_ERROR (AcpiStatus); return AcpiStatus; } -- 2.36.1.windows.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-12 0:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1665437608.git.isaac.w.oram@intel.com>
2022-10-10 21:41 ` [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/AcpiPlatform: Fix table install logic Isaac Oram
2022-10-12 0:04 ` Nate DeSimone
2022-10-12 0:10 ` Isaac Oram
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox