From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Pabba, PhanindraX Babu" <phanindrax.babu.pabba@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Subject: Re: [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool
Date: Mon, 25 Mar 2024 22:31:29 +0000 [thread overview]
Message-ID: <MW4PR11MB58217B7E197766FF0AC2618ACD362@MW4PR11MB5821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <de8a732f7c23f270e1fd4cc4f5350bcee24176c7.1708671087.git.phanindrax.babu.pabba@intel.com>
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
-----Original Message-----
From: Pabba, PhanindraX Babu <phanindrax.babu.pabba@intel.com>
Sent: Thursday, February 22, 2024 10:52 PM
To: devel@edk2.groups.io
Cc: Pabba, PhanindraX Babu <phanindrax.babu.pabba@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
Subject: [PATCH] IpmiFeaturePkg: Add missed call to FreePool
From: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
Adding missed out call to FreePool API to free the allocated memory.
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: PhanindraX Babu Pabba <phanindrax.babu.pabba@intel.com>
---
.../Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
index 990b4b9e..070a3452 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.c
@@ -250,6 +250,7 @@ BmcAcpiEntryPoint (
// Increment the instance
//
Instance++;
+ FreePool (CurrentTable);
}
}
--
2.39.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117093): https://edk2.groups.io/g/devel/message/117093
Mute This Topic: https://groups.io/mt/104524860/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-25 22:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-23 6:52 [edk2-devel] [PATCH] IpmiFeaturePkg: Add missed call to FreePool phanindrax.babu.pabba
2024-03-25 22:31 ` Nate DeSimone [this message]
2024-03-25 22:33 ` Nate DeSimone
2024-03-26 3:19 ` Chiu, Chasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR11MB58217B7E197766FF0AC2618ACD362@MW4PR11MB5821.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox