[edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/ServerManagementLib: Fix a GCC compile error

[edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/ServerManagementLib: Fix a GCC compile error

[Xu, Wei6]

The source file definition in INF file is ServerManagementELog.c,
while the actual file name is ServerManagementElog.c. The case is
mismatched. Correct the definition in INF file to fix this issue.

Cc: Abner Chang <Abner.Chang@amd.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Wei6 Xu <wei6.xu@intel.com>
---
 .../Library/ServerManagementLib/ServerManagementLib.inf       | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManagementLib/ServerManagementLib.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManagementLib/ServerManagementLib.inf
index 6e7702e0db33..5c5e8f6d48af 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManagementLib/ServerManagementLib.inf
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManagementLib/ServerManagementLib.inf
@@ -1,6 +1,6 @@
 ### @file
 #
-# Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2023 - 2024, Intel Corporation. All rights reserved.<BR>
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -17,7 +17,7 @@
   LIBRARY_CLASS              = ServerManagementLib
 
 [Sources]
-  ServerManagementELog.c
+  ServerManagementElog.c
   ServerManagementTime.c
 
 [Packages]
-- 
2.29.2.windows.2



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113957): https://edk2.groups.io/g/devel/message/113957
Mute This Topic: https://groups.io/mt/103791804/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/ServerManagementLib: Fix a GCC compile error

[Michael D Kinney]

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Xu, Wei6
> Sent: Wednesday, January 17, 2024 10:12 AM
> To: devel@edk2.groups.io
> Cc: Xu, Wei6 <wei6.xu@intel.com>; Abner Chang <Abner.Chang@amd.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel] [PATCH edk2-platforms 1/1]
> IpmiFeaturePkg/ServerManagementLib: Fix a GCC compile error
> 
> The source file definition in INF file is ServerManagementELog.c,
> while the actual file name is ServerManagementElog.c. The case is
> mismatched. Correct the definition in INF file to fix this issue.
> 
> Cc: Abner Chang <Abner.Chang@amd.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Wei6 Xu <wei6.xu@intel.com>
> ---
>  .../Library/ServerManagementLib/ServerManagementLib.inf       | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManage
> mentLib/ServerManagementLib.inf
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManage
> mentLib/ServerManagementLib.inf
> index 6e7702e0db33..5c5e8f6d48af 100644
> ---
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManage
> mentLib/ServerManagementLib.inf
> +++
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerManage
> mentLib/ServerManagementLib.inf
> @@ -1,6 +1,6 @@
>  ### @file
>  #
> -# Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2023 - 2024, Intel Corporation. All rights
> reserved.<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -17,7 +17,7 @@
>    LIBRARY_CLASS              = ServerManagementLib
> 
>  [Sources]
> -  ServerManagementELog.c
> +  ServerManagementElog.c
>    ServerManagementTime.c
> 
>  [Packages]
> --
> 2.29.2.windows.2
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114016): https://edk2.groups.io/g/devel/message/114016
Mute This Topic: https://groups.io/mt/103791804/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/ServerManagementLib: Fix a GCC compile error

[Xu, Wei6]

Thanks Mike for the review.

Hi Nate,

Could you please help review this patch and merge it? Thank you very much.

BR,
Wei
>-----Original Message-----
>From: Kinney, Michael D <michael.d.kinney@intel.com>
>Sent: Friday, January 19, 2024 7:13 AM
>To: devel@edk2.groups.io; Xu, Wei6 <wei6.xu@intel.com>
>Cc: Abner Chang <Abner.Chang@amd.com>; Desimone, Nathaniel L
><nathaniel.l.desimone@intel.com>; Kinney, Michael D
><michael.d.kinney@intel.com>
>Subject: RE: [edk2-devel] [PATCH edk2-platforms 1/1]
>IpmiFeaturePkg/ServerManagementLib: Fix a GCC compile error
>
>Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
>
>
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Xu,
>> Wei6
>> Sent: Wednesday, January 17, 2024 10:12 AM
>> To: devel@edk2.groups.io
>> Cc: Xu, Wei6 <wei6.xu@intel.com>; Abner Chang
><Abner.Chang@amd.com>;
>> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
>> Subject: [edk2-devel] [PATCH edk2-platforms 1/1]
>> IpmiFeaturePkg/ServerManagementLib: Fix a GCC compile error
>>
>> The source file definition in INF file is ServerManagementELog.c,
>> while the actual file name is ServerManagementElog.c. The case is
>> mismatched. Correct the definition in INF file to fix this issue.
>>
>> Cc: Abner Chang <Abner.Chang@amd.com>
>> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
>> Signed-off-by: Wei6 Xu <wei6.xu@intel.com>
>> ---
>>  .../Library/ServerManagementLib/ServerManagementLib.inf       | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git
>>
>a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerMa
>na
>> ge
>> mentLib/ServerManagementLib.inf
>>
>b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerMa
>na
>> ge
>> mentLib/ServerManagementLib.inf
>> index 6e7702e0db33..5c5e8f6d48af 100644
>> ---
>>
>a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerMa
>na
>> ge
>> mentLib/ServerManagementLib.inf
>> +++
>>
>b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerMa
>na
>> ge
>> mentLib/ServerManagementLib.inf
>> @@ -1,6 +1,6 @@
>>  ### @file
>>  #
>> -# Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
>> +# Copyright (c) 2023 - 2024, Intel Corporation. All rights
>> reserved.<BR>
>>  #
>>  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -17,7 +17,7 @@
>>    LIBRARY_CLASS              = ServerManagementLib
>>
>>  [Sources]
>> -  ServerManagementELog.c
>> +  ServerManagementElog.c
>>    ServerManagementTime.c
>>
>>  [Packages]
>> --
>> 2.29.2.windows.2
>>
>>
>>
>> 
>>



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114761): https://edk2.groups.io/g/devel/message/114761
Mute This Topic: https://groups.io/mt/103791804/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/ServerManagementLib: Fix a GCC compile error

[Nate DeSimone]

Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Xu, Wei6
> Sent: Wednesday, January 17, 2024 10:12 AM
> To: devel@edk2.groups.io
> Cc: Xu, Wei6 <wei6.xu@intel.com>; Abner Chang <Abner.Chang@amd.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel] [PATCH edk2-platforms 1/1]
> IpmiFeaturePkg/ServerManagementLib: Fix a GCC compile error
> 
> The source file definition in INF file is ServerManagementELog.c, while the
> actual file name is ServerManagementElog.c. The case is mismatched. Correct
> the definition in INF file to fix this issue.
> 
> Cc: Abner Chang <Abner.Chang@amd.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Wei6 Xu <wei6.xu@intel.com>
> ---
>  .../Library/ServerManagementLib/ServerManagementLib.inf       | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerMa
> nagementLib/ServerManagementLib.inf
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerMa
> nagementLib/ServerManagementLib.inf
> index 6e7702e0db33..5c5e8f6d48af 100644
> ---
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerMa
> nagementLib/ServerManagementLib.inf
> +++
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerMa
> +++ nagementLib/ServerManagementLib.inf
> @@ -1,6 +1,6 @@
>  ### @file
>  #
> -# Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2023 - 2024, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -17,7 +17,7 @@
>    LIBRARY_CLASS              = ServerManagementLib
> 
>  [Sources]
> -  ServerManagementELog.c
> +  ServerManagementElog.c
>    ServerManagementTime.c
> 
>  [Packages]
> --
> 2.29.2.windows.2
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114973): https://edk2.groups.io/g/devel/message/114973
Mute This Topic: https://groups.io/mt/103791804/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH edk2-platforms 1/1] IpmiFeaturePkg/ServerManagementLib: Fix a GCC compile error

[Nate DeSimone]

Pushed as 8b9a0ec

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Xu, Wei6
> Sent: Wednesday, January 17, 2024 10:12 AM
> To: devel@edk2.groups.io
> Cc: Xu, Wei6 <wei6.xu@intel.com>; Abner Chang <Abner.Chang@amd.com>;
> Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel] [PATCH edk2-platforms 1/1]
> IpmiFeaturePkg/ServerManagementLib: Fix a GCC compile error
> 
> The source file definition in INF file is ServerManagementELog.c, while the
> actual file name is ServerManagementElog.c. The case is mismatched. Correct
> the definition in INF file to fix this issue.
> 
> Cc: Abner Chang <Abner.Chang@amd.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Wei6 Xu <wei6.xu@intel.com>
> ---
>  .../Library/ServerManagementLib/ServerManagementLib.inf       | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerMa
> nagementLib/ServerManagementLib.inf
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerMa
> nagementLib/ServerManagementLib.inf
> index 6e7702e0db33..5c5e8f6d48af 100644
> ---
> a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerMa
> nagementLib/ServerManagementLib.inf
> +++
> b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/ServerMa
> +++ nagementLib/ServerManagementLib.inf
> @@ -1,6 +1,6 @@
>  ### @file
>  #
> -# Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2023 - 2024, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -17,7 +17,7 @@
>    LIBRARY_CLASS              = ServerManagementLib
> 
>  [Sources]
> -  ServerManagementELog.c
> +  ServerManagementElog.c
>    ServerManagementTime.c
> 
>  [Packages]
> --
> 2.29.2.windows.2
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114974): https://edk2.groups.io/g/devel/message/114974
Mute This Topic: https://groups.io/mt/103791804/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-