From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6C57D941E54 for ; Thu, 2 May 2024 23:45:56 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=iwm88jGFdfYeTloYZJWd3SxUVm9DVA5Zlw5NrTdFVu8=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1714693555; v=1; b=hkRQbre2kYDlPDnfvQEorgS4H3XXbT+KlRCTlklUgQb3MuLTdbn6gvZoqJfdt1KFYmZO0lJH a2ZqQlvTaT9vugJSFpDRAUX6XqRf5zsIJquRTby4cjzYlN8/OlktrmN5pRwwR0m0gva58Ic6Ldh 9GPnhjVMpPXOp82oKAjSNfhM3xXuYlqj1xGQ4y1zFAcFJq71rTGpXKPNsSe17o8AgWcg/yuoMCZ yuuPQJHNxYfliUlyW2Q7DlSstnHhERohsQw9MAf/cL5LjNtyUVo2gaBIEWmClwCQB+ZiWaxMAbP Gau8/KyRBdgahGCcAr1pbaLIAkRenWMxusutbgrhPsRnQ== X-Received: by 127.0.0.2 with SMTP id NGLQYY7687511xwER6ZgCnZ8; Thu, 02 May 2024 16:45:55 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) by mx.groups.io with SMTP id smtpd.web11.1156.1714693554284633596 for ; Thu, 02 May 2024 16:45:54 -0700 X-CSE-ConnectionGUID: 6aN0jtRxT1iGpcAkUAKXCA== X-CSE-MsgGUID: oKmtCJRMRcqFp26929HHJQ== X-IronPort-AV: E=McAfee;i="6600,9927,11062"; a="10653277" X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="10653277" X-Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2024 16:45:54 -0700 X-CSE-ConnectionGUID: UIdDtBD3Q2yEDk0kQOmGng== X-CSE-MsgGUID: b0/xkj4KQBCoC1v9vdWvYA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,247,1708416000"; d="scan'208";a="27393594" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 02 May 2024 16:45:55 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 2 May 2024 16:45:53 -0700 X-Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 2 May 2024 16:45:53 -0700 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 2 May 2024 16:45:53 -0700 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by DM4PR11MB5972.namprd11.prod.outlook.com (2603:10b6:8:5f::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Thu, 2 May 2024 23:45:47 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6c2d:9d64:aa3c:321f]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6c2d:9d64:aa3c:321f%5]) with mapi id 15.20.7519.035; Thu, 2 May 2024 23:45:46 +0000 From: "Nate DeSimone" To: "Hsueh, DoraX" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Chuang, Rosen" , "Kasbekar, Saloni" , "Tang, Haoyu" , "Chiu, Chasel" Subject: Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Halt the TCO timer. Thread-Topic: [PATCH] AlderlakeOpenBoardPkg: Halt the TCO timer. Thread-Index: AQHalJC+Ptt+0b+580GYb+r62H7farGEqcGA Date: Thu, 2 May 2024 23:45:46 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|DM4PR11MB5972:EE_ x-ms-office365-filtering-correlation-id: 21a1fbe3-e37c-4712-4af2-08dc6b01fcf6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?0FkgDc6ckL6nRqpZ6JffH+nThuIaEsy3Oic44vtRgd9lbHojtPqPJi/vd7DG?= =?us-ascii?Q?4M64HgoGCcaK9ZBXse4g0RVH8EO+LOUmETIMuQ2duosM0V7cp+B3YAGhGtz1?= =?us-ascii?Q?KymlOSghVyZ0zdXv7b9FX3S7rU0Cbd3I9XOavFrJTefQRa/gHitML6yEH9yi?= =?us-ascii?Q?Cs2UP5Nvnrp3QvLu7SZMyOjxSdqyw+Md5lQyX2ImHOXOsJDfAyuojf8DV3V9?= =?us-ascii?Q?3Mv4HaC1NSG6QfuG9ZVEN0Y/etsKaBkV3zBu6ophtUL1/82n9+ITDn1J92D2?= =?us-ascii?Q?Z59VCWbVpDGmvCo4seo9uMEmUf3qOgUHgB8Xa7FGGjeG55Dt+SDwJKcjtQxl?= =?us-ascii?Q?WyezCQWe82FgAYVOy7m3PTyW2b2rEyUg+ByF1plCk5kAQMgXshNwQZ5bQjUQ?= =?us-ascii?Q?YQxgRHa3AevydxJ9PKfmNsB2G7O8pm5y7SU7mf/sKN9S6s+8WIqEeyMUQJq5?= =?us-ascii?Q?QvD88GDq0pRkYkE9odfb10ykJx/4JQcTDw/kFI2LK2Vwj0XQ5x+BG/QdK3YG?= =?us-ascii?Q?Mwl4wI3fvWcZwSfuAbLbrP7magPfZw38byAgzitNXE1AHmx63mTHTb30OAFX?= =?us-ascii?Q?eS/VrG6hfl2LaUYlR/zr+8POkgLcF6PCds+CmZyRn7yfbpPDwKjJ9GLz8pGB?= =?us-ascii?Q?GfI4P5EHMLBvYAPtonl/6VaXMLWgH3h38fB/RsxphCpZGgP0cSb0ziIRAAd0?= =?us-ascii?Q?aqi0pjvM+CRj0HnesEwP6nxY/4EfKOzvLvUMpmLBXfze9yLZzdPJky2BhVTS?= =?us-ascii?Q?SVuqPybr8Bg+D1yKdbCb+dIF2i3ftZ/GiPD9qQtK0DuLfQTeFVDDjgKVtSTN?= =?us-ascii?Q?3ENWvsOUP1iOvVNUjtfeIWLpAc+1P6MmZ6Fgn+ikP3i8NIBeK+gTRCKfJfdM?= =?us-ascii?Q?bnCn5e0/+uEpCEv338lDsPsI8vPngQq3qBmLAu7wDrTb4dumjhlv+i8eoxm6?= =?us-ascii?Q?x1OyFwk2i2RuXLKgkGdcMZucbGh9ellayp1bIMcQCrLyFRgUFf/7bHBZT9bO?= =?us-ascii?Q?AiJ+9oY+gMiaCHEPRKPRjY6cB9PAoVaZGain8HduS7FOV2K7Ep39DmaUW1Le?= =?us-ascii?Q?Z1mb7O6FUENKkt4nRFyWD+49xeFFdBd6VbYiTL6iXvekGo1kqNORTbagtp/G?= =?us-ascii?Q?Rku2lRSvwEUlGZHw35O/8Yq58PxpXogsTTM+69w+8eCy5L7bHtVXUwGs1EHt?= =?us-ascii?Q?QoA0LfQQ6w+2MyN9TF4Iwr//Vq3egXr3sY9X9owuj8qLdQ1xxt11JVSEot19?= =?us-ascii?Q?8+HiWRbvpXG6xt0uyo4fulnJgNgjMKEwahOgoAerug=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fVq4TlaRHiv4v4UI4Upfutvm7/E4iLW6T4re3vN1A0eC7qq4F19NqMbhJtkS?= =?us-ascii?Q?v3uU/wWO1qxoD2k8dJf3mfuNY5reEpZ8aHAwPHG8vU6Yp5p5g8HOOKNmLhSQ?= =?us-ascii?Q?RQLLjPZszOa82BVuVXDWwRCyoYku7wyAkos4wtDpsWxoxNhIFMF5KDjVJbxM?= =?us-ascii?Q?dq9kRHwup7m4upNzNriIV/JECY8+B/HIzOJGkq+1OOqM4v18+R5rzcqfAlvf?= =?us-ascii?Q?+21aLV+f6Nmy0NAJoXK8TnEsas0ek6vqp/074v4m008MfzrwF3nXPdI4YgxT?= =?us-ascii?Q?EZFEZjAneyyIjpyLEioTx1z0w3JaRhDi4E+DMbl1z2R0nOa66OI5qg9ECaIF?= =?us-ascii?Q?KVHMQfc2iiYKQJFMrp/fGy1/QVyiSlLSRYcRupF0hIJDytSkJTW5ewWCFw+2?= =?us-ascii?Q?o53PU1vJlQbCmBfy4aZ5kM0lwt+zsf1Sx87KYC2xAZOwWjUGjNlewQ5WZBjX?= =?us-ascii?Q?ZDpjOZDVaBpmxoavemuzdmS2/8Xw3bBQU1dUjHnLCUatYIONL68xzvDnqqr0?= =?us-ascii?Q?vXkIVWH5u3+u/WcmWjcROuPt4oWbP1VfN7Mwpu5Z0mwRsT4SYFmG9cHgMxhe?= =?us-ascii?Q?5rKlmP8rRdYGXteftneqZdFIIKDuIsbOyQ5/WQiawX6fAW2u0bkiisVhSbiV?= =?us-ascii?Q?tgWEApRPMU7QyBd88zej/TJiy04tudPeG+LdlD/wfAThpwhOn7y82RgMmMo3?= =?us-ascii?Q?ACH82AjD3HnpkEN0oefFt1Cc1PIcwlLuVekstb3Qyo2SEt2rqs2G+kZczapc?= =?us-ascii?Q?9QJG7Lp44sz/9x/bwZ3cPkEKFJ6W8Cva6H4ID4jBhcQyO0E8ZJ0//p6aLiGL?= =?us-ascii?Q?cvdZjyeaGBhPIqsvuB9gTwHJZDFkpQ1bWO8OAVI6LudZV0jblCOuAzIk+m0J?= =?us-ascii?Q?+qIZFpns2i08+SyK/ERwsLPdEx/IeY+CCrMiXLVnFt/TNu2Z40JXZg71MjRQ?= =?us-ascii?Q?b3KWUaxawrJRgyesX62+bf2P9ZeUu/x7Db7utqd9hW474dg0v1U6ok5EycAF?= =?us-ascii?Q?P5Cz1VAKSgNqxHCtRdtVx3vVMDQlOeOh/mK4NqXCCatPqbqfYKzCxiz1ChVk?= =?us-ascii?Q?RUinaboSgh7o6Fg5a5lul81eqNF8Okpkx+wF3JYePVWEqpCi69kwpU7gETgH?= =?us-ascii?Q?CuH/9T5Om86RLIGzMwH2G2npuhhOFT6Y/rDB5quK/r0jLiDjWgAQIO502Kyv?= =?us-ascii?Q?M+MyFlrA6NVGBdVCnzjFSh4uKzppxTjFHuGMB8IfAiKM7tfIeA3tUg1LH7ub?= =?us-ascii?Q?rPrkUuLb0d7epSaFODJSvUxhYKZeHMcPc7BFQbKlsf24xZR/cJCB3FJUKwU/?= =?us-ascii?Q?aFjHItipTTp8KwAI0XQ6IAFC8W85MdzKKhWkGnKMluupB9H+4s/XcvBwmC0H?= =?us-ascii?Q?kWQmupER2StaAiK1KL4aFr91TL1O6IvsasK7TNdtMNBr3xLg7Fw3eiw3vlIT?= =?us-ascii?Q?CYu/8EgbSdCJaD67Q8mp5E/Qa04LQnTMlBQkcFY51PDhy+e1aaLZc2O9l/1+?= =?us-ascii?Q?Cyp03h9+A0kHnvn80K6NEOR/vYjImLwjS24vBytGh9I/8+YfzcYtrxqd+QAR?= =?us-ascii?Q?oaTbV1tCeTGysW+ImGTcJB8UPG3ZWIB6X693MtHKWPjb6JSCmx8yco+3dUvB?= =?us-ascii?Q?9w=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21a1fbe3-e37c-4712-4af2-08dc6b01fcf6 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2024 23:45:46.2562 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cjMf1grBcx+8x7g8FCj3pjDvScROMqCC8e7oZ+nBgTUYk9orepM+Agk6/UUaREzrETMDY71LgTfq5f8iCOYJ3BtqMLo5qkqw5uoWi4bXSdo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5972 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 02 May 2024 16:45:54 -0700 Resent-From: nathaniel.l.desimone@intel.com Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: eaasBP3SVJe7XIbGtqXMNbrrx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=hkRQbre2; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Nate DeSimone > -----Original Message----- > From: Hsueh, DoraX > Sent: Monday, April 22, 2024 1:40 AM > To: devel@edk2.groups.io > Cc: Hsueh, DoraX ; Chaganty, Rangasai V > ; Chuang, Rosen ; > Kasbekar, Saloni ; Tang, Haoyu > ; Desimone, Nathaniel L > ; Chiu, Chasel > Subject: [PATCH] AlderlakeOpenBoardPkg: Halt the TCO timer. >=20 > From: DoraX Hsueh >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4761 >=20 > Halt the TCO timer to fix release mode hang. >=20 > Cc: Sai Chaganty > Cc: Rosen Chuang > Cc: Saloni Kasbekar > Cc: Haoyu Tang > Cc: Nate DeSimone > Cc: Chasel Chiu > Signed-off-by: DoraX Hsueh > --- > .../AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc | 3 ++- > .../Library/SecFspWrapperPlatformSecLib/PlatformInit.c | 8 ++++++++ > .../SecFspWrapperPlatformSecLib.inf | 1 + > 3 files changed, 11 insertions(+), 1 deletion(-) >=20 > diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoard= Pkg.dsc b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.d= sc > index 59350f06..ea92ec75 100644 > --- a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc > +++ b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.dsc > @@ -233,8 +233,9 @@ > =20 > [LibraryClasses.X64.DXE_SMM_DRIVER] > =20 > -!if $(TARGET) =3D=3D DEBUG > SpiFlashCommonLib|IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiF= lashCommonLib.inf > + > +!if $(TARGET) =3D=3D DEBUG > TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/S= mmTestPointCheckLib.inf > TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLibNu= ll/TestPointCheckLibNull.inf > !endif > diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecF= spWrapperPlatformSecLib/PlatformInit.c b/Platform/Intel/AlderlakeOpenBoardP= kg/FspWrapper/Library/SecFspWrapperPlatformSecLib/PlatformInit.c > index f7ec4f9e..e930c9c7 100644 > --- a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp= erPlatformSecLib/PlatformInit.c > +++ b/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp= erPlatformSecLib/PlatformInit.c > @@ -12,6 +12,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include > #include > #include > +#include > +#include > =20 > /** > Platform initialization. > @@ -28,6 +30,12 @@ PlatformInit ( > IN VOID *EndOfRange > ) > { > + > + /// > + /// Halt the TCO timer as early as possible > + /// > + IoWrite16 (PcdGet16 (PcdTcoBaseAddress) + R_TCO_IO_TCO1_CNT, B_TCO_IO_= TCO1_CNT_TMR_HLT); > + > // > // Platform initialization > // Enable Serial port here > diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecF= spWrapperPlatformSecLib/SecFspWrapperPlatformSecLib.inf b/Platform/Intel/Al= derlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapperPlatformSecLib/SecFspWr= apperPlatformSecLib.inf > index 3e51cb36..abc84057 100644 > --- a/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp= erPlatformSecLib/SecFspWrapperPlatformSecLib.inf > +++ b/Platform/Intel/AlderlakeOpenBoardPkg/FspWrapper/Library/SecFspWrapp= erPlatformSecLib/SecFspWrapperPlatformSecLib.inf > @@ -89,6 +89,7 @@ > gIntelFsp2WrapperTokenSpaceGuid.PcdFsptBaseAddress ##= CONSUMES > gIntelFsp2PkgTokenSpaceGuid.PcdFspTemporaryRamSize ##= CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdSecSerialPortDebugEnable ##= CONSUMES > + gSiPkgTokenSpaceGuid.PcdTcoBaseAddress ##= CONSUMES > =20 > [FixedPcd] > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase ##= CONSUMES > --=20 > 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118543): https://edk2.groups.io/g/devel/message/118543 Mute This Topic: https://groups.io/mt/105665490/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-