From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 71302AC1A1E for ; Mon, 8 Apr 2024 22:26:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=08MD0UEpzzVcYFcHVbFpzEC30NC/x1d73rvt7zl+zuM=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1712615159; v=1; b=hXPnobQ6c4ofpJWRbPJ24/7+V7ItewBDH/bBSINoGSA5qPiqgCnqs9/hQF9WMXhIrGLiukd0 xqng2FBNJhTqxVhLi/a4uo7vEZBQ+8mKO1FuFI+31hdKzxZGT4qlXS2PfnNtMrRrOkfrc/9KIwi j3bpO/T3B4RJvFejS+jkU2+MPbR+IGGXjsmme2T5cqowxmnBKag2T9wzDYQnDKd42NAGmtgH+I1 B4ToA/Fio6moe7IxYWdU3K+EmHF2Yaz8ANXpxSFtkCfeLljCSFAmzWd2cx6B52CxMfdi/twJm6h N8kYafPTpyhqwSalqQg9U0cgD02gTbPBPfbqDkNgkhsVw== X-Received: by 127.0.0.2 with SMTP id YTerYY7687511xu27T31YhKE; Mon, 08 Apr 2024 15:25:59 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mx.groups.io with SMTP id smtpd.web10.121988.1712615158422523629 for ; Mon, 08 Apr 2024 15:25:58 -0700 X-CSE-ConnectionGUID: jlEjHHchRq2/ZAtZeeLI8A== X-CSE-MsgGUID: 1XilsAvGSjO+5K4kBwNQ6g== X-IronPort-AV: E=McAfee;i="6600,9927,11038"; a="8094949" X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208";a="8094949" X-Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Apr 2024 15:25:58 -0700 X-CSE-ConnectionGUID: F6C8M+lBRCW/pZWPnVPY7A== X-CSE-MsgGUID: 1862RYNySMWyWUxAexIvZA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,187,1708416000"; d="scan'208";a="19891355" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa010.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Apr 2024 15:25:58 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Apr 2024 15:25:57 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 8 Apr 2024 15:25:57 -0700 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 8 Apr 2024 15:25:57 -0700 X-Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.40) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 8 Apr 2024 15:25:56 -0700 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by SJ2PR11MB8372.namprd11.prod.outlook.com (2603:10b6:a03:539::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.26; Mon, 8 Apr 2024 22:25:53 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2769:a1e8:3236:e5a1]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::2769:a1e8:3236:e5a1%4]) with mapi id 15.20.7452.019; Mon, 8 Apr 2024 22:25:53 +0000 From: "Nate DeSimone" To: "Hsueh, DoraX" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Chuang, Rosen" , "Kasbekar, Saloni" , "Tang, Haoyu" Subject: Re: [edk2-devel] [PATCH] AlderlakeOpenBoardPkg: Fix BootStage 5 can't install Windows11. Thread-Topic: [PATCH] AlderlakeOpenBoardPkg: Fix BootStage 5 can't install Windows11. Thread-Index: AQHaVbfcdyatwTiEF0yEcEIp5fG/sbFfW1Hg Date: Mon, 8 Apr 2024 22:25:53 +0000 Message-ID: References: <86f11c0468a61985547906fa0a27ceede244a226.1706858499.git.dorax.hsueh@intel.com> In-Reply-To: <86f11c0468a61985547906fa0a27ceede244a226.1706858499.git.dorax.hsueh@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|SJ2PR11MB8372:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 7eL6HytZamb+8r41dParhPHDjjtisC6W12/JjXq+uR4MgRxv8dEGUxl9kNqrrNt06tkXTBdAciM2NFPj7r3qvuDGz1Zz+idbwUDGF7jYfTIglG9LpUWhmnHZrrAXrLT/7IYtPiChBlaG6XxVpgMiQ1KR4+94y7aX9pC6DmOZM0GAl7MsRGwUeM5cocTYmhg6jbCvqL/qbbPoYr9WjmlQdSX8FvT4V1Z6LdDpSQG5k8sDMHQoFs0hLJxKVGIw3Zaqm31cnXi6Ir/vnQBIZt1pTT/+niRvZ4buLQJ4iVlO7T7skUdGQOwgq29DYwy0nQCxh7tyRK0g+dg5Fv3Q+ZHL3q1W8jxNdFHN0wnX5y+RDeDkDkNBT6gbWaCmHXoRDeIMFBcJDT1iIQJQ4T9CMVRGb3HthtEaY0agYe1UHNRtvrW5Lb4fO0pLQe6WsMoYbBAh2zXSH4OL1KOeynvmEKPAXF4MvQD+6MwNsTw2zl6luahNt7lUdDInE6GigOAukbFDrXJx1NzRQ4DW9d/eJho7Yed6iRr+Ca2c6UDsH8x+Kq8alArRtVthXhAMRrHJH+DKch4P1gbFml8HeHlIs3EKvNOcomP48QrxMlHjj/0QaKE= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?JgaZwAHG/J11Wv8c4Bnn0UjarjtMjBSTOblCnIwYW9fTH2Acpe1PcQDqcoiq?= =?us-ascii?Q?9O1DxHkWPkWsdHTPk5rwM3Rrn7FPjVPn5l1HeM9Wso93RY38yLUVy0/0AGTm?= =?us-ascii?Q?cQoGNK+mIZUD9WSR1Y/lmt2/YAAS/owIvAUo0y82fRSrYqmoZbL9twzQFeqc?= =?us-ascii?Q?EgGJd3DKImDjIjqFIJXQ2G+hpmNGFlJbfNYHolIzOvStcXDOv6jOxjzVHIW0?= =?us-ascii?Q?DsaX62wFt3DMsivNfbsQpRMyFLuar/4BITDGg0YdrDcLPYSW320JMQvNDp1Z?= =?us-ascii?Q?2fxS4kiZHaZHzfLxt8/1lnyjoA4jB84H5lC8T8c29JRTbNhIzQ7Dcuardi6F?= =?us-ascii?Q?Rj32kVzAp7iPfhHovdo16FoafkjF/igmlYsfvF4PJBkBUPxP/xv801Nijgym?= =?us-ascii?Q?3Gjma6LXGxBNiCe/lGN5zvrsoIRHlA7JpD/kjy55Kp2AIVINQzgc0TFC44QO?= =?us-ascii?Q?IJNWvBbM6YVi1X1hP9L1KV//gXtCNHPix+6+DD/VIF/3YSeoxdB9wdtyK8t1?= =?us-ascii?Q?134FJFw0+N9uaxj7ZOVn8Qm2mc7ZI/E+D0FDoq3k3u58uvFROTyN+UU0PFYI?= =?us-ascii?Q?BN/JSadf1q6y/YrRx6Bog+AzF2fmjei596TTVRtvkSHk8cRzeYEpFlqcD/qH?= =?us-ascii?Q?JFq4iY2nRMUV4RBZDlvfwmy8qywZBSGJJ7cuyjdXXarmMQevOQhoT49b6CKa?= =?us-ascii?Q?YhTWXJKeUfwc2QEcTHNMNpR2PSrm1x/+Afb8V7Se0TWecQAoXQpjPwQgP+q5?= =?us-ascii?Q?07Pbu7L0pEYzWCJWVejTVqGgz1/3yXz3apW++FAsxFL48Zk3avlbnfCL6pkc?= =?us-ascii?Q?4jo1HwJiKADWS7QvwJ2eIoR/DkjdpVWha01PAaCHL6/O9gJNBOWM6aqGd1t8?= =?us-ascii?Q?DRafCl1P1ZfgZqBvgnSjt+V6qCVcMtXWkbKcB+Bl7Qss5fw3l8cOJ2wHrRfM?= =?us-ascii?Q?fAp0my4clbRvrSxU/k4SYP8w57krd2EoGING8LsBbZp90OLGmwRECnTbX8C8?= =?us-ascii?Q?S1UMigwVtihsXVE+PffgrHlmsz7LdJPkDYPPwPG5fAbLGpaErrV9JbV7q9ax?= =?us-ascii?Q?zs8/4x7/OeSrRBNycZfAYiq49E0EdL2wfWAwrLZ4kH/j0n0wrLipvQooq+IV?= =?us-ascii?Q?Sx9nsJAlwGLfDMoZ+FFa8YjTG6AMKRqplEdeqT8KT8lIsaqEMCTeQpqdOhQL?= =?us-ascii?Q?+beoz/VC2Ie694n1QS/gVc24miCwKuBw4fIR106mZXRalTuHc2jpk37tYa1d?= =?us-ascii?Q?7CWs+td3NPqcMSRfekXa4QOYfyUmH6qspbc/5FCPzlGUUJtHBlJmkhJpPULm?= =?us-ascii?Q?Q4CtH36jz4/UXUPxyfkf+mUnFLlOnZD+Rud/+9Y49QM9ALGzsWMshGoAwdSh?= =?us-ascii?Q?aqortibOTxCFH1Zbe6vEoQ3EJYb1rjk3QuAeSeLX0CpT75KKE+hw2gASRV6Y?= =?us-ascii?Q?krXhK0cEsJkjJrSHZyrV1HgJ+vsJIMDFjDuz3ZAepOIpz4TmMHdn1RaSFi5T?= =?us-ascii?Q?zxZ10FKyZXiw+QEYxDKT9+GOxICqAOMC6hrewguKzB3P+rQbJxpmJ9ILEKis?= =?us-ascii?Q?j0wngG8BRIFEfoXMVY1G6NRxc7KLkRyAVmNhh9QfkxNgJxlUJ8I78U1c1TUU?= =?us-ascii?Q?rQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9cb8de8-8ada-44e1-930a-08dc581ada7b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2024 22:25:53.7295 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mPtduBo6iZEE1AoXLmUaJNd07qrOfjqybySUUtOXM/KWW+Q9Elascf5sx3RXuiiFrPSgSdKLvk4bO2fOHtp8WUJggI16vzntLwME01ZqOsU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8372 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 08 Apr 2024 15:25:58 -0700 Resent-From: nathaniel.l.desimone@intel.com Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: cGZBmgwRBkTk0aCewtbymMOlx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=hXPnobQ6; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Dora, Removing FvAdvanced in a violation of the MinPlatform specification. The re= levant section is here: https://tianocore-docs.github.io/edk2-MinimumPlatformSpecification/draft/ap= pendix_a_full_maps/a1_firmware_volume_layout.html#a1-firmware-volume-layout Please add FvAdvanced back into the ROM. In addition, PcdBootStage should be set to 6 by default (not 5). Thanks, Nate > -----Original Message----- > From: Hsueh, DoraX > Sent: Friday, February 2, 2024 1:12 AM > To: devel@edk2.groups.io > Cc: Hsueh, DoraX ; Chaganty, Rangasai V > ; Chuang, Rosen ; > Kasbekar, Saloni ; Tang, Haoyu > ; Desimone, Nathaniel L > > Subject: [PATCH] AlderlakeOpenBoardPkg: Fix BootStage 5 can't install > Windows11. >=20 > From: DoraX Hsueh >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D4665 >=20 > Since installing windows does not meet the minimum system requirements, > Added TPM related code to meet the requirements. >=20 > Cc: Sai Chaganty > Cc: Rosen Chuang > Cc: Saloni Kasbekar > Cc: Haoyu Tang > Cc: Nate DeSimone > Signed-off-by: DoraX Hsueh > --- > .../Include/Fdf/FlashMapInclude.fdf | 20 +++++----- > .../AlderlakePRvp/OpenBoardPkg.fdf | 37 +++---------------- > .../AlderlakePRvp/OpenBoardPkgPcd.dsc | 10 ++++- > .../AlderlakeOpenBoardPkg/BiosInfo/BiosInfo.c | 9 +---- > .../BiosInfo/BiosInfo.inf | 2 - > .../AlderlakeOpenBoardPkg/OpenBoardPkg.dec | 1 - > 6 files changed, 25 insertions(+), 54 deletions(-) >=20 > diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/Include/F= df/FlashMapInclude.fdf b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp= /Include/Fdf/FlashMapInclude.fdf > index 03c198c0..9a4ae7e8 100644 > --- a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/Include/Fdf/Flas= hMapInclude.fdf > +++ b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/Include/Fdf/Flas= hMapInclude.fdf > @@ -25,23 +25,21 @@ SET gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageF= twWorkingSize =3D 0x000020 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareOffset = =3D 0x00030000 # Flash addr (0xFF030000) > SET gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize = =3D 0x00030000 # > =20 > -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedOffset = =3D 0x000E0000 # Flash addr (0xFF0E0000) > -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedSize = =3D 0x00310000 # > -SET gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalOffset = =3D 0x003F0000 # Flash addr (0xFF400000) > -SET gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalSize = =3D 0x00360000 # > -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecurityOffset = =3D 0x00750000 # Flash addr (0xFF760000) > +SET gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalOffset = =3D 0x000E0000 # Flash addr (0xFF400000) > +SET gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalSize = =3D 0x00650000 # > +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecurityOffset = =3D 0x00730000 # Flash addr (0xFF760000) > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecuritySize = =3D 0x00090000 # > -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvOsBootOffset = =3D 0x007E0000 # Flash addr (0xFF7F0000) > +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvOsBootOffset = =3D 0x007C0000 # Flash addr (0xFF7F0000) > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvOsBootSize = =3D 0x000A0000 # > -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootOffset = =3D 0x00880000 # Flash addr (0xFF860000) > +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootOffset = =3D 0x00860000 # Flash addr (0xFF860000) > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootSize = =3D 0x00180000 # > =20 > -SET gBoardModuleTokenSpaceGuid.PcdFlashFvFirmwareBinariesOffset = =3D 0x00A00000 # Flash addr (0xFFA00000) > +SET gBoardModuleTokenSpaceGuid.PcdFlashFvFirmwareBinariesOffset = =3D 0x009E0000 # Flash addr (0xFFA00000) > SET gBoardModuleTokenSpaceGuid.PcdFlashFvFirmwareBinariesSize = =3D 0x00080000 # Keep 0x80000 or larger > -SET gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset = =3D 0x00A80000 # Flash addr (0xFFA80000) > +SET gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvOffset = =3D 0x00A60000 # Flash addr (0xFFA80000) > SET gIntelSiliconPkgTokenSpaceGuid.PcdFlashMicrocodeFvSize = =3D 0x00230000 # > -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemoryOffset = =3D 0x00CB0000 # Flash addr (0xFFCB0000) > -SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemorySize = =3D 0x00040000 # > +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemoryOffset = =3D 0x00C90000 # Flash addr (0xFFCB0000) > +SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemorySize = =3D 0x00060000 # > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSOffset = =3D 0x00CF0000 # Flash addr (0xFFCF0000) > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize = =3D 0x000A0000 > SET gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMOffset = =3D 0x00D90000 # Flash addr (0xFFD90000) > diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoard= Pkg.fdf b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.f= df > index f1ce271b..7fb6198f 100644 > --- a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.fdf > +++ b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkg.fdf > @@ -113,9 +113,15 @@ DATA =3D { > #Blockmap[1]: End > 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, > ## This is the VARIABLE_STORE_HEADER > +!if gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable =3D=3D TRUE > + # Signature: gEfiAuthenticatedVariableGuid =3D { 0xaaf32c78, 0x947b, = 0x439a, { 0xa1, 0x80, 0x2e, 0x14, 0x4e, 0xc3, 0x77, 0x92 }} > + 0x78, 0x2c, 0xf3, 0xaa, 0x7b, 0x94, 0x9a, 0x43, > + 0xa1, 0x80, 0x2e, 0x14, 0x4e, 0xc3, 0x77, 0x92, > +!else > # Signature: gEfiVariableGuid =3D { 0xddcf3616, 0x3275, 0x4164, { 0x9= 8, 0xb6, 0xfe, 0x85, 0x70, 0x7f, 0xfe, 0x7d }} > 0x16, 0x36, 0xcf, 0xdd, 0x75, 0x32, 0x64, 0x41, > 0x98, 0xb6, 0xfe, 0x85, 0x70, 0x7f, 0xfe, 0x7d, > +!endif > #Size: 0x2E000 (gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageVariab= leSize) - 0x48 (size of EFI_FIRMWARE_VOLUME_HEADER) =3D 0x2DFB8 > # This can speed up the Variable Dispatch a bit. > 0xB8, 0xDF, 0x02, 0x00, > @@ -141,11 +147,6 @@ gMinPlatformPkgTokenSpaceGuid.PcdFlashNvStorageFtwSp= areOffset|gEfiMdeModulePkgTo > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareBase|gEfiMdeModu= lePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize > #NV_FTW_SPARE > =20 > - > -gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedOffset|gMinPlatformPkgTo= kenSpaceGuid.PcdFlashFvAdvancedSize > -gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedBase|gMinPlatformPkgToke= nSpaceGuid.PcdFlashFvAdvancedSize > -FV =3D FvAdvanced > - > gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalOffset|gBoardModuleTokenSpa= ceGuid.PcdFlashFvOptionalSize > gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalBase|gBoardModuleTokenSpace= Guid.PcdFlashFvOptionalSize > FV =3D FvOptional > @@ -646,28 +647,6 @@ INF $(PLATFORM_PACKAGE)/Tcg/Tcg2PlatformDxe/Tcg2Pla= tformDxe.inf > =20 > INF IntelSiliconPkg/Feature/SmmAccess/SmmAccessDxe/SmmAccess.inf > =20 > - > -[FV.FvAdvanced] > -BlockSize =3D $(FLASH_BLOCK_SIZE) > -FvAlignment =3D 16 > -ERASE_POLARITY =3D 1 > -MEMORY_MAPPED =3D TRUE > -STICKY_WRITE =3D TRUE > -LOCK_CAP =3D TRUE > -LOCK_STATUS =3D TRUE > -WRITE_DISABLED_CAP =3D TRUE > -WRITE_ENABLED_CAP =3D TRUE > -WRITE_STATUS =3D TRUE > -WRITE_LOCK_CAP =3D TRUE > -WRITE_LOCK_STATUS =3D TRUE > -READ_DISABLED_CAP =3D TRUE > -READ_ENABLED_CAP =3D TRUE > -READ_STATUS =3D TRUE > -READ_LOCK_CAP =3D TRUE > -READ_LOCK_STATUS =3D TRUE > -FvNameGuid =3D B23E7388-9953-45C7-9201-0473DDE5487A > - > - > [FV.FvFwBinaries] > BlockSize =3D $(FLASH_BLOCK_SIZE) > FvAlignment =3D 16 > @@ -688,10 +667,6 @@ READ_LOCK_CAP =3D TRUE > READ_LOCK_STATUS =3D TRUE > FvNameGuid =3D 8B98AB22-E354-42f0-88B9-049810F0FDAA > =20 > - > - > - > - > [FV.FvOptional] > BlockSize =3D $(FLASH_BLOCK_SIZE) > FvAlignment =3D 16 > diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoard= PkgPcd.dsc b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPk= gPcd.dsc > index 3eb9a575..b52ed92c 100644 > --- a/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkgPcd.= dsc > +++ b/Platform/Intel/AlderlakeOpenBoardPkg/AlderlakePRvp/OpenBoardPkgPcd.= dsc > @@ -25,7 +25,7 @@ > # Stage 5 - boot to OS with security boot enabled > # Stage 6 - boot with advanced features enabled > # > - gMinPlatformPkgTokenSpaceGuid.PcdBootStage|4 > + gMinPlatformPkgTokenSpaceGuid.PcdBootStage|5 > =20 > # > # 0: FSP Wrapper is running in Dispatch mode. > @@ -313,6 +313,14 @@ gIntelFsp2WrapperTokenSpaceGuid.PcdFspsUpdDataAddres= s|0x00000000 > gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber|16 > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChange|F= ALSE > =20 > +!if gMinPlatformPkgTokenSpaceGuid.PcdTpm2Enable =3D=3D TRUE > + gEfiSecurityPkgTokenSpaceGuid.PcdTpmInitializationPolicy|1 > + gEfiSecurityPkgTokenSpaceGuid.PcdTpmInstanceGuid|{0x5a, 0xf2, 0x6b, 0x= 28, 0xc3, 0xc2, 0x8c, 0x40, 0xb3, 0xb4, 0x25, 0xe6, 0x75, 0x8b, 0x73, 0x17} > +!endif > + > +[PcdsDynamicHii.common.DEFAULT] > + gEfiSecurityPkgTokenSpaceGuid.PcdTpm2AcpiTableRev|L"TCG2_VERSION"|gTcg= 2ConfigFormSetGuid|0x8|4|NV,BS > + > [PcdsDynamicHii.X64.DEFAULT] > gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|L"Timeout"|gEfiGlobalV= ariableGuid|0x0|5 # Variable: L"Timeout" > gEfiMdePkgTokenSpaceGuid.PcdHardwareErrorRecordLevel|L"HwErrRecSupport= "|gEfiGlobalVariableGuid|0x0|1 # Variable: L"HwErrRecSupport" > diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/BiosInfo/BiosInfo.c b/P= latform/Intel/AlderlakeOpenBoardPkg/BiosInfo/BiosInfo.c > index 64462900..306b42d9 100644 > --- a/Platform/Intel/AlderlakeOpenBoardPkg/BiosInfo/BiosInfo.c > +++ b/Platform/Intel/AlderlakeOpenBoardPkg/BiosInfo/BiosInfo.c > @@ -19,7 +19,7 @@ > #include > #include > =20 > -#define BASE_FV_SIZE 10 > +#define BASE_FV_SIZE 9 > =20 > #define FSP_WRAPPER_FV_SIZE 3 > =20 > @@ -65,13 +65,6 @@ GLOBAL_REMOVE_IF_UNREFERENCED BIOS_INFO mBiosInfo =3D= { > FixedPcdGet32 (PcdFlashNvStorageVariableSize) + FixedPcdGet32 (Pcd= FlashNvStorageFtwWorkingSize) + FixedPcdGet32 (PcdFlashNvStorageFtwSpareSiz= e), > FixedPcdGet32 (PcdFlashNvStorageVariableBase) > }, > - { > - FIT_TYPE_07_BIOS_STARTUP_MODULE, > - BIOS_INFO_STRUCT_ATTRIBUTE_BIOS_POST_IBB, > - 0x0100, > - FixedPcdGet32 (PcdFlashFvAdvancedSize), > - FixedPcdGet32 (PcdFlashFvAdvancedBase) > - }, > { > FIT_TYPE_07_BIOS_STARTUP_MODULE, > BIOS_INFO_STRUCT_ATTRIBUTE_BIOS_POST_IBB, > diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/BiosInfo/BiosInfo.inf b= /Platform/Intel/AlderlakeOpenBoardPkg/BiosInfo/BiosInfo.inf > index b1145180..70b1f80b 100644 > --- a/Platform/Intel/AlderlakeOpenBoardPkg/BiosInfo/BiosInfo.inf > +++ b/Platform/Intel/AlderlakeOpenBoardPkg/BiosInfo/BiosInfo.inf > @@ -51,8 +51,6 @@ > gEfiMdeModulePkgTokenSpaceGuid.PcdFlashNvStorageFtwSpareSize ## CON= SUMES > gBoardModuleTokenSpaceGuid.PcdFlashFvFirmwareBinariesBase ## CON= SUMES > gBoardModuleTokenSpaceGuid.PcdFlashFvFirmwareBinariesSize ## CON= SUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedBase ## CON= SUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedSize ## CON= SUMES > gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalBase ## CON= SUMES > gBoardModuleTokenSpaceGuid.PcdFlashFvOptionalSize ## CON= SUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecurityBase ## CON= SUMES > diff --git a/Platform/Intel/AlderlakeOpenBoardPkg/OpenBoardPkg.dec b/Plat= form/Intel/AlderlakeOpenBoardPkg/OpenBoardPkg.dec > index 0f0ed386..7f3295d8 100644 > --- a/Platform/Intel/AlderlakeOpenBoardPkg/OpenBoardPkg.dec > +++ b/Platform/Intel/AlderlakeOpenBoardPkg/OpenBoardPkg.dec > @@ -28,7 +28,6 @@ Include > # > # FvImage File > # > - gFvAdvancedFileGuid =3D {0xAD198BA5, 0xC330, 0x41CD,= {0xB0, 0x97, 0x16, 0x48, 0x83, 0x28, 0xB7, 0x98}} > gFvOsBootFileGuid =3D {0xB9020753, 0x84A8, 0x4BB6,= {0x94, 0x7C, 0xCE, 0x7D, 0x41, 0xF5, 0xCE, 0x39}} > gFvUefiBootFileGuid =3D {0x9E21FD93, 0x9C72, 0x4c15,= {0x8C, 0x4B, 0xE7, 0x7F, 0x1D, 0xB2, 0xD7, 0x92}} > gTianoLogoGuid =3D {0x7BB28B99, 0x61BB, 0x11D5= , {0x9A, 0x5D, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D}} > --=20 > 2.26.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117506): https://edk2.groups.io/g/devel/message/117506 Mute This Topic: https://groups.io/mt/104120130/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-