From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.1610.1666657143045422884 for ; Mon, 24 Oct 2022 17:19:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=KGGH5Hw5; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666657143; x=1698193143; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Kwu5xEbOCznD2O2Ob02vW5ryVqLqzBSCnhv7CQralcE=; b=KGGH5Hw5oghglGt5uCGCtev0DUhZuG7w6ThuCz1AYQN//tzfIhIcQfOM NO7qEEcZ7xCz3v+IggtppouhhPzjlKo1R+scI7EbjxH4BN5w7uadCclkL F4N4JBrDQgxR0j5uVrFj0z+zuBcLSclSv18MKL4LubkOHOSnrXv+EyIkw UecmBMj4bP4gL1KnbW9b7F2CZ3g5/h+xLV2izYsgeRoChqTrUXCm1k6xI wOifkqHhPcO+T9GaX6ejHbi8PJCU5rnfepK4j1B9Szi+XNkhzpzdno8vJ 6PlLuDEpGOMr06+jTz1HYYIoHUp0cxyGPw6HSa43IdGTEkefGLdMnvFjT g==; X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="287271370" X-IronPort-AV: E=Sophos;i="5.95,210,1661842800"; d="scan'208";a="287271370" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 17:19:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="806481426" X-IronPort-AV: E=Sophos;i="5.95,210,1661842800"; d="scan'208";a="806481426" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP; 24 Oct 2022 17:19:01 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct 2022 17:19:01 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 24 Oct 2022 17:19:01 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Mon, 24 Oct 2022 17:19:01 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Mon, 24 Oct 2022 17:19:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FH4ilBEWQk1x4pdoYtvVkXVz4AA01WEezCZdgrzV+vDgqU9o3oNyOl3CpU9QlLZs81wtC0i4yFDTfccKsolpIZIs8mMZXb96NilQYoNz49+W6vGhAqCjtWcF0dT7iWc4n/eEuAB9KiABEWhFiD4cdd9+tXn6PTnS0KSNW/JjQEvfz1CM10/ma5RfnSMjzTgx6b0tRJW1yhqqFlu4Hp1cwQgFKLul+iJvPm56z7HMGT2V9J6ylC2DyB8PI4duDXfh5hxq0mb6eoLk670cf+r27itVcMRQAgO6y9SkHTWEYiz2Urz2RbR6y/CfBozhjmFu5ztDUePwyzPS4nPd9ozWeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OC6y7ZlG1ykCC1tf+KH3+fejDCznrWSqZK2tlxLj5fc=; b=Gq/L1StpUjUxZxpaNp222tk0QquuIS3TrkWycW5D28Syb99tIhNd6IM9oM3doNjhqUXxaLZwwuS6dc1ZefJyV7FHXkWlCro/zWVyX1FtCVlZLgh3Nly9wHOPBRQA5inNSt/udJmhD7UTHgb+4u2jbEbNFI5HuzrpLNw+u3adtsnRpXtI7l64bFyCWOdB1vOcqQLCs8XJTgeyDT9uXsS43/xwUO8HqBbAja7NX+feQvdbUyElCZNH+MfvChA4sS+9VsX2EvTSFKOeu4uYAr6IcZZvG1P0FjdlcKLP1/pzrgHYDYSWHIHoe0b/+4J080AriHMQneOLjILmo2ORM2jwkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by BL1PR11MB5955.namprd11.prod.outlook.com (2603:10b6:208:386::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.41; Tue, 25 Oct 2022 00:18:59 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::a748:40a8:78d3:38e6]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::a748:40a8:78d3:38e6%3]) with mapi id 15.20.5723.033; Tue, 25 Oct 2022 00:18:58 +0000 From: "Nate DeSimone" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Luo, Heng" , "Chaganty, Rangasai V" Subject: Re: [edk2-platforms][PATCH v2 0/3] Silicon/Intel: Fix invalid DEBUG() macros Thread-Topic: [edk2-platforms][PATCH v2 0/3] Silicon/Intel: Fix invalid DEBUG() macros Thread-Index: AQHY3kVB74lM+T7HKUCOUNnyutKL4a4eUhiw Date: Tue, 25 Oct 2022 00:18:58 +0000 Message-ID: References: <20221012141610.668-1-mikuback@linux.microsoft.com> In-Reply-To: <20221012141610.668-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|BL1PR11MB5955:EE_ x-ms-office365-filtering-correlation-id: 053e265e-b00b-479e-8482-08dab61e82ff x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vQF2usev+JEcI0a3ICbDNZ9dP1oWVgyFA4qXVrojS6DpR9J6qYcOegqcSBlq182IirOxQPqjzNfj2IkVC+DTf8GudDHxH59Tu0zIvw6wKMzMlWbJvUufgVHyuZgrVku1q17paRrd8UcsOGzszcR0dk8EZTVhOTkObx4fA3fB5tcMC5jeFTdyiK2bXL4UNI9tLXiNZjUxBE/2AtegpyGGvUyufb4kOFV7jfFcd7nGjhHlef/ok5DDA3m3PXlFF0zr7OCqUqY8UmBUbxLnBCL2J8e2Qo7NRfl04eGe8ulBWWW6CkxTZb2r2qB29WnT1i4TUSk1W176clJK8ZwPZMGOv06Xvux5+daELD23OQa9PpU8qN6hU2bMexlKctggWhmataIXOaQlEvhMqJPpWRpi3UydJTmBtPkwZoX/93TYz6beoT574hk42nyN+r/w2e65vZ6zI6t9+55wJFboLW8fU311P4SDx9uluTIgmLqOa3Ujs9Dro+e8SfPQegkhomcfz3Uf3CezW6GlXPo6lOaGBgNM/K7wUbhjR70fdHURJEYRsT5z56CRzl4y2u7m30D+iVxJ1hzUlvKEcWVYE3qjr0yK1jgDsyYyDIthY8BKGc/V9/IvuiVA5MxL4WpYpQZWc+dAL75ef1h6pmmJZlPFeklp7D0+ptA6Fg/n1Z1usFCieTNxhKt9HWIDk+bHA4A/KRAm1fo7bte492HzhXBCELfQ5FQU+yaVb7F7m/kJQ4VOtGGKpM09AyyoiQy8rF8Xc3u+LBEaeC6ZQ8F2QmsKpT70AQ46h6VSBuyNlAyNSN0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(39860400002)(346002)(376002)(136003)(396003)(451199015)(53546011)(7696005)(83380400001)(66476007)(6506007)(41300700001)(52536014)(8936002)(38070700005)(33656002)(5660300002)(38100700002)(186003)(82960400001)(122000001)(76116006)(26005)(478600001)(71200400001)(2906002)(55016003)(66946007)(316002)(66556008)(8676002)(107886003)(110136005)(54906003)(66446008)(9686003)(4326008)(86362001)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0ZsTLuyCRk59kFt/vPQE6TxjFppyzJ9O3eIzFaVaxPPDilU9hPXqDl31253x?= =?us-ascii?Q?9q1JtDzanhy0jD88B/rnCOCvRIlpnR6Jd2Y/HDtM4ZpAXYwdqlVz34TsGzhw?= =?us-ascii?Q?vWEXRg+4iXJgn5me5ZNJx+8EHcCNnIIMCz6DGlrMdE25m4yiCr+ez1K2ikki?= =?us-ascii?Q?HMRSPPbFWGfX+5wBLSQoAwR+zQbjPxe12gftjXTjmvMCzjHRSxdE4Wg13Ir9?= =?us-ascii?Q?aMmjK06wzzRQQFV58V6vRsqgrCT3sQn2NE2vkZN9xwXqD3M4S1EnDpsTqYFY?= =?us-ascii?Q?KpdKSHs/6/S9IsDcNRjoabQ/VdmUOtbJlLEVIC6LEyZBhdZCq1UJSQ3VnOCh?= =?us-ascii?Q?F+TD1KWAYgKDi3HlQdqpL4yLNt2FSW5XC7CqiWHlhNpKOkltDeByhjzU6Emf?= =?us-ascii?Q?joZo6rmU+9dUDhIPt/zH/nwht1cSKcgBNqWOZx0X1uNdgVyoGYZjnKnKcsPI?= =?us-ascii?Q?WxYu1PBic6OnZ9ILa6bUs9pSMIKX9cleHXydLRWQ7f4CoMgd6fSSdA/dUGxA?= =?us-ascii?Q?JStxBN30kzEsZo5X9cOOxvz1qXC2yGzLgTNKVpgweOFVbM/XlXrIwCPX+oc/?= =?us-ascii?Q?fpJBQsLAVb7k12OcSna8kA9PGzrwZE8o+1xFqPL0DNSFZxbKuK7zAJ3fdl3o?= =?us-ascii?Q?YWN5cWIUEOq+2aBt7PtCMYQFhQwx8Alwi7NTx3Ow7LUzvExJU9GZzHCM65FJ?= =?us-ascii?Q?bRUhsYwgVe4w0ZvmTb61axtZ7B3sVWUd6yDBdzuUqh+B9xBVB0rw5o2+5I7d?= =?us-ascii?Q?KBQv6u+6qBA57Y8RDmt+VZ2g4CEeIpn7wHSAoBtmNOa1GZE03MQcpQB1BeEI?= =?us-ascii?Q?sQ/jHVoXZxQWWRkX1lQpZzX1KtiSAgZFisr0W8lJSN+W5XEwix7O9mct5jSn?= =?us-ascii?Q?YRT/d8Q8IVnN76tZwU/2uADQ2eXzCU3e0h19RUVZaCC852Y/9Y0uAfBxhBME?= =?us-ascii?Q?zNUnP7aoxp+PVFFB13rLvibcGIdCv+t6F1x4HfLtRIFnFHJWibmutl4bdZQk?= =?us-ascii?Q?7snuTKyz4RHQyVPDNLe2SDvCWhRaWi/rjYhn4R2nPkNnLLvoNHMrqLC5XlvV?= =?us-ascii?Q?APrYJ31FRG6ZB9AAMv9ngnwtXTlcVfUllJ3GTNhGyu2AHvgiY2wBuEI8rRjN?= =?us-ascii?Q?rZEb9avbV1bYMcvBztrLuepQSXHVzYdAA8lO/OS5FZzylrCElSPWMDpviy35?= =?us-ascii?Q?vEQ4Dw2ZVAqxy0h7gylXmm+H1+NcMMRAhaaM/UaiCloJx21y95F1MXCtampC?= =?us-ascii?Q?s/OI6RFeBML/AHx7DcltROGWv2EB8EwCXPHeYFD0YWbvjoqhDG/lSHEls9dU?= =?us-ascii?Q?r38RcMRQ8M/kjQ/e9D80Jq+KprDl17SvUM97X/Yc/1rAkQDtlB0lUQ+cfMds?= =?us-ascii?Q?A+XlVRm8UYUCydJZeM91yBHYFRjEeCn/sHd7yzvbqya4EP6ADkNzhxWmbLht?= =?us-ascii?Q?6Ap98UxZou8Hql3tT+qdnDq0quPsuE4J511sAEJ1vRp9vOYodT7x5Aik5MWs?= =?us-ascii?Q?ZjRuY1ee15kX1Wc/2SEpovWfjxzjiARRiacfWpdKqRQc/6ZXmKKKJrGE9oYq?= =?us-ascii?Q?WQAkbK0FUyV06o9XVPEv4sCSToBmxUO/wb3bN4nmCZY+BDbwaFh7FfugrnFt?= =?us-ascii?Q?sQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 053e265e-b00b-479e-8482-08dab61e82ff X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2022 00:18:58.9091 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IOKx2dwKBwJzWk6TdsYG4u7tIJTPggySYa7Y8ojZ2Ay6M5YT1UH5O5rvwmlm+s6oiFczxVYj6zHtBt6Ie9djcJPoZu9JRNhrn3/SsOgidvc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5955 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For the series... Reviewed-by: Nate DeSimone -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Wednesday, October 12, 2022 7:16 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Luo, Heng ; D= esimone, Nathaniel L ; Chaganty, Rangasai V= Subject: [edk2-platforms][PATCH v2 0/3] Silicon/Intel: Fix invalid DEBUG() = macros From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4095 Fixes several debug macros in Silicon/Intel that have a mismatched number o= f print specifiers to arguments. The original author's intention is not always 100% obvious. Though, this se= ries is relatively straightforward. v2 changes: - Applied debug macro suggestions in Nate's feedback Cc: Chasel Chiu Cc: Heng Luo Cc: Nate DeSimone Cc: Sai Chaganty Signed-off-by: Michael Kubacki Michael Kubacki (3): CoffeelakeSiliconPkg: Fix invalid debug macros KabylakeSiliconPkg: Fix invalid debug macros TigerlakeSiliconPkg: Fix invalid debug macros Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrintPol= icy.c | 2 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiDxeSmmGbeMdiLib/GbeMdiLi= b.c | 2 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c = | 4 ++-- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/PeiDxeSmmPchPciExpr= essHelpersLib/PchPciExpressHelpersLibrary.c | 2 +- Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/CpuPrintPolic= y.c | 19 +++++++++++-------- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiOcWdtLib/PeiOcWdtLib.c = | 4 ++-- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Gbe/LibraryPrivate/PeiDxeSmmGbeM= diLib/GbeMdiLib.c | 2 +- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/PcieRp/LibraryPrivate/PciExpress= HelpersLibrary/PciExpressHelpersLibrary.c | 2 +- 8 files changed, 20 insertions(+), 17 deletions(-) -- 2.28.0.windows.1