From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.6156.1644287887801849284 for ; Mon, 07 Feb 2022 18:38:08 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RE9ndRfo; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: nathaniel.l.desimone@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644287887; x=1675823887; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=mknOCfUpLpBvcZt2xXdGAG9qTBY8T29YvEmNzEAgONY=; b=RE9ndRfowDVR9Gbba7nV+YbmjgVoTuCMuOQq4kvMrvE1U3hvnQZB4yWt 4g/FzRoc42ItvvcAVv7wQGx819T2/DEDwy5NIDFw3sXNg+suSpaVuU5ni u1ZP+EiE9FOilWlEDWAJm7N+Ao/DCwsDeUt4qXCamSRuOMPDqyZR0Nu7/ tgWnmBRQRIf6IYXL529cDLBca0k8uYn8DICDIgajj4yW2iP9ptI2Uc4cG JWskH1gXyMvdmBZFK2UBZesSBUkubvuNf9vmfsVrWxewWXbqBWTIFRz08 aMt2ovci+KPhyGhN5A0T9Ftb7nDEaves4bIqz5Y31e2DcgBVbaZFmS1j2 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10251"; a="335259486" X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="335259486" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 18:38:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="567693789" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga001.jf.intel.com with ESMTP; 07 Feb 2022 18:38:06 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 7 Feb 2022 18:38:06 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 7 Feb 2022 18:38:05 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 7 Feb 2022 18:38:05 -0800 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 7 Feb 2022 18:38:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bfuSvyY7uj1i5K7n91vZ96P+mVHgDyQ7dQZktSIFjVvrztqUjpGjDakUexEh41wdWz/eraKAblsfqXllakkhoG8nFZaoGzR+/1A9BMXgEQk36qo1dnymBbZ/3nw7VBwl6X0/w3L3Si3kv4/v2196eP09GC6OapAGzLM1aqbimpBYOC12k7jd1eV2m3OzHI+8LhsEmQdrX/6uMPMCD6egpSwa2aRUL8b96JEv8eqHpKLkkWGuM7mL5w6CVxvYXIu64RSiX+3lOMPdkKUCR5qn8CPuMilwnPwnKLDRZUroV2rH2KM+M2s7WporSn/jx+2xMkXnV8f0i85TUmevIR/F+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gj57WJqY0eIeCFlcjNXdrP3Lccu7Ca6aXDacWHblJCg=; b=N4j1Q7dj5BiZgZTZP/wqbDU40WGNkw2yrTIZJDcd0StxWrboN0tYmeUlQnXoJyz7Gx8KS7BYjkOi53He4xD9n8l5Bx/ceq90KlCI2ltSEfpSf5vRJipXRT0Bl/wJOZGdAWjEtASpuilMbV192fqKC8Yeu3q+UnpfByc5y+J3VX/CB5NQhinzp7sGhsCf6DtLOlCs4gXWbZoLqbgHGiOS+YFPjinz+OeraP+bmTLaYdMIfbI8TEUyaVQ8L/66Qoh4awUUXkvn4jAtJQPTchWMWs4q2DNeJ72j4QkuzlgogvJNNiYzm68BOWSr89zunYVk9xt1TKuJV4g4+bLlr4Widw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by CY4PR11MB1624.namprd11.prod.outlook.com (2603:10b6:910:8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Tue, 8 Feb 2022 02:38:04 +0000 Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::6920:39b9:e18c:9dc5%7]) with mapi id 15.20.4930.022; Tue, 8 Feb 2022 02:38:04 +0000 From: "Nate DeSimone" To: "Zhang, Xiaoqiang" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Oram, Isaac W" Subject: Re: [PATCH v1] MinPlatformPkg: Install memory relating PPIs Thread-Topic: [PATCH v1] MinPlatformPkg: Install memory relating PPIs Thread-Index: AQHYG/pgNH/YEkNYhEudw8BZndnz5ayI8aDA Date: Tue, 8 Feb 2022 02:38:03 +0000 Message-ID: References: <20220207081109.1094-1-xiaoqiang.zhang@intel.com> In-Reply-To: <20220207081109.1094-1-xiaoqiang.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3c64fb00-c09e-43af-5501-08d9eaac0814 x-ms-traffictypediagnostic: CY4PR11MB1624:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:466; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HB9UIB7RcxTcVCJ6ywqDlBQp7tnv+JeHUi50KbcqsbTd07KcK/UcIQSWTBiv8g4lgeVIDD9Z+UeRCLyuxUcEBmYDJQD6PEpvhWzp46kXisIPBKFZDTT2Qk1RnyiPVNfQJ5pgJGM6HjKCFBXz4sysOcP9TZsh6mWbyRKqpjqcLnmFA04Ka/tuVaDvIOlqU4NzbP4IY1nQ6UQeGjnjh4MS9iLUWe6iRNH5CbEFt7k+GBGa+yWfDeuV20e//RoQUsoq3dDdK8nDspfSmlC4w5qMFLvndkWCNrItO1MfVZ41RTv5xNC4HOmyXHyVvZFRNnjpr3vvDVIsSyIJCZPHvF2qTV9zuy+KO2Xhvg+8yrsDSHxmVooTldnUQtvxTF4e6pedOTcl2JolNwSjjmihq01uR0VAR57WbM7Nam96Puc8+yRIV46sr+q0BmoEYa1nEQGhK737BV31Ok3jJfa3R0/mPh1xqzicvnlEtOm616LDHza66lKT5lg0Q2PpCXxDnKQvi40/9umv4LI9gvaZTaukP2uF/tqcDcc69voetxZ6UZBFsAxwoK8KcDCUkynmtCWwrBuu1orn18HTE5YDDVy3illBPgbDySUadrAVfe4cpmsl+fvzegqj76E8Zg9fD1f1HJshBw9BY5QW1a0mYoL+HFYIaoTWHNVk/+hO9afBEQbaBt3qMKv13gNkDzsSXt0zxRxQhshat09F5Gdt83kzc+Lpy3SObXySzKodNcRmYoAvINgsvpTAKpScYwsAGwJR0oKUpj+Sf/B21gURDTx0l8/mLSFGBPM3sJxnzyhjjYs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5821.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(83380400001)(71200400001)(4326008)(5660300002)(7696005)(6506007)(9686003)(53546011)(52536014)(76116006)(64756008)(66946007)(66556008)(8936002)(66446008)(107886003)(2906002)(8676002)(33656002)(26005)(186003)(54906003)(38100700002)(966005)(66476007)(508600001)(55016003)(38070700005)(82960400001)(122000001)(19627235002)(110136005)(86362001)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RBL0B6tBZiVeRFO2TLCVTo987e+Ol5fjjYPnqK7FdQ63XkD8VsuvqX1v1wxS?= =?us-ascii?Q?vtHR1U3nto7i0bxYaJ/zYSXK0oUF/g4YNKcQHHx87bh/4V3DKnJYQhV2ixEF?= =?us-ascii?Q?1y18DmcasGm3gtw7Kzb9JWsbt5GmWyHhaEkL4etXkH/xuKU5TfKAe14pGnJJ?= =?us-ascii?Q?0ZYRioywhF03+IKG94pPgYeFiBiIPOrB8cQQVSmHIZD66Xq4AlVE7LwU1g2X?= =?us-ascii?Q?dtnj8QrONcY0GsMoJwQl+QrKjT1eQAY7CAhkuyRZ4dXnQsOYGGhcYLtjwR+P?= =?us-ascii?Q?Hrcgx6jz9FvwH4XSc8uOaiDsUhBTMLzIWtQq+kHKpo+tYyHxWzo9hhw0/N9f?= =?us-ascii?Q?RKvGYrTqL9K7bI6DfvBOv23HfygKJ1ra0/LSqXlKS5WeinR/w+8NFhHijTCj?= =?us-ascii?Q?8Me6wGkmssr/zSqo2W2o8wQjsFNzFYJ+q6qQMdQ1a0R1+lKP88sX5mmXtqy0?= =?us-ascii?Q?mg2ms7oMduCdrE8DvZVj20WUctZS7vmKa4HVwKp5dW5pVIfdYQOw0zWlCVWN?= =?us-ascii?Q?jJWofmi+AjXDhLGOWEoRVN8C2zttzlEhDVUk5lpLKBuofGQk5D28qDVjH8Pk?= =?us-ascii?Q?Ob7GOd2PRuZ8pKgVVA0gkWPQmPLlDchHHpEUghJuf84VmkvqomE4w4uEsWpS?= =?us-ascii?Q?/oPynnuLBV+Lqsdml1oZoAjKWHKZwvx4UOdvcntVxYPyDY7Bh19ZIT0MSmND?= =?us-ascii?Q?CTqWXFNGIi27nItqp+rQzdPdS7PDt+1nuu7z5O0SM5Nh5Nx1dV0r1ugRpeaC?= =?us-ascii?Q?s0TNYal8aAg9zXrljvSA2ro4Z+bMkIQ84XVth/2nuSFzKQOFkbvZ9r1wMbHH?= =?us-ascii?Q?EMlGw4UuWjmULqbjZ1Y4eQbeCeYKcrN1iXeTaBIWhzssakXN2+TxZIwB01Y5?= =?us-ascii?Q?9qFPdtlksn9j6Ab6EYVh9NsN3NHp3+Hyxd9baqyYCq/CGbds+VRYRcxrZMSZ?= =?us-ascii?Q?UECeIc3kZqwU8gLWz05udsTSvT5pPvGXND8npfsv08jettO2xeesLvt+AZ5C?= =?us-ascii?Q?wme2mDcPcS9SPtMPi+aULI6/ZjqHqDTzkZieWlXyecaSh9ySH3wODjUrPhyT?= =?us-ascii?Q?DTUCusTgRcjKCiI4GL8+eDWv/KFPIUhGio0zbpv3USC2gumxMZB8DkyiC5O9?= =?us-ascii?Q?5Ln7YrHmpbWHhVYcoP6iHd5zV8pDRpU5iUhHWjzmmgHOXg+VyoV5trBsj+1v?= =?us-ascii?Q?mfq/NlANuEfVKlBARd0w7uHqavGa5+ujttP7FwG110W934TUrotSFwslgXsE?= =?us-ascii?Q?nJEDTHNefFvkqKbVeg91YOURH5Ql37K5mLyNtp7EIADsx8oHTcXEtAGtasJm?= =?us-ascii?Q?9iLDJPv+0knISV3kh5yEjPQH8urQT/zmHmbsVr6Q/5dT8tS6tp6monXG+BSs?= =?us-ascii?Q?BmwRG+drcv06vrzxW3MgLwnvo8M5hNJMsVHvMz/GSRFACWc7B8Keavh8YYqw?= =?us-ascii?Q?5hSVfgb/VT9gWzGJd/o94aPVy70HiQTMbgX5Xi6OrY+PQZLPe43z+iftBm4e?= =?us-ascii?Q?turbfUsYgL4OR0Ans/qelJ5kFEeb96wRfzCOR+8LOPqb4gTfN0Mbb5TBjQZo?= =?us-ascii?Q?JfBgOAttiOAltrQt0xfzcEl/4J1AMoxcdGbFstaoRQjY1FTzWP3re4ebqzSI?= =?us-ascii?Q?PzEZd5ErCIftQtYROQydTfr7pk0VvMl+WGgraxSvEq8amwHBksLwm5eZ79gY?= =?us-ascii?Q?A9iUMA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c64fb00-c09e-43af-5501-08d9eaac0814 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 02:38:03.9197 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kbqpeKkVJVp5rq/MRDcqHnW3kR4x1rVBGHxskWKaIEl211mSGrbHJJLbEka+6yptdDiUvooZWB5jrXOWh9Cg+nj5xAe4Wh27V10lll2pbAg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1624 Return-Path: nathaniel.l.desimone@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Good catch Xiaoqiang! Reviewed-by: Nate DeSimone -----Original Message----- From: Zhang, Xiaoqiang =20 Sent: Monday, February 7, 2022 12:11 AM To: devel@edk2.groups.io Cc: Zhang, Xiaoqiang ; Chiu, Chasel ; Desimone, Nathaniel L ; Oram, = Isaac W Subject: [PATCH v1] MinPlatformPkg: Install memory relating PPIs REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3824 Install memory relating PPIs for EDKII native build and FSP dispatch mode Signed-off-by: Xiaoqiang Zhang Cc: Chasel Chiu Cc: Nate DeSimone Cc: Isaac Oram --- Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre= Mem.c | 5 ++++- Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre= Mem.inf | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/Pla= tformInitPreMem.c b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInit= Pei/PlatformInitPreMem.c index 6519fdd042..d8c96b52f4 100644 --- a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformIn= itPreMem.c +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformIn= itPreMem.c @@ -481,7 +481,10 @@ PlatformInitPreMem ( =20 BuildMemoryTypeInformation (); =20 - if (!PcdGetBool(PcdFspWrapperBootMode)) { + if ((!PcdGetBool (PcdFspWrapperBootMode)) || (PcdGet8 (PcdFspModeSelecti= on) =3D=3D 0)) { + // + // Install memory relating PPIs for EDKII native build and FSP dispatc= h mode + // Status =3D PeiServicesInstallPpi (mMemPpiList); ASSERT_EFI_ERROR (Status); } diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/Pla= tformInitPreMem.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformIn= itPei/PlatformInitPreMem.inf index fb997838ef..86d8246f02 100644 --- a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformIn= itPreMem.inf +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformIn= itPreMem.inf @@ -34,11 +34,13 @@ MdeModulePkg/MdeModulePkg.dec MdePkg/MdePkg.dec IntelSiliconPkg/IntelSiliconPkg.dec + IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec =20 [Pcd] gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode ## CONSUMES gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit ## CONSUMES gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit ## CONSUMES + gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection ## CONSUMES =20 [FixedPcd] gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize ## CO= NSUMES --=20 2.32.0.windows.1