public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] Merge commit in edk2-non-osi
Date: Wed, 21 Feb 2024 23:42:39 +0000	[thread overview]
Message-ID: <MW4PR11MB58218ADAA9E355062924C154CD572@MW4PR11MB5821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAMj1kXEdgOnamjKE7aeF4Xtwnd8CYr3iz8deH4avZox8fwsX9Q@mail.gmail.com>

> -----Original Message-----
> From: Ard Biesheuvel <ardb@kernel.org>
> Sent: Wednesday, February 21, 2024 3:29 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Subject: Re: [edk2-devel] Merge commit in edk2-non-osi
> 
> On Wed, 21 Feb 2024 at 16:05, Michael D Kinney
> <michael.d.kinney@intel.com> wrote:
> >
> > Hi Ard,
> >
> > I disagree.  We have never allowed a force push to the main branch of
> > TianoCore repos.  This has happened before and was discussed and the
> > policy is to not fix.  Even the edk2 repo has some merge commits in
> > its history that were discussed and not fixed.
> >
> > We can never know how many downstream consumers are syncing with
> main
> > branches.
> >
> 
> Fair enough. Better to be cautious, and my argument works both ways:
> the contents would not change by 'fixing' the history, and this change does not
> look problematic for bisect.

Fair enough, I will continue with my reviews/patch merges.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115753): https://edk2.groups.io/g/devel/message/115753
Mute This Topic: https://groups.io/mt/104481195/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-02-21 23:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21  1:49 [edk2-devel] Merge commit in edk2-non-osi Nate DeSimone
2024-02-21  8:06 ` Ard Biesheuvel
2024-02-21 15:05   ` Michael D Kinney
2024-02-21 23:29     ` Ard Biesheuvel
2024-02-21 23:42       ` Nate DeSimone [this message]
2024-02-21  8:57 ` Marcin Juszkiewicz
2024-02-21 15:26   ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB58218ADAA9E355062924C154CD572@MW4PR11MB5821.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox