public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nate DeSimone" <nathaniel.l.desimone@intel.com>
To: "Zhang, Xiaoqiang" <xiaoqiang.zhang@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Chiu, Chasel" <chasel.chiu@intel.com>,
	"Oram, Isaac W" <isaac.w.oram@intel.com>
Subject: Re: [PATCH v1] MinPlatformPkg: Install memory relating PPIs
Date: Wed, 9 Feb 2022 03:26:56 +0000	[thread overview]
Message-ID: <MW4PR11MB58218BECB0CCC92AC82B7758CD2E9@MW4PR11MB5821.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220207081109.1094-1-xiaoqiang.zhang@intel.com>

Pushed: https://github.com/tianocore/edk2-platforms/commit/b6f9674

> -----Original Message-----
> From: Zhang, Xiaoqiang <xiaoqiang.zhang@intel.com>
> Sent: Monday, February 7, 2022 12:11 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Xiaoqiang <xiaoqiang.zhang@intel.com>; Chiu, Chasel
> <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>
> Subject: [PATCH v1] MinPlatformPkg: Install memory relating PPIs
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3824
> 
> Install memory relating PPIs for EDKII native build and FSP dispatch mode
> 
> Signed-off-by: Xiaoqiang Zhang <xiaoqiang.zhang@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Cc: Isaac Oram <isaac.w.oram@intel.com>
> ---
> 
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.c   | 5 ++++-
> 
> Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPre
> Mem.inf | 2 ++
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.c
> b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.c
> index 6519fdd042..d8c96b52f4 100644
> ---
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.c
> +++
> b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.c
> @@ -481,7 +481,10 @@ PlatformInitPreMem (
> 
>    BuildMemoryTypeInformation ();
> 
> -  if (!PcdGetBool(PcdFspWrapperBootMode)) {
> +  if ((!PcdGetBool (PcdFspWrapperBootMode)) || (PcdGet8
> (PcdFspModeSelection) == 0)) {
> +    //
> +    // Install memory relating PPIs for EDKII native build and FSP dispatch
> mode
> +    //
>      Status = PeiServicesInstallPpi (mMemPpiList);
>      ASSERT_EFI_ERROR (Status);
>    }
> diff --git
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.inf
> b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.inf
> index fb997838ef..86d8246f02 100644
> ---
> a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.inf
> +++
> b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitP
> reMem.inf
> @@ -34,11 +34,13 @@
>    MdeModulePkg/MdeModulePkg.dec
>    MdePkg/MdePkg.dec
>    IntelSiliconPkg/IntelSiliconPkg.dec
> +  IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec
> 
>  [Pcd]
>    gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode          ##
> CONSUMES
>    gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit          ##
> CONSUMES
>    gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit            ##
> CONSUMES
> +  gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection          ##
> CONSUMES
> 
>  [FixedPcd]
>    gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize
> ## CONSUMES
> --
> 2.32.0.windows.1


  parent reply	other threads:[~2022-02-09  3:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07  8:11 [PATCH v1] MinPlatformPkg: Install memory relating PPIs Xiaoqiang Zhang
2022-02-07  9:09 ` Chiu, Chasel
2022-02-08  1:32   ` Oram, Isaac W
2022-02-08  2:38     ` Nate DeSimone
2022-02-08  2:38 ` Nate DeSimone
2022-02-09  3:26 ` Nate DeSimone [this message]
2022-02-09  5:04   ` Zhang, Xiaoqiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW4PR11MB58218BECB0CCC92AC82B7758CD2E9@MW4PR11MB5821.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox