From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 95A38D8026F for ; Mon, 11 Dec 2023 21:21:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Ywl1JeApo+4uLB8rlr7odIva0Zzhsz5Oy7B/46jBF2A=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702329690; v=1; b=xGW7xDf9hgDfU2fLvn/qotSnuvwCj1FTyw4UwIHUOPrYduaKuVLaQKkRHsIitg/bDpM2gcpT O7lUighgMrT1ISWt2LXrGc69E0xxrzh/t74dEL2ixhkVNgp6n2EDJU8sKb3KkefSnRmEeE4EI49 MbJf86mhFaZCb1CuWGT/Y/KI= X-Received: by 127.0.0.2 with SMTP id SsBZYY7687511xKtCITrLEnG; Mon, 11 Dec 2023 13:21:30 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.3295.1702329689752662408 for ; Mon, 11 Dec 2023 13:21:29 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10921"; a="398560982" X-IronPort-AV: E=Sophos;i="6.04,268,1695711600"; d="scan'208";a="398560982" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Dec 2023 13:21:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10921"; a="1104627571" X-IronPort-AV: E=Sophos;i="6.04,268,1695711600"; d="scan'208";a="1104627571" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Dec 2023 13:21:29 -0800 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 11 Dec 2023 13:21:28 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 11 Dec 2023 13:21:28 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 11 Dec 2023 13:21:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fQEgt6b2Q+pJ7AYQcRD5zIuweiJew7IpDeaPgmshy2+6P8CGwrh7cWENChnmTfMekJDilVcsIQbSKEyK++XPnsemTkbAS9YziLDNhHtNfRf7vFkN9H7fpihgO1I8REnMvunYoJFY3gmOuA7rRq/gYyLAvBQbQH2hyk5R1lKELoiG8bgaMYxEOHYNBqFO19x070Fc/BGqGY9l4tiCLXsEK9+uabZO0NlTbtATHcweIi+9gQLBA5h6/0DjwEqLQ0CoqByHc7xkveWpvoc7LPrUgIgRdrN5GDyJSzKvMIdZvMJg4p9SYPid+ziHEMNQevqh1Rc4LxhEZjAlrWmFcOCGqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4hazR12v5XOmiKnBEuMmy+0wNrIOE3YyLyeiy1hqY3Q=; b=Xfn9a7MEOeADgw6zG/4vtAFTA45umG9NNtZC9mX+rbatEubXA2HSRz9p8ESUbTG4PxpwDCucBqxiYDxIG3qC/KHdQlEmAQEGaUauW1Abd4bzc2ZzZrfSRm/7hDRA8Wkla8smqQWUpZQqkw6PR79dU5wlh5frmAeZbnb3tPDWc6BTvzKc1IMDaZWFKLNCa1N3BpJU1wITRwW6kEBCEiU1xrGN4TArHRx3HkUHyzsVTvJnJk4xhdjgx3KjXdOFHo5RCQZ/0Rgzp14zi/ivbmMQcwP0VLCFQ1alXNmOy7GRjlSSv4CXMisNd1pDgh2ixgYBvMrOLqPfV2JrioM+8hW0OA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com (2603:10b6:303:184::5) by MN6PR11MB8148.namprd11.prod.outlook.com (2603:10b6:208:472::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 21:21:26 +0000 X-Received: from MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::ced7:2db7:4cae:ab0]) by MW4PR11MB5821.namprd11.prod.outlook.com ([fe80::ced7:2db7:4cae:ab0%7]) with mapi id 15.20.7068.031; Mon, 11 Dec 2023 21:21:26 +0000 From: "Nate DeSimone" To: Abdul Lateef Attar , "devel@edk2.groups.io" CC: Abdul Lateef Attar , "Chaganty, Rangasai V" , "Oram, Isaac W" , "Gao, Liming" , Abner Chang Subject: Re: [edk2-devel] [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/GSI Thread-Topic: [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/GSI Thread-Index: AQHZxdTF+UyDuL6/ckKkjwYxAYsCa7ClZDoA Date: Mon, 11 Dec 2023 21:21:25 +0000 Message-ID: References: <91291c25394aa9b63d1c5865e3137328903dfb87.1691044467.git.abdattar@amd.com> In-Reply-To: <91291c25394aa9b63d1c5865e3137328903dfb87.1691044467.git.abdattar@amd.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5821:EE_|MN6PR11MB8148:EE_ x-ms-office365-filtering-correlation-id: 7a620111-0af3-403e-7a63-08dbfa8f21fb x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: aWVR65vRewj5CMWdAfh/xkamQIWetaRhYDiiyq6jbCxm7SFUIwztt+pekfCWaEp5GxOlFBjgNsKDxPyZhwSegBFD4Xov6lLDMxldj8/XBsehNvkpUN2grwVHwNHR0LGdiEVNvWAgDrUwI/B9lnJ+9nHH4qF5t+oNQzz6u8AvY4+EkJfVMI20lrdwOoIIBmNIgRBD9ZSg5KjWJWJ4BiUH2eSbQvyrXj5e7k/yq3H12sRTX1YKlDCT0oh/GTf7ecxw6Je4+SMPs0fK5QJX25FRW7AUDUKm+H1EpTjYxgarHzrIzdGZnkfDpsnjdGPuJ7nGCmC5LteOkEMtVHEggEbye4zCJKxXYM+KwQgy5vjXGUmADnNvSHaew590nr8PI2k+8aUoVcLIwum2r2DfmGlaxRzmgUIjNrTt2iR4Ky8kgNyA7e10SG3rN5wG1ETzjM9c1ywlHNRVmYEIEQmEWd3llwEIu9cSQjpRUIUv0L1lyvKmCGf8h+Is/+/SXYXUppqflCDVPM04oRAcng2CaEaxOZDDoH1T+aZu0YyKbIhWdIg3xZcuBdGEzxi6cpNJEn2cOrBkq9z1YlTb1d/S4kV99rzwmIdq7jZodb7NIy1QkfATnkk3Brj9BRIS+fOggwc1 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rAiaObjD5ImJkz2Mifu0WMnJG/rRgREEnv6ig+xmWoxVKkJk4goEQqctA0JV?= =?us-ascii?Q?c/R0MArHdmmL1Po/9pO+JqQNscAjn8LhlmD4lpvIqybloyxh/uEocCX1WgMC?= =?us-ascii?Q?RLlGUMGJPoRSA+VXM1Xz1HWmmD1T9XUwMRfGLqblpnDPuYjQ8LFlnHkbLvCi?= =?us-ascii?Q?SANMnwXQ/m6/7m6XX38wSQtTbKCHW7C2UVsXJxP6GQtH9dHt4ZVIs3NfwvpJ?= =?us-ascii?Q?343H83a9cyWoLw+21rgDxXVu1sGOpG61XjHlwgQ7GL5oR0hNE1h6hYaOWwsK?= =?us-ascii?Q?1LdC0sddB4TJ+mlDimendnSjFWUgR92J1PHrBjpj2eVin5e1kKNIVKsQxqfX?= =?us-ascii?Q?0pNMtcTIgLEWdKt7wszEdWG7QXo5i72WI1hDw0ifS2I2aZvZfdR8aZbtfE1Z?= =?us-ascii?Q?eFIuNnbRj4MSu3JJhx4NvLIpQ7Zo0SAzO3E+dYbq2Q97BxnF7uRyMtR5iaXP?= =?us-ascii?Q?SMVM1uDaWVnUlLwx2eII2tVDzYplb2ov0e1JTvfMK6AfdDRygSbieW4EVqPy?= =?us-ascii?Q?7IGnbJJT57QtTU3sNnzvJYgCiB6u4jhyXE9BwMMYjyWyyTQKHXNIlgq4hJ72?= =?us-ascii?Q?NiTRndAXIj7zQlIa6IN0RgdjBMBUeXTa3gtyJaoZCKglMDe5DlMmMJa/7NqI?= =?us-ascii?Q?gnEIom3kTNB49jBY80letm43Iq4OUkPIrGIAFxLzeX09y4vANOxBOEuoZjzn?= =?us-ascii?Q?jNhAmkRDM/XPpV1CNErbmXTV4dWOn7rJrH5Z8qF/YtsB25Nvr6GFUFo/bRqo?= =?us-ascii?Q?TML4oB73NHO0ukRYi9Tk6rnXw5wJ29uSghnpF1gbNxhMbZD1OnysWCqxlSa2?= =?us-ascii?Q?TJZK0gxIrFoaNW9IvHtYv0kxAABb4HahDc/r8B258CuJpNTrS7aTiEAabNcP?= =?us-ascii?Q?LHTi+eTa2RfI6UNZbANh0mR8/ZVOfQTpVGcwIRmG1yqmyvigXE06UY2oTH5R?= =?us-ascii?Q?58AJZLk8LjDh7JFkFc6BGOQXXacV2ly1GnW11kzVbkB5m3UVXflu96CH5Pm8?= =?us-ascii?Q?vdo5LHvCE+5z3NDLB+473kuqMxyBu0tsQ8N0nr6S88jvfFFP7v8WVvK30qfy?= =?us-ascii?Q?b50c2BKmylSTKY8q4wEVdran5XC26C7bpCu2xLOCYU46iNj+3co6E+Pk4WYM?= =?us-ascii?Q?OD1RMiAgpJDF7bMyygrpGFRMzYDTNYYHGKSr+c9tSobKHhKTQ/iifMlk7WWm?= =?us-ascii?Q?IoeQfBubvZbm95XvTjKVbe42etGB1HHtEu7ANVfOgN81T2dsl5dJS511UJPT?= =?us-ascii?Q?NTpemGo3FqcLL27txlAthtU0n/2IFKHRB3UEGBfhUXHwa62M9sDLRy65ATZg?= =?us-ascii?Q?lE8se4s+bLTX/d/Dcg9+0M6pC97vn5PjxgemyiawJ4GBRarPGGLte1CqG61/?= =?us-ascii?Q?EJNSWLCX0ZTRWrBJPm3dDhkZyUOBki84SwKOIT/zCdaXnmAU/wOkS6kPGERD?= =?us-ascii?Q?FliC+ZO8hNFwxe06HkatgMRaPm+s4HSmBSlSeJ7dDusCIwA/f5hLmPy+hvTM?= =?us-ascii?Q?nODT/JdeHS+k6lAi5Spcn4tLo5fLmITG/wR3FPkj2EC7XofGrV0dI26qgpv5?= =?us-ascii?Q?Umxdf2KNm9ydv2N/KxetOOxhI9BHHa3TA4gV3oxUSK2Tr/x80uVBXoGXeK0y?= =?us-ascii?Q?XA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5821.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a620111-0af3-403e-7a63-08dbfa8f21fb X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2023 21:21:25.9841 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KbG9RYygj02uWCFdTOBqFdURnMz1nfdx878gLaVzGEies2Ysm8LXj1YU2BbAvjOj3cth9ao1p5hLUsb8U8PNZfEVCijYmm3vJdlCppq5Uc0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8148 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nathaniel.l.desimone@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: CUPR1OiizHdGH4bcVD4vG8dix7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=xGW7xDf9; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Pushed as 3c0adfe. -----Original Message----- From: Abdul Lateef Attar =20 Sent: Wednesday, August 2, 2023 11:35 PM To: devel@edk2.groups.io Cc: Abdul Lateef Attar ; Chaganty, Rangasai V ; Oram, Isaac W ; Desi= mone, Nathaniel L ; Gao, Liming ; Abner Chang Subject: [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/GSI From: Abdul Lateef Attar Create a new PCD to hold the IRQ or GSI number for SPCR, with default value= s of 4. Update the ACPI SPCR table's IRQ value based on PCD. Cc: Sai Chaganty Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Cc: Abner Chang Signed-off-by: Abdul Lateef Attar Change-Id: I7218903fa5572f8139ad45db598ab085f079713b --- .../OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dec | 5 +++++ .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpiDxe.inf | 4 ++++ .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.h | 3 +++ .../SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 7 ++++--- 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeatureP= kg.dec b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d= ec index b084fad89220..d69d650f3f20 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dec +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d +++ ec @@ -7,6 +7,7 @@ # for the build infrastructure. # # Copyright (c) 2020, Intel Corporation. All rights reserved.
+# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -24,6 +25,10 @@ [Incl= udes] [Guids] gSpcrFeaturePkgTokenSpaceGuid =3D { 0xe978c988, 0xeeba, 0x4671, { 0xb8, = 0x0d, 0xcc, 0x8b, 0x89, 0xb5, 0xd1, 0xef }} =20 +[PcdsFixedAtBuild] + # SPCR default IRQ set to 4 + gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrInterrupt|4|UINT8|0x00000010 + [PcdsFeatureFlag] gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrFeatureEnable|FALSE|BOOLEAN|0x00000= 001 =20 diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpiDxe.inf b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcp= iDxe/SpcrAcpiDxe.inf index 9a4f95e86bbf..cd43afea5242 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcp= iDxe.inf +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr +++ AcpiDxe.inf @@ -24,6 +24,7 @@ [LibraryClasses] UefiDriverEntryPoint UefiLib SpcrDeviceLib + PcdLib =20 [Packages] MdePkg/MdePkg.dec @@ -51,5 +52,8 @@ [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdSerialRegisterStride gEfiMdeModulePkgTokenSpaceGuid.PcdSerialUseMmio =20 +[FixedPcd] + gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrInterrupt + [Depex] TRUE diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.h b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.h index c11da439fcb8..245a847762c5 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcp= i.h +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr +++ Acpi.h @@ -3,6 +3,8 @@ SPCR is abbreviation of Serial Port Console Redirection Table (SPCR). =20 Copyright (c) 2004 - 2020, Intel Corporation. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. + SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -23,6 +25,7 @@ #include #include #include +#include =20 #include #include diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/= SpcrAcpi.c index 51449d0fad9e..e92db96caaa9 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcp= i.c +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/Spcr +++ Acpi.c @@ -3,7 +3,7 @@ SPCR is abbreviation of Serial Port Console Redirection Table (SPCR). =20 Copyright (c) 2004 - 2020, Intel Corporation. All rights reserved.
- Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.
+ Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 **/ @@ -83,8 +83,8 @@ EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE gSpcrInfo = =3D { }, =20 0x03, //INTERRUPT_TYPE, - 0x04, //IRQ, - 0x04, //GLOBAL_SYSTEM_INTERRUPT, + FixedPcdGet8 (PcdSpcrInterrupt), // IRQ, + FixedPcdGet8 (PcdSpcrInterrupt), // GLOBAL_SYSTEM_INTERRUPT, 0x07, //BAUD_RATE, 0x00, //PARITY, 0x01, //STOP_BITS, @@ -441,6 +441,7 @@ OutOfBandACPITableConstruction ( gSpcrInfo.FlowControl =3D UART_FLOW_CONTROL_HARDWARE; } =20 + if (HasIsaSerialNode(SavedDevicePath)) { GetIsaTypeInfo (SavedDevicePath); } else { -- 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112331): https://edk2.groups.io/g/devel/message/112331 Mute This Topic: https://groups.io/mt/100521521/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-